CHANGELOG.md

@@ -1,15 +1,6 @@
 # Changelog
 
-## [0.14.1] - 2026-03-08
-
-### Added
-
-- Added isArchived to contact json output (Thanks @moppman)
-- Added support for group member labels
-
-### Fixed
-
-- Adapt registration to signal server changes
+## [Unreleased]
 
 ## [0.14.0] - 2026-03-01
 

build.gradle.kts

@@ -3,12 +3,12 @@ plugins {
     application
     eclipse
     `check-lib-versions`
-    id("org.graalvm.buildtools.native") version "0.11.5"
+    id("org.graalvm.buildtools.native") version "0.11.4"
 }
 
 allprojects {
     group = "org.asamk"
-    version = "0.14.1"
+    version = "0.14.1-SNAPSHOT"
 }
 
 java {

client/src/cli.rs

@@ -598,12 +598,6 @@ pub enum CliCommands {
 
         #[arg(short = 'e', long)]
         expiration: Option<u32>,
-
-        #[arg(long = "member-label-emoji")]
-        member_label_emoji: Option<String>,
-
-        #[arg(long = "member-label")]
-        member_label: Option<String>,
     },
     UpdateProfile {
         #[arg(long = "given-name")]

client/src/jsonrpc.rs

@@ -460,8 +460,6 @@ pub trait Rpc {
         #[allow(non_snake_case)] setPermissionEditDetails: Option<String>,
         #[allow(non_snake_case)] setPermissionSendMessages: Option<String>,
         expiration: Option<u32>,
-        #[allow(non_snake_case)] memberLabelEmoji: Option<String>,
-        #[allow(non_snake_case)] memberLabel: Option<String>,
     ) -> Result<Value, ErrorObjectOwned>;
 
     #[method(name = "updateProfile", param_kind = map)]

client/src/main.rs

@@ -535,8 +535,6 @@ async fn handle_command(
             set_permission_edit_details,
             set_permission_send_messages,
             expiration,
-            member_label_emoji,
-            member_label,
         } => {
             client
                 .update_group(
@@ -570,8 +568,6 @@ async fn handle_command(
                         GroupPermission::OnlyAdmins => "onlyAdmins".to_owned(),
                     }),
                     expiration,
-                    member_label_emoji,
-                    member_label,
                 )
                 .await
         }

data/org.asamk.SignalCli.metainfo.xml

@@ -45,9 +45,6 @@
         <content_attribute id="social-chat">intense</content_attribute>
     </content_rating>
     <releases>
-        <release version="0.14.1" date="2026-03-08">
-            <url type="details">https://github.com/AsamK/signal-cli/releases/tag/v0.14.1</url>
-        </release>
         <release version="0.14.0" date="2026-03-01">
             <url type="details">https://github.com/AsamK/signal-cli/releases/tag/v0.14.0</url>
         </release>

lib/src/main/java/org/asamk/signal/manager/api/Group.java

@@ -12,9 +12,10 @@ public record Group(
         String title,
         String description,
         GroupInviteLinkUrl groupInviteLinkUrl,
-        Set<GroupMember> members,
+        Set<RecipientAddress> members,
         Set<RecipientAddress> pendingMembers,
         Set<RecipientAddress> requestingMembers,
+        Set<RecipientAddress> adminMembers,
         Set<RecipientAddress> bannedMembers,
         boolean isBlocked,
         int messageExpirationTimer,
@@ -36,7 +37,8 @@ public record Group(
                 groupInfo.getGroupInviteLink(),
                 groupInfo.getMembers()
                         .stream()
-                        .map(m -> org.asamk.signal.manager.api.GroupMember.from(m, recipientStore))
+                        .map(recipientStore::resolveRecipientAddress)
+                        .map(org.asamk.signal.manager.storage.recipients.RecipientAddress::toApiRecipientAddress)
                         .collect(Collectors.toSet()),
                 groupInfo.getPendingMembers()
                         .stream()
@@ -48,6 +50,11 @@ public record Group(
                         .map(recipientStore::resolveRecipientAddress)
                         .map(org.asamk.signal.manager.storage.recipients.RecipientAddress::toApiRecipientAddress)
                         .collect(Collectors.toSet()),
+                groupInfo.getAdminMembers()
+                        .stream()
+                        .map(recipientStore::resolveRecipientAddress)
+                        .map(org.asamk.signal.manager.storage.recipients.RecipientAddress::toApiRecipientAddress)
+                        .collect(Collectors.toSet()),
                 groupInfo.getBannedMembers()
                         .stream()
                         .map(recipientStore::resolveRecipientAddress)

lib/src/main/java/org/asamk/signal/manager/api/GroupMember.java

@@ -1,14 +0,0 @@
-package org.asamk.signal.manager.api;
-
-import org.asamk.signal.manager.helper.RecipientAddressResolver;
-import org.asamk.signal.manager.storage.groups.GroupMemberInfo;
-
-public record GroupMember(
-        RecipientAddress recipientAddress, boolean isAdmin, String labelEmoji, String label
-) {
-
-    public static GroupMember from(final GroupMemberInfo memberInfo, final RecipientAddressResolver recipientStore) {
-        return new GroupMember(recipientStore.resolveRecipientAddress(memberInfo.getRecipientId())
-                .toApiRecipientAddress(), memberInfo.isAdmin(), memberInfo.labelEmoji(), memberInfo.labelString());
-    }
-}

lib/src/main/java/org/asamk/signal/manager/api/UpdateGroup.java

@@ -19,8 +19,6 @@ public class UpdateGroup {
     private final String avatarFile;
     private final Integer expirationTimer;
     private final Boolean isAnnouncementGroup;
-    private final String labelEmoji;
-    private final String labelString;
 
     private UpdateGroup(final Builder builder) {
         name = builder.name;
@@ -38,8 +36,6 @@ public class UpdateGroup {
         avatarFile = builder.avatarFile;
         expirationTimer = builder.expirationTimer;
         isAnnouncementGroup = builder.isAnnouncementGroup;
-        labelEmoji = builder.labelEmoji;
-        labelString = builder.labelString;
     }
 
     public static Builder newBuilder() {
@@ -61,9 +57,7 @@ public class UpdateGroup {
                 copy.editDetailsPermission,
                 copy.avatarFile,
                 copy.expirationTimer,
-                copy.isAnnouncementGroup,
-                copy.labelEmoji,
-                copy.labelString);
+                copy.isAnnouncementGroup);
     }
 
     public static Builder newBuilder(
@@ -81,9 +75,7 @@ public class UpdateGroup {
             final GroupPermission editDetailsPermission,
             final String avatarFile,
             final Integer expirationTimer,
-            final Boolean isAnnouncementGroup,
-            final String labelEmoji,
-            final String labelString
+            final Boolean isAnnouncementGroup
     ) {
         return new Builder(name,
                 description,
@@ -99,9 +91,7 @@ public class UpdateGroup {
                 editDetailsPermission,
                 avatarFile,
                 expirationTimer,
-                isAnnouncementGroup,
-                labelEmoji,
-                labelString);
+                isAnnouncementGroup);
     }
 
     public String getName() {
@@ -164,14 +154,6 @@ public class UpdateGroup {
         return isAnnouncementGroup;
     }
 
-    public String getLabelEmoji() {
-        return labelEmoji;
-    }
-
-    public String getLabelString() {
-        return labelString;
-    }
-
     public static final class Builder {
 
         private String name;
@@ -189,8 +171,6 @@ public class UpdateGroup {
         private String avatarFile;
         private Integer expirationTimer;
         private Boolean isAnnouncementGroup;
-        private String labelEmoji;
-        private String labelString;
 
         private Builder() {
         }
@@ -210,9 +190,7 @@ public class UpdateGroup {
                 final GroupPermission editDetailsPermission,
                 final String avatarFile,
                 final Integer expirationTimer,
-                final Boolean isAnnouncementGroup,
-                final String labelEmoji,
-                final String labelString
+                final Boolean isAnnouncementGroup
         ) {
             this.name = name;
             this.description = description;
@@ -229,8 +207,6 @@ public class UpdateGroup {
             this.avatarFile = avatarFile;
             this.expirationTimer = expirationTimer;
             this.isAnnouncementGroup = isAnnouncementGroup;
-            this.labelEmoji = labelEmoji;
-            this.labelString = labelString;
         }
 
         public Builder withName(final String val) {
@@ -308,16 +284,6 @@ public class UpdateGroup {
             return this;
         }
 
-        public Builder withLabelEmoji(final String val) {
-            labelEmoji = val;
-            return this;
-        }
-
-        public Builder withLabelString(final String val) {
-            labelString = val;
-            return this;
-        }
-
         public UpdateGroup build() {
             return new UpdateGroup(this);
         }

lib/src/main/java/org/asamk/signal/manager/config/ServiceConfig.java

@@ -29,7 +29,7 @@ public class ServiceConfig {
 
     public static AccountAttributes.Capabilities getCapabilities(boolean isPrimaryDevice) {
         final var attachmentBackfill = !isPrimaryDevice;
-        final var spqr = true;
+        final var spqr = !isPrimaryDevice;
         return new AccountAttributes.Capabilities(true, true, attachmentBackfill, spqr);
     }
 

lib/src/main/java/org/asamk/signal/manager/helper/GroupHelper.java

@@ -299,9 +299,7 @@ public class GroupHelper {
             final GroupPermission editDetailsPermission,
             final String avatarFile,
             final Integer expirationTimer,
-            final Boolean isAnnouncementGroup,
-            final String labelEmoji,
-            final String labelString
+            final Boolean isAnnouncementGroup
     ) throws IOException, GroupNotFoundException, AttachmentInvalidException, NotAGroupMemberException, GroupSendingNotAllowedException {
         var group = getGroupForUpdating(groupId);
         final var avatarBytes = readAvatarBytes(avatarFile);
@@ -325,9 +323,7 @@ public class GroupHelper {
                             editDetailsPermission,
                             avatarBytes,
                             expirationTimer,
-                            isAnnouncementGroup,
-                            labelEmoji,
-                            labelString);
+                            isAnnouncementGroup);
                 } catch (ConflictException e) {
                     // Detected conflicting update, refreshing group and trying again
                     group = getGroup(groupId, true);
@@ -346,9 +342,7 @@ public class GroupHelper {
                             editDetailsPermission,
                             avatarBytes,
                             expirationTimer,
-                            isAnnouncementGroup,
-                            labelEmoji,
-                            labelString);
+                            isAnnouncementGroup);
                 }
             }
 
@@ -707,9 +701,7 @@ public class GroupHelper {
             final GroupPermission editDetailsPermission,
             final byte[] avatarFile,
             final Integer expirationTimer,
-            final Boolean isAnnouncementGroup,
-            final String labelEmoji,
-            final String labelString
+            final Boolean isAnnouncementGroup
     ) throws IOException {
         SendGroupMessageResults result = null;
         final var groupV2Helper = context.getGroupV2Helper();
@@ -766,7 +758,7 @@ public class GroupHelper {
         if (admins != null) {
             final var newAdmins = new HashSet<>(admins);
             newAdmins.retainAll(group.getMembers());
-            newAdmins.removeAll(group.getAdminMemberRecipientIds());
+            newAdmins.removeAll(group.getAdminMembers());
             if (!newAdmins.isEmpty()) {
                 for (var admin : newAdmins) {
                     var groupGroupChangePair = groupV2Helper.setMemberAdmin(group, admin, true);
@@ -779,7 +771,7 @@ public class GroupHelper {
 
         if (removeAdmins != null) {
             final var existingRemoveAdmins = new HashSet<>(removeAdmins);
-            existingRemoveAdmins.retainAll(group.getAdminMemberRecipientIds());
+            existingRemoveAdmins.retainAll(group.getAdminMembers());
             if (!existingRemoveAdmins.isEmpty()) {
                 for (var admin : existingRemoveAdmins) {
                     var groupGroupChangePair = groupV2Helper.setMemberAdmin(group, admin, false);
@@ -838,15 +830,6 @@ public class GroupHelper {
             result = sendUpdateGroupV2Message(group, groupGroupChangePair.first(), groupGroupChangePair.second());
         }
 
-        if (labelString != null || labelEmoji != null) {
-            final var selfRecipientId = account.getSelfRecipientId();
-            final var selfMember = group.getMember(selfRecipientId);
-            var groupGroupChangePair = groupV2Helper.setMemberLabels(group,
-                    labelEmoji != null ? labelEmoji : selfMember.labelEmoji(),
-                    labelString != null ? labelString : selfMember.labelString());
-            result = sendUpdateGroupV2Message(group, groupGroupChangePair.first(), groupGroupChangePair.second());
-        }
-
         if (name != null || description != null || avatarFile != null) {
             var groupGroupChangePair = groupV2Helper.updateGroup(group, name, description, avatarFile);
             if (avatarFile != null) {
@@ -876,7 +859,7 @@ public class GroupHelper {
             final GroupInfoV2 groupInfoV2,
             final Set<RecipientId> newAdmins
     ) throws LastGroupAdminException, IOException {
-        final var currentAdmins = groupInfoV2.getAdminMemberRecipientIds();
+        final var currentAdmins = groupInfoV2.getAdminMembers();
         newAdmins.removeAll(currentAdmins);
         newAdmins.retainAll(groupInfoV2.getMembers());
         if (currentAdmins.contains(account.getSelfRecipientId())
@@ -905,7 +888,7 @@ public class GroupHelper {
         var group = SignalServiceGroup.newBuilder(SignalServiceGroup.Type.UPDATE)
                 .withId(g.getGroupId().serialize())
                 .withName(g.name)
-                .withMembers(g.getMemberRecipientIds()
+                .withMembers(g.getMembers()
                         .stream()
                         .map(context.getRecipientHelper()::resolveSignalServiceAddress)
                         .toList());

lib/src/main/java/org/asamk/signal/manager/helper/GroupV2Helper.java

@@ -533,18 +533,6 @@ class GroupV2Helper {
         return commitChange(groupInfoV2, change);
     }
 
-    Pair<DecryptedGroup, GroupChangeResponse> setMemberLabels(
-            GroupInfoV2 groupInfoV2,
-            String labelEmoji,
-            String labelString
-    ) throws IOException {
-        final GroupsV2Operations.GroupOperations groupOperations = getGroupOperations(groupInfoV2);
-        final var change = groupOperations.createChangeMemberLabel(getSelfAci(),
-                labelString == null ? "" : labelString,
-                labelEmoji);
-        return commitChange(groupInfoV2, change);
-    }
-
     private AccessControl.AccessRequired toAccessControl(final GroupLinkState state) {
         return switch (state) {
             case DISABLED -> AccessControl.AccessRequired.UNSATISFIABLE;

lib/src/main/java/org/asamk/signal/manager/helper/SendHelper.java

@@ -320,9 +320,7 @@ public class SendHelper {
         messageBuilder.withExpiration(g.getMessageExpirationTimer());
 
         final var message = messageBuilder.build();
-        final var recipients = includeSelf
-                ? g.getMemberRecipientIds()
-                : g.getMembersWithout(account.getSelfRecipientId());
+        final var recipients = includeSelf ? g.getMembers() : g.getMembersWithout(account.getSelfRecipientId());
 
         if (g.isAnnouncementGroup() && !g.isAdmin(account.getSelfRecipientId())) {
             if (message.getBody().isPresent()

lib/src/main/java/org/asamk/signal/manager/helper/SyncHelper.java

@@ -114,7 +114,7 @@ public class SyncHelper {
                     if (record instanceof GroupInfoV1 groupInfo) {
                         out.write(new DeviceGroup(groupInfo.getGroupId().serialize(),
                                 Optional.ofNullable(groupInfo.name),
-                                groupInfo.getMemberRecipientIds()
+                                groupInfo.getMembers()
                                         .stream()
                                         .map(context.getRecipientHelper()::resolveSignalServiceAddress)
                                         .toList(),

lib/src/main/java/org/asamk/signal/manager/internal/ManagerImpl.java

@@ -633,9 +633,7 @@ public class ManagerImpl implements Manager {
                         updateGroup.getEditDetailsPermission(),
                         updateGroup.getAvatarFile(),
                         updateGroup.getExpirationTimer(),
-                        updateGroup.getIsAnnouncementGroup(),
-                        updateGroup.getLabelEmoji(),
-                        updateGroup.getLabelString());
+                        updateGroup.getIsAnnouncementGroup());
     }
 
     @Override

lib/src/main/java/org/asamk/signal/manager/storage/groups/GroupInfo.java

@@ -6,7 +6,6 @@ import org.asamk.signal.manager.api.GroupPermission;
 import org.asamk.signal.manager.storage.recipients.RecipientId;
 import org.whispersystems.signalservice.api.push.DistributionId;
 
-import java.util.Collection;
 import java.util.Set;
 import java.util.stream.Collectors;
 import java.util.stream.Stream;
@@ -25,18 +24,7 @@ public sealed abstract class GroupInfo permits GroupInfoV1, GroupInfoV2 {
 
     public abstract GroupInviteLinkUrl getGroupInviteLink();
 
-    public abstract Collection<GroupMemberInfo> getMembers();
-
-    public Set<RecipientId> getMemberRecipientIds() {
-        return getMembers().stream().map(GroupMemberInfo::getRecipientId).collect(Collectors.toSet());
-    }
-
-    public GroupMemberInfo getMember(RecipientId recipientId) {
-        return getMembers().stream()
-                .filter(member -> member.getRecipientId().equals(recipientId))
-                .findFirst()
-                .orElseThrow();
-    }
+    public abstract Set<RecipientId> getMembers();
 
     public Set<RecipientId> getBannedMembers() {
         return Set.of();
@@ -50,7 +38,7 @@ public sealed abstract class GroupInfo permits GroupInfoV1, GroupInfoV2 {
         return Set.of();
     }
 
-    public Set<RecipientId> getAdminMemberRecipientIds() {
+    public Set<RecipientId> getAdminMembers() {
         return Set.of();
     }
 
@@ -73,23 +61,21 @@ public sealed abstract class GroupInfo permits GroupInfoV1, GroupInfoV2 {
     public abstract GroupPermission getPermissionSendMessage();
 
     public Set<RecipientId> getMembersWithout(RecipientId recipientId) {
-        return getMemberRecipientIds().stream()
-                .filter(member -> !member.equals(recipientId))
-                .collect(Collectors.toSet());
+        return getMembers().stream().filter(member -> !member.equals(recipientId)).collect(Collectors.toSet());
     }
 
     public Set<RecipientId> getMembersIncludingPendingWithout(RecipientId recipientId) {
-        return Stream.concat(getMemberRecipientIds().stream(), getPendingMembers().stream())
+        return Stream.concat(getMembers().stream(), getPendingMembers().stream())
                 .filter(member -> !member.equals(recipientId))
                 .collect(Collectors.toSet());
     }
 
     public boolean isMember(RecipientId recipientId) {
-        return getMembers().stream().anyMatch(m -> m.getRecipientId().equals(recipientId));
+        return getMembers().contains(recipientId);
     }
 
     public boolean isAdmin(RecipientId recipientId) {
-        return getMembers().stream().anyMatch(m -> m.isAdmin() && m.getRecipientId().equals(recipientId));
+        return getAdminMembers().contains(recipientId);
     }
 
     public boolean isPendingMember(RecipientId recipientId) {

lib/src/main/java/org/asamk/signal/manager/storage/groups/GroupInfoV1.java

@@ -80,8 +80,8 @@ public final class GroupInfoV1 extends GroupInfo {
         return null;
     }
 
-    public Collection<GroupMemberInfo> getMembers() {
-        return members.stream().map(m -> (GroupMemberInfo) new GroupMemberInfoV1(m)).toList();
+    public Set<RecipientId> getMembers() {
+        return new HashSet<>(members);
     }
 
     @Override

lib/src/main/java/org/asamk/signal/manager/storage/groups/GroupInfoV2.java

@@ -3,17 +3,18 @@ package org.asamk.signal.manager.storage.groups;
 import org.asamk.signal.manager.api.GroupIdV2;
 import org.asamk.signal.manager.api.GroupInviteLinkUrl;
 import org.asamk.signal.manager.api.GroupPermission;
+import org.asamk.signal.manager.storage.recipients.RecipientAddress;
 import org.asamk.signal.manager.storage.recipients.RecipientId;
 import org.asamk.signal.manager.storage.recipients.RecipientResolver;
 import org.signal.core.models.ServiceId;
 import org.signal.libsignal.zkgroup.groups.GroupMasterKey;
 import org.signal.storageservice.storage.protos.groups.AccessControl;
+import org.signal.storageservice.storage.protos.groups.Member;
 import org.signal.storageservice.storage.protos.groups.local.DecryptedGroup;
 import org.signal.storageservice.storage.protos.groups.local.EnabledState;
 import org.whispersystems.signalservice.api.push.DistributionId;
 import org.whispersystems.signalservice.api.push.SignalServiceAddress;
 
-import java.util.Collection;
 import java.util.Set;
 import java.util.stream.Collectors;
 
@@ -121,11 +122,14 @@ public final class GroupInfoV2 extends GroupInfo {
     }
 
     @Override
-    public Collection<GroupMemberInfo> getMembers() {
+    public Set<RecipientId> getMembers() {
         if (this.group == null) {
             return Set.of();
         }
-        return group.members.stream().map(m -> (GroupMemberInfo) new GroupMemberInfoV2(m, recipientResolver)).toList();
+        return group.members.stream()
+                .map(m -> ServiceId.parseOrThrow(m.aciBytes))
+                .map(recipientResolver::resolveRecipient)
+                .collect(Collectors.toSet());
     }
 
     @Override
@@ -171,11 +175,16 @@ public final class GroupInfoV2 extends GroupInfo {
     }
 
     @Override
-    public Set<RecipientId> getAdminMemberRecipientIds() {
-        return this.getMembers()
-                .stream()
-                .filter(GroupMemberInfo::isAdmin)
-                .map(GroupMemberInfo::getRecipientId)
+    public Set<RecipientId> getAdminMembers() {
+        if (this.group == null) {
+            return Set.of();
+        }
+        return group.members.stream()
+                .filter(m -> m.role == Member.Role.ADMINISTRATOR)
+                .map(m -> new RecipientAddress(ServiceId.ACI.parseOrNull(m.aciBytes),
+                        ServiceId.PNI.parseOrNull(m.pniBytes),
+                        null))
+                .map(recipientResolver::resolveRecipient)
                 .collect(Collectors.toSet());
     }
 

lib/src/main/java/org/asamk/signal/manager/storage/groups/GroupMemberInfo.java

@@ -1,20 +0,0 @@
-package org.asamk.signal.manager.storage.groups;
-
-import org.asamk.signal.manager.storage.recipients.RecipientId;
-
-public interface GroupMemberInfo {
-
-    RecipientId getRecipientId();
-
-    default boolean isAdmin() {
-        return false;
-    }
-
-    default String labelEmoji() {
-        return null;
-    }
-
-    default String labelString() {
-        return null;
-    }
-}

lib/src/main/java/org/asamk/signal/manager/storage/groups/GroupMemberInfoV1.java

@@ -1,17 +0,0 @@
-package org.asamk.signal.manager.storage.groups;
-
-import org.asamk.signal.manager.storage.recipients.RecipientId;
-
-public class GroupMemberInfoV1 implements GroupMemberInfo {
-
-    private final RecipientId recipientId;
-
-    public GroupMemberInfoV1(final RecipientId recipientId) {
-        this.recipientId = recipientId;
-    }
-
-    @Override
-    public RecipientId getRecipientId() {
-        return this.recipientId;
-    }
-}

lib/src/main/java/org/asamk/signal/manager/storage/groups/GroupMemberInfoV2.java

@@ -1,38 +0,0 @@
-package org.asamk.signal.manager.storage.groups;
-
-import org.asamk.signal.manager.storage.recipients.RecipientId;
-import org.asamk.signal.manager.storage.recipients.RecipientResolver;
-import org.signal.core.models.ServiceId;
-import org.signal.storageservice.storage.protos.groups.Member;
-import org.signal.storageservice.storage.protos.groups.local.DecryptedMember;
-
-public class GroupMemberInfoV2 implements GroupMemberInfo {
-
-    private final RecipientResolver recipientResolver;
-    private final DecryptedMember member;
-
-    public GroupMemberInfoV2(final DecryptedMember member, final RecipientResolver recipientResolver) {
-        this.recipientResolver = recipientResolver;
-        this.member = member;
-    }
-
-    @Override
-    public RecipientId getRecipientId() {
-        return recipientResolver.resolveRecipient(ServiceId.ACI.parseOrThrow(member.aciBytes));
-    }
-
-    @Override
-    public boolean isAdmin() {
-        return member.role == Member.Role.ADMINISTRATOR;
-    }
-
-    @Override
-    public String labelEmoji() {
-        return member.labelEmoji.isEmpty() ? null : member.labelEmoji;
-    }
-
-    @Override
-    public String labelString() {
-        return member.labelString.isEmpty() ? null : member.labelString;
-    }
-}

lib/src/main/java/org/asamk/signal/manager/storage/groups/GroupStore.java

@@ -648,7 +648,7 @@ public class GroupStore {
                                         ON CONFLICT (group_id, recipient_id) DO NOTHING
                                         """.formatted(TABLE_GROUP_V1_MEMBER);
             try (final var statement = connection.prepareStatement(sqlInsertMember)) {
-                for (final var recipient : groupV1.getMemberRecipientIds()) {
+                for (final var recipient : groupV1.getMembers()) {
                     statement.setLong(1, internalId);
                     statement.setLong(2, recipient.id());
                     statement.executeUpdate();

lib/src/main/java/org/asamk/signal/manager/storage/prekeys/KyberPreKeyStore.java

@@ -133,11 +133,6 @@ public class KyberPreKeyStore implements SignalServiceKyberPreKeyStore {
         return getPreKey(keyId) != null;
     }
 
-    /**
-     * When we mark Kyber pre-keys used, we want to keep a record of last resort tuples, which are deleted when the key
-     * itself is deleted from this table via a cascading delete.
-     * For non-last-resort keys, this method just deletes them like normal.
-     */
     @Override
     public void markKyberPreKeyUsed(
             final int kyberPreKeyId,

man/signal-cli-jsonrpc.5.adoc

@@ -154,7 +154,7 @@ RESPONSE: `{"jsonrpc":"2.0","result":{"timestamp":999},"id":4}`
 
 ---
 
-REQUEST: `{"jsonrpc":"2.0","method":"updateGroup","params":{"groupId":"GROUP_ID=","name":"new group name","members":["+ZZZ"],"link":"enabledWithApproval","setPermissionEditDetails":"only-admins","memberLabelEmoji":"😀","memberLabel":"My Label"},"id":"someId"}`
+REQUEST: `{"jsonrpc":"2.0","method":"updateGroup","params":{"groupId":"GROUP_ID=","name":"new group name","members":["+ZZZ"],"link":"enabledWithApproval","setPermissionEditDetails":"only-admins"},"id":"someId"}`
 
 RESPONSE: `{"jsonrpc":"2.0","result":{"timestamp":9999},"id":"someId"}`
 

man/signal-cli.1.adoc

@@ -754,12 +754,6 @@ Groups where only admins can send messages are also called announcement groups
 Set expiration time of messages (seconds).
 To disable expiration set expiration time to 0.
 
-*--member-label-emoji* EMOJI::
-Specify the emoji for the member label.
-
-*--member-label* STRING::
-Specify the string for the member label.
-
 === quitGroup
 
 Send a quit group message to all group members and remove self from member list.

src/main/java/org/asamk/signal/commands/ListGroupsCommand.java

@@ -1,7 +1,5 @@
 package org.asamk.signal.commands;
 
-import com.fasterxml.jackson.annotation.JsonInclude;
-
 import net.sourceforge.argparse4j.impl.Arguments;
 import net.sourceforge.argparse4j.inf.Namespace;
 import net.sourceforge.argparse4j.inf.Subparser;
@@ -9,7 +7,6 @@ import net.sourceforge.argparse4j.inf.Subparser;
 import org.asamk.signal.commands.exceptions.CommandException;
 import org.asamk.signal.manager.Manager;
 import org.asamk.signal.manager.api.Group;
-import org.asamk.signal.manager.api.GroupMember;
 import org.asamk.signal.manager.api.RecipientAddress;
 import org.asamk.signal.output.JsonWriter;
 import org.asamk.signal.output.OutputWriter;
@@ -40,55 +37,33 @@ public class ListGroupsCommand implements JsonRpcLocalCommand {
         subparser.addArgument("-g", "--group-id").help("Specify one or more group IDs to show.").nargs("*");
     }
 
-    private static Set<String> resolveMembers(Set<GroupMember> addresses) {
-        return addresses.stream()
-                .map(m -> m.recipientAddress().getLegacyIdentifier() + (m.isAdmin() ? "{ADMIN}" : "") + (
-                        m.labelEmoji() != null || m.label() != null ? "(" + (
-                                m.labelEmoji() != null ? m.labelEmoji() : ""
-                        ) + (
-                                m.label() != null ? m.label() : ""
-                        ) + ")" : ""
-                ))
-                .collect(Collectors.toSet());
-    }
-
-    private static Set<String> resolveMemberAddress(Set<RecipientAddress> addresses) {
+    private static Set<String> resolveMembers(Set<RecipientAddress> addresses) {
         return addresses.stream().map(RecipientAddress::getLegacyIdentifier).collect(Collectors.toSet());
     }
 
-    private static Set<JsonGroupMemberAddress> resolveJsonMembers(Set<RecipientAddress> addresses) {
+    private static Set<JsonGroupMember> resolveJsonMembers(Set<RecipientAddress> addresses) {
         return addresses.stream()
-                .map(address -> new JsonGroupMemberAddress(address.number().orElse(null),
+                .map(address -> new JsonGroupMember(address.number().orElse(null),
                         address.uuid().map(UUID::toString).orElse(null)))
                 .collect(Collectors.toSet());
     }
 
-    private static Set<JsonGroupMember> resolveFullJsonMembers(Set<GroupMember> addresses) {
-        return addresses.stream().map(member -> {
-            final var address = member.recipientAddress();
-            return new JsonGroupMember(address.number().orElse(null),
-                    address.uuid().map(UUID::toString).orElse(null),
-                    member.isAdmin(),
-                    member.labelEmoji(),
-                    member.label());
-        }).collect(Collectors.toSet());
-    }
-
     private static void printGroupPlainText(PlainTextWriter writer, Group group, boolean detailed) {
         if (detailed) {
             final var groupInviteLink = group.groupInviteLinkUrl();
 
             writer.println(
-                    "Id: {} Name: {} Description: {} Active: {} Blocked: {} Members: {} Pending members: {} Requesting members: {} Banned: {} Message expiration: {} Link: {}",
+                    "Id: {} Name: {} Description: {} Active: {} Blocked: {} Members: {} Pending members: {} Requesting members: {} Admins: {} Banned: {} Message expiration: {} Link: {}",
                     group.groupId().toBase64(),
                     group.title(),
                     group.description(),
                     group.isMember(),
                     group.isBlocked(),
                     resolveMembers(group.members()),
-                    resolveMemberAddress(group.pendingMembers()),
-                    resolveMemberAddress(group.requestingMembers()),
-                    resolveMemberAddress(group.bannedMembers()),
+                    resolveMembers(group.pendingMembers()),
+                    resolveMembers(group.requestingMembers()),
+                    resolveMembers(group.adminMembers()),
+                    resolveMembers(group.bannedMembers()),
                     group.messageExpirationTimer() == 0 ? "disabled" : group.messageExpirationTimer() + "s",
                     groupInviteLink == null ? '-' : groupInviteLink.getUrl());
         } else {
@@ -121,14 +96,10 @@ public class ListGroupsCommand implements JsonRpcLocalCommand {
                             group.isMember(),
                             group.isBlocked(),
                             group.messageExpirationTimer(),
-                            resolveFullJsonMembers(group.members()),
+                            resolveJsonMembers(group.members()),
                             resolveJsonMembers(group.pendingMembers()),
                             resolveJsonMembers(group.requestingMembers()),
-                            resolveJsonMembers(group.members()
-                                    .stream()
-                                    .filter(GroupMember::isAdmin)
-                                    .map(GroupMember::recipientAddress)
-                                    .collect(Collectors.toSet())),
+                            resolveJsonMembers(group.adminMembers()),
                             resolveJsonMembers(group.bannedMembers()),
                             group.permissionAddMember().name(),
                             group.permissionEditDetails().name(),
@@ -154,23 +125,15 @@ public class ListGroupsCommand implements JsonRpcLocalCommand {
             boolean isBlocked,
             int messageExpirationTime,
             Set<JsonGroupMember> members,
-            Set<JsonGroupMemberAddress> pendingMembers,
-            Set<JsonGroupMemberAddress> requestingMembers,
-            @Deprecated Set<JsonGroupMemberAddress> admins,
-            Set<JsonGroupMemberAddress> banned,
+            Set<JsonGroupMember> pendingMembers,
+            Set<JsonGroupMember> requestingMembers,
+            Set<JsonGroupMember> admins,
+            Set<JsonGroupMember> banned,
             String permissionAddMember,
             String permissionEditDetails,
             String permissionSendMessage,
             String groupInviteLink
     ) {}
 
-    private record JsonGroupMemberAddress(String number, String uuid) {}
-
-    private record JsonGroupMember(
-            String number,
-            String uuid,
-            boolean isAdmin,
-            @JsonInclude(JsonInclude.Include.NON_NULL) String labelEmoji,
-            @JsonInclude(JsonInclude.Include.NON_NULL) String label
-    ) {}
+    private record JsonGroupMember(String number, String uuid) {}
 }

src/main/java/org/asamk/signal/commands/UpdateGroupCommand.java

@@ -75,8 +75,6 @@ public class UpdateGroupCommand implements JsonRpcLocalCommand {
                 .choices("every-member", "only-admins");
 
         subparser.addArgument("-e", "--expiration").type(int.class).help("Set expiration time of messages (seconds)");
-        subparser.addArgument("--member-label-emoji").help("Specify the emoji for the member label.");
-        subparser.addArgument("--member-label").help("Specify the string for the member label.");
     }
 
     GroupLinkState getGroupLinkState(String value) throws UserErrorException {
@@ -128,8 +126,6 @@ public class UpdateGroupCommand implements JsonRpcLocalCommand {
         var groupAddMemberPermission = getGroupPermission(ns.getString("set-permission-add-member"));
         var groupEditDetailsPermission = getGroupPermission(ns.getString("set-permission-edit-details"));
         var groupSendMessagesPermission = getGroupPermission(ns.getString("set-permission-send-messages"));
-        var memberLabelEmoji = ns.getString("member-label-emoji");
-        var memberLabelString = ns.getString("member-label");
 
         try {
             boolean isNewGroup = false;
@@ -163,8 +159,6 @@ public class UpdateGroupCommand implements JsonRpcLocalCommand {
                             .withIsAnnouncementGroup(groupSendMessagesPermission == null
                                     ? null
                                     : groupSendMessagesPermission == GroupPermission.ONLY_ADMINS)
-                            .withLabelEmoji(memberLabelEmoji)
-                            .withLabelString(memberLabelString)
                             .build());
             if (results != null) {
                 if (groupMessageResults == null) {

src/main/java/org/asamk/signal/dbus/DbusManagerImpl.java

@@ -12,7 +12,6 @@ import org.asamk.signal.manager.api.DeviceLinkUrl;
 import org.asamk.signal.manager.api.Group;
 import org.asamk.signal.manager.api.GroupId;
 import org.asamk.signal.manager.api.GroupInviteLinkUrl;
-import org.asamk.signal.manager.api.GroupMember;
 import org.asamk.signal.manager.api.GroupNotFoundException;
 import org.asamk.signal.manager.api.GroupPermission;
 import org.asamk.signal.manager.api.GroupSendingNotAllowedException;
@@ -835,22 +834,24 @@ public class DbusManagerImpl implements Manager {
         final var group = getRemoteObject(groupPath, Signal.Group.class).GetAll("org.asamk.Signal.Group");
         final var id = (byte[]) group.get("Id").getValue();
         try {
-            final var admins = new HashSet<>(((List<String>) group.get("Admins").getValue()));
             return new Group(GroupId.unknownVersion(id),
                     (String) group.get("Name").getValue(),
                     (String) group.get("Description").getValue(),
                     GroupInviteLinkUrl.fromUri((String) group.get("GroupInviteLink").getValue()),
                     ((List<String>) group.get("Members").getValue()).stream()
-                            .map(m -> new GroupMember(new RecipientAddress(m), admins.contains(m), null, null))
+                            .map(m -> new RecipientAddress(m))
                             .collect(Collectors.toSet()),
                     ((List<String>) group.get("PendingMembers").getValue()).stream()
-                            .map(RecipientAddress::new)
+                            .map(m -> new RecipientAddress(m))
                             .collect(Collectors.toSet()),
                     ((List<String>) group.get("RequestingMembers").getValue()).stream()
-                            .map(RecipientAddress::new)
+                            .map(m -> new RecipientAddress(m))
+                            .collect(Collectors.toSet()),
+                    ((List<String>) group.get("Admins").getValue()).stream()
+                            .map(m -> new RecipientAddress(m))
                             .collect(Collectors.toSet()),
                     ((List<String>) group.get("Banned").getValue()).stream()
-                            .map(RecipientAddress::new)
+                            .map(m -> new RecipientAddress(m))
                             .collect(Collectors.toSet()),
                     (boolean) group.get("IsBlocked").getValue(),
                     (int) group.get("MessageExpirationTimer").getValue(),

src/main/java/org/asamk/signal/dbus/DbusSignalImpl.java

@@ -10,7 +10,6 @@ import org.asamk.signal.manager.api.DeviceLinkUrl;
 import org.asamk.signal.manager.api.GroupId;
 import org.asamk.signal.manager.api.GroupInviteLinkUrl;
 import org.asamk.signal.manager.api.GroupLinkState;
-import org.asamk.signal.manager.api.GroupMember;
 import org.asamk.signal.manager.api.GroupNotFoundException;
 import org.asamk.signal.manager.api.GroupPermission;
 import org.asamk.signal.manager.api.GroupSendingNotAllowedException;
@@ -625,7 +624,7 @@ public class DbusSignalImpl implements Signal, AutoCloseable {
         if (group == null) {
             return List.of();
         } else {
-            final var members = group.members().stream().map(GroupMember::recipientAddress).collect(Collectors.toSet());
+            final var members = group.members();
             return getRecipientStrings(members);
         }
     }
@@ -1301,20 +1300,13 @@ public class DbusSignalImpl implements Signal, AutoCloseable {
                                     () -> getGroup().messageExpirationTimer(),
                                     this::setMessageExpirationTime),
                             new DbusProperty<>("Members",
-                                    () -> new Variant<>(getRecipientStrings(getGroup().members()
-                                            .stream()
-                                            .map(GroupMember::recipientAddress)
-                                            .collect(Collectors.toSet())), "as")),
+                                    () -> new Variant<>(getRecipientStrings(getGroup().members()), "as")),
                             new DbusProperty<>("PendingMembers",
                                     () -> new Variant<>(getRecipientStrings(getGroup().pendingMembers()), "as")),
                             new DbusProperty<>("RequestingMembers",
                                     () -> new Variant<>(getRecipientStrings(getGroup().requestingMembers()), "as")),
                             new DbusProperty<>("Admins",
-                                    () -> new Variant<>(getRecipientStrings(getGroup().members()
-                                            .stream()
-                                            .filter(GroupMember::isAdmin)
-                                            .map(GroupMember::recipientAddress)
-                                            .collect(Collectors.toSet())), "as")),
+                                    () -> new Variant<>(getRecipientStrings(getGroup().adminMembers()), "as")),
                             new DbusProperty<>("Banned",
                                     () -> new Variant<>(getRecipientStrings(getGroup().bannedMembers()), "as")),
                             new DbusProperty<>("PermissionAddMember",

src/main/resources/META-INF/native-image/org.asamk/signal-cli/reachability-metadata.json

@@ -2048,19 +2048,6 @@
       "allDeclaredMethods": true,
       "allDeclaredConstructors": true
     },
-    {
-      "type": "org.asamk.signal.commands.ListGroupsCommand$JsonGroupMemberAddress",
-      "methods": [
-        {
-          "name": "number",
-          "parameterTypes": []
-        },
-        {
-          "name": "uuid",
-          "parameterTypes": []
-        }
-      ]
-    },
     {
       "type": "org.asamk.signal.commands.ListIdentitiesCommand$JsonIdentity",
       "allDeclaredFields": true,
@@ -7806,18 +7793,6 @@
     {
       "type": "org.whispersystems.signalservice.internal.push.GroupMismatchedDevices[]"
     },
-    {
-      "type": "org.whispersystems.signalservice.internal.push.GroupPatchResponse",
-      "methods": [
-        {
-          "name": "<init>",
-          "parameterTypes": [
-            "java.lang.Integer",
-            "java.lang.String"
-          ]
-        }
-      ]
-    },
     {
       "type": "org.whispersystems.signalservice.internal.push.GroupStaleDevices",
       "allDeclaredFields": true,