nik/FreedomBox
1
0
Fork 0
mirror of https://github.com/freedombox/FreedomBox.git synced 2026-01-21 07:55:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

uninstall: Use reverse order when uninstalling components

Browse Source 
Tests:

- Functional tests for bepasty app work.

Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
Reviewed-by: James Valleroy <jvalleroy@mailbox.org>
This commit is contained in:
Sunil Mohan Adapa 2025-05-15 16:01:27 -07:00 committed by James Valleroy
parent ad2908630c
commit 3b1eba216a
No known key found for this signature in database
GPG Key ID: 77C0C75E7B650808
2 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
plinth/app.py
View File

@ -147,7 +147,9 @@ class App:
def uninstall(self):
"""De-configure and uninstall the app."""
for component in self.components.values():
# Remove components in the reverse order so that dependencies among
# components is properly satisfied.
for component in reversed(self.components.values()):
component.uninstall()
def get_setup_state(self) -> SetupState:

4
plinth/tests/test_package.py
View File

@ -264,8 +264,8 @@ def test_packages_uninstall_exclusion(cache, uninstall,
TestApp3()
app1.uninstall()
uninstall.assert_has_calls([
call(['package11', 'package3', 'dep6'], purge=True),
call(['package12', 'package3'], purge=True)
call(['package12', 'package3'], purge=True),
call(['package11', 'package3', 'dep6'], purge=True)
])