nik/FreedomBox
1
0
Fork 0
mirror of https://github.com/freedombox/FreedomBox.git synced 2026-01-21 07:55:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

views: Fix failure in redirecting from language selection page

Browse Source 
is_safe_url() expects allowed_hosts argument instead of host. This is an
internal method. Found by reviewing the release notes for Django 2.0, 2.1 and
2.2. This should be final change needed for Django 2.2 support.

Closes: #1518.

Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
Reviewed-by: James Valleroy <jvalleroy@mailbox.org>
This commit is contained in:
Sunil Mohan Adapa 2019-08-30 18:01:32 -07:00 committed by James Valleroy
parent 8266d61192
commit 7dbdb8037a
No known key found for this signature in database
GPG Key ID: 77C0C75E7B650808
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
plinth/views.py
View File

@ -101,7 +101,8 @@ class LanguageSelectionView(FormView):
"""Return the URL in the next parameter or home page."""
redirect_to = self.request.GET.get(REDIRECT_FIELD_NAME, '')
redirect_to = self.request.POST.get(REDIRECT_FIELD_NAME, redirect_to)
if is_safe_url(url=redirect_to, host=self.request.get_host()):
if is_safe_url(url=redirect_to,
allowed_hosts={self.request.get_host()}):
return redirect_to
return reverse('index')