nik/FreedomBox
1
0
Fork 0
mirror of https://github.com/freedombox/FreedomBox.git synced 2026-05-27 10:44:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

backups: Fix issue with showing exports from disks without labels

Browse Source 
When a disk does not have a label, its device path is used. This contains a '/'
which by default is not encoded by 'urlencode' filter in Django templates. This
leads to the expected URL not matching the regex in urls.py. Fix this by
ensuring that '/' is also encoded by 'urlencode'.

Reviewed-by: James Valleroy <jvalleroy@mailbox.org>
This commit is contained in:
Joseph Nuthalapati 2018-10-22 11:25:20 -07:00 committed by James Valleroy
parent 41b8c16a68
commit d5860ac179
No known key found for this signature in database
GPG Key ID: 77C0C75E7B650808
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
plinth/modules/backups/templates/backups.html
View File

@ -120,11 +120,11 @@
<td class="export-name">{{ name }}</td> <td class="export-name">{{ name }}</td>
<td class="export-operations"> <td class="export-operations">
<a class="download btn btn-sm btn-default" target="_blank" <a class="download btn btn-sm btn-default" target="_blank"
href="{% url 'backups:download' label|urlencode name|urlencode %}"> href="{% url 'backups:download' label|urlencode:'' name|urlencode:'' %}">
{% trans "Download" %} {% trans "Download" %}
</a> </a>
<a class="restore btn btn-sm btn-default" <a class="restore btn btn-sm btn-default"
href="{% url 'backups:restore' label|urlencode name|urlencode %}"> href="{% url 'backups:restore' label|urlencode:'' name|urlencode:'' %}">
{% trans "Restore" %} {% trans "Restore" %}
</a> </a>
</td> </td>