As reported by Jan Costermans, it is possible that for an access point
scanned by a Wi-Fi device, get_ssid() returns None. The reported as
follows:
if access_point.get_ssid().get_data() == ssid:
AttributeError: 'NoneType' object has no attribute 'get_data'
- A lot of boiler plate code can be removed from Plinth if enabling and
disabling an application can be done using a common base form.
- This also allows to define a reusable method in an application for
enabling and disabling.
- This brings more structure to a application module and paves way for
having a different views such as dashboard.
- Run tests on Ubuntu Trusty (14.04) instead of Ubuntu Precise (12.04).
- Use pygobject instead of pgi to test what we actually use in
production.
- Use a virtualenv trick to make sure that Python actually picks up
system packages (python3-gi).
https://pygobject.readthedocs.org/en/latest/testing.html#example-travis-ci-configuration
- Don't let apt-get hang for user input. Specify -y.
- Since we are trusting the remote user header, it is much safer not
listen on external addresses. We don't that since Apache connects on
internal address.
- There is no reason to limit the number of languages supported by the
application. This is what happens when LANGUAGES is set during Django
configuration. Users should be able to set a language using browser
preferences and see at least the Django translated messages even if
Plinth messages are not translated (example user create/edit form).
- If we wish to limit the number of language options shown duing
language selection (for quality perception reasons), we should perform
the limiting at the time of configuration.
- Note that when a new language is requested in translation tool, we
create an empty file and that may lead to language being shown but
with few strings actually translated. This will have poor impact on
user experience. I wonder if we should filter language at all,
keeping this in mind.
pgi 0.0.11.1 does not build successfully however 0.0.10.1 works.
Reported upstream issue https://github.com/lazka/pgi/issues/31.
Meanwile, to fix the builds, depend on older version.
