4156 Commits

Author SHA1 Message Date
Sunil Mohan Adapa
ebca76b236
utils: Introduce abstraction over distutils comparison of versions
In future, if the semantics need to better align with Debian's version
comparison, we can implement that easily.

Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
Reviewed-by: James Valleroy <jvalleroy@mailbox.org>
2019-03-01 23:50:37 -05:00
Sunil Mohan Adapa
3d57feac24
setup: Pass better data structure for force upgrade operation
Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
Reviewed-by: James Valleroy <jvalleroy@mailbox.org>
2019-03-01 23:50:34 -05:00
James Valleroy
d4fa87bbf1
users: When ssh used in tests, add users to admin group
This allows the tests to pass even if logins are restricted by
security module.

Signed-off-by: James Valleroy <jvalleroy@mailbox.org>
Reviewed-by: Sunil Mohan Adapa <sunil@medhas.org>
2019-03-01 20:09:43 -08:00
James Valleroy
7ee48da299
security: Migrate access config to new file
Fixes #1504

Signed-off-by: James Valleroy <jvalleroy@mailbox.org>
Reviewed-by: Sunil Mohan Adapa <sunil@medhas.org>
2019-03-01 20:09:40 -08:00
Sunil Mohan Adapa
f524219387
openvpn: Work around firewalld bug 919517
Instead of using a wildcard tun+ interface, use a fixed number of tun
interfaces and hope OpenVPN will use one of them.

Fixes: #1438.

Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
Reviewed-by: James Valleroy <jvalleroy@mailbox.org>
2019-03-01 22:01:09 -05:00
Sunil Mohan Adapa
b8d4b55c0a
openvpn: Make frontpage shortcut appear after an upgrade
Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
Reviewed-by: James Valleroy <jvalleroy@mailbox.org>
2019-03-01 18:13:39 -05:00
Sunil Mohan Adapa
117c3d7507
openvpn: Fix issues with upgrade easy-rsa 2 to 3 migration
- Set permissions properly as if they are created newly.

- Ensure that configuration file is rewritten so that new certificate paths are
  used.

- Run easyrsa init-pki to ensure that configuration file is present.

- Create necessary empty directories as per new structure.

Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
Reviewed-by: James Valleroy <jvalleroy@mailbox.org>
2019-03-01 18:13:37 -05:00
Joseph Nuthalapati
0457f34c21
openvpn: Increment version number for easy-rsa 3 migration
Signed-off-by: Joseph Nuthalapati <njoseph@thoughtworks.com>
Reviewed-by: Sunil Mohan Adapa <sunil@medhas.org>
2019-03-01 18:13:34 -05:00
Joseph Nuthalapati
544c317cd2
openvpn: Migration from easy-rsa 2 to 3 for existing installations
- Change file and directory structure from easy-rsa 2's flat format to easy-rsa
  3's format.

Signed-off-by: Joseph Nuthalapati <njoseph@thoughtworks.com>
Reviewed-by: Sunil Mohan Adapa <sunil@medhas.org>
2019-03-01 18:13:27 -05:00
Sunil Mohan Adapa
2aef91b187
config: Don't pass configuration file argument to action
Due to security risk that a compromised Plinth process will give adversary the
ability to write to any file on the system.

Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
2019-03-01 13:23:04 -08:00
Joseph Nuthalapati
d1d3eae3db
config: Reset home page setting in freedombox.conf during migration
While moving the home page configuration to a new file, also reset the home page
path in freedombox.conf to its default setting of /plinth.

Signed-off-by: Joseph Nuthalapati <njoseph@thoughtworks.com>
Reviewed-by: Sunil Mohan Adapa <sunil@medhas.org>
2019-03-01 13:22:58 -08:00
Joseph Nuthalapati
530423d490
config: Revert changes in freedombox.conf to avoid conffile prompt
The changes made to freedombox.conf in moving the apache homepage configuration
to an external file freedombox-apache-homepage.conf will cause a conffile prompt
when upgrading to freedombox 19.2. Reverting changes in freedombox.conf to avoid
this.

Signed-off-by: Joseph Nuthalapati <njoseph@thoughtworks.com>
Reviewed-by: Sunil Mohan Adapa <sunil@medhas.org>
2019-03-01 13:22:32 -08:00
James Valleroy
7c01585f2b
debian/copyright: Fix filename for tahoe-lafs logo
Signed-off-by: James Valleroy <jvalleroy@mailbox.org>
2019-03-01 06:19:38 -05:00
Sunil Mohan Adapa
44dd3c0ec1
LICENSES: Remove files that are same license as rest of the source
No need to list them explicitly. They were added while the project was under the
AGPL-3+ license.

Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
2019-03-01 02:00:17 -08:00
Sunil Mohan Adapa
4fa1e2ab1b
static: Remove unused files
Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
2019-03-01 02:00:06 -08:00
Sunil Mohan Adapa
0a1a0cd1b4
debian/copyright: Update copyright for logos
Robert Martinez the original author transferred all copyrights for the initial
logo work to the FreedomBox foundation. The icons are derivatives of this work.

Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
2019-03-01 01:58:59 -08:00
Sunil Mohan Adapa
06d1b167bb
debian/copyright: Add license text for CC-BY-SA-3.0
Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
2019-03-01 01:58:35 -08:00
Sunil Mohan Adapa
1e48a64ddf
debian/copyright: Add license text for GPL-2 and GPL-3
They are different from GPL-2+ and GPL-3+.

Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
2019-03-01 01:57:59 -08:00
Sunil Mohan Adapa
f5c85471ee
debian/copyright: Add license text for public-domain
Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
2019-03-01 01:57:32 -08:00
Sunil Mohan Adapa
a4fdf3f703
debian/copyright: Add full text for AGPL-3+
Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
2019-03-01 01:57:29 -08:00
Sunil Mohan Adapa
130102e1f4
debian/copyright: Minor fixes
- Update copyright year for fonts based on information embedded in .ttf file.

- Remove incorrect copyright text.

- Each session should have only one copyright line.

- Fix syntax for multiple licenses.

Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
2019-03-01 01:57:07 -08:00
James Valleroy
e4e379926f
debian/copyright: Move some more app icons from LICENSES
Signed-off-by: James Valleroy <jvalleroy@mailbox.org>
2019-03-01 01:28:33 -08:00
James Valleroy
a1d130299a
debian/copyright: Include some URLs dropped from LICENSES
Signed-off-by: James Valleroy <jvalleroy@mailbox.org>
2019-03-01 01:28:30 -08:00
James Valleroy
2297defe3d
debian/copyright: Move more app icons from LICENSES
Signed-off-by: James Valleroy <jvalleroy@mailbox.org>
2019-03-01 01:28:26 -08:00
James Valleroy
990c2446a7
debian/copyright: Fix typo in year
Signed-off-by: James Valleroy <jvalleroy@mailbox.org>
2019-02-28 23:55:14 -08:00
James Valleroy
f2b45ea15b
debian/copyright: Move some app icons from LICENSES
Signed-off-by: James Valleroy <jvalleroy@mailbox.org>
2019-02-28 23:55:11 -08:00
James Valleroy
7b0957d795
debian/copyright: Remove unnecessary fields for native package
Signed-off-by: James Valleroy <jvalleroy@mailbox.org>
2019-02-28 23:55:07 -08:00
James Valleroy
d4b4d1e29f
debian/copyright: Move all license texts to end
Signed-off-by: James Valleroy <jvalleroy@mailbox.org>
2019-02-28 23:55:04 -08:00
James Valleroy
4e5b1f346f
debian: Add copyright info for theme images
Signed-off-by: James Valleroy <jvalleroy@mailbox.org>
2019-02-28 23:55:01 -08:00
James Valleroy
354b0ca78a
LICENSES: Add reference to debian/copyright
Signed-off-by: James Valleroy <jvalleroy@mailbox.org>
2019-02-28 23:54:58 -08:00
James Valleroy
2202439af8
debian: Add copyright info for individual logo files
Remove from LICENSES.

Signed-off-by: James Valleroy <jvalleroy@mailbox.org>
2019-02-28 23:54:54 -08:00
James Valleroy
5b9b1cbfa9
debian: Add copyright info for lato fonts
Remove from LICENSES.

Signed-off-by: James Valleroy <jvalleroy@mailbox.org>
2019-02-28 23:54:51 -08:00
Joseph Nuthalapati
668d4de77a
matrix-synapse: Fix LDAP login issue
Pass the `mail` attribute as an empty string instead of None (null in yaml)

Fixes #1484

Signed-off-by: Joseph Nuthalapati <njoseph@thoughtworks.com>
Reviewed-by: Sunil Mohan Adapa <sunil@medhas.org>
2019-02-28 19:13:59 -08:00
Sunil Mohan Adapa
ec68eb3d89
setup: Make additional info available for force upgrading
This includes list of packages for which conffile prompts will be shown. For
each package current version of the package, new version of the package and list
of configuration files that were modified.

Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
Reviewed-by: James Valleroy <jvalleroy@mailbox.org>
2019-02-28 20:48:51 -05:00
Sunil Mohan Adapa
7862325bb6
apache: Increment app version number
To trigger setting up all the necessary modules again.

Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
Reviewed-by: James Valleroy <jvalleroy@mailbox.org>
2019-02-28 20:13:48 -05:00
Sunil Mohan Adapa
7bdf47eea2
apache: Use cgid module instead of cgi
Trying to enable cgi module results in cgid being enabled. Checking for cgi
being enabled always results in failure.

Your MPM seems to be threaded. Selecting cgid instead of cgi.
Module cgid already enabled

No module matches cgi (disabled by site administrator)

This is the reason why installing ikiwiki was causing Apache restart even though
the modules required by ikiwiki are already enabled.

Closes: #1448.

Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
Reviewed-by: James Valleroy <jvalleroy@mailbox.org>
2019-02-28 20:13:45 -05:00
Sunil Mohan Adapa
3af207a4e8
sso: Pre-enable necessary apache modules
To avoid Apache restart during installation (although sso is an essential app
and this is not an issue).

Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
Reviewed-by: James Valleroy <jvalleroy@mailbox.org>
2019-02-28 20:13:42 -05:00
Sunil Mohan Adapa
33f54089b8
ikiwiki: Pre-enable necessary apache modules
To avoid restart during installation.

Closes: #1482.

Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
Reviewed-by: James Valleroy <jvalleroy@mailbox.org>
2019-02-28 20:13:40 -05:00
Sunil Mohan Adapa
cf06aa3d56
letsencrypt: Pre-enable necessary apache modules
To avoid restart during installation (although since letsencrypt is an essential
app and this is not an issue).

Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
Reviewed-by: James Valleroy <jvalleroy@mailbox.org>
2019-02-28 20:13:38 -05:00
Sunil Mohan Adapa
c50e322cdb
radicale, searx: Pre-enable necessary apache modules
To avoid Apache restart during installation.

Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
Reviewed-by: James Valleroy <jvalleroy@mailbox.org>
2019-02-28 20:13:36 -05:00
Sunil Mohan Adapa
3c420c1488
cockpit: Pre-enable necessary apache modules
To avoid Apache restart during installation.

Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
Reviewed-by: James Valleroy <jvalleroy@mailbox.org>
2019-02-28 20:13:33 -05:00
Joseph Nuthalapati
241d3a98d5
Disable Coquelicot for Buster release
As confirmed by multiple users, Coquelicot is no longer useful for uploading
files, which makes it useless as a file sharing application.

We might enable it in the future if it's actively maintained once again, or find
an alternative.

- Skip functional tests

- Disable modules-enabled file

Signed-off-by: Joseph Nuthalapati <njoseph@thoughtworks.com>
Reviewed-by: James Valleroy <jvalleroy@mailbox.org>
2019-02-28 18:34:14 -05:00
Sunil Mohan Adapa
ee87c00578
ttrss: Make functional test definitions specific to ttrss
- So as not to clash with future apps that may have feed add/remove capability.

Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
2019-02-26 15:24:09 -08:00
James Valleroy
1eed7d581d
ttrss: Add backup support
- Use backup hooks to dump and restore database.
- Add functional test for backup and restore.

Signed-off-by: James Valleroy <jvalleroy@mailbox.org>
Reviewed-by: Sunil Mohan Adapa <sunil@medhas.org>
2019-02-26 15:23:47 -08:00
James Valleroy
8a60581f3d
radicale: Add description of web interface
Signed-off-by: James Valleroy <jvalleroy@mailbox.org>
Reviewed-by: Sunil Mohan Adapa <sunil@medhas.org>
2019-02-26 12:50:11 -08:00
Joseph Nuthalapati
a4887ef0d0
users: Add nscd as a dependency
Currently, nscd comes as a recommended package of nslcd, which is a dependency
of Plinth. Plinth needs nscd to work. An installation with the --no-recommends
option will cause errors in Plinth.

Users is an essential package in plinth. nscd is now a managed package of users.

Fixes #1213

Signed-off-by: Joseph Nuthalapati <njoseph@thoughtworks.com>
Reviewed-by: Sunil Mohan Adapa <sunil@medhas.org>
2019-02-26 11:07:24 -08:00
Sunil Mohan Adapa
871215abb0
setup: Rush force upgrade in development mode
- So that developers don't have to wait a long time to see the changes.

Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
Reviewed-by: James Valleroy <jvalleroy@mailbox.org>
2019-02-26 06:24:25 -05:00
Sunil Mohan Adapa
d51a2b6865
bind: Handle conffile prompt during upgrade
- Simply keep the old configuration as the configuration format for bind is
  unlikely to change due to its stability. Future versions may consider checking
  for version of package being upgraded to.

- Don't start service if not already running.

- Don't perform firewall changes.

- No need to rerun setup as old configuration is being kept.

Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
Reviewed-by: James Valleroy <jvalleroy@mailbox.org>
2019-02-26 06:24:22 -05:00
Sunil Mohan Adapa
16252a10f3
setup: Trigger force upgrade for app that implement it
Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
Reviewed-by: James Valleroy <jvalleroy@mailbox.org>
2019-02-26 06:24:19 -05:00
Sunil Mohan Adapa
c8b2ba8c99
package: Helper method to filter packages that need conffile prompt
Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
Reviewed-by: James Valleroy <jvalleroy@mailbox.org>
2019-02-26 06:24:17 -05:00