25 Commits

Author SHA1 Message Date
Joseph Nuthalapati
19d96f30e8
snapshot: Sort snapshot list from newest to oldest
Fixes #1655

Signed-off-by: Joseph Nuthalapati <njoseph@riseup.net>
Reviewed-by: James Valleroy <jvalleroy@mailbox.org>
2019-11-04 06:15:48 -05:00
Sunil Mohan Adapa
12ea72eb0a
snapshot: Refactor configuration migration
- Only do the configuration based on version run the remaining setup code
  without considering version.

- Don't force upgrade/setup configuration when doing from version 4 and above.

- Force set cleanup=yes values during migration too.

Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
2019-01-08 14:01:34 -08:00
Joseph Nuthalapati
4fdd68cb3b
snapshot: Merge the functionality of the migrate command into setup
- Added a command-line argument called --old-version to the setup command based
  on which it can decide whether to do a new setup or a migration.
- Removed the migrate command.

Signed-off-by: Joseph Nuthalapati <njoseph@thoughtworks.com>
Reviewed-by: Sunil Mohan Adapa <sunil@medhas.org>
2019-01-08 13:59:56 -08:00
Joseph Nuthalapati
ad049af276
snapshot: Enable TIMELINE_CLEANUP and NUMBER_CLEANUP by default
Signed-off-by: Joseph Nuthalapati <njoseph@thoughtworks.com>
Reviewed-by: Sunil Mohan Adapa <sunil@medhas.org>
2019-01-08 13:59:30 -08:00
Joseph Nuthalapati
f68070c758
snapshot: ui: Remove NUMBER_MIN_AGE setting and add FREE_LIMIT
The free space limit value is allowed to a maximum of 60%, since setting the
it to a value higher than possible will effectively disable snapshotting.

Signed-off-by: Joseph Nuthalapati <njoseph@thoughtworks.com>
Reviewed-by: Sunil Mohan Adapa <sunil@medhas.org
2019-01-08 13:59:15 -08:00
Joseph Nuthalapati
8ba0bda869
snapshot: Fix snapshots filling up the disk
- Snapper's cleanup algorithms don't apply limits unless they are specified in
the form of ranges. Changed all limit values in the configuration to ranges.
- Also, all MIN_AGE values have been set to 0 to avoid the disk space filling up
in case of a large number of snapshots generated in a very short amount of time.
- FREE_LIMIT has been increased to 30% from the default 20% since backup
archives also take up disk space on the root partition.

Fixes #1435

Signed-off-by: Joseph Nuthalapati <njoseph@thoughtworks.com>
Reviewed-by: Sunil Mohan Adapa <sunil@medhas.org>
2019-01-08 13:57:46 -08:00
Joseph Nuthalapati
055e40820c
snapshots: Fix default snapshot listing
The latest snapper returns the currently active snapshot like "4*", which
interferes with both the urls and the templates. Stripping off the unnecessary
asterisk since we have better ways of detecting what the currently active
snapshot is.

Signed-off-by: Joseph Nuthalapati <njoseph@thoughtworks.com>
Reviewed-by: James Valleroy <jvalleroy@mailbox.org>
2018-12-02 11:08:01 -05:00
James Valleroy
30fd4015b7
snapshot: Handle snapper list output change
Fixes #1408.

Signed-off-by: James Valleroy <jvalleroy@mailbox.org>
Reviewed-by: Joseph Nuthalapati <njoseph@thoughtworks.com>
2018-10-25 15:11:32 +05:30
Joseph Nuthalapati
03a6cf25e5
snapshot: Enable backup/restore
Reviewed-by: James Valleroy <jvalleroy@mailbox.org>
2018-10-21 19:18:56 -04:00
Joseph Nuthalapati
a5d66a1362
snapshot: Fix issue with setting configuration
snapper set-config expects each key-value pair to be passed as a separate
argument separated by '='.

Reviewed-by: James Valleroy <jvalleroy@mailbox.org>
2018-10-21 19:18:37 -04:00
James Valleroy
04d5f12ae0
snapshot: Format code with yapf
Signed-off-by: James Valleroy <jvalleroy@mailbox.org>
2018-04-09 18:51:11 -04:00
Shubham Agarwal
0b3880a4cf
snapper: enable/diable apt snapshots
Reviewed-by: James Valleroy <jvalleroy@mailbox.org>
2018-04-09 18:43:00 -04:00
Joseph Nuthalapati
8416c0831d
snapshots: Fix for permissions issue when updating configuration
- Change `configure` command to `set-config` for consistency with `get-config`
- Run `set-config` as superuser

Fixes freedombox-team/plinth#1290

Signed-off-by: Joseph Nuthalapati <njoseph@thoughtworks.com>
Reviewed-by: James Valleroy <jvalleroy@mailbox.org>
2018-04-09 18:38:02 -04:00
Joseph Nuthalapati
9ab0e13ab9
snapshots: Refactoring and indentation changes
- Made updating snapshot configuration more efficient by running a single
  snapper command instead of one per configuration.
- Set default configuration for NUMBER_LIMIT only once at the time of
  installation. Snapshot version has been incremented to support this.

Signed-off-by: Joseph Nuthalapati <njoseph@thoughtworks.com>
2018-03-09 13:42:54 +05:30
Sunil Mohan Adapa
dea4af17fb
Rename Plinth to FreedomBox in license headers
Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
Reviewed-by: James Valleroy <jvalleroy@mailbox.org>
2018-02-16 20:10:09 -05:00
Joseph Nuthalapati
d74f42749d
snapshots: Increment version to 2
Signed-off-by: Joseph Nuthalapati <njoseph@thoughtworks.com>
2018-02-12 18:04:41 +05:30
Joseph Nuthalapati
3e5057e8cd
snapshots: Refactoring and text changes
Signed-off-by: Joseph Nuthalapati <njoseph@thoughtworks.com>
2018-02-12 17:44:16 +05:30
Aakanksha Saini
ace8abe34a
Snapper: Modify configurations to reduce disk usage
Signed-off-by: Aakanksha Saini <aakanksa@thoughtworks.com>
Signed-off-by: Shubham Agarwal <shubhama@thoughtworks.com>
Reviewed-by: Joseph Nuthalapati <njoseph@thoughtworks.com>
2018-02-12 17:43:06 +05:30
Joseph Nuthalapati
fe17a8e541
snapshot: Delete All should skip currently active snapshot
Delete All in case of rollbacks was failing because it cannot delete the
snapshot that's active. This has to be skipped and the remaining snapshots
deleted.

Also, the active snapshot won't be listed in the form to delete all snapshots.

Signed-off-by: Joseph Nuthalapati <njoseph@thoughtworks.com>
Reviewed-by: Sunil Mohan Adapa <sunil@medhas.org>
2018-02-12 16:40:33 +05:30
hanisha
76ffad7955
Option to enable/disble automatic timeline snapshots
Signed-off-by: Hanisha P<hanishap@thoughtworks.com>
Reviewed-by: Joseph Nuthalapati <njoseph@thoughtworks.com>
2017-12-18 12:21:01 +05:30
Joseph Nuthalapati
3e5dcfcbf5
snapshots: Button to delete all snapshots
- closes #1144

Signed-off-by: Joseph Nuthalapati <njoseph@thoughtworks.com>
Reviewed-by: James Valleroy <jvalleroy@mailbox.org>
2017-12-14 10:04:07 -05:00
Johannes Keyser
634afef1c9
actions: Make subparsers mandatory, fixes calls without arguments
Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
2017-04-10 11:54:23 +05:30
Sunil Mohan Adapa
395155d306
snapshot: Use augeas for modifying fstab 2016-08-08 22:22:04 +05:30
Sunil Mohan Adapa
d615709b8a
snapshot: Improved messages and minor refactoring
- Make the default snapshot detection slightly more robust and refactor.

- Expand description to explain automatic snapshotting, etc.

- Show description even after setup.

- Show default snapshot as a bootstrap label.

- Message explaing how rollback can be undone.

- Minor updates to delete/rollback confirmation messages.

- Minor style refactoring
2016-08-08 22:21:31 +05:30
James Valleroy
5e18a648e1
snapshot: New module for disk snapshots
- Create and list filesystem snapshots. Hide "current" snapshot.

- Allow deleting snapshots, except for default subvolume.

- Allow rollback to a snapshot.
2016-08-08 22:21:21 +05:30