mirror of
https://github.com/freedombox/FreedomBox.git
synced 2026-04-22 10:01:45 +00:00
- Don't use command line argument for sending the join password for security. - murmurd can switch to mumble-server UID before performing database operations. Remove code to switch to mumble-server user. - murmurd seems to return correct response code of 0 upon successfully setting the password. Simplify code accordingly. - Use subprocess.run() instead of subprocess.Popen for convenience. Tests: - Run functional and unit tests on Debian stable. - Perform a fresh installation. - Verify that setting super user password works. - Verify that setting root channel names works. - Verify that setting join password works. Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org> Reviewed-by: James Valleroy <jvalleroy@mailbox.org>