Sunil Mohan Adapa 7470821dc7
mumble: Use privileged decorator for superuser actions
- Don't use command line argument for sending the join password for security.

- murmurd can switch to mumble-server UID before performing database operations.
Remove code to switch to mumble-server user.

- murmurd seems to return correct response code of 0 upon successfully setting
the password. Simplify code accordingly.

- Use subprocess.run() instead of subprocess.Popen for convenience.

Tests:

- Run functional and unit tests on Debian stable.

- Perform a fresh installation.

- Verify that setting super user password works.

- Verify that setting root channel names works.

- Verify that setting join password works.

Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
Reviewed-by: James Valleroy <jvalleroy@mailbox.org>
2022-06-24 08:41:23 -04:00

53 lines
1.7 KiB
Python

# SPDX-License-Identifier: AGPL-3.0-or-later
"""
Views for mumble app.
"""
from django.contrib import messages
from django.utils.translation import gettext_lazy as _
from plinth.modules import mumble
from plinth.modules.mumble.forms import MumbleForm
from plinth.views import AppView
from . import privileged
class MumbleAppView(AppView):
app_id = 'mumble'
form_class = MumbleForm
def get_initial(self):
"""Return the values to fill in the form."""
initial = super().get_initial()
initial['domain'] = mumble.get_domain()
initial['root_channel_name'] = privileged.get_root_channel_name()
return initial
def form_valid(self, form):
"""Apply form changes."""
new_config = form.cleaned_data
if mumble.get_domain() != new_config['domain']:
privileged.set_domain(new_config['domain'])
mumble.app.get_component('letsencrypt-mumble').setup_certificates()
messages.success(self.request, _('Configuration updated'))
password = new_config.get('super_user_password')
if password:
privileged.set_super_user_password(password)
messages.success(self.request,
_('SuperUser password successfully updated.'))
join_password = new_config.get('join_password')
if join_password:
privileged.change_join_password(join_password)
messages.success(self.request, _('Join password changed'))
name = new_config.get('root_channel_name')
if name:
privileged.change_root_channel_name(name)
messages.success(self.request, _('Root channel name changed.'))
return super().form_valid(form)