mirror of
https://github.com/freedombox/FreedomBox.git
synced 2026-01-21 07:55:00 +00:00
e04ae48637
- Handle groups needed by an app.
- Handle reserved usernames for an app.
- Updated documentation
- Updated unit tests
Tests performed:
- Reserved usernames: ez-ipupd, ejabberd, Debian-minetest, mldonkey,
monkeysphere, mumble-server, privoxy, quasselcore, radicale, debian-tor,
debian-transmission
- Reserved usernames checks should work in the following forms:
- Create user
- Update user
- First boot user creation
- Full list of available groups should appear in following cases:
- Create user form
- Update user form
- Full list of groups should get created in Django DB during:
- Update user form display
- First boot form save
- When updating the last admin user, the 'admin' group choice is checked
and disabled.
- Following groups show up (sorted by group name):
- bit-torrent: Download files using BitTorrent applications
- git-access: Read-write access to Git repositories
- i2p: Manage I2P application
- wiki: View and edit wiki applications
- minidlna: Media streaming server
- ed2k: Download files using eDonkey applications
- freedombox-share: Access to the private shares
- web-search: Search the web
- syncthing: Administer Syncthing application
- feed-reader: Read and subscribe to news feeds
- admin: Access to all services and system settings
- Directory validation form checks for write permissions for following apps:
- deluge with debian-deluged user
- transmission with debian-transmission user
- Sharing app should show all the groups in add/edit share forms
- The following apps should get added to share group during setup:
debian-transmission
debian-deluged
- Unit tests pass
- Functional tests for users and groups pass
- Test that an app (example syncthing) provides the necessary
permissions to users in that group (but not in admin group).
Signed-off-by: Joseph Nuthalapati <njoseph@riseup.net>
[sunil: Fix i18n of group descriptions]
[sunil: Update developer documentation]
[sunil: Separate out cosmetic changes]
[sunil: Fix component ID for mumble]
[sunil: sharing: Remove unneeded dependency on users app]
[sunil: Implement better API for getting groups in component]
[sunil: Fix incorrect regression change ttrss app]
[sunil: Make iterating over gourps more readable]
[sunil: Improve tests, drop single use fixtures]
[sunil: Simplify test_view.py fixture]
Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
Tested-by: Sunil Mohan Adapa <sunil@medhas.org>
Reviewed-by: Sunil Mohan Adapa <sunil@medhas.org>
Reviewed-by: James Valleroy <jvalleroy@mailbox.org>
65 lines
2.3 KiB
Python
65 lines
2.3 KiB
Python
# SPDX-License-Identifier: AGPL-3.0-or-later
|
|
"""
|
|
Django forms for sharing app.
|
|
"""
|
|
|
|
from django import forms
|
|
from django.core.exceptions import ValidationError
|
|
from django.utils.translation import ugettext_lazy as _
|
|
|
|
from plinth.modules import sharing
|
|
from plinth.modules.users.components import UsersAndGroups
|
|
|
|
|
|
class AddShareForm(forms.Form):
|
|
"""Form to add a new share."""
|
|
|
|
name = forms.RegexField(
|
|
label=_('Name of the share'), strip=True, regex=r'^[a-z0-9]+$',
|
|
help_text=_(
|
|
'A lowercase alpha-numeric string that uniquely identifies a '
|
|
'share. Example: <em>media</em>.'))
|
|
|
|
path = forms.CharField(
|
|
label=_('Path to share'), strip=True, help_text=_(
|
|
'Disk path to a folder on this server that you intend to share.'))
|
|
|
|
is_public = forms.BooleanField(
|
|
label=_('Public share'), required=False, help_text=_(
|
|
'Make files in this folder available to anyone with the link.'))
|
|
|
|
groups = forms.MultipleChoiceField(
|
|
choices=UsersAndGroups.get_group_choices,
|
|
widget=forms.CheckboxSelectMultiple, required=False,
|
|
label=_('User groups that can read the files in the share'),
|
|
help_text=_(
|
|
'Users of the selected user groups will be able to read the '
|
|
'files in the share.'))
|
|
|
|
def __init__(self, *args, **kwargs):
|
|
"""Initialize the form with extra request argument."""
|
|
super().__init__(*args, **kwargs)
|
|
self.fields['name'].widget.attrs.update({'autofocus': 'autofocus'})
|
|
|
|
def clean_name(self):
|
|
"""Check if the name is valid."""
|
|
name = self.cleaned_data['name']
|
|
if 'name' in self.initial and name == self.initial['name']:
|
|
return name
|
|
|
|
if any((share for share in sharing.list_shares()
|
|
if name == share['name'])):
|
|
raise ValidationError(_('A share with this name already exists.'))
|
|
|
|
return name
|
|
|
|
def clean(self):
|
|
"""Check that at least one group is added for non-public shares."""
|
|
super(AddShareForm, self).clean()
|
|
is_public = self.cleaned_data.get('is_public')
|
|
groups = self.cleaned_data.get('groups')
|
|
if not is_public and not groups:
|
|
raise forms.ValidationError(
|
|
_('Shares should be either public or shared with at '
|
|
'least one group'))
|