mirror of
https://github.com/freedombox/FreedomBox.git
synced 2026-01-21 07:55:00 +00:00
e04ae48637
- Handle groups needed by an app.
- Handle reserved usernames for an app.
- Updated documentation
- Updated unit tests
Tests performed:
- Reserved usernames: ez-ipupd, ejabberd, Debian-minetest, mldonkey,
monkeysphere, mumble-server, privoxy, quasselcore, radicale, debian-tor,
debian-transmission
- Reserved usernames checks should work in the following forms:
- Create user
- Update user
- First boot user creation
- Full list of available groups should appear in following cases:
- Create user form
- Update user form
- Full list of groups should get created in Django DB during:
- Update user form display
- First boot form save
- When updating the last admin user, the 'admin' group choice is checked
and disabled.
- Following groups show up (sorted by group name):
- bit-torrent: Download files using BitTorrent applications
- git-access: Read-write access to Git repositories
- i2p: Manage I2P application
- wiki: View and edit wiki applications
- minidlna: Media streaming server
- ed2k: Download files using eDonkey applications
- freedombox-share: Access to the private shares
- web-search: Search the web
- syncthing: Administer Syncthing application
- feed-reader: Read and subscribe to news feeds
- admin: Access to all services and system settings
- Directory validation form checks for write permissions for following apps:
- deluge with debian-deluged user
- transmission with debian-transmission user
- Sharing app should show all the groups in add/edit share forms
- The following apps should get added to share group during setup:
debian-transmission
debian-deluged
- Unit tests pass
- Functional tests for users and groups pass
- Test that an app (example syncthing) provides the necessary
permissions to users in that group (but not in admin group).
Signed-off-by: Joseph Nuthalapati <njoseph@riseup.net>
[sunil: Fix i18n of group descriptions]
[sunil: Update developer documentation]
[sunil: Separate out cosmetic changes]
[sunil: Fix component ID for mumble]
[sunil: sharing: Remove unneeded dependency on users app]
[sunil: Implement better API for getting groups in component]
[sunil: Fix incorrect regression change ttrss app]
[sunil: Make iterating over gourps more readable]
[sunil: Improve tests, drop single use fixtures]
[sunil: Simplify test_view.py fixture]
Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
Tested-by: Sunil Mohan Adapa <sunil@medhas.org>
Reviewed-by: Sunil Mohan Adapa <sunil@medhas.org>
Reviewed-by: James Valleroy <jvalleroy@mailbox.org>
68 lines
2.2 KiB
Python
68 lines
2.2 KiB
Python
# SPDX-License-Identifier: AGPL-3.0-or-later
|
|
"""
|
|
Tests for the UsersAndGroups app component.
|
|
"""
|
|
|
|
import pytest
|
|
|
|
from ..components import UsersAndGroups
|
|
|
|
|
|
@pytest.fixture(autouse=True)
|
|
def fixture_empty_components():
|
|
"""Remove all components from the global list before every test."""
|
|
UsersAndGroups._all_components = set()
|
|
|
|
|
|
def test_create_users_and_groups_component():
|
|
"""Test initialization of users and groups component."""
|
|
component = UsersAndGroups('simple-component')
|
|
assert component.groups == {}
|
|
assert component.reserved_usernames == []
|
|
assert len(component._all_components) == 1
|
|
assert component in component._all_components
|
|
|
|
groups = {'test-group1', 'Test description'}
|
|
component = UsersAndGroups('another-component', groups=groups,
|
|
reserved_usernames=['test-user1'])
|
|
assert component.groups == groups
|
|
assert component.reserved_usernames == ['test-user1']
|
|
assert len(component._all_components) == 2
|
|
assert component in component._all_components
|
|
|
|
|
|
def test_get_groups():
|
|
"""Test getting all the groups.
|
|
|
|
Test that:
|
|
1. Group names are unique
|
|
2. All components have the same global set of groups
|
|
|
|
"""
|
|
UsersAndGroups('component-with-no-groups')
|
|
UsersAndGroups('component-with-one-group',
|
|
groups={'group1': 'description1'})
|
|
UsersAndGroups('component-with-groups', groups={
|
|
'group1': 'description1',
|
|
'group2': 'description2'
|
|
})
|
|
|
|
assert UsersAndGroups.get_groups() == {'group1', 'group2'}
|
|
assert UsersAndGroups.get_group_choices() == [
|
|
('group1', 'description1 (group1)'),
|
|
('group2', 'description2 (group2)')
|
|
]
|
|
|
|
|
|
def test_check_username_reservation():
|
|
"""Test username reservations by multiple components."""
|
|
UsersAndGroups('complex-component',
|
|
reserved_usernames=['username1', 'username2'],
|
|
groups={'somegroup', 'some description'})
|
|
assert not UsersAndGroups.is_username_reserved('something')
|
|
assert UsersAndGroups.is_username_reserved('username1')
|
|
|
|
assert not UsersAndGroups.is_username_reserved('username3')
|
|
UsersAndGroups('temp-component', reserved_usernames=['username3'])
|
|
assert UsersAndGroups.is_username_reserved('username3')
|