If SQLite clearAll fails mid-panic, in-memory state was already cleared
but a process restart could reload encrypted history from disk (#699).
Fall back to deleting the database files before reporting failure.
A relay that fails is retried on an exponential backoff, then abandoned
for the lifetime of the process. Nothing brings it back: the relay layer
registers no connectivity callback, the periodic subscription validator
only repairs subscriptions on sockets that are already open (and returns
immediately when connectedRelayCount is 0, which is exactly the state
after an outage), and connect() runs once from NostrClient.initialize().
The remaining paths that reset reconnectAttempts are a manual retry, a
Tor state change, and a successful open.
Two ways a relay died permanently:
- Any error whose message mentioned DNS returned before scheduling
anything at all. "Unable to resolve host" is what this device reports
when it simply has no network, so a moment in a tunnel killed every
relay at once, with no retry ever.
- Otherwise the schedule stopped at MAX_RECONNECT_ATTEMPTS. With
INITIAL=1s and MULTIPLIER=2 that is nine waits totalling about eight
and a half minutes, after which the relay was dead. MAX_BACKOFF_INTERVAL
was unreachable: attempt 9 asks for 256s and attempt 10 gave up, so the
five-minute ceiling the constant defines never applied to anything.
Let the backoff saturate at MAX_BACKOFF_INTERVAL and keep retrying there.
A name-resolution failure now backs off like any other error. Steady state
costs one connection attempt per relay per five minutes; the previous
behaviour cost the user every internet DM, delivery receipt and geohash
channel until they noticed and restarted the app.
The schedule moves into RelayReconnectPolicy so it is unit-testable
without OkHttp or a Context.
Pins the ASCII behaviour so the limit is provably unchanged, then covers the
cases that used to break: a split surrogate pair, a ZWJ sequence, and a name
that is one long grapheme. A sweep over four names at every limit from 1 to 20
asserts the result is always a prefix, always inside the limit, and never ends
in a lone surrogate.
truncateNickname compared and cut with String.length and take, both of which
count UTF-16 code units. A name whose 15th unit is the high surrogate of an
emoji lost its low surrogate, leaving a lone U+D83D that renders as a tofu box
wherever the name is shown - the peer list, the geohash people list, and every
inline mention.
Step back to the last grapheme boundary at or before the limit instead, so a
truncated name is always whole. The limit itself is unchanged, so an ASCII
name truncates exactly as before.
