If SQLite clearAll fails mid-panic, in-memory state was already cleared
but a process restart could reload encrypted history from disk (#699).
Fall back to deleting the database files before reporting failure.
A relay that fails is retried on an exponential backoff, then abandoned
for the lifetime of the process. Nothing brings it back: the relay layer
registers no connectivity callback, the periodic subscription validator
only repairs subscriptions on sockets that are already open (and returns
immediately when connectedRelayCount is 0, which is exactly the state
after an outage), and connect() runs once from NostrClient.initialize().
The remaining paths that reset reconnectAttempts are a manual retry, a
Tor state change, and a successful open.
Two ways a relay died permanently:
- Any error whose message mentioned DNS returned before scheduling
anything at all. "Unable to resolve host" is what this device reports
when it simply has no network, so a moment in a tunnel killed every
relay at once, with no retry ever.
- Otherwise the schedule stopped at MAX_RECONNECT_ATTEMPTS. With
INITIAL=1s and MULTIPLIER=2 that is nine waits totalling about eight
and a half minutes, after which the relay was dead. MAX_BACKOFF_INTERVAL
was unreachable: attempt 9 asks for 256s and attempt 10 gave up, so the
five-minute ceiling the constant defines never applied to anything.
Let the backoff saturate at MAX_BACKOFF_INTERVAL and keep retrying there.
A name-resolution failure now backs off like any other error. Steady state
costs one connection attempt per relay per five minutes; the previous
behaviour cost the user every internet DM, delivery receipt and geohash
channel until they noticed and restarted the app.
The schedule moves into RelayReconnectPolicy so it is unit-testable
without OkHttp or a Context.
closestRelaysForGeohash wraps the decode in a try/catch and returns an
empty list on failure, but decodeToCenter never throws: it hands back
(0, 0), so an empty or malformed geohash quietly selects the relays
nearest the Gulf of Guinea and connects to them.
Use the nullable decoder, so the empty-list path the code already
intended is the one that runs.
Geohash.decodeToBounds maps an empty or malformed string onto the
degenerate box at (0, 0), and decodeToCenter therefore returns (0, 0) —
which is a real place in the Gulf of Guinea, so a caller cannot tell
"could not decode" from "the user picked the origin".
Add isValid plus decodeToCenterOrNull / decodeToBoundsOrNull, and say in
the doc comments which one to reach for. The existing decoders keep their
behaviour, since the map view relies on getting a box back.
