mirror of
https://github.com/permissionlesstech/bitchat-android.git
synced 2026-08-15 06:56:30 +00:00
7b86bafbac
The cooldown was tracked in two places. ApkRateLimitStore persisted it per scope and per route, and the ViewModel kept a second copy in downloadRetryAtMillis plus a retryAtMillis on Resumable and Error, frozen into WorkManager output data on the way through. The copy was the weaker of the two: it lived in memory, so a cold start lost it, and the deadline it froze belonged to whichever route earned it, which is exactly the drift the per-route store exists to prevent. It also could not expire on its own. downloadRetryBlocked was computed with System.currentTimeMillis() during composition, so nothing recomposed when the deadline passed; scheduleRetryUnlock papered over that with a viewModelScope delay that died with the process. Meanwhile the disabled row and icon gave the user no countdown to read, so a tap simply did nothing. Drops the copy. The store is consulted where the request is actually made and the UI stays enabled, which costs a worker that fails in well under a tenth of a second without touching the network. RateLimitedWithWait goes with it. Its "try again in %2$s min" was computed at failure time and baked into static text that never ticked down, so it was wrong within a minute; RateLimited says "try again later" and stays true. Removing it leaves nothing pre-formatted, so Resumable and Error now carry an ApkFailureMessage of string id plus arguments and the row resolves it during composition. Failure text follows the device locale rather than the locale the worker happened to run under. Anchors the GitHub cooldown at the moment it is judged. now was sampled before awaitRoute(), which can hold a request for the full 60-second route timeout, so a relative Retry-After interpreted against it could land in the past and let the very next check reach GitHub - the loop this branch set out to close. Reads the clock again once the route is ready and once the response arrives, and uses each where it applies. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>