223 Commits

Author SHA1 Message Date
jack
8fccbe69b9 Fix session destruction race condition causing handshake delays
Root cause: When receiving a handshake initiation (32 bytes) from a peer
with whom we already had an established session, the code would destroy
the existing session to "help" the other side. This created a cascade:
- Peer A completes handshake with Peer B
- Peer A sends message, realizes no session, initiates handshake
- Peer B destroys its working session to "help"
- Peer B now has no session, initiates handshake
- Both peers keep destroying each other's sessions

Fix:
- Never destroy an established session when receiving new handshake attempts
- Add early check in handshake initiation to skip if session exists
- Clear handshake rate limit timers when session already established

This eliminates the delays and repeated handshakes seen in the logs.
2025-07-22 11:06:57 +02:00
jack
0be35a5378 Fix Noise session persistence during peer ID rotation
- Add session migration when peer IDs rotate
- Sessions now follow peers across ID changes via fingerprint
- Add migratePeerSession to NoiseEncryptionService
- Add migrateSession to NoiseSessionManager
- Integrate migration in BluetoothMeshService updatePeerBinding

This fixes the issue where established Noise sessions were lost
when peer IDs rotated, causing "No Noise session" errors and
requiring re-handshake.
2025-07-22 11:01:24 +02:00
jack
83a808fce6 Implement Ed25519 signatures for identity announcements
- Add Ed25519 signing key pair to NoiseEncryptionService
- Update NoiseIdentityAnnouncement to include signingPublicKey
- Replace HMAC signatures with proper Ed25519 signatures
- Fix timestamp synchronization between signing and verification
- Add signature verification in PeerIdentityBinding
- Persist signing keys in keychain alongside Noise static keys

This provides cryptographic non-repudiation for peer identity claims
and strengthens the security of the identity rotation mechanism.
2025-07-22 10:50:47 +02:00
jack
079f36664c
Merge pull request #254 from permissionlesstech/remove-message-retention-and-save
Remove message retention and /save command
2025-07-16 16:00:08 +02:00
jack
b61904bee9 Remove message retention and /save command
- Delete MessageRetentionService.swift
- Remove retentionEnabledChannels from ChatViewModel
- Remove /save command handling
- Remove retention UI elements from ContentView
- Remove channelRetention message type from protocol
- Update documentation and tests
2025-07-16 15:59:38 +02:00
jack
fcc0735928
Merge pull request #253 from permissionlesstech/ui/move-verified-badge-position
Move encryption status icons and implement slide-over navigation
2025-07-16 15:39:32 +02:00
jack
ee2c7550d1 Move encryption status icons after peer names and implement slide-over navigation
- Moved encryption/handshake status icons to appear after peer names in sidebar and private message headers
- Converted private messages and channels to slide-over views with smooth transitions
- Added swipe-right gesture to dismiss private chats and channels
- Added vertical separator bars to slide-over views for visual consistency
2025-07-16 15:38:20 +02:00
jack
17e96e9993 Replace RSSI dot with radio wave icon in sidebar 2025-07-16 00:49:06 +02:00
jack
92a8bab411
Merge pull request #246 from permissionlesstech/feat/protocol-version-negotiation
Add protocol version negotiation
2025-07-15 14:37:30 +02:00
jack
f0e7284cdf
Update README.md 2025-07-15 14:36:27 +02:00
jack
6ebd55fe18
Update README.md 2025-07-15 14:35:55 +02:00
jack
3fb39b8a30 Add protocol version negotiation for future compatibility
- Add version negotiation messages (0x20 versionHello, 0x21 versionAck)
- Implement VersionHello and VersionAck message types with platform info
- Add ProtocolVersion struct for version management and negotiation
- Update BinaryProtocol to check supported versions
- Add version negotiation to connection flow before Noise handshake
- Maintain backward compatibility with legacy peers (assume v1)
- Add comprehensive test suite with 40+ test cases
- Update documentation with version negotiation details

This ensures BitChat clients can negotiate protocol versions for smooth
upgrades while maintaining full backward compatibility with existing clients.
2025-07-15 14:33:37 +02:00
jack
59927486eb Fix mermaid diagram syntax error in whitepaper
Replace SHA256(PublicKey) with quoted text to resolve mermaid rendering issue
2025-07-15 13:29:12 +02:00
jack
1e0dd24626
Merge pull request #244 from permissionlesstech/feat/bring-the-noise
Implement Noise Protocol Framework and peer ID rotation
2025-07-15 13:24:02 +02:00
jack
3070a4d307 Implement Noise Protocol Framework and peer ID rotation for enhanced security and privacy
This major update replaces the basic encryption with the Noise Protocol Framework
and adds ephemeral peer ID rotation for enhanced privacy.

Key Changes:

Security Infrastructure:
- Implemented Noise Protocol Framework (XX handshake pattern)
- End-to-end encryption with forward secrecy and identity hiding
- Session management with automatic rekey support
- Channel encryption with password-derived keys

Privacy Enhancements:
- Ephemeral peer ID rotation (5-15 minute random intervals)
- Persistent identity through public key fingerprints
- Favorites and verification persist across ID rotations
- Block list based on fingerprints, not ephemeral IDs

Core Components Added:
- NoiseEncryptionService: Main encryption service
- NoiseSession: Individual peer session management
- NoiseChannelEncryption: Password-protected channel support
- SecureIdentityStateManager: Persistent identity storage
- FingerprintView: Visual fingerprint verification UI

Bug Fixes:
- Fixed handshake storm with tie-breaker mechanism
- Fixed missing connect messages during peer rotation
- Fixed delivery ACK compression issues
- Fixed race conditions in message queue
- Fixed nickname resolution for rotated peer IDs

Testing:
- Comprehensive test suite for Noise implementation
- Security validator tests
- Channel encryption tests
- Identity persistence tests
- Rate limiter tests

Documentation:
- BRING_THE_NOISE.md: Technical implementation details
- Updated WHITEPAPER.md: Simplified and focused on core innovations
- Removed temporary debug documentation

The implementation maintains backward compatibility while significantly
improving security and privacy. All existing features (channels, private
messages, favorites, blocking) work seamlessly with the new system.
2025-07-15 13:15:31 +02:00
jack
6d39222ea0
Update README.md 2025-07-15 12:01:46 +02:00
jack
4ba720f111
Merge pull request #148 from vignesh1507/patch-1 2025-07-10 17:50:08 +02:00
Vignesh Skanda
c0f7b1903a
Update PRIVACY_POLICY.md
Proper link wasn't added in the contact section, replaced it with the correct link.
2025-07-10 21:00:12 +05:30
jack
214fa34dc5
Update README.md 2025-07-10 17:15:32 +02:00
jack
a9c5c7d468
Update README.md 2025-07-10 17:12:13 +02:00
jack
0ece2d6610
Update README.md 2025-07-10 17:10:36 +02:00
jack
e69eaec9a8
Merge pull request #76 from marcusziade/feature/add-accessibility-labels 2025-07-10 17:07:34 +02:00
jack
e27b028922
Merge pull request #138 from jackjackbits/fix/mac-entitlements
Fix macOS Bluetooth entitlements
2025-07-10 12:57:54 +02:00
jack
022050193f Fix macOS Bluetooth entitlements and remove debug logging
- Created separate macOS entitlements file with required Bluetooth permission
- Fixed "Bluetooth unsupported" issue on Mac by adding com.apple.security.device.bluetooth entitlement
- Removed all debug logging from BluetoothMeshService
- Re-enabled scan duty cycling
- Reverted RSSI threshold back to -90 dBm from temporary -100 dBm debug value
2025-07-10 12:53:51 +02:00
jack
c6d74b7574 Fix macOS Bluetooth permissions by adding proper entitlements
- Create separate bitchat-macOS.entitlements file with com.apple.security.device.bluetooth
- Update project.yml to use the macOS-specific entitlements for the macOS target
- Regenerate Xcode project with proper entitlements configuration

This fixes the 'Bluetooth unsupported' issue on macOS which was caused by missing
device.bluetooth entitlement required for sandboxed apps
2025-07-10 12:45:00 +02:00
jack
7e78d0fe87 Add more Bluetooth debugging and disable scan duty cycling
- Add better state descriptions for both central and peripheral managers
- Add logging when setting up peripheral and adding service
- Temporarily disable scan duty cycling to ensure continuous scanning
- Add service UUID logging during peripheral setup

This should help identify:
1. Why Mac shows 'unsupported' state for Bluetooth
2. Whether services are being added successfully
3. If advertising is actually starting
2025-07-10 12:39:58 +02:00
jack
d111a9537f Add extensive Bluetooth debug logging to diagnose peer discovery issues
- Add debug logs to centralManagerDidUpdateState and peripheralManagerDidUpdateState
- Add logging to startServices to show manager states at initialization
- Add logging when peripherals are discovered with RSSI values
- Temporarily lower RSSI threshold from -90 to -100 dBm for testing
- Add logging to show when scanning starts and if it's blocked
2025-07-10 12:29:24 +02:00
jack
dd05089da9
Merge pull request #123 from michaelneale/micn/macos 2025-07-10 10:07:42 +02:00
Michael Neale
d9ad5c123b macos readme notes 2025-07-10 11:22:21 +10:00
Michael Neale
f76d5c340b progress 2025-07-10 11:17:08 +10:00
Michael Neale
6774306c27 checkpoint 2025-07-10 11:04:31 +10:00
Michael Neale
93c38b9543 restoring 2025-07-10 10:04:05 +10:00
Michael Neale
857affa46d running on macos 2025-07-10 10:00:28 +10:00
Michael Neale
391955d879 working on macos 2025-07-10 09:37:29 +10:00
jack
d3031b5a97
Update README.md 2025-07-09 21:49:12 +02:00
jack
cb2a1801cd Update project configuration with code signing and launch settings
- Add development team L3N5LHJD5Y to all targets in project.yml
- Add automatic code signing settings to test targets
- Fix UIRequiresFullScreen setting to false for launch storyboard compatibility
- Update Info.plist with proper launch configuration
- Ensure all targets have consistent code signing configuration
2025-07-09 19:48:26 +02:00
jack
ccc09d6ce6 Fix iOS launch configuration requirements
- Add UILaunchStoryboardName to Info.plist
- Add UIRequiresFullScreen setting
- Add UIBackgroundModes for Bluetooth background operations
- Add interface orientation support for iPhone and iPad
- Add development team to all project targets
2025-07-09 19:39:52 +02:00
jack
ad3afab943
Update README.md 2025-07-09 16:58:27 +02:00
jack
2ad7b93535
Merge pull request #96 from Mirza-Samad-Ahmed-Baig/fix/compression-buffer-overflow
Fix: Prevent potential buffer overflow in CompressionUtil.swift
2025-07-09 16:31:39 +02:00
jack
fc5e83612a Fix iPhone 16 screen display issue with proper launch screen
- Add LaunchScreen.storyboard to properly support all iPhone models
- Configure UILaunchStoryboardName in Info.plist for full screen display
- Add UIRequiresFullScreen to prevent black bars on newer devices
- Update project.yml to include launch screen in iOS target resources
- Add proper interface orientation support for iPhone and iPad
2025-07-09 16:28:56 +02:00
jack
76786bb199 Remove debug print statements from LinkPreviewView
Remove excessive debug logging that was spamming console output when checking for markdown links in messages
2025-07-09 16:21:56 +02:00
jack
033a5881b4
Update project.yml 2025-07-09 16:17:34 +02:00
jack
c352542331 Fix macOS build error and iPhone 16 display issues
- Split multi-platform target into separate iOS and macOS targets to prevent iOS share extension from being embedded in macOS build
- Add launch screen configuration and full screen support for proper iPhone 16 display
- Configure iOS-specific Info.plist entries for background modes and interface orientations
2025-07-09 16:08:37 +02:00
jack
1017017bd1 Update alert text to lowercase style 2025-07-09 15:19:57 +02:00
jack
e00a6c1feb Fix build error and failing test
- Add CODE_SIGN_ALLOW_ENTITLEMENTS_MODIFICATION to share extension
- Fix test assertion to match lowercase error message
2025-07-09 15:19:57 +02:00
jack
d296f1d6a4
Merge pull request #20 from jmecom/jm/warning-readme
Add warning to readme
2025-07-09 13:45:26 +02:00
mirza-samad-ahmed-baig
653f2b2812 Fix: Prevent potential buffer overflow in CompressionUtil.swift 2025-07-09 15:51:48 +05:00
jack
5ec79e8080
Merge pull request #75 from nanoterran/main
Fixing macOS build
2025-07-09 11:13:03 +02:00
Marcus Ziadé
a3605bbfcc Add accessibility labels to icon-only UI elements
This commit improves VoiceOver support by adding descriptive accessibility labels to all icon-only buttons and visual indicators in the app. This ensures users with visual impairments can understand and interact with all UI elements.

Changes made:
- Send message button: Added label "Send message" with context-aware hints
- Navigation buttons: Added "Back to main chat" labels for back arrows
- Favorite stars: Dynamic labels that change between "Add to favorites" and "Remove from favorites"
- Lock icons: Context-aware labels for password protection status
- Signal strength indicators: Descriptive labels (excellent/good/fair/poor) instead of color-only information
- Unread message indicators: Clear labels for envelope and number icons
- People/channel counts: Proper pluralization and descriptive text
- Save/bookmark buttons: Labels indicating retention enable/disable action

Technical details:
- Used .accessibilityLabel() for descriptive text
- Added .accessibilityHint() for additional context where helpful
- Used .accessibilityHidden(true) to hide redundant decorative elements
- All labels are dynamic and update based on current state

This change ensures BitChat meets WCAG accessibility guidelines and provides a better experience for all users.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-07-09 00:50:49 +03:00
nanoterran
77d13020f5 Fixing MAC OS build 2025-07-08 17:12:47 -04:00