4018 Commits

Author SHA1 Message Date
Andrew Ruthven
0ec4fb4dc5 Correct case and plural 2024-01-19 00:43:53 +13:00
Andrew Ruthven
fa1b9ae353 Lower case CN, and use the example domain 2024-01-19 00:43:02 +13:00
Andreas Haerter
11a57a85c6 Another mapping_field key to prevent PHP warnings; typos 2024-01-18 11:05:25 +00:00
Andreas Haerter
d53dad3363 Fix typos in example config; Improve Active Directory example
This fixes a few typos and trailing spaces and improves the AD
example:

- missing port leads to PHP warnings
- use more common and compatible field names for attribute mapping
- distinguishedName as bind user example
2024-01-18 11:05:25 +00:00
Andrew Ruthven
3d2e3d9f12 Move the CSP to only apply to DAViCal htdocs 2023-10-23 18:22:53 +13:00
Andrew Ruthven
aaa70a83f8 Remove sis.redsys.es from CSP
As raised in https://sourceforge.net/p/davical/mailman/message/47766326/
2023-10-23 17:56:54 +13:00
Benedikt Spranger
c88c730236 Gitlab tests: Use postgres 16
Signed-off-by: Benedikt Spranger <b.spranger@linutronix.de>
2023-10-23 17:47:42 +13:00
Athos Ribeiro
0502860a95 Add support for phpunit 10
In phpunit 10, global states are no longer preserved by default [1].

* https://bugs.debian.org/1039746

[1] https://github.com/sebastianbergmann/phpunit/blob/10.0.0/ChangeLog-10.0.md#changed
2023-07-06 16:28:53 -03:00
eppesuig
de29c6c6ee Better check for $_SERVER['PATH_INFO'] 2023-06-21 23:21:57 +00:00
Andrew Ruthven
6ac6b30c7a Additional record to CONFIDENTIAL resources
Update due to 5ab4f4391406bda5a6f1bc7b2288844bb6fefa06
2023-05-02 10:44:52 +00:00
Andrew Ruthven
ea2a75d86b Confidential resources should retain more reccurence information
To allow for correct expansion of recurring confidential information
we also need to retain EXDATE, RECURRENCE-ID and SEQUENCE, otherwise
client side expansion may well be wrong.

Closes #291
2023-05-02 10:44:52 +00:00
Andrew Ruthven
720eb89adb Add tests for checking that CONFIDENTIAL resources include all recurrance information
This is to tickle #291. The only test that is actually required is
2603-GET-resource-confidential, but I want to make sure all the options were
correct.

In this commit 2603-GET-resource-confidential is expected to fail.
2023-05-02 10:44:52 +00:00
Andrew Ruthven
d4b91f2627 Set UNTIL for some RRULEs
This is to get these events out of the way for some new tests.
2023-05-02 10:44:52 +00:00
Andrew Ruthven
fdf58827e3 Allow enabling debugging via environment variable 2023-05-02 00:12:48 +12:00
Andrew Ruthven
e8f3a3e6f2 Add a missing space to a SQL statement to fix adding groups.
It looks to me like this bug has been present since 2011.

Closes: #294
2023-04-30 12:13:37 +12:00
Scott Savarese
0059d0dcdb Support ldap connections via URI to handle ldaps and redundant ldap servers 2023-04-27 11:00:50 +00:00
Florian Schlichting
effc004741 use "." to concatenate strings, not "+" (fixes #288)
Unsupported operand types: string + string at /usr/share/davical/inc/caldav-ACL.php:146
2023-03-23 22:17:23 +01:00
Florian Schlichting
72b13cfc65 gitlab-ci.yml: add missing phpunit, awl to targets running debuild
we now require this for "make test"
2023-03-13 23:24:37 +01:00
Florian Schlichting
4301a795ac release davical 1.1.12 r1.1.12 2023-03-13 22:00:55 +01:00
Florian Schlichting
ab89530819 add Debian autopkgtests 2023-03-13 21:56:13 +01:00
Florian Schlichting
477425f3fe Fix phpunit tests ('Attempt to read property "rrule_loop_limit" on null') and add them to 'make test' 2023-03-13 21:56:13 +01:00
Andrew Ruthven
b40c96debb If time-range is set, only return matching events.
Closes #280
2023-03-12 20:19:10 +01:00
Andrew Ruthven
4a2db83b7c Update ChangeLog 2023-03-12 20:19:02 +01:00
Andrew Ruthven
15d01c8bed Store DTSTART and DTEND from user in shadow columns
We want to store the calculated dtstart and dtend in the database so we can
use SQL to fetch records. However, we also need what the user sent us so we
can allow prop-filters to be used as well.

So we store what the user sends us in dtstart_orig and dtend_orig and only
use for relevant prop-filter reports.
2023-03-12 20:17:43 +01:00
Andrew Ruthven
5a73991496 DTSTART on VTODO is optional, don't force it to be set.
If we force setting DTSTART, then you can't use prop-filter to find VTODOs
with a DUE set and DTSTART unset. And, well, why should DTSTART be set to DUE?

This was introduced in 18150d702d91fa1a687801baa582d967e79fff8d .
2023-03-12 20:05:48 +01:00
Andrew Ruthven
badeca53c7 Update tests that check for CLASS in the database.
We no longer force CLASS to be PUBLIC in the database if it isn't set.
2023-03-12 20:05:48 +01:00
Andrew Ruthven
149ec3555f CLASS is an optional field, don't set it to PUBLIC
As specified in RFC5545 the CLASS field is optional, and if it isn't present
is treated as PUBLIC. To allow a is-not-defined prop-filter to find
resources without CLASS set, we need to not store in the database. This
turns out to be okay, because to enforce privacy we always check to see if
it is PRIVATE or CONFIDENTIAL. We never check to see if it is PUBLIC.

Closes #284.
2023-03-12 20:05:48 +01:00
Andrew Ruthven
4a380b12a2 Fixes to is-defined and is-not-defined prop-filter
Gosh, this was completely broken previously. A number of different scenarios now work.

I have used some of the state I've seen in a largish production database with the
presence of NULL and empty strings. I've assumed that empty string should be treated
as is-not-defined. Happy to be talked out of that.

Closes #281.
2023-03-12 20:05:48 +01:00
Andrew Ruthven
7349944fbc Remove change entry in file, that's what git history is for 2023-03-12 20:05:48 +01:00
Piotr Filip
13c77fdcab check owner when deleting 2023-03-01 21:29:44 +01:00
Florian Schlichting
4b7abbbd83 drop default $position argument from BuildXMLTree everywhere (awl!22) 2023-02-26 22:10:34 +01:00
Andrew Ruthven
8fbab49f0d Create unique constraints for tmp_password and role_member. 2023-02-15 07:42:34 +00:00
Andrew Ruthven
e3b5c331be Add a primary key to calendar_alarm table.
Also fixed a bug in scripts/refresh-alarms.php if there was an
alarm with a duplicate trigger.

This is part of the fix for #276.
2023-02-15 07:42:34 +00:00
Andrew Ruthven
6819d6d7d1 Add a primary_key to the addressbook_addresses_* tables
This is part of the fix for #276.
2023-02-15 07:42:34 +00:00
Andrew Ruthven
c3970f3be2 Fix RRULE for BYHOUR, BYMINUTE and BYSECOND
Closes #283.
2023-02-15 07:28:35 +00:00
Andrew Ruthven
8444347b02 We no longer support PHP 5.1, assume that DateTime is available 2023-02-15 07:28:35 +00:00
Andrew Ruthven
43996a3297 Create .in and .out calendars on principal creation.
Closes #227
2023-02-05 13:04:09 +00:00
Andrew Ruthven
0041577fc8 Handle baseDNGroups being unset. 2023-02-04 19:03:50 +13:00
Andrew Ruthven
444a098130 Ensure that groups_nothing_done is defined
Closes #278.
2023-02-04 05:48:09 +00:00
Andrew Ruthven
f86eaef5b8 Use dbg_error_log instead of dbg_log_array
Closes #277.
2023-02-04 03:21:48 +00:00
Andrew Ruthven
be60ec1778 Improve on SQL syntax fix to keep logging working, and add regression test.
Closes #279.
2023-02-04 03:09:40 +00:00
Tobias Brox
6e6ff6b115 Fix SQL syntax error if is-not-defined is used as a prop-filter. 2023-02-04 03:09:40 +00:00
Andrew Ruthven
533d407196 Update ChangeLog 2023-01-18 00:11:57 +13:00
Andrew Ruthven
0762022453 Depend on AWL 0.64 to get fixed memcache support 2023-01-18 00:11:57 +13:00
Andrew Ruthven
0da12be223 Stop caching bound collections.
This was causing binding/1038-PROPFIND-Depth-2 to fail as the getctag that
was found didn't match what was expected. Looking at how bound collections
are handled, there is a lot of metadata that we're missing.

Preferably we'd cache or otherwise restore that metadata, but I'm going
to leave that as a future enhancement. ;)
2023-01-18 00:11:57 +13:00
Andrew Ruthven
ad1be4b640 Add CI for memcache 2023-01-18 00:11:57 +13:00
Andrew Ruthven
0cb7381c88 Keep track of proxy information for a Collection when using memcached
The test regression-suite/0549-iCal-REPORT was failing due to us not
keeping track of the proxy information when storing/fetching collections
from the cache.
2023-01-18 00:11:57 +13:00
Andrew Ruthven
7a3486563c Only cache a Principal if we've actually loaded something. 2023-01-18 00:11:57 +13:00
Andrew Ruthven
5db0622d65 Provide example configuration on using memcache. 2023-01-18 00:11:57 +13:00
Andrew Ruthven
0c2f55cd66 Update the ChangeLog for my fixes over the past week 2023-01-18 00:10:46 +13:00