Previously a stack trace would be returned as the call to dav_name failed,
for example:
Exception [0] Can't calculate dav_name for unknown username
At line 382 of /usr/share/davical/inc/Principal.php
================= Stack Trace ===================
/usr/share/davical/htdocs/freebusy.php[49] Principal->dav_name()
the second argument of param_to_global, if set, becomes the first
argument of a call to preg_match(). Unless it's the special value 'int',
it needs to have regex delimiters around it, like '/.*/'
In this case, we're not interested in the value of the add-member
parameter, we only want to check for its existence, so skip validation.
This reverts commit 38788acc5cbec147d6a46a6254ef8eec0a270c71, which
causes the following tests to fail (not return any FREEBUSY):
tests/regression-suite/0832-freebusy.test
tests/regression-suite/0836-freebusy.test
tests/regression-suite/0837-freebusy.test
tests/regression-suite/0888-GET-freebusy.test
It seems to be the case, that array indicies in $_SERVER are always
uppercase. Sadly I could not find any documentation of this but at
least with mod_php it is the case. Also a extensive search on github
projects seems to support this thesis.
On my installation the 'X-FORWARDED-PROTO' is even then uppercase when
its mixed case in the Header provided by the reverse proxy.
Signed-off-by: Jan Losinski <losinski@wh2.tu-dresden.de>
There's a long-standing annoyance about catching errors in the early
stages of startup - sometimes they seem to disappear nowhere and yet
nothing works. This fixes at least part of that.
As can be seen from the reporter's debug output, the problem is that
the POST goes to .../?add-member, whereas davical expects / works with /
redirects to ?add_member (note the underscore). So we have davical treat
?add-member the same as ?add_member
Fixed grouped Properties naming (e.g. Addresses: item1.ADR instead of just ADR) …
…that caused item1.ADR to be written to DB(address_address_adr) because it doesn't match ADR, fix works ofr every grouped Property (yet there is only ADR...)
Added VCard Property ORG as nondefault (because it takes more then one Value)
Fixed false handling of Properties that can have more than one value (e.g. ORG) where values are seperated by semicolons
See merge request !19