mirror of
https://gitlab.com/davical-project/davical.git
synced 2026-03-14 08:10:13 +00:00
71a2d247e1
Removed favicon.ico work around (fix #53, Debian bug #703294) This relates to debian bug report #703294 <https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=703294>; of Chris Mitterer. He makes the case to delete a block at the very beginning of the file caldav.php. Andrew authored that code block once (6 years ago?) with the following commit message: > Provide passthru on icons, images, css and js files. > In Chrome it requests the favicon (for example) very frequently > which was causing a prompt for authentication where there was a > poorly considered regex in the rewrite rules. I think this is > a good backup to the rewrite rules to pass through on such files. As far as i unterstand the code it does in fact passthrough requests for favicon.ico. But these should not happen at all anyway (but seem to have happened with a specific browser and a malformed rewrite rule). And I agree with Chris: most of the code does not work as intended and is potentially introducing security holes. So after having a closer look on this I vote to follow the recommendation of Chris to DELETE this block and close the bug. See merge request !20
DAViCal CalDAV Server by Andrew McMillan. For documentation you are best advised to visit the DAViCal website at http://davical.org/ or search our general mailing list at https://lists.sourceforge.net/mailman/listinfo/davical-general There's lots of useful information at http://wiki.davical.org/ as well, and if you want access to update that contact us on IRC (#davical on OFTC, be patient and stick around for a while) or send an e-mail to <wiki-access@davical.org>. Good luck! Andrew McMillan ----------------------------------------------- Copyright: 2006-2011 Andrew McMillan <andrew@mcmillan.net.nz> This program is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation; either version 2 of the License, or (at your option) any later version. This program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details. You should have received a copy of the GNU General Public License along with this program; if not, write to the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA