6273a80637f06cd907c82df203f8e78ec9ace288 Add message that wallet was deleted to wallet member (edouardparis)
Pull request description:
close#1793
ACKs for top commit:
pythcoiner:
tACK 6273a806
Tree-SHA512: 9c80861b5e4ef73c697e9ca3232bd434f04b0d7a9bf52f20cd96be6cec49ed1d625aca31ad759f38b5c6a9a800ecaf720149539c86b16e29e4f4abaa9187f81b
88966c2b09d3025f730e648c523e7caa0e6487c9 fix: move focused_tab if >= removed index (edouardparis)
a242834bffcea459932d5c8269120fb6bb3a584a fix: missing closing tabs with wallet loading (edouardparis)
Pull request description:
ACKs for top commit:
pythcoiner:
tACK 88966c2b, it fixes the second issue
Tree-SHA512: f1b661c767984157cee63e7b458f4041741e326d7dd98a9bf78b6c2262c89981c3d7b62d2433b653a62e6438bc71007392a1a622e0ba9231cb209daadc0b5c34
If the focused tab index is before the removed tab index,
then it must not change, if it is equal or after, because
all the elements are moved to the left, the focused tab
index must be decremented with 0 as minimum.
b1e06ee10638895e2bcf7ac41bd5933048e2ca34 global_settings: do not create file if not existing & empty (pythcoiner)
a0b74709f33d7eb84c2c9692d2d079096891c283 settings: add a tests for GlobalSettings (pythcoiner)
c53ace8b0bb2e006221ae2faf013fe7ab0b1e16d gui: store the window size in global settings only on shutdown (pythcoiner)
13652e3c33f1844440831761d01faa7bfc499d0e settings: add a lock to read/write global settings (pythcoiner)
b696f50f8c9b4938e9a43e0bcb6b77db82c5b002 gui: apply previous screen size before launch (pythcoiner)
2dc838f85c0de563ee19d28332f7c60f4a9c094c gui: be smart with window size at launch (pythcoiner)
089992b9475d4d9b2868399afeb1ceadf7ee37f5 settings: add window_config to GlobalSettings (pythcoiner)
cb8a421571bebb2fe0ac206175682167b7b1b64c settings: rename global::Settings => global::GlobalSettings (pythcoiner)
bf666539bfed7a75a0dfc2d34ac377b1b094278b gui: implement State::datadir_path() (pythcoiner)
Pull request description:
closes#1546 following last requirements:
> Currently the consensus has been on the following solution: resize the window according to a logic similar to https://github.com/wizardsardine/liana/pull/1695 at the first launch and then remember the last size for following launches of the application.
Summary of the feature introduced in this PR:
- The first time Liana launch, the window is maximized in order to "guess" the maximum usable size on the monitor, and then we apply [this logic](https://github.com/wizardsardine/liana/issues/1546#issuecomment-2750974470) for deciding the default size.
- The default size is recorded in `global_settings.json` (so this aplly to ALL wallets)
- On nexts Liana launch, the window is resized to the value contained in `global_settings.json`
I added something not clearly defined: if the user resize its screen, we reapply the last screen size at startup.
ACKs for top commit:
edouardparis:
ACK b1e06ee10638895e2bcf7ac41bd5933048e2ca34
Tree-SHA512: 1ffb0ef852846d5599a747d619a19a2ee2b47ecbb26172de95ffbf6ad2d0c65851b3236070081e81b2503914e6916abc3ed59899131a8a475f6d07662a951d0e
ceec4f9e79cd464f5ea39c0d85f92e199b70a491 feat(gui): add links with info about backend/node settings (Michael Mallan)
0d48f8efee45eee05156b3acea8d8a9f2adbdd1e refactor(installer): fix typo in clipboard enum variant (Michael Mallan)
Pull request description:
This implements #1755.
TODO:
- [x] Update URL to relevant support page
ACKs for top commit:
edouardparis:
tACK ceec4f9e79cd464f5ea39c0d85f92e199b70a491
Tree-SHA512: 0bb7a2ea9627953d94d5ae05059ad74646facb5521be3e874b763e52c7eeff2c61784aef81cf84707a9dede35380fa37b1f1f52e30c078dfba55ed2f45efddfa
d86d6852b93013df15e914f43a8e631dd7cbe084 fix: a wallet with remote auth does not use managed bitcoind (Michael Mallan)
Pull request description:
This is a follow-up to #1746 to address the case where the wallet uses Liana Connect, in which case `start_internal_bitcoind` is set to `null` in the settings file.
ACKs for top commit:
edouardparis:
utACK d86d6852b93013df15e914f43a8e631dd7cbe084
Tree-SHA512: 23cf226651f8321b1ff482c977e7d23137debf8d62a3d824d197c2fefed576234eaee7ea014e2ae16dcedc70c198cfc2c5e00d57040b13108033728bb2aeb863
f62d9429581371d830ef455feb1158024199739f Add check of user membership to delete wallet modal (edouardparis)
1ca02a48979a7a36440ac57d8d83f988241af92e Delete wallet on Liana-Connect (edouardparis)
Pull request description:
ACKs for top commit:
edouardparis:
Self-ACK f62d9429581371d830ef455feb1158024199739f
Tree-SHA512: d624955703c83b8308378231a4563c575ed13c7e419377f3f4d8636bdb2b1a7fc157f8ae75f47ccabbf4c9a44ae3f449314987052dbe8337e8e44f8a145700d2
ac1043a1e09ec1570c489d537fbcff3ebb4c7152 chore: fix some minor issues in the comments (cloudclaim)
Pull request description:
fix some minor issues in the comments
ACKs for top commit:
jp1ac4:
ACK ac1043a1e09ec1570c489d537fbcff3ebb4c7152.
Tree-SHA512: ef571e559dddf5a87d03d50cc0eaf041d961280e9e09cc9df4da7a963da6d45df1f91615779412465e75bec46c942cfd8a287434bf51e5f1cf6f8c1f737c8d61
cb60089ace858772446ba82dcb76fc082a13242e fix(poller): only update last used index for affected keychain (Michael Mallan)
Pull request description:
This fixes#1333 by only setting the last used index of the affected keychain.
ACKs for top commit:
edouardparis:
utACK cb60089ace858772446ba82dcb76fc082a13242e
Tree-SHA512: fe376063378e7b531f6e4db0a6b42272344e50da01274571cdd089245b4e42f632180fa30528030c73c47e647bb02cf5d91eecf815be2274e7f371a77057ccc6
612608616b8ab448b1fcfebabf33bcfeb41e5807 Add alias to confirmation message of delete wallet modal (edouardparis)
Pull request description:
close#1763
ACKs for top commit:
jp1ac4:
tACK 612608616b8ab448b1fcfebabf33bcfeb41e5807.
Tree-SHA512: aa5e578db9b750a111d5ed148bf1e883aa6a20a6d3e30728f0f9c831101721d6067f2165e83e9d9e91d0c72c44872e63d27962c6a91c9191346fac728f2a42b4
d9c540ad1442bc7787fe33b69b2e60b62e17a650 liana-ui: add warning to form::Value (pythcoiner)
Pull request description:
This PR add a `warning` field to `form::Value`, so the warning can be accessed also from outside the view scope. This field will be "inherited" by the `form::Form`.
This PR "closes" a TODO in `EditXpubModal`, but I decided to go with a separate `warning` field as it can be useful to display a warning even if a value is considered valid.
Note: as this change do not modify the usage from within the view scope, usages of `form::Form` have not been updated.
ACKs for top commit:
edouardparis:
utACK d9c540ad1442bc7787fe33b69b2e60b62e17a650
Tree-SHA512: 377c29c7ca8a6e62c496ac73f4beb6bf2677c7f4388e068e9ac51793b0e62c0345363bb3e7a5b2fd3b71f3a98121712a340b69103564ede60854d1d552a0f46d
ba96bb6c063641debcbe2baf2c0f8e52e133f89a fix: skip syncing screen if node is not bitcoind (Michael Mallan)
Pull request description:
Fixes#1256.
The loading screen showing the blockchain sync progress will skipped if the node type is not Bitcoin Core.
ACKs for top commit:
edouardparis:
utACK ba96bb6c063641debcbe2baf2c0f8e52e133f89a
Tree-SHA512: 3a438e0e8d031ea416c8096742514769e446422dfe6523eaf19fa12d7551f0b1c86df37851e03a4794de5a152aee25d6a169714f35c1ea88e793042ac3e84a34
91ed79cb559fbfc0e3fc6befef5690aab85caefd make remove_tab safer (edouardparis)
5587b5cb8dc1d963167f300ccb82451d44db0538 simplify logger_setup (edouardparis)
fd858d2b4ac71efe121b1da96d59dce2b0b1de3c Close tabs of deleted wallet (edouardparis)
8dce52e22de41ab04f387b659e7cca3f9696eba4 Make sidebar responsive (edouardparis)
2866b8ea18e233d76e41b2da75d6f489e7190a34 Add grid with split button (edouardparis)
9f1de060eb942887a9ae1e8d7311263baebe895f Add pane tabs (edouardparis)
e771a42f456fb710306d7a2d265aa58c64e7be36 Change log destination for a file in the liana directory (edouardparis)
cdc2b56a3b8b64be8a12827188244fd987a4b4ea Detach tab from the gui general scope (edouardparis)
ce38ea1881e2675d10199fb0cc89ea5d754fa5da Migrate gui to its own module (edouardparis)
Pull request description:
ACKs for top commit:
edouardparis:
Self-ACK 91ed79cb559fbfc0e3fc6befef5690aab85caefd
Tree-SHA512: 473d782667560e919120d9b858f86223b0fcb2e1f26bf32bbaeee2a5edd2ead1bfc078da1808db2218c08dbbe626fac96a2c342f41bcea7a48b420b80d870021
