d9c540ad1442bc7787fe33b69b2e60b62e17a650 liana-ui: add warning to form::Value (pythcoiner)
Pull request description:
This PR add a `warning` field to `form::Value`, so the warning can be accessed also from outside the view scope. This field will be "inherited" by the `form::Form`.
This PR "closes" a TODO in `EditXpubModal`, but I decided to go with a separate `warning` field as it can be useful to display a warning even if a value is considered valid.
Note: as this change do not modify the usage from within the view scope, usages of `form::Form` have not been updated.
ACKs for top commit:
edouardparis:
utACK d9c540ad1442bc7787fe33b69b2e60b62e17a650
Tree-SHA512: 377c29c7ca8a6e62c496ac73f4beb6bf2677c7f4388e068e9ac51793b0e62c0345363bb3e7a5b2fd3b71f3a98121712a340b69103564ede60854d1d552a0f46d
74087c37cf0b0796e794f98bebb11167ca243969 refactor: map fingerprint only once (Thomas Ballivet)
86c4896534c1ac169a3352651b0e27170e8cb06f Disable signing devices that are not related to the actual spending path (Thomas Ballivet)
Pull request description:
Inspired by #1607 this shoud closes#1041.
Notice that I added the wanted logic also for the recovery spending. That means you can only select a signing device related to the primary path for usual spend. But for recovery spending you can only select a signing device related to the recovery_path.
You can see here both examples :
ACKs for top commit:
jp1ac4:
tACK 74087c37cf0b0796e794f98bebb11167ca243969.
Tree-SHA512: 93e452ca9f56e214f308cbaf3cdc9ffb52301e64fded860d1a961e97df21270e18f994cef83358459981ddc3029c89183d23bc33bab863253cfa2a2c5a9d9554
c8e455c8ceb2a7b5408380dbe3cd30ce3959ff57 lianad: add a test for LianaDescriptor::contains_fingerprint() (pythcoiner)
aead34cc8eaa3e74d2c76c7e1e8341d756d779a2 installer: hint the user if the plugged signing device is not part of the descriptor (pythcoiner)
5ae13dd025c2e038e17746f5bfc8cf72ec5120c7 liana-ui: make it more clear when a device key is not part of the wallet descriptor (pythcoiner)
fa8fd4782f97b8969f6a655e0511bf8f96924232 liana: implement LianaDescriptor::contains_fingerprint() (pythcoiner)
Pull request description:
This PR:
- [x] Add `LianaDescriptor::contains_fingerprint()` method
- [x] make more explicit when a signing device is not part of the wallet descriptor
before (user had to hover the button to see the tooltip):
after:
- [x] Hint the user in the installer if the plugged device is not part of the created/imported descriptor:
ACKs for top commit:
jp1ac4:
tACK c8e455c8ceb2a7b5408380dbe3cd30ce3959ff57.
Tree-SHA512: 092b8cb6efe6b6a6dc4f8505649783cb7c83c231242ab14f479b573e12cd61bab4e6e27a173bee19097d3ad90a8f1e578ecf4b699a4a481b40588f5f60cb9c71
ad2c096715da49223f7c2cf3389e575b7e62a064 gui: disable replacement fee input if tx is already replaced (pythcoiner)
Pull request description:
this PR disable input on feerate TextInput if the tx already have been replaced, it's fine to do so because we still can RBF the new replacing tx.
close#1138
ACKs for top commit:
jp1ac4:
tACK ad2c096715.
Tree-SHA512: 528dc513ee83a839c86a6dd8d49fa5af61814e7c440d5337d294205269ebcef3d50001a5b41815c95276d4f3e6660d5f5e081456feb77843b527d8f9eed897b8
