e4ae6dc368d6600fbbdd5adaea1d52feb0f4b2a9 descriptors: include segwit marker and flag (Michael Mallan)
03a3230a67e9bf09e556d10550d9cdd08fb805d6 descriptors: add method to get max tx weight (Michael Mallan)
Pull request description:
This fixes#1406, building on the fix from #1451 for estimating the weight of each input.
An extra 2 is added to the unsigned transaction's weight to account for the Segwit marker and flag.
ACKs for top commit:
edouardparis:
utACK e4ae6dc368d6600fbbdd5adaea1d52feb0f4b2a9
Tree-SHA512: de78763d85ed38d5e2797d6f95b1ef293bbedf3cd4d5d1f69085bd134a117ae270a24c3487d738398191fb4126c4f8319bba53b902cec1625dad1c501f3f2aa9
71ad55e06bfc804754983debd7502db02b6bc524 gui: reload home if wallet is not syncing (Michael Mallan)
Pull request description:
Following #1386, this PR will show past payments on the home page while the blockchain is still syncing. Currently, these are not loaded until the wallet has finished syncing.
This change won't apply if the wallet itself is still syncing. The reason is that this is not expected to take so long and so it's better to wait for the updated data. Furthermore, the DB may be locked if the poller is running, in which case we wouldn't be able to load past transactions until the wallet has synced anyway. The home page reloads automatically as soon as the wallet finishes syncing.
ACKs for top commit:
edouardparis:
utACK 71ad55e06bfc804754983debd7502db02b6bc524
Tree-SHA512: 5fcf179ec859616ff1d7150597e73e20cb2ef0aa3ad882eeea37d6149754e58b44e37d6553ecb690a60383a95228f9724ec812dc4ae825d2620d377861c31e19
5d65a4e1253a7f8312641523981ec90344ffb9ac Use 2 decimal for sync progression in home page (thomas)
Pull request description:
Solves #907
ACKs for top commit:
pythcoiner:
ACK [5d65a4e](5d65a4e125)
Tree-SHA512: 677a132d42f426a37e30829e8a91bc6e7f258d3cfe808d4f0b5cadd1951b3cccd75527574200cf5e2319cf90e6ff5e6e88f387c457123cb9d556c81da458fe12
a8c3612d271c8a9e73010b04e6230e037e00d161 fix link logo in README.md (edouardparis)
Pull request description:
ACKs for top commit:
edouardparis:
Self-ACK a8c3612d271c8a9e73010b04e6230e037e00d161
Tree-SHA512: 105bd63245db514f2dc1914762858d61d04d3130ebbb73bbca6ee3c4a33e90c2ea0143e1581e6c8e6a6bfb3cbe6d339170b537809802635d23aadb537239a049
6175ca7b58324a19ba7d8309fac4f18e6a07c178 fix doc (edouardparis)
f32b6aa30dc68623361f7884111707edd0bf3b42 fix the reproducible build to include the workspace change (edouardparis)
8973ee0c7c7b8df37378dde3f1a73b2447147200 fix test not building on windows (edouardparis)
f28b40fe8df967364f2201e3bea84c081b18cac6 fix fuzz, build and tests (edouardparis)
2ab6e40c9399942e2ef756f63e07ff76fb1496b9 refac workspace: move files (edouardparis)
Pull request description:
This PR clarifies the rust workspace with its members:
- `liana`: The `lianad` and `liana-cli` crate
- `liana-gui`: The gui crate to build the graphical interface
- `liana-ui`: A crate to quickly iterate on a design system
It allows to have coordination across crates easier, consistent build and shared dependency versions.
As a result the build processes in the guix container and the macos container are way faster as the dependencies are built only once.
The overall MSRV is changed for rust 1.71.1, which is the `liana-gui` MSRV.
Only one rust version is used for all the crates.
This PR is also a change of vision of the project. The liana daemon is not used as it is. It is too much cumbersome. It should be at the service of the future applications and for now at the service of the GUI.
The security aspects of the project should be aware of what the end user is using and in reality it is the `liana-gui` binary.
ACKs for top commit:
pythcoiner:
ACK 6175ca7b58324a19ba7d8309fac4f18e6a07c178
jp1ac4:
ACK 6175ca7b58.
Tree-SHA512: 4b193ed92d3108672d785b28ed54ff95168d365f163235b72cd7e24a7023a7293853ddb458930fb4640d7b1c60a8965e1b38cc060a426474d50b29e2eec4a6d2
6e74a96e12feb00fcf0f6974f56002c0356e0960 Revert "spend: add 10 sats to fee for 1 sat/vb txs" (Michael Mallan)
cf88aca3aee0fed9a817dd4946db7ad3c1b080a7 descriptors: fix satisfaction size for Taproot (Michael Mallan)
e9c699570669e9723bec47b1fcd6df66257a8128 qa: add threshold paramater for multisig descs (Michael Mallan)
Pull request description:
This is a fix to #1371 and the related #1322.
As per https://github.com/wizardsardine/liana/issues/1371#issuecomment-2446921093, this adds the varint length for the script and control block elements of a Taproot primary path spend.
I think this is what caused #1322 and so I have reverted the change from #1323.
ACKs for top commit:
edouardparis:
utACK 6e74a96e12feb00fcf0f6974f56002c0356e0960
Tree-SHA512: 754e5c2186de853cde9006aeab7989141a4d363b9e3d8adb3f0264bcbca7e3b56a94822d434f6f7d8108e7c0e3023959fa407643e5868082f8981c5ce10b9a1e
439af752a57410f4667664a2d5de93ddb9fa705e Fix blockchain sync precision, add tests (thomas)
Pull request description:
I've merged `roundup_progress` in `rounded_up_progress` since was in utils and was no longer used by any other method.
I also added some tests to verify the precision's update but also for specific cases that we manage. By the way tests has been moved in the related file.
Solves #907
ACKs for top commit:
pythcoiner:
ACK 439af75
jp1ac4:
Tested ACK 439af752a5.
Tree-SHA512: a87998d1e25c47d751dabc38f641f05f2544bf17cbdcf95d24e829a0aa9dd8ce2de3bdc72a52aced04ffd777412ca206641f914d9a083241d98ceea33d4c10cc
ef55e8f01e65f67faff5bd2f07c2c1302d562dd9 gui(installer): list wallets using secondary buttons (Michael Mallan)
Pull request description:
This is to fix#1445:
ACKs for top commit:
edouardparis:
ACK ef55e8f01e65f67faff5bd2f07c2c1302d562dd9
Tree-SHA512: 4bad1cb94f43d69c0e4da79ce251ca73c529f1e093ab65b78a8054b187f9f7072d2527f112ecfe7670c279e275c9d16b183ac4c3ce2d62bd4896ce763b33df04
86cebc2ddf70b1cfe2d717eb379999ee68699a5e gui(installer): use fixed keys ordering (Michael Mallan)
Pull request description:
This is to fix#1439. It follows the same approach as used in the settings to ensure consistent ordering when iterating over keys.
ACKs for top commit:
edouardparis:
utACK 86cebc2ddf70b1cfe2d717eb379999ee68699a5e
Tree-SHA512: 97c95804d9656f1a24c65134f7f4269b3410252f4ebd743d57e4ef9400b68e5ab534cf304cb5c414ffb2339ea00ed64564a43eee7338dc0c0f07f87d4b421a5b
d1bcb71ea4d4bdafe4b81fcfbfe78558b7fd8366 gui(installer): fix word plurality when adding keys (Michael Mallan)
Pull request description:
This is to fix#1440.
ACKs for top commit:
edouardparis:
utACK d1bcb71ea4d4bdafe4b81fcfbfe78558b7fd8366
Tree-SHA512: 590b19ec0d717fc3c82f9323a9fc41e79cc52e7b60df9b1319e24b851f1c99d75e12b4bf74d4e6381671895298388b942d494c395d2bbd8c6138b941b01f218b
953a85b94321093d29926283df951c3f4f00d2aa Add compression algo flag to dpkg command for arch build (edouardparis)
Pull request description:
Arch package failed to be extracted during pacman update because of the default zstd algo
ACKs for top commit:
edouardparis:
Self-ACK 953a85b94321093d29926283df951c3f4f00d2aa
Tree-SHA512: f5c0885981c5f60e291614fae8f8942b243059bc3c98c2fd313eb8f30a99d4eb832cde1e63e0206e0f71ccb637a0ddb3426283abb8e56231a5eadc65f8775309
f075b3de74ccbce8d73bf3fc2e8a1ced32192e2e gui(installer): 37dab1bff29333e6f73616238d5e608975002ce7 make only the warning displayed when a device does not support tapminiscript, this commit add also the 'selected' icon (pythcoiner)
Pull request description:
ACKs for top commit:
edouardparis:
ACK f075b3de74ccbce8d73bf3fc2e8a1ced32192e2e
Tree-SHA512: bda25aec6719cf6934e021bfa7ba0c6fa2d193b00cb63f53f52d956b3541769942eb9e4a9b0a09f66fc94ac4f3533441d7f7725fd61136cf40544cd90d130f17
c620c8278ffb8a051a5613be7620b2589c6a19f7 Add specific comparaison order for HistoryTransaction (edouardparis)
6de5016c0886d297350b47267e3a6614bae38df3 Refac pagination: sort list in async command (edouardparis)
Pull request description:
This is part of a major rework to fix performance issue while loading lot of transactions in the gui.
ACKs for top commit:
jp1ac4:
ACK c620c8278ffb8a051a5613be7620b2589c6a19f7.
Tree-SHA512: 54abaf0a00e14b6ca0ae58dc8025cdd0707cc7ced3b168a4cbc97b60ab46ee72fdbda99e488053b8a101b17682c8fe1d996b5721e49134f4e520f84a5a692eb3
47a5d3218503294065acebaee1add5b7d52d3a81 gui(installer): make edit key modal scrollable (Michael Mallan)
Pull request description:
This is to fix#1402 following the suggestion in https://github.com/wizardsardine/liana/issues/1402#issuecomment-2448730840.
ACKs for top commit:
pythcoiner:
tACK [47a5d32](47a5d32185)
edouardparis:
ACK 47a5d3218503294065acebaee1add5b7d52d3a81
Tree-SHA512: 4bf84e041e4e2ae6cbb7645a75290912d975c7c7312e7779b95f855753dc8000ff6f377b13c85ed69cd68be721fde2998c6c1f3034b92b0dab03a07edc82af68
