fe52fbaa49096d1b1beffee09d56f5cc8272a585 gui: bump to 0.4 (Antoine Poinsot)
Pull request description:
This bumps the GUI to 0.4, using the 0.4 branch from lianad.
ACKs for top commit:
darosior:
self-ACK fe52fbaa49096d1b1beffee09d56f5cc8272a585
Tree-SHA512: 9f3ab6e45587ebc5e9f70f67bb30265a34d712bb04e71270cafa271c00bdba54c65bca7bcd0f7af008627e9d9b6e14b1621351280e72e9d4928ce8801e14c603
997829bdfe30a950ca40412fc1d273c2f1ca7e43 fix unregistered hardware wallet view (edouard)
53d32085147fe6f8c0094c26008314eddfcc3bd0 Add alias to hot signer (edouard)
Pull request description:
When a hot signer is suggested to user and an alias was entered then the alias must be displayed with the "This computer" label as signer kind.
ACKs for top commit:
edouardparis:
Self-ACK 997829bdfe30a950ca40412fc1d273c2f1ca7e43
Tree-SHA512: 68cd8f6ca8bdbd439f6392fddf4f34f1d8a1a8b312003f219e20519dabff43b95af496051eef857fed132f80b3b49ee5cd3034361f0af7fdfe9ef666b2c16c2e
3314b7e597a11b5c6fa653ec9c18058aff64adde gui: fix a misleading tooltip on hw connection error (Antoine Poinsot)
Pull request description:
The error may not be due to an unsupported version. For instance the device may just be locked. In these cases telling the user to update their device is very misleading.
Fixes#418.
ACKs for top commit:
edouardparis:
ACK 3314b7e597a11b5c6fa653ec9c18058aff64adde
Tree-SHA512: fc1627d10e071b0be7d8879455d40dd1969a1d8f4ca850dc5348b921817f103c2fa0c059cfeeddea4a636e7c0de61dd1b2509bdc3470a6a0f3fb200d7fc66e80
9dccc273bfe1e9513881b2cfa95a9e0caa3882eb gui creates datadir for fresh install (edouard)
Pull request description:
ACKs for top commit:
darosior:
ACK 9dccc273bfe1e9513881b2cfa95a9e0caa3882eb -- tested with a relative datadir (`--datadir ./test`) and everything worked smoothly.
Tree-SHA512: 19ce785b95d53ba12f83780eb5a9f9fdc5bc00b27385e8859ece029669ae954083234561c607b7a29acc5ab2a9e62f715904144ab618bae4653bf1eba562c8d2
The error may not be due to an unsupported version. For instance the
device may just be locked. In these cases telling the user to update
their device is very misleading.
Fixes#418.
54fd0d8f50836d5d414dc43de88cfd86d3a210de fix gui jsonrpc client: wrong createspend args (edouard)
Pull request description:
Wrong order.
We should find a way to test the jsonrpc client agains the liana rpc api.
ACKs for top commit:
edouardparis:
Self-ACK 54fd0d8f50836d5d414dc43de88cfd86d3a210de
Tree-SHA512: 47da8c14b071121ab605ecf81265df77b4110dad3224f93c7af5053ca173a9dfb3ff4f289ae8ac8ce879b87155433739acb53b7d9377071c3a0df0fbbe0adafa
9c30c0dff2dab6251a8c462f7a38c884318942c9 Check for same sequence recovery paths (edouard)
Pull request description:
ACKs for top commit:
edouardparis:
Self-ACK 9c30c0dff2dab6251a8c462f7a38c884318942c9
Tree-SHA512: 65fae3f119c0873ee523aa7974b1d221b682c264559ccb7267c53913a33461d12f4c60346f3cbaa6ea5e356f64b18a2471ad8461a2a3e369a65d0029366e0713
6cc4efd303bb5e5cc5a1d50a4925428429f93ab9 ci: run the backward compat functional test (Antoine Poinsot)
96ff447fc98d50f72142abe1f1619bade768c8ec tests: add a datadir migration functional test (Antoine Poinsot)
Pull request description:
Based off #392.
This introduces a backward-compatibility functional test. For now it really is targeted at testing the DB migration from 0.3 to the upcoming 0.4, but the concept is also useful more generally to automatically test backward compatibility between our releases.
ACKs for top commit:
darosior:
self-ACK 6cc4efd
Tree-SHA512: cb52a5de2de73d1e5b0bce51bbc7f586b63e1b67fdd95026be09134ab764d047ab33f0965f28700a2fef13108e9637937860edac03c49a7392f0cd71c3d03657
e8186eeaa967a169d94c2d851d5ec7ab371f3074 tests: fix a race in the reorg exclusion test (Antoine Poinsot)
Pull request description:
ACKs for top commit:
darosior:
self-ACK e8186eeaa967a169d94c2d851d5ec7ab371f3074
Tree-SHA512: a18c88b488d0882a949ff49113cdf3549474448a12a764729b1308589302b36e630f74540bcf2f3733ee30cd9dbc05b833f387eb2ff32dd21907e2c71d814d8c
Spend transactions are first ordered by status
in the following order: pending, broadcast, spent,
deprecated, then by `updated_at` field with last
updated tx first.
close#281
f262ca2d1ca864e37704ab2a35d9426f85a31c6c tests: reduce the number of workers for the executor (Antoine Poinsot)
104c6e1a093238045cad0c149f61f424ac0a9dc7 commands: add an 'updated_at' field to listspendtxs entries (Antoine Poinsot)
6b666e75c0fc306dc58574a48346af0bc958a153 db: unit test the migration from v0 to v1 (Antoine Poinsot)
29ae0a4a5e5e17ae0ca4951ed3b4e7043803c683 db: add a new 'updated_at' column to Spend transactions (Antoine Poinsot)
Pull request description:
This is an alternative to #390.
We add a new column in the `spend_transactions` SQLite table, and as such introduce a straightforward migration system. This field is in turn always set in `updatespendtx` when we store the new PSBT, and listed in `listspendtxs` entries. It is useful for instance to sort spend transactions on the GUI (#281).
ACKs for top commit:
darosior:
ACK f262ca2d1ca864e37704ab2a35d9426f85a31c6c -- i've tested it both manually and with #393, and Edouard too with the GUI
Tree-SHA512: 44d3309fcc83069125ab74a20a6eb2c7c662df30fe0da4b90e5f74ca57f26e76c604453bf040f1bf2718e123350d3c42b946755c1650a84ee1beb69913bff856
Since this is our first modification to the database schema since the
first release of the software this also introduces migration logic for
existing databases.
f1549e1e976a30105bc6f36488a7e90beac700e5 Add key alias to hardware wallets (edouard)
328748873768dc44a092cb61297471bcf6236447 Add unregistered policy warning on hw list (edouard)
Pull request description:
close#369close#339
ACKs for top commit:
edouardparis:
Self-ACK f1549e1e976a30105bc6f36488a7e90beac700e5
Tree-SHA512: 8a1ebb91e299bc162b0e2593c73b3ac6afb47d77445bf3798633fa7ca2fdd4e6f33d6113f715cb1ffe19c49a03e9177576210ce53774dec4aada7d4bc838691b
3eeba082483c06318ca7a1f018ce2c5da47f5f32 fix not found settings file error for old gui versions. (edouard)
Pull request description:
After migrating from a 0.1 or 0.2 version of the gui user may want to update the keys aliases in the settings This commit makes sure that a settings file exists when wallet is loaded.
ACKs for top commit:
edouardparis:
Self-ACK 3eeba082483c06318ca7a1f018ce2c5da47f5f32
Tree-SHA512: f1bb7e04b9e71bf8d169410a5c701a5a027866353b648d9ed56fce9cde109c234a34a51c9d1f7ab4890902fbe781bcb9e6739f2d7b6a2875cf05b04e60b4ede5
After migrating from a 0.1 or 0.2 version of the gui
user may want to update the keys aliases in the settings
This commit makes sure that a settings file exists when
wallet is loaded.
7211b96ca936a449916b0cca3e0a64b09463e813 tests: extend the recovery functional tests for multipath descriptors (Antoine Poinsot)
b20cdd0cd81ed0f90ce36192aa8607206c12f3df tests: introduce a lianad_multipath fixture as well as a trivial test (Antoine Poinsot)
0d75f0a2c77b05b247adac3a08371203d12ac1d6 tests: handle multiple recovery paths in MultiSigner (Antoine Poinsot)
3aa99806359efd7043b79becd71ad26877e63a9e tests: simplify the MultiSigner (Antoine Poinsot)
75ea3672357e30418c49fa4d444f85d7d248e0ba tests: make most of the body of the multisig test a general helper (Antoine Poinsot)
d68d0e113473e59310723f805fd86ca204e5f1ed commands: adapt 'createrecovery' to multiple recovery paths (Antoine Poinsot)
cfbb02c7c8cda56216cfefc84bc6be3ed37a7847 descriptors: multi-recovery-path Liana descriptor (Antoine Poinsot)
ec0009113a8405396950f5c347d0dace3c3c33d0 descriptors: lift the bounds to create a Liana policy (Antoine Poinsot)
55d86c62a59bcfe632b866d1b24653219f4c4399 descriptors: use the Miniscript compiler to create a descriptor (Antoine Poinsot)
Pull request description:
This introduces the possibility to have multiple recovery paths in a Liana wallet. This is particularly helpful for decaying multisigs or a spending policy that involves a third-party co-signer in the recovery (in order to have a later recovery path that gets rid of the co-signer).
We start by introducing the Miniscript policy compiler to create the Liana descriptor from spending policies configuration. As a by-product, we also lift the limits on the number of keys usable per spending path that were in place because we hardcoded the use of `multi()`. The partial spend analysis and the `createrecovery` commands are adapted to support multiple recovery paths.
Is there any place i might be missing that needs to be adapted or that would assume single-recovery-path descriptors?
Closes https://github.com/wizardsardine/liana/issues/54.
ACKs for top commit:
darosior:
re-ACK 7211b96ca936a449916b0cca3e0a64b09463e813 -- re-applying Edouard's ack after a trivial rebase.
Tree-SHA512: f1f9f6080bda17768b087958e6236e8b7470043d1f570ce4a3f3826a5b4a13d37461bfa9ee64acc4e1ee103f0c82e03f79c2df999351a86f18cc35ac9cdc3c45
