366e9b7d49eb7261df4801534224cb737a49149f gui: use descriptor method to detect psbt change outputs (edouardparis)
Pull request description:
This commit also fix handling of create_spend result while updating liana:master
close#841
ACKs for top commit:
edouardparis:
Self-ACK 366e9b7d49eb7261df4801534224cb737a49149f
Tree-SHA512: 5316e610ec6fe1c09447329c031a52710fa7802c0135cc2e386d9926d5f189f1b381596b1f5b081beb2904341d4d7468fa1b4148e9fc49644670e5d8335ca015
39299263954b4d29f6bdcb177e9b2377d1ea92ed descriptors: add a method to get a PSBT's change outputs (Antoine Poinsot)
c6b554da93bdc90b0c2a6cb70d962fcaaf718aff descriptors: unit test we do take into account derivation steps before wildcard and multipath (Antoine Poinsot)
Pull request description:
Fixes#857.
ACKs for top commit:
darosior:
ACK 39299263954b4d29f6bdcb177e9b2377d1ea92ed -- re-applying Edouard's ACK. Only change is the addition of an `index()` method on the `ChangeOutput` enum.
Tree-SHA512: fceaa4e492684be08d45ab09d74345d5825b73d930f5caa4162862e5ff94f32cd5e9ab23b0730bc7ef44569c8e10cfed0f343b4843590a2163122d3402fc3734
13398982534d56a5723dfa86723c5917483c8653 commands: include missing amount in response (jp1ac4)
Pull request description:
This PR follows a discussion around https://github.com/wizardsardine/liana/pull/873#issuecomment-1886715468.
The GUI uses the `InsufficientFunds` error to get the missing amount when the user is creating a new spend, but it is not straightforward to extract this information in a general way from the RPC error (see https://github.com/wizardsardine/liana/issues/822#issuecomment-1836482355) and instead the spend module's `create_spend` is currently used (see https://github.com/wizardsardine/liana/pull/863).
With this PR, the missing amount will be included in the `createspend` response rather than as an error.
These changes are based on suggestions from @darosior and @edouardparis.
In a follow-up PR, the GUI should revert to using the `createspend` command to calculate the amount left to select.
ACKs for top commit:
darosior:
re-ACK 1339898
Tree-SHA512: bf702d6b355339e96e719c1d95824e7941ac4fbaece4ec4cccd00b56ea4683ce7fb0cefc43faa5731b57e7935ef99da3a2c73b84aaeb9fa5f67703c799be2196
The GUI uses the InsufficientFunds error to get the missing
amount when the user is creating a new spend.
It is not straightforward to extract this information in a
general way from the RPC error. Instead, this missing amount
will be included in the command response.
These changes are based on suggestions from darosior
and edouardparis.
3196a8025ea9686cf76f407043b3ef2f85e0b4fa gui: bump liana:master and async-hwi:master (edouardparis)
99bc44d2b17264e87d80ccada51a4568efbcba3e gui: remove base64 dep (edouardparis)
c9bb7b00de7ce6310b3e6596e8a8df12c1941b72 ci gui: rust version 1.74 for linter, 1.65 for tests (edouardparis)
1526d157687000472b5adb67a2eb796fb7eea109 fix clippy errors for rust 1.74 (edouardparis)
Pull request description:
ACKs for top commit:
edouardparis:
Self-ACK 3196a8025ea9686cf76f407043b3ef2f85e0b4fa
Tree-SHA512: 21bf7e968d0b593788fac4c1a1f577763f541986c9dddc0c99ccef031277d059a77d5d74a7a183b7a42b8c015837e03264c3fb8f9f196d170aca3f85d527f49f
ca583cd847c757ff5b4f6e9db15ce714d825c1a7 go directly to installer if datadir empty (pythcoiner)
Pull request description:
address #263, now if there is a .liana dir already existing but not network folder (`bitcoin`/`testnet`/`signet`/`regtest`) inside, liana start directly into installer (before is was starting the launcher even if no network to launch, and displaying a weird 'Install liana on another network')
ACKs for top commit:
darosior:
ACK ca583cd847c757ff5b4f6e9db15ce714d825c1a7 -- as per Edouard's review
Tree-SHA512: e4c7725c277082fa354bb9397744dfa92e90c14e96b21cad31cb3e111424de15b9aeab1a4d775a59efcf43b385616852e64b1cd2d184f1ddef4be5348d380218
5c06eef586ebd540f14f3ded4d3639dcbcfb0209 gui(daemon): fix rbfpsbt params for external daemon (jp1ac4)
Pull request description:
The `is_cancel` parameter gives an "invalid parameter" error when converted to string.
The `feerate_vb` parameter should only be passed if it has a value as otherwise it gives an "invalid parameter" error.
ACKs for top commit:
edouardparis:
utACK 5c06eef586ebd540f14f3ded4d3639dcbcfb0209
Tree-SHA512: 73d192186ffac19c560cf7dd0aef8ae5c276bc6ff09852d7b1bc59aa23fe9f980c11e53654fc20fdc41ab2fee9f4433a91591c869ba0aebade8f2febce2121b5
5a15c744e796c9ebe4f6c1eb3010b824189f7855 commands: return warnings from spend creation (jp1ac4)
da474ad6ce1a7553bdc16a586565ef509d74f8ee spend: add warning when adding change to fee (jp1ac4)
8d84f0de863c8fea97d7402651482b908b6d5b87 spend: return max possible change from coin selection (jp1ac4)
e4d8330f34cf82e43bd7d1dc54e56ebf4cfe0baf spend: use debug log level in coin selection (jp1ac4)
Pull request description:
This is a first step towards #811. The GUI will be updated in a follow-up PR.
It adds a warning if there is any change/excess available that has been added to the fee, building on the assumption from https://github.com/bitcoindevkit/coin-select/pull/14 that the decision whether to include change depends on whether the excess is over a threshold. The function `select_coins_for_spend()` now returns this threshold so that the caller can check if the possible change amount is above it.
I've used an `enum` for the different warnings, but could use strings directly.
If the approach looks fine, I'll add some tests.
ACKs for top commit:
darosior:
ACK 5a15c744e796c9ebe4f6c1eb3010b824189f7855
Tree-SHA512: 12716b1e299d3154c520667c66aeb7a176a770f4a1d53125a8334d7c5a7e7bb2ce1dcb795ad5998bffc1303d9cb34c651cf8d3ef3dee8210572d75069012bddd
b4f505c4312c3ef4c54dde82a940e923c2b3ca1d Change text when downloading Bitcoin to include version number (Aaron Carlucci)
Pull request description:
Simple text change to add bitcoind version number to download wording as per #858. First issue exploration.
ACKs for top commit:
pythcoiner:
ACK b4f505c4312c3ef4c54dde82a940e923c2b3ca1d
jp1ac4:
ACK b4f505c431.
Tree-SHA512: 768941de9f308681b903235bc3f9dc6273bd1eac3cdc0b800e7ad1182c3468f37eb9e1169e4ccc79a4e465668d215b419d2e433754914a3a12447575dd693558
