6c5f83ce15805997632cc6f698d40b4c2eb4017e gui: fix displayed feerate estimate (jp1ac4)
Pull request description:
This is to fix#1168.
When estimating transaction size, check if any inputs are using a relative locktime.
I think this logic could later be moved to the `unsigned_tx_max_vbytes` method itself.
ACKs for top commit:
edouardparis:
ACK 6c5f83ce15805997632cc6f698d40b4c2eb4017e
Tree-SHA512: b95853b0b59729d4f8356e6e556c209025eec25e235cacf2385920f90e19f2e4a057d0d59aa28015fdfcc72f7133f122bfa3f3a9e3ced77e2f189ba43570413c
3ee7a5bb99a2d267f8b3cb3955ec9885c24a8f57 gui: fix clippy warning (edouardparis)
Pull request description:
I do not know why but clippy started throwing warning about this line of code
ACKs for top commit:
jp1ac4:
ACK 3ee7a5bb99.
Tree-SHA512: 536d5398649d0223b0f43b6c7be1063c617ed001579c07e9b2fb5f94602470677644a9f774e7413428a9c7416da30839f967f9a3d52429d39121f04db80896fc
5c59c4f5deb5576b7935191d4ed11a8916c974de Add interrupt method to state trait (edouardparis)
Pull request description:
Before changing panel, the previous state may need to release a hardware connection for example.
In order to achieve this we introduce an interrupt method that is used to drop action state.
close#1162
ACKs for top commit:
pythcoiner:
tACK 5c59c4f5deb5576b7935191d4ed11a8916c974de
jp1ac4:
ACK 5c59c4f5deb5576b7935191d4ed11a8916c974de.
Tree-SHA512: 6405a928f0303b25ff863e76dcc7a36e703471cf726c10e755b4145d301d4e01b0ca241160b49216cb456fc7d934c83fcbecf976dcee56473163cce01507f7b0
Before changing panel, the previous state
may need to release a harware connection
for example.
In order to achieve this we introduce an interrupt method
that is used to drop action state.
close#1162
973938fb20cfba75536623f21d4277c5407bb3cc gui: bump version to v6 (Antoine Poinsot)
Pull request description:
In preparation of the rc1 release.
ACKs for top commit:
darosior:
self-ACK 973938fb20cfba75536623f21d4277c5407bb3cc
Tree-SHA512: 9f7cdaf88d800a16a0dcbd05b1d0cb20ee9e4aaae157cacff761cce822a29239d33eeb0a2cbe80429cb0bd28d46e84ef03e4d471b76cadbc8169a8cb3e9b0e75
b0d30dbebf23b44399e5f75a2a786c4fd66293eb Use rustc 1.70 required by gui for docker reproducible build (edouardparis)
Pull request description:
ACKs for top commit:
darosior:
utACK b0d30dbebf23b44399e5f75a2a786c4fd66293eb
Tree-SHA512: 752187b01c573701e22d5f388fb61b30e9e2688a1f2b5540efa61bc53221dcf9a7b4cc6b29b89d2f148ec972cde1a476c454a71a447b72004de1cd8c3a2c2462
15f4e819724006f52b9468b3b6a176460682fd59 doc: slight improvement to Jade documentation (Antoine Poinsot)
2bd25b6eaaedf52e2e9672bd2e05d8d07580917f Release notes for 6.0 (Antoine Poinsot)
168112de10617f03abf8bd7bdf1ea4dd5dbaabaf Bump version to 6.0 (Antoine Poinsot)
Pull request description:
The first step toward the v6 release: bump the lianad version and update the release notes.
ACKs for top commit:
darosior:
self-ACK 15f4e819724006f52b9468b3b6a176460682fd59
Tree-SHA512: 211e5ed7ae440f26e1761b178401c5b36bbe2de0c893a0aae03ae7ef770e5a0df67d0fb9bcce05b766845f2fc8df7cc0db4cdc13c47ecf84d2b521ccce989905
3d55616b66e8a0995e2ef9e4ad6d294bf23fe6a7 installer: add a warning if remote adress is not loopback (pythcoiner)
Pull request description:
This PR is a variant of #1137, it add a warning under text input field if user try to connect to a non-loopback address & use RPCAuth:
It also add a check on address + RPC user/password/cookie:
Check connection button is greyed out until address is valid + user and password are filled (if RPCAuth selected)
Closes https://github.com/wizardsardine/liana/issues/1059
ACKs for top commit:
jp1ac4:
Tested ACK 3d55616b66.
Tree-SHA512: a48efe85ee178a4bf216a9cc60b03cbb705c6337b1ce21a49bd031a032e2e81e70428fa4cd76c5ee297b428912dc64f51ffc8ce8dfa928b000dcff412ca530db
c289186803ab6a26ee95e71a59cb5b24414d3260 check validity of user form for psbt update (edouardparis)
b70d83ec29fa0ab69a618fb696de84e8306985e8 gui: non regression test for psbt update (edouardparis)
Pull request description:
first commit is a non regression test, should fail on CI.
close#1133
ACKs for top commit:
edouardparis:
Self-ACK c289186803ab6a26ee95e71a59cb5b24414d3260
Tree-SHA512: 79b88e3dbf996f18af9b9e3546418194f9f5d01054c9fdffe2dae36191b4f9eb2b3f0a2c09ca42f6bccf635c6e8efb6325e3250d242a7b29913f822681c0c04d
a8e256eb6b5463dfd32599618998592a94835193 clippyfy (pythcoiner)
Pull request description:
Note [this](7a11fe584a/gui/src/main.rs (L5-L6)) is related to a clippy warning that appear on MacOs (and i guess on windows)
ACKs for top commit:
edouardparis:
utACK a8e256eb6b5463dfd32599618998592a94835193
Tree-SHA512: 33d84a14718f14caf97c0a46796488cd1f3415b78efb285277afa8384b10831522a2ed15c73c9bdee4dd775ffd294ba76b146e3034d734a067c30ab25b483790
0eda557fdf219b16af8b2d831a755148f1286669 descriptors: improve satisfaction size estimate for primary path (jp1ac4)
Pull request description:
This is to resolve#1118.
It improves the satisfaction size estimate in the case of a primary path spend involving a single key.
Tests have been updated to account for transaction fees now being lower in some cases due to better estimates.
It was already known that we sometimes end up with a transaction feerate (in sat/vb) lower than our target value, since our fee calculation from coin selection is based on sat/weight, which can give a sat/vb value lower than our target due to rounding. This will probably happen more often now given that we'll pay lower fees due to better size estimates.
ACKs for top commit:
darosior:
ACK 0eda557fdf219b16af8b2d831a755148f1286669
Tree-SHA512: 588ded7d69e937dd32ee66ca0d59daad405a1bc4605eef1b6342788625f07a6b9d2c166fb35722d0f002e10104d6e57c13abfa7a7fbbc0fd84391b91c766b2aa
40f9dd9bc43bac0c966585ac2770a02aa4c92765 replace the descriptor by template + key vector in descriptor registration step (pythcoiner)
Pull request description:
This PR replace the descriptor displayed in the installer descriptor registration step, by the wallet policies template + its keys, as almost (all?) signing devices displays the discriptor in this way for registration.
closes#727
ACKs for top commit:
jp1ac4:
Tested ACK 40f9dd9bc43bac0c966585ac2770a02aa4c92765.
Tree-SHA512: 396d20d766b89b93d3f598b3168311dfa693fcd83efe02e0515ee6428e006a5e2db4f502e3b21f50a085f37e44a1049bbfa3e4e09719a6101396012b80486cea
3bca6faffe6f1802e08471af05548f355804767c set minimum window size (pythcoiner)
Pull request description:
fixes#506
i put ~~800x800~~ as default size, feel free to told me if you think something else more appropriate.
edit: i change to 1000x800 so we can also close#507 (i do not have strong opinion, 1000 looks a bit large to me, but if we decide less than 1000 i think we shouls close#507 also)
ACKs for top commit:
edouardparis:
ACK 3bca6faffe6f1802e08471af05548f355804767c
Tree-SHA512: 673e40304c9070777ebcc539975fdc28b14df559330b68dd8f6b23f7ab09dee22364a037967604ab70e1ca9596ecc028930dbb80878faadd085f11e47d3fa491
33b67fca980e364d97fca9b2142bdae381960914 update hw support info (pythcoiner)
Pull request description:
Fixes#1106, taproot support already specified in doc/signing_devices.md
ACKs for top commit:
jp1ac4:
ACK 33b67fca98.
Tree-SHA512: c5fcc6ea7bb2af49039ad0649e689e1d4d3c01bb510e9f6b5f3db1622f42c84eefbe1f2205d667d369bcc89dd45cabac4bb3a830484557296667a88d2e598af3
8921140f6b5adec85f129b07a2040b78c45a72c1 Revert "add specter support for tap-miniscript" (edouardparis)
Pull request description:
This reverts commit 876d83af6518a3e4ae45e156ef2952a7e67affc1.
TAP_KEY_SIG was in fact not implemented by specter version 1.9.0 db3ce3e918
ACKs for top commit:
jp1ac4:
ACK 8921140f6b.
Tree-SHA512: abe108775441680139d72b7067dac0679f20f176762fc4d9471fc31061de594840099c7b4f4fc7a3bf75d54026af8cb7256bee9d3c15ef84eb2da1f20b88cbda
a9cfe45c0a010e39cb2fdd0b59926be5c13f2a4e fix ui: wrong usage of widget state (edouardparis)
Pull request description:
In a previous PR #1096, we made usage
of the widget state instead of the component state to set the collapsed value when the widget is created. But the widget is reset at each refresh of the interface, instead the component state does not change.
This commit makes the distinction between the two by having the widget state as an initial state and the component one as a capture of the user clicks.
ACKs for top commit:
jp1ac4:
Tested ACK a9cfe45c0a.
Tree-SHA512: abe108775441680139d72b7067dac0679f20f176762fc4d9471fc31061de594840099c7b4f4fc7a3bf75d54026af8cb7256bee9d3c15ef84eb2da1f20b88cbda
In a previous PR #1096, we made usage
of the widget state instead of the component state to
set the collapsed value when the widget is created.
But the widget is reset at each refresh of the interface,
instead the component state does not change.
This commit makes the distinction between the two by
having the widget state as an initial state and the component
one as a capture of the user clicks.
c0e7b63809fd60f4fc6f5e9cd5223c138e25cfde fix launcher wording (edouardparis)
977d8fa2dda00b45178b18ee3120082c0780b5ad Create datadir before install to store installer.log (edouardparis)
dee083c6d1b12eff07edef2f888bc1899c57bb72 Add blue banner for testing network (edouardparis)
be343aec37d6a8d6249285cf64759e23673e85e8 Add previous button to installer first page (edouardparis)
9ae33408cb0c0446e5ce729d46aa23dce3eb614d Move all network setup in launcher (edouardparis)
Pull request description:
This Pull requests introduce three changes:
1. Network can only be chosen with the launcher panel. A drop down showing what network user can install is shown to the user when clicking on install a new network.
2. A previous button is added to the first installer page, so user can be redirected to launcher and the network choices if he has chosen the wrong network. close#306
3. In order to make it clear for the user which network he is actually using or he is currently installing a blue banner is added on top of the window if the network is different than the bitcoin mainnet.
ACKs for top commit:
jp1ac4:
Tested ACK c0e7b63809.
Tree-SHA512: 9a0673ac785835da06fe313a861d76bdd14438cff56edb37b108b0564fd473e54028a63e209ad253b25aea318b3eb65a062cc190f76117df1baf35a251ce8356
