020fef4b31a108e39b590b645aaca080c75871c9 fix: send-to-self payments include change from outgoing only (Michael Mallan)
Pull request description:
This is a follow-up fix to #1507.
Only those change outputs from outgoing transactions should be considered send-to-self payments.
ACKs for top commit:
edouardparis:
utACK 020fef4b31a108e39b590b645aaca080c75871c9
Tree-SHA512: 92a699d8bfd2724c1c309e7f957fe9bf9dd2460f562ff8f93d4e0fb026d43cae0f270fbc96d0ca6002ba9ce70c2ee09da80ff8c08b08d08db81d03ff2f78251c
1b3c4080c7a2a5894f019dccdbc140d33e8bfb77 gui: stop auto load of address when opening receive panel (edouardparis)
Pull request description:
close https://github.com/wizardsardine/liana/issues/1461
Stop generating addresses without user explicitly asking so.
Otherwise, the gap will be too big and some rescan with default gap limit on other wallets will not detect funds.
ACKs for top commit:
pythcoiner:
tACK 1b3c4080
jp1ac4:
tACK 1b3c4080c7.
Tree-SHA512: 97679dd0cceb9038342bc2bf5a91dd4f93134e5d13877e4aa4a327eedaa620230d166baf46beb870f2cf71d39bfeffd88f9926f4bd1816b5af006761f88b1b0f
b7b52d73bec0522af6dd08e9018868841b9363ca Revert "Merge #1500: gui: allow to connect to an electrum server w/ a self signed certificate" (edouardparis)
Pull request description:
This reverts commit 2d2d080888f5c2a0fd82d6c4a4009a254b2dbcb2, reversing changes made to cfe15b360d0f9a40d0de2ca00bdd1530e6e6c8e9.
We are not ready yet to have openssl dynamically link library dependency for our users.
ACKs for top commit:
jp1ac4:
utACK b7b52d73be.
Tree-SHA512: e85963ac9dd9d449c4af5806d7f7aaee70de676d38e9f931e50ed7c060a5a9522209a27db77a0a6254249f55ae52259dc7c747fe2032d830a4d6d92f1cb6a72b
6b914fd2491841bb3daa41f59641677c10cc880b bitcoind: parse descriptor before comparing strings (Michael Mallan)
652eb5b799c8d2ed9f65ab24c0101af3e09905f8 refactor(bitcoind): extract logic to function (Michael Mallan)
Pull request description:
The `startrescan` command uses the response from bitcoind's `listdescriptors` RPC method to confirm that the rescan has started.
This check includes a string comparison that can fail in some cases (Taproot descriptors with a spending path having only a single key) as the descriptor string returned by bitcoind may contain both `h` and `'` , whereas Liana's descriptor string only uses `'` (as per the `Descriptor::to_string()` method).
This PR changes the check to first parse each descriptor string as a `Descriptor` object to avoid any `h` / `'` mismatch issues.
ACKs for top commit:
edouardparis:
utACK 6b914fd2491841bb3daa41f59641677c10cc880b
Tree-SHA512: 14d3eaef950a490020af2157e03adcbd1cc821c92750f21e682ba74bc4fd3531552a7ba0f70144792d5bbc18546b919567f181e468e2b196c6c473ca45d9d9de
55b92b3da707310900fca1570269c5e13b709d64 fix: treat change outputs as send-to-self payments (Michael Mallan)
Pull request description:
This is a follow-up to #1503 to fix an issue with change outputs appearing as outgoing payments on the home page.
It expands the definition of `PaymentKind::SendToSelf` to include change outputs since these are also payments to self.
ACKs for top commit:
edouardparis:
utACK 55b92b3da707310900fca1570269c5e13b709d64
Tree-SHA512: 347045e45a75632024e2539fedc7ab3f76b25fa14aeeac2490e5def7a746cf37097e636110e52823af84744f0970a07c70300fd324b62703f8d4cbd1be76ae7a
b1736bbd404df91a0150c06985998ac1575c317d export transactions: output a blank if fee is 0 (pythcoiner)
Pull request description:
This PR replace the fee displayed as 0 by a blank.
ACKs for top commit:
jp1ac4:
Tested ACK b1736bbd404df91a0150c06985998ac1575c317d.
Tree-SHA512: 02d132b5de988e0f8b0c3ad6ec463c0a70f9d207b0620560ab1fb683b3729f96bc044d6f4315dc0f48eea4ddb6142ea60141e1cb430c879f2e177eb3a549ee9a
308355322cd62b4e98a91de40c92070c3a8ae011 ci: add openssl to 'windows_latest' (pythcoiner)
09bb450b1fbd39aabec61719b9e67e12180641ba gui: allow user to not validate the ssl domain for an electrum server (pythcoiner)
efb23300dae06702459e07334ab458bfcc54b3e6 lianad(electrum): add an option to not validate SSL domain in order to work w/ self signed certificates (pythcoiner)
Pull request description:
closes#1300
The issue about connecting to an electrum certificate using `rustls` have been fixed [upstream](https://github.com/bitcoindevkit/bdk/issues/1598) but in order to beneficiate from it we have to update `bdk_electrum` and `rust-bitvoin` dependencies.
Meanwhile, this PR introduce a workaround: the initial issue is related to `electrum-client` `use-rustls` feature and `use-openssl` feature is not reexported by `bdk_electrum` but we can use `electrum-client` crate directly and use `use-openssl` feature by this way:
- [x] use `electrum-client` directly w/ `use-openssl`
- [x] add and option to opt-out of ssl domain validation
- [x] let user change the `validate_domain` values in `Settings` menu.
Note: ssl://testnet.aranguren.org:51002 electrum server can be used to test this PR
ACKs for top commit:
jp1ac4:
ACK 308355322c.
Tree-SHA512: 28139ef6c6073045b413303c725c0d6c83b193d89c7b39edfb1d10108a1551c1ac9fdf20c941bc770d62f0075fb47ffa305b4975ea38e1840ae3d631ca9e39e6
22f48753a367187a1d08bc34d20e5b75bdfc01b8 gui: add and export transactions feature (pythcoiner)
Pull request description:
This PR add a feature to export transactions:
Done:
- [x] Subscription to run the feature in a detached thread w/ possibility to send update about the ongoing progress.
- [x] Let user choose the path using `rfd` crate
- [x] Add a modal that show progress of the process
- [x] estimate the progress
- [x] cancel feature
ACKs for top commit:
jp1ac4:
Tested ACK 22f48753a367187a1d08bc34d20e5b75bdfc01b8.
Tree-SHA512: 5cf271d52878c4845347c5951a562e08e7f7efea08f0dc702d0500e41d6ad8eab7cb31f7e8a7b4edba48916648759ce97a9f591d1bcb4564a0c7067d5274fa08
79057a0cd9ea8010e91f9d7ea035a85c1b06bdb1 Do not include self transfer in home events (edouardparis)
790beaa6700b514f6f94b38acb356d4938ab87f5 Use payment model in the home (edouardparis)
b1abce5a244b2fb101bb4faeabadab4ec877ac3d Separate Labelled from LabelsLoader (edouardparis)
0d8f88839eb01d3fce0b71bea955b288ef1c27cb change event selection in home to load model (edouardparis)
Pull request description:
Some users may have txs with a lot of inputs/outputs. We wrongly iter over them in the view which is the origin of performance issues.
ACKs for top commit:
jp1ac4:
Tested ACK 79057a0cd9ea8010e91f9d7ea035a85c1b06bdb1.
Tree-SHA512: 2c66703e35c1e67447cfd50d72e5dcd79ac7e1469e513d082001ec5ec94ca88c6a0a5e65f87e6ceb213e21b43e9bfa2005ca1c63fee4d230d2cd2d1374fd3212
c07c81659809ad23369fdcb56f3e3615816367e1 bump msrv 1.80 (edouardparis)
Pull request description:
The update of the reproducible system allow us to bump the minimal rust supported version. Although bumping a MSRV should be conservative, it is a requirement for us if we want to be able to support last https://github.com/iced-rs/iced version and improve the experience of our users.
ACKs for top commit:
edouardparis:
Self-ACK c07c81659809ad23369fdcb56f3e3615816367e1
Tree-SHA512: d3f51e45a7a1d0f6cf3d98ae03bf9b44d7d7f0216b58ee1837dc5a2022f12b5c33a369d392391256709bf512d3020ae7a8b864c87f072a13007a4ca6066df2e8
6b4e7b0521c7328647738b46afd67386273c403e fix reproducible dpkg-deb (edouardparis)
cc083f9be6f6dd2f50a60572d09872913ece5dd0 Remove docker reproducible build (edouardparis)
34e6afd54351178fdfae6eca01ee24e744d21fa1 Add script contrib/release/sign.sh for signing binaries (edouardparis)
a2917c5bd73e230d9b2cb13ec25250bd36b6d5ad Add SOURCE_DATE_EPOCH and TAR_OPTIONS for reproducibility (edouardparis)
2c70aba2d573d80a9b4ed78c0914e3996a6352ca nix build and nix shells for release (edouardparis)
Pull request description:
The nix build replace the docker build. Sadly zip is not fully deterministic so release_assets may not have always the same hash, but users can still audit the binaries reproducible build.
ACKs for top commit:
edouardparis:
Self-ACK 6b4e7b0521c7328647738b46afd67386273c403e
Tree-SHA512: cc66465073aa15c23e941cc41ec03918ee604adb40a3a65de524ff03a1651ababf0d40287f749a03aea9c8c165172b1e9a3b3aaffb120074a152697a0920b2f8
091d7728ee33d231fbafb839ac497f86122d0851 commands: use unconfirmed from self for coin selection (Michael Mallan)
Pull request description:
This is to resolve#1484.
We previously used unconfirmed change for coin selection as a best-guess way of identifying those unconfirmed coins from self, but now we have the `is_from_self` field we can use it directly and be sure we only select coins that are fully under our control.
ACKs for top commit:
edouardparis:
Self-ACK 091d7728ee33d231fbafb839ac497f86122d0851
Tree-SHA512: 31e3b292e6f2ed293374ba6971f82736fa53f12341f433ffb7b59891d996682eebf031154aed6619f5c3b17fda176e01cccc20fdc523d428b04856bc5d444518
We previously used unconfirmed change as a best-guess way of
identifying those coins from self, but now we have the
`is_from_self` field we can use it directly and be sure we only
select coins that are fully under our control.
715aeb9298d1bac41ab3c904201696ddf9a794be gui(lianalite): use is_from_self from response (Michael Mallan)
8d99981c143b424d660b04b829da17afdfb1608a gui: include unconfirmed from self in confirmed balance (Michael Mallan)
31224ba44369e8eb76f004fefb0ddb4206458f4d gui: set missing fields for new home page (Michael Mallan)
0a4861f409867744c768228889b1107ea2ae8a9a refactor(gui): use common function for coins summary (Michael Mallan)
Pull request description:
This is to complete #1375, building on the changes from #1483.
The Liana Connect API response has been updated to include `is_from_self` so this will work for both local and remote backends.
ACKs for top commit:
edouardparis:
utACK 715aeb9298d1bac41ab3c904201696ddf9a794be
Tree-SHA512: 905494ee29f19dd527b2b1173075e6f2c332030b00ec05aca680921fc50411fee0d65977d2ee29b82fcfb07472df7717d8844a60cd629ffd8850d77c29b4f71e
e3acfa7f806a0694d29adb9369984c25760840e3 Update guix commit: rust 1.82 (edouardparis)
d2379bd71ad395891d45c307ca0e9f2174221e8b Use cargo-zigbuild for reproducible build with glibc 2.31 (edouardparis)
Pull request description:
Zig language has solved many issues regarding compilation linker.
It allows us to compile to a smaller version of glibc while using latest guix commit.
No need then to bootstrap multiple version of rust, the current supported version is 1.71.1
close#414
ACKs for top commit:
edouardparis:
Self-ACK e3acfa7f806a0694d29adb9369984c25760840e3
Tree-SHA512: 1a0bce14900034c5522fe06dc00807d5d2e4660f58a6c9d035c26a34f13b893a3cf56cb43dd246913926c6cf76d61cff039418c2c55b436e8673ab700829577c
1c0338610f76419287157c14a6647a362160f9e4 commands: add is_from_self to listcoins response (Michael Mallan)
c1e55716e619249c264193776d36c640df9bc946 database: add is_from_self to Coin (Michael Mallan)
6dd92052af0afc37bddb67493a64af396e7964c9 database: track whether coin is from self (Michael Mallan)
da185361f99eb319554ec78daa2fccdcd72eb298 sqlite: add helper to query single row (Michael Mallan)
4f6dcbfdfd7eaf471a38badc0c9ce48aefac814c sqlite: add columns to transactions and coins tables (Michael Mallan)
f2c910f6eb9f2b74329fa026c93f7e813f3baa53 sqlite: refactor test to not depend on order of coins (Michael Mallan)
bde3299db1c38eb6b0b09d7da2a73c43e40181b9 sqlite: refactor migration tests (Michael Mallan)
Pull request description:
⚠️ This PR upgrades and migrates DB version so a wallet opened against this PR will no longer work on Liana v8.
This is a first step towards #1375.
Following the approach from #1391, this PR adds a new `is_from_self` field to the response of the `listcoins` command.
The underlying information is stored in a new `is_from_self` column in the coins database table. This column could instead have been added to the transactions table, but for consistency with other transaction-related columns, I added it to the coins table. It's also important to note that being from self is wallet-dependent, so adding it to the transactions table would not work if multiple wallets were supported in the same DB (h/t edouardparis).
A subsequent PR will then use this field in the GUI to determine which unconfirmed coins, if any, can be included in the confirmed balance. It also needs to be added to the corresponding Liana Connect API call. Another use of this field will be to determine which unconfirmed coins to include in coin selection (https://github.com/wizardsardine/liana/issues/1484).
The first commit in this PR refactors some existing DB migration tests so that they will not be affected by future changes to the coins table schema.
ACKs for top commit:
pythcoiner:
utACK 1c033861
edouardparis:
ACK 1c0338610f76419287157c14a6647a362160f9e4
Tree-SHA512: cdadb1f887989d40a08370a479310d80087b9075ff766dd518167baed4630ccbcbb0dc8f49b7fb31ad9aebddfb4ca459d83aeed3c47158bdb046a91352f98fc7
