6f4eb79a5a45751a1c919565ea9c88f59fbda0ab gui: refresh cache more often while height is 0 (Michael Mallan)
a51110269c96e7a9d7c4143e0bd6f8cf27a703a3 gui(home): indicate that wallet is syncing (Michael Mallan)
b452966653da1f2d857dd5901972171aa9d1250c gui(home): track blockheight from cache (Michael Mallan)
1d1e735ae975bb73af5389090e1eee68c727c7ea ui: add loading spinner that types text (Michael Mallan)
3c46a7337c57ef646626d052a0ab23a7fa0ecb17 ui: add carousel loading spinner (Michael Mallan)
e4c1ab106d74ad193aa1ba2f5746ce598c4801e5 ui: render amount with chosen colors (Michael Mallan)
013feb3909ebed0a8850a51a7d61383f327b5d4d ui: refactor amount function (Michael Mallan)
Pull request description:
This is to resolve#1361.
The home page considers the wallet to be syncing if its height is 0. In this case, the balance will slowly blink and a "Syncing..." text will appear just below.
The home page will check the wallet's height upon each cache refresh, and will reload the home page once the syncing has completed so that the updated balance is displayed without the user needing to do anything.
Both the blinking balance and "Syncing..." text use a new `Carousel` widget that cycles through different child widgets at a specified rate.
EDIT: I've added an extra commit to address #1363 as that is also related to the wallet height and cache refresh.
ACKs for top commit:
edouardparis:
ACK 6f4eb79a5a45751a1c919565ea9c88f59fbda0ab
Tree-SHA512: 04214ccb1cf998ae6f7589f2c37335416a6d39b668269c4e07e30c8713e1a0e9e46257c60cea7b19ee6d6e35cbdccaf1122d25a66e6e7e905de51fce185f9180
The secondary button is light grey border and transparent
background that has border and text green on hover.
It brings consistency with item list selection that
has green border on hover.
The wallet's height is taken from the cache and is used to check
if the wallet has been initially synced after creation.
For the remote backend, the cache refresh should be done with the
usual frequency while the wallet's height is 0 so that the sync
completion can be detected sooner.
We check if we are able to fetch master fingerprint
to see if the bitcoin app is open. The error is then displayed
with the generic connection error message.
The problem:
We display the button if the size of the list is a multiple of the page
size. Otherwise, we assume that the user has reached a partial page,
indicating they've reached the bottom. However, since we chose to
include all transactions with the same block time on a single page
(because it's not possible to order them by block index in the database,
as we don't store the block index), this can cause the page size to
exceed the set limit. As a result, the list size may not be a multiple
of the page size.
The solution:
keep in the state if the last fetched page has a length inferior
of the expected page size and do not display the button 'See more'
then as we reached the bottom.
6a6a72408fe105c278b9e66d885d30310b92dd8a grammar: USAGE.md download it there -> download it here (Ben Westgate)
80fddb20f3522e4baf917468ebacef6aa4dd9718 grammar fixes: loader.rs (Ben Westgate)
b821896f7792c6f5b7e101666751a50e71b93c5d installer/prompt: improve grammar and fix typos (Ben Westgate)
Pull request description:
Closes https://github.com/wizardsardine/liana/issues/1283
back up is a verb, backup is a noun.
Other words had improper plurality to match the verbs used or the verb had the wrong conjugation or adjectives were placed outside of normal locations. More descriptive pronouns used.
ACKs for top commit:
darosior:
ACK 6a6a72408fe105c278b9e66d885d30310b92dd8a
Tree-SHA512: dffa8158c0c59045cccac9b124f60dbfe0489cf0e6cf43be462aaf38e4ebdcb418a26cfc7d7c7e813d30e4e0c35bc6a563a985437e882b376f6b14c10bd07d4d
b73193ae77dccde519d43e5042324742dbee5523 Deserialize error from create_spend http response (edouardparis)
Pull request description:
Instead of having an unclear and ugly message like:
data did not match any variant of untagged enum DraftPsbtResult
ACKs for top commit:
edouardparis:
Self-ACK b73193ae77dccde519d43e5042324742dbee5523
Tree-SHA512: 8182c01ce4067b30dc821dc8f13243b3df4a85fa8f146d779bd9922fedd26f0eabd7fca07c47fdc517b0d958cbe0185c7003e09d6d28f32312e6cb4d4fb9ba52
ff3d497fe12a70c606e9953cfb29fa4af0520859 gui(settings): fix daemon reload handling for electrum (Michael Mallan)
Pull request description:
In case of error reloading daemon for Electrum, set edited to false (same handling as for bitcoind).
ACKs for top commit:
darosior:
tested ACK ff3d497fe12a70c606e9953cfb29fa4af0520859. Not bulletproof as i need to get back to the settings and re-click save with the previous settings for the daemon to be restarted, but still helps a lot to have the previous-working-config ready to be saved.
Tree-SHA512: c9c6aad38a8a834d51a6642b42c560107e503afa820db971a2af23c979681ee8487ff4c1c635d99ac740351fab0fe9c3b0119d0d3326193b5aea81f7dfe6598b
819eb920c0210b9d95689f40cfbeba65c03280af gui(settings): allow to change node type (Michael Mallan)
2381227216663a6a2336ee79905646fb2a3aadca gui(settings): view & edit Electrum settings (Michael Mallan)
b570039ff8e740be43c6aebdc62910f4ab4eac05 gui(settings): rename Bitcoin Core to Node (Michael Mallan)
db20ae4b677cf4ffdf19ad0df6f50ea983b34a02 gui(installer): reduce empty space height (Michael Mallan)
0993905879629c58da24a1145acbb49faf31da3a gui(installer): update wording to include Electrum (Michael Mallan)
f40af570bccecf9361410df334ad30e45f57659b gui(installer): split long string and run cargo fmt (Michael Mallan)
0f09be151ca3ba1353d23b170805c845fc8ab5cc gui(installer): don't change values while waiting for ping result (Michael Mallan)
c93aa88d74620a555bd442bc3504e12af198f00a gui(installer): add electrum node option (Michael Mallan)
341e4467dbf727d78f31690b8dbc405995ab4088 gui(installer): allow for different node types (Michael Mallan)
83172c7bc584283d7dd4b93f3f18ec0f2d9a1ad0 gui(installer): add general node definition (Michael Mallan)
046b54e6a9337aaf478ea6e61f2d28d73f1b15c1 gui(installer): define bitcoind from general node struct (Michael Mallan)
c5d9d007fb908308592635b8f85236a1b7a4b5ae gui: move bitcoind to new node module (Michael Mallan)
4536eff561459648cbf0666ec757db95ac29de4f gui(installer): extract logic for try ping bitcoind (Michael Mallan)
ef44cf329adc0eed01451950454edfb7e54be515 gui(installer): add module for node step (Michael Mallan)
f74f071b8a3e4eda77cc5b468f891b21c5e4e2a4 gui: upgrade liana dependency (jp1ac4)
Pull request description:
This is for #1223.
For now, it's possible to edit the node's settings but not to change node type.
Remaining tasks:
- [x] Revert Cargo.toml once #1222 is merged.
- [x] Update wording as per https://github.com/wizardsardine/liana/issues/1223#issuecomment-2286483134.
ACKs for top commit:
pythcoiner:
ACK 819eb920c0210b9d95689f40cfbeba65c03280af
Tree-SHA512: 362a14d32c2e13ba286d252d9f8a1106d63e5c40198776653b0623b433435329663126307e17da017fdbbd8a8ad273b703cc3ba54fd13fa5a0afd7dd9179089a
Once the user is connected we redirect him to
the next step in the install process, but
we keep the Connected state in case the user
want to edit email after clicking on Previous
As discussed in #1240
