2061 Commits

Author SHA1 Message Date
edouardparis
6cefd2464a remove liana from vendored source link 2024-11-19 12:03:29 +01:00
edouardparis
b0fbe0839d liana-gui: import liana with directory path 2024-11-19 10:43:07 +01:00
edouardparis
c14c55beee remove daemonize from config 2024-11-18 18:36:23 +01:00
edouardparis
c8112ab027 move rpc code to its own module 2024-11-18 18:36:23 +01:00
edouardparis
a636cda2f7 liana: remove the daemon feature
We expect user to use systemd service to manage a daemon or
to handle their process by themself.

The json-rpc server is exposed only for unix systems through
unix sockets, it is moved to its own module while the implementation
for windows is marked as TODO.
2024-11-18 18:36:23 +01:00
edouardparis
d83f34c876
Merge #1468: tests: notifyAll() is deprecated, replace w/ notify_all()
5c088b2eb69bdc6f868131a60c46ac4a219d2cb5 tests: notifyAll() is deprecated, replace w/ notify_all() (pythcoiner)

Pull request description:

  closes #1253

ACKs for top commit:
  edouardparis:
    ACK 5c088b2eb69bdc6f868131a60c46ac4a219d2cb5

Tree-SHA512: 86e87277b77aa3be3159cb4337bedaf5206cac6d1610e93c9ec0c4223e00791d121bdd49fc60a08e18c0d983e6c4e8efd76046bcab78459073101ae775f9c54e
2024-11-18 11:51:06 +01:00
pythcoiner
5c088b2eb6 tests: notifyAll() is deprecated, replace w/ notify_all() 2024-11-18 11:35:12 +01:00
edouardparis
1b00cdfd75
Merge #1452: descriptors: fix unsigned tx max satisfaction weight
e4ae6dc368d6600fbbdd5adaea1d52feb0f4b2a9 descriptors: include segwit marker and flag (Michael Mallan)
03a3230a67e9bf09e556d10550d9cdd08fb805d6 descriptors: add method to get max tx weight (Michael Mallan)

Pull request description:

  This fixes #1406, building on the fix from #1451 for estimating the weight of each input.

  An extra 2 is added to the unsigned transaction's weight to account for the Segwit marker and flag.

ACKs for top commit:
  edouardparis:
    utACK e4ae6dc368d6600fbbdd5adaea1d52feb0f4b2a9

Tree-SHA512: de78763d85ed38d5e2797d6f95b1ef293bbedf3cd4d5d1f69085bd134a117ae270a24c3487d738398191fb4126c4f8319bba53b902cec1625dad1c501f3f2aa9
2024-11-18 09:32:18 +01:00
edouardparis
35e2ffde53
Merge #1453: Update usage references
a36544c69e48796d8e2ef4526b7d9bef8862b9a6 Update usage references (Emmanuel Ferdman)

Pull request description:

  # PR Summary
  PR fixes the broken references found in the `doc/USAGE.md` file.

ACKs for top commit:
  jp1ac4:
    Tested ACK a36544c69e48796d8e2ef4526b7d9bef8862b9a6.

Tree-SHA512: 3f8df14c584f110b654d5f6d595b4c896c02f96261e837bbbd1d7f57759941e66b279069a0927700dec8fe438f08750246f7f74b570a0c44302eb89bc8779de1
2024-11-18 09:29:51 +01:00
edouardparis
27dce54c13
Merge #1437: gui: reload home if wallet is not syncing
71ad55e06bfc804754983debd7502db02b6bc524 gui: reload home if wallet is not syncing (Michael Mallan)

Pull request description:

  Following #1386, this PR will show past payments on the home page while the blockchain is still syncing. Currently, these are not loaded until the wallet has finished syncing.

  This change won't apply if the wallet itself is still syncing. The reason is that this is not expected to take so long and so it's better to wait for the updated data. Furthermore, the DB may be locked if the poller is running, in which case we wouldn't be able to load past transactions until the wallet has synced anyway. The home page reloads automatically as soon as the wallet finishes syncing.

ACKs for top commit:
  edouardparis:
    utACK 71ad55e06bfc804754983debd7502db02b6bc524

Tree-SHA512: 5fcf179ec859616ff1d7150597e73e20cb2ef0aa3ad882eeea37d6149754e58b44e37d6553ecb690a60383a95228f9724ec812dc4ae825d2620d377861c31e19
2024-11-18 09:22:08 +01:00
edouardparis
8e1831366d
Merge #1465: Use 2 decimal for sync progression in home page
5d65a4e1253a7f8312641523981ec90344ffb9ac Use 2 decimal for sync progression in home page (thomas)

Pull request description:

  Solves #907

ACKs for top commit:
  pythcoiner:
    ACK [5d65a4e](5d65a4e125)

Tree-SHA512: 677a132d42f426a37e30829e8a91bc6e7f258d3cfe808d4f0b5cadd1951b3cccd75527574200cf5e2319cf90e6ff5e6e88f387c457123cb9d556c81da458fe12
2024-11-18 09:16:52 +01:00
edouardparis
5133137d49
Merge #1425: gui(send): display max calculated amount w/ 8 decimals
7ab6d05f0bc0c00cfe9a160e8320f4c7de1ae212 gui(send): display max calculated amount w/ 8 decimals (pythcoiner)

Pull request description:

  fixes #1424
  ![image](https://github.com/user-attachments/assets/ffdfc45e-3162-4bc9-ae80-cd4379cb0981)

ACKs for top commit:
  edouardparis:
    utACK 7ab6d05f0bc0c00cfe9a160e8320f4c7de1ae212

Tree-SHA512: 9c4dc7f2ccf2a8c2e6b62a0d628f70bc9a357b70960d215b64d3c695e32610158ee875c78d41e6c942c87cc9fe9633f77e509056d4cf85614c98ee05bf926eab
2024-11-18 09:15:28 +01:00
edouardparis
326064b107
Merge #1153: clippyfy
376621abdfc15e7ee00286338c932298a980517c clippyfy (pythcoiner)

Pull request description:

  Clippy was yelling on Win10 & macOS:

  ![image](https://github.com/wizardsardine/liana/assets/124568858/5f1fe3b0-aaed-4056-8a4f-ce5ca5a9b6cb)

  ![image](https://github.com/wizardsardine/liana/assets/124568858/3ceddc7c-f2c1-43e5-a48d-82792de2fcb8)

ACKs for top commit:
  edouardparis:
    ACK 376621abdfc15e7ee00286338c932298a980517c

Tree-SHA512: 2f447176a1260fdcc11afcd1c3c7b444fb148bafc417e3244c3c8f3283ec272b90af5f997c66a226ccb7703a7f0ec70ee02a30801a35854aab97579028a0c478
2024-11-18 09:10:26 +01:00
pythcoiner
376621abdf clippyfy 2024-11-18 08:00:08 +01:00
pythcoiner
7ab6d05f0b gui(send): display max calculated amount w/ 8 decimals 2024-11-18 06:28:08 +01:00
thomas
5d65a4e125 Use 2 decimal for sync progression in home page 2024-11-15 17:18:36 +01:00
Michael Mallan
71ad55e06b
gui: reload home if wallet is not syncing 2024-11-15 13:47:23 +00:00
Michael Mallan
e4ae6dc368
descriptors: include segwit marker and flag 2024-11-15 13:44:31 +00:00
Michael Mallan
03a3230a67
descriptors: add method to get max tx weight
Errors in the weight calculation could be hidden when converting
to vbytes. This separate method will make it easier to spot any
such errors.
2024-11-15 13:44:28 +00:00
edouardparis
327f0ea665
Merge #1464: fix link logo in README.md
a8c3612d271c8a9e73010b04e6230e037e00d161 fix link logo in README.md (edouardparis)

Pull request description:

ACKs for top commit:
  edouardparis:
    Self-ACK a8c3612d271c8a9e73010b04e6230e037e00d161

Tree-SHA512: 105bd63245db514f2dc1914762858d61d04d3130ebbb73bbca6ee3c4a33e90c2ea0143e1581e6c8e6a6bfb3cbe6d339170b537809802635d23aadb537239a049
2024-11-15 13:48:32 +01:00
edouardparis
a8c3612d27 fix link logo in README.md 2024-11-15 13:47:06 +01:00
edouardparis
89a4187a80
Merge #1448: Refac workspace to follow rust guidelines.
6175ca7b58324a19ba7d8309fac4f18e6a07c178 fix doc (edouardparis)
f32b6aa30dc68623361f7884111707edd0bf3b42 fix the reproducible build to include the workspace change (edouardparis)
8973ee0c7c7b8df37378dde3f1a73b2447147200 fix test not building on windows (edouardparis)
f28b40fe8df967364f2201e3bea84c081b18cac6 fix fuzz, build and tests (edouardparis)
2ab6e40c9399942e2ef756f63e07ff76fb1496b9 refac workspace: move files (edouardparis)

Pull request description:

  This PR clarifies the rust workspace with its members:
  - `liana`: The `lianad` and `liana-cli` crate
  - `liana-gui`: The gui crate to build the graphical interface
  - `liana-ui`: A crate to quickly iterate on a design system

  It allows to have coordination across crates easier, consistent build and shared dependency versions.
  As a result the build processes in the guix container and the macos container are way faster as the dependencies are built only once.

  The overall MSRV is changed for rust 1.71.1, which is the `liana-gui` MSRV.
  Only one rust version is used for all the crates.

  This PR is also a change of vision of the project. The liana daemon is not used as it is. It is too much cumbersome. It should be at the service of the future applications and for now at the service of the GUI.
  The security aspects of the project should be aware of what the end user is using and in reality it is the `liana-gui` binary.

ACKs for top commit:
  pythcoiner:
    ACK 6175ca7b58324a19ba7d8309fac4f18e6a07c178
  jp1ac4:
    ACK 6175ca7b58.

Tree-SHA512: 4b193ed92d3108672d785b28ed54ff95168d365f163235b72cd7e24a7023a7293853ddb458930fb4640d7b1c60a8965e1b38cc060a426474d50b29e2eec4a6d2
2024-11-15 13:45:09 +01:00
edouardparis
6175ca7b58 fix doc 2024-11-15 13:26:13 +01:00
edouardparis
f32b6aa30d fix the reproducible build to include the workspace change 2024-11-15 13:26:13 +01:00
edouardparis
8973ee0c7c fix test not building on windows 2024-11-15 13:26:13 +01:00
edouardparis
f28b40fe8d fix fuzz, build and tests 2024-11-15 13:26:13 +01:00
edouardparis
2ab6e40c93 refac workspace: move files 2024-11-15 13:26:13 +01:00
edouardparis
cfe653f631
Merge #1451: descriptors: fix max satisfaction weight for Taproot multisig primary path spends
6e74a96e12feb00fcf0f6974f56002c0356e0960 Revert "spend: add 10 sats to fee for 1 sat/vb txs" (Michael Mallan)
cf88aca3aee0fed9a817dd4946db7ad3c1b080a7 descriptors: fix satisfaction size for Taproot (Michael Mallan)
e9c699570669e9723bec47b1fcd6df66257a8128 qa: add threshold paramater for multisig descs (Michael Mallan)

Pull request description:

  This is a fix to #1371 and the related #1322.

  As per https://github.com/wizardsardine/liana/issues/1371#issuecomment-2446921093, this adds the varint length for the script and control block elements of a Taproot primary path spend.

  I think this is what caused #1322 and so I have reverted the change from #1323.

ACKs for top commit:
  edouardparis:
    utACK 6e74a96e12feb00fcf0f6974f56002c0356e0960

Tree-SHA512: 754e5c2186de853cde9006aeab7989141a4d363b9e3d8adb3f0264bcbca7e3b56a94822d434f6f7d8108e7c0e3023959fa407643e5868082f8981c5ce10b9a1e
2024-11-15 13:21:40 +01:00
edouardparis
b46efc6cf4
Merge #1457: Fix blockchain sync progress
439af752a57410f4667664a2d5de93ddb9fa705e Fix blockchain sync precision, add tests (thomas)

Pull request description:

  I've merged `roundup_progress` in `rounded_up_progress` since was in utils and was no longer used by any other method.
  I also added some tests to verify the precision's update but also for specific cases that we manage. By the way tests has been moved in the related file.

  Solves #907

ACKs for top commit:
  pythcoiner:
    ACK 439af75
  jp1ac4:
    Tested ACK 439af752a5.

Tree-SHA512: a87998d1e25c47d751dabc38f641f05f2544bf17cbdcf95d24e829a0aa9dd8ce2de3bdc72a52aced04ffd777412ca206641f914d9a083241d98ceea33d4c10cc
2024-11-13 13:36:53 +01:00
thomas
439af752a5 Fix blockchain sync precision, add tests 2024-11-13 11:15:58 +01:00
edouardparis
387f431c3b
Merge #1459: gui(installer): fix typo in remote backend description
eba3b616b90bdafb6bc21e2c404f85d251f9f947 gui(installer): fix typo in remote backend description (pythcoiner)

Pull request description:

  closes #1458

ACKs for top commit:
  edouardparis:
    ACK eba3b616b90bdafb6bc21e2c404f85d251f9f947

Tree-SHA512: 226d8c57ce5b8f72c31cc13f079486b53419d8ec345ba87cc1b2ab1a4afd5d02be35f7baae46329a433217c9352ccd73182686160c3dc17dc08186321fac4540
2024-11-13 10:09:23 +01:00
pythcoiner
eba3b616b9 gui(installer): fix typo in remote backend description 2024-11-13 01:45:51 +01:00
Emmanuel Ferdman
a36544c69e
Update usage references
Signed-off-by: Emmanuel Ferdman <emmanuelferdman@gmail.com>
2024-11-09 05:16:25 -08:00
Michael Mallan
6e74a96e12
Revert "spend: add 10 sats to fee for 1 sat/vb txs"
This reverts commit 74a53baa39c409d8a39a27affc5ebac34128cb24.

I also removed the extra sats being added in the functional test.
2024-11-08 15:27:25 +00:00
Michael Mallan
cf88aca3ae
descriptors: fix satisfaction size for Taproot
This includes the sizes of the script and control block elements.
2024-11-08 15:27:23 +00:00
Michael Mallan
e9c6995706
qa: add threshold paramater for multisig descs 2024-11-08 15:26:36 +00:00
edouardparis
f3206f9dfa
Merge #1446: gui(installer): list wallets using secondary buttons
ef55e8f01e65f67faff5bd2f07c2c1302d562dd9 gui(installer): list wallets using secondary buttons (Michael Mallan)

Pull request description:

  This is to fix #1445:

  ![image](https://github.com/user-attachments/assets/007ec779-f5b5-468b-825b-865106716f31)

ACKs for top commit:
  edouardparis:
    ACK ef55e8f01e65f67faff5bd2f07c2c1302d562dd9

Tree-SHA512: 4bad1cb94f43d69c0e4da79ce251ca73c529f1e093ab65b78a8054b187f9f7072d2527f112ecfe7670c279e275c9d16b183ac4c3ce2d62bd4896ce763b33df04
2024-11-07 11:11:09 +01:00
Michael Mallan
ef55e8f01e
gui(installer): list wallets using secondary buttons 2024-11-07 09:55:51 +00:00
edouardparis
ff968ea51f
Merge #1442: gui(installer): use fixed keys ordering
86cebc2ddf70b1cfe2d717eb379999ee68699a5e gui(installer): use fixed keys ordering (Michael Mallan)

Pull request description:

  This is to fix #1439. It follows the same approach as used in the settings to ensure consistent ordering when iterating over keys.

ACKs for top commit:
  edouardparis:
    utACK 86cebc2ddf70b1cfe2d717eb379999ee68699a5e

Tree-SHA512: 97c95804d9656f1a24c65134f7f4269b3410252f4ebd743d57e4ef9400b68e5ab534cf304cb5c414ffb2339ea00ed64564a43eee7338dc0c0f07f87d4b421a5b
2024-11-06 11:49:55 +01:00
Michael Mallan
86cebc2ddf
gui(installer): use fixed keys ordering
This follows the same approach as used in the settings.
2024-11-06 09:34:41 +00:00
edouardparis
7fadb9a60c
Merge #1441: gui(installer): fix word plurality when adding keys
d1bcb71ea4d4bdafe4b81fcfbfe78558b7fd8366 gui(installer): fix word plurality when adding keys (Michael Mallan)

Pull request description:

  This is to fix #1440.

ACKs for top commit:
  edouardparis:
    utACK d1bcb71ea4d4bdafe4b81fcfbfe78558b7fd8366

Tree-SHA512: 590b19ec0d717fc3c82f9323a9fc41e79cc52e7b60df9b1319e24b851f1c99d75e12b4bf74d4e6381671895298388b942d494c395d2bbd8c6138b941b01f218b
2024-11-06 10:31:39 +01:00
Michael Mallan
d1bcb71ea4
gui(installer): fix word plurality when adding keys 2024-11-06 08:59:20 +00:00
edouardparis
2fa8294f60
Merge #1434: gui: prepare version 8.0
81dc4eaa22d496bf3b2c3f497b2aa6e62383ec69 gui: version 8.0 (edouardparis)

Pull request description:

ACKs for top commit:
  edouardparis:
    Self-ACK 81dc4eaa22d496bf3b2c3f497b2aa6e62383ec69

Tree-SHA512: 947716aad16060f71f0adadb27fd99ab97d0211a1efe771afb564da63b239ba97e49cf3a9df2833ce4568a4eb99b7704f0460cf2e77af65c721768aa85fa5e67
2024-11-05 12:39:04 +01:00
edouardparis
81dc4eaa22 gui: version 8.0 2024-11-05 12:18:52 +01:00
edouardparis
89299f60b4
Merge #1433: Prepare v8 release
9c30aad9e2f245e587eb5bcd689383e4215b1ed6 Update doc for v8 (edouardparis)
95e97bc7dc769f635d5e4a51d3690ec46cf60fb3 Bump liana version v8 (edouardparis)

Pull request description:

ACKs for top commit:
  jp1ac4:
    ACK 9c30aad9e2.

Tree-SHA512: 9b909b997cf638bc0bb3d7fefd4c237f5e5b96f9bab9919ea39a945e3c96929dc09ce12796bf882137420bdc8f653a64835fcaf84ca63b2788e49cbd849f4bf4
2024-11-05 12:14:03 +01:00
edouardparis
9c30aad9e2 Update doc for v8 2024-11-05 12:02:15 +01:00
edouardparis
95e97bc7dc Bump liana version v8 2024-11-05 11:11:20 +01:00
edouardparis
84a370e339
Merge #1350: Add compression algo flag to dpkg command for arch build
953a85b94321093d29926283df951c3f4f00d2aa Add compression algo flag to dpkg command for arch build (edouardparis)

Pull request description:

  Arch package failed to be extracted during pacman update because of the default zstd algo

ACKs for top commit:
  edouardparis:
    Self-ACK 953a85b94321093d29926283df951c3f4f00d2aa

Tree-SHA512: f5c0885981c5f60e291614fae8f8942b243059bc3c98c2fd313eb8f30a99d4eb832cde1e63e0206e0f71ccb637a0ddb3426283abb8e56231a5eadc65f8775309
2024-11-05 10:33:47 +01:00
edouardparis
0b9a029e2a
Merge #1431: gui(installer): display warning & selected icons
f075b3de74ccbce8d73bf3fc2e8a1ced32192e2e gui(installer): 37dab1bff29333e6f73616238d5e608975002ce7 make only the warning displayed when a device does not support tapminiscript, this commit add also the 'selected' icon (pythcoiner)

Pull request description:

  ![image](https://github.com/user-attachments/assets/b0ccc3e6-5d61-47f2-b8e3-0bd17d7c68b8)

ACKs for top commit:
  edouardparis:
    ACK f075b3de74ccbce8d73bf3fc2e8a1ced32192e2e

Tree-SHA512: bda25aec6719cf6934e021bfa7ba0c6fa2d193b00cb63f53f52d956b3541769942eb9e4a9b0a09f66fc94ac4f3533441d7f7725fd61136cf40544cd90d130f17
2024-11-05 10:03:44 +01:00
edouardparis
d3a1e19b8a
Merge #1404: Refac pagination: sort list in async command
c620c8278ffb8a051a5613be7620b2589c6a19f7 Add specific comparaison order for HistoryTransaction (edouardparis)
6de5016c0886d297350b47267e3a6614bae38df3 Refac pagination: sort list in async command (edouardparis)

Pull request description:

  This is part of a major rework to fix performance issue while loading lot of transactions in the gui.

ACKs for top commit:
  jp1ac4:
    ACK c620c8278ffb8a051a5613be7620b2589c6a19f7.

Tree-SHA512: 54abaf0a00e14b6ca0ae58dc8025cdd0707cc7ced3b168a4cbc97b60ab46ee72fdbda99e488053b8a101b17682c8fe1d996b5721e49134f4e520f84a5a692eb3
2024-11-05 09:50:53 +01:00