e072e896c7dc744147c38a7d36d9eedd413399fa bitcoind: don't set load_on_startup when loading watchonly wallet (Antoine Poinsot)
Pull request description:
This was necessary to transition wallets that were created without this flag, but since v2 they are always created with it so this is redundant: it'd unnecessarily try to update the flag over and over again on bitcoind's side, always with the same value.
Fixes#641.
ACKs for top commit:
edouardparis:
utACK e072e896c7dc744147c38a7d36d9eedd413399fa
Tree-SHA512: 517cdb2ee44f9237325dee76646aa84decc5bfb8c375798ebf6a8729c3acbe1661afb61eb69901a284bd6074b2b090115d145ec2a87cba1d434e6f77e78cbb14
For transactions that have been broadcast, the feerate is calculated
using the transaction's actual size. For PSBTs, the feerate is
calculated using the max satisfaction size for all inputs, whether
they have been signed or not.
This was necessary to transition wallets that were created without this
flag, but since v2 they are always created with it so this is redundant:
it'd unnecessarily try to update the flag over and over again on
bitcoind's side, always with the same value.
9895b493f1d79ae8fc5a1591ef455ccda2d81ccd gui: trim text input strings (jp1ac4)
d3f2931375ff95c201a60164bf1015f18c6e87ce gui: remove unused file (jp1ac4)
Pull request description:
This is to resolve#323.
Following suggestions in #323, I've added a new `TrimmedString` struct that takes a string and applies `trim()`. This type is then used as `form::Value<TrimmedString>` to ensure text inputs are trimmed.
I'm creating this PR as draft to check if this is the right approach before applying the change to other inputs.
I've also removed a view file that seems to have been created accidentally.
ACKs for top commit:
edouardparis:
ACK 9895b493f1d79ae8fc5a1591ef455ccda2d81ccd
Tree-SHA512: 76c7f28ed2d0b6b6b76658a9368b918b0b211e2fabd72ac5d19c13adcbb2d3645b78680a8849f235ee58620fbe8df440ef8354f2d50d39601879bb7727465335
f771e674faccf150a5210b3abe829d443619c3e6 gui(installer): restrict clicking previous on final step (jp1ac4)
45f91216d5d0991d7aebde8d4c8bc99edaf5521a gui(installer): remove unused fields from final step (jp1ac4)
03c2bd76b8c6c1b721014afb37da7732ddfeb0cd gui(installer): install and start automatically on final step (jp1ac4)
Pull request description:
This is to resolve#679.
The following changes have been made:
- Change title of final step to "Finalize installation"
- Install and load wallet automatically when reaching final step
- Remove fields from `Final` step that are no longer used
This is how the page looks when installing:
The following is only shown for ~1 sec once wallet has been installed and before loading wallet:
ACKs for top commit:
edouardparis:
ACK f771e674faccf150a5210b3abe829d443619c3e6
Tree-SHA512: b5360c77a13e4028331e4072246f1c897aa6fe61b0c8697b33d5c91ed460e55fe76b8808f4779db2b2f0322e27433e5dbb72fd0210cbf77f28a270bd82ea2558
7079c6f82b89bdd968b21a6b8bce37cff7e51d89 installer: show message when starting bitcoind (jp1ac4)
Pull request description:
This is to resolve#714.
The "Starting..." message will now be shown also in case bitcoind was already installed on a previous occasion:
ACKs for top commit:
edouardparis:
ACK 7079c6f82b89bdd968b21a6b8bce37cff7e51d89
Tree-SHA512: 86d843208b0fa16eb9bc489b3e283ad1deb8e4aecf7743a7e124a23a4809c06d8b0dc8bc4fa68b6204f6ff0cede431b9799cda3d5d68e58720764b7fd089fb40
36e04edc8207df2b3b3c9fac78f11700514ee2bd db: update docstring for spend_coins (jp1ac4)
c492c51f26b55cc2fd1558bba2ea8a0ab2638d3f db: use coins() with filter in list_spending_coins() (jp1ac4)
eeaf90e5223049ee89832b5aa4a28a85d6c0f38e commands: optionally filter `listcoins` by status and/or outpoint (jp1ac4)
Pull request description:
This is to resolve#676.
I've renamed `CoinType` to `CoinStatus` and updated its values.
The `listcoins` command and related functions can be optionally filtered by coin status and/or outpoint.
Opening this as draft to check that I'm on the right track.
Remaining tasks:
- [x] Update tests
- [x] Update API doc
- [x] Possibly use the updated functions elsewhere, e.g. `list_spending_coins()`
ACKs for top commit:
darosior:
ACK 36e04edc8207df2b3b3c9fac78f11700514ee2bd
Tree-SHA512: 3f5692cd92c2b2011f845adb09523e86b5ea7b13a8bcf42452241b2e6229441c1d46efceb6138446cd7ddb083b3a8c9c2043b058f5caf691768f2f4b472e0fd0
34afbe415bf475c75427b74fcfbe1feb9e219b7c contrib: update the Arch PKGBUILD to use the Debian package (Antoine Poinsot)
Pull request description:
Fixes#675.
ACKs for top commit:
darosior:
ACK 34afbe415bf475c75427b74fcfbe1feb9e219b7c -- tested by Kevin.
Tree-SHA512: 876c14d17dda19f03b0ff00809ec7aad31954dc805912a0cb5579391da0dce38754bf2461d347cfa9dd783acfe32e6769d0e7b97493f851b7e2b0a88093853d2
2890fe7e9afa05212b00994a5fb623bf8c405843 README: update binaries' version to 2.0 (Antoine Poinsot)
702cca5f0f2953d258f198357146a58a3abb18d7 contrib: update Arch PKGBUILD to v2.0 (Antoine Poinsot)
Pull request description:
ACKs for top commit:
darosior:
ACK 2890fe7e9afa05212b00994a5fb623bf8c405843 -- Kevin tested it locally.
Tree-SHA512: 96144e4957920bbe5f92d7177362aceee77db94091b5e55dff5489e072ee70120d09551f4ca613cddef5a196ce3ed8aae6a6389a3c5295b067bd3086b593be23
eebf0c20350554f422a028076a460b19f88a7c34 contrib: adapt GUIX build for iced_futures patch (edouard)
df849ba960ace67615a452970ffd2f323a53974e gui: use patch for iced_futures (edouard)
Pull request description:
from #685
ACKs for top commit:
darosior:
ACK eebf0c20350554f422a028076a460b19f88a7c34 -- that's a clean backport of #685 (which i ack'd) and of #687 (which i authored).
Tree-SHA512: e80777417dad0301ce6b9762b2fac02a684e3ce312ad77509e5f2457bfdd11f93d46108fe7bed451eeacf7cc0f3703a8cfa8e18e2dda8f193e704a44c42d019a
7c02557bc86bbac0f0511ea9a793105a5d7ddbb5 Allow rescan for external daemon and internal bitcoind (edouard)
Pull request description:
ACKs for top commit:
darosior:
ACK 7c02557bc86bbac0f0511ea9a793105a5d7ddbb5 -- tested locally, i can now rescan on my mainnet wallet with an internal bitcoind.
Tree-SHA512: 2c3df72a0e3764c41ee8bcfe99b2c61fb14e98da0326e7245640fb3b1fd70cfc42568e3ca76434975198c4871aca76c5cfc96195c408cfe0041eae199dfafa69
9d2309ea5e7ee91eb0c06777153df59249d88926 CHANGELOG: warn about v2 descriptors being possibly incompatible with v1 (Antoine Poinsot)
3a4192bfc5b36b85315e6665604e9dc2d19e0624 [bugfix] gui: installer: don't let them generate more than one xpub (Antoine Poinsot)
Pull request description:
This is a quick and dirty fix to be backported. Doing something like #291 could make sense in the future.
ACKs for top commit:
edouardparis:
utACK 9d2309ea5e7ee91eb0c06777153df59249d88926
Tree-SHA512: e6e4f93a30088a53bf690ccd5b90eadb690fa575e034440b99501dbf6dd59034fa7615b04238a5940da58f618f3ecc4f67ede95906139ea562de66ae1e3bda13
