a2c584f6030d233854ae6508911c0c5301b9b6db doc: add a document about signing devices and specifically the Ledger app (Antoine Poinsot)
Pull request description:
ACKs for top commit:
edouardparis:
ACK a2c584f6030d233854ae6508911c0c5301b9b6db
Tree-SHA512: 2bedc0639094833b470236bacf19d8b93d9a9f75cd692e20363505929f01f8c233a8569e2ca50ddc92fc33494ec4f76750f46e9ecd86f5cd711fc50eff210f8e
b177f190d144986c1268c640075c89399f4c599d gui: store descriptor in wallet module (edouard)
Pull request description:
A new module wallet is introduced that contains the main_descriptor retrieved from `getinfo`.
It removes the requirement for the `Daemon` trait to provide the demon config in the other components of the application.
Actually BitcoindSettings cannot be edited if the gui is connected to an external daemon, this PR just remove the display of the Bitcoind Settings section.
ACKs for top commit:
edouardparis:
Self-ACK b177f190d144986c1268c640075c89399f4c599d
Tree-SHA512: 1b5d00b9406a96d51e2b974d850322ea6046d8232fdd061d4e79ac7a8529c1459815fa022b5e35156664c27aedc0b08ad94d9cbf6984af09ee3c2bdd44ebe2f6
should_exit method is replaced for the
iced:🪟:close() command at the main.rs
level. iced_native::Event message handling
is not anymore required in the sub states of
the iced application.
d81c22767c489d5a11db78cc34f59eb008f431f9 gui: order coins list in coins panel (edouard)
Pull request description:
close#193
ACKs for top commit:
edouardparis:
Self-ACK d81c22767c489d5a11db78cc34f59eb008f431f9
Tree-SHA512: 9ae179b38aaea7b5e74f071b9f7788996ae76de858f81be61169efcb75a4507d1245d210715b829cd2fe4151cd519a68bb2d75d422df9a98ff2b4a9559baf013
afc4636ad98bcff9ab2b63f3fbf08f9318031cf9 Forbid next step if amount sent > available amount (edouard)
3eddedd7a8c77acf53ebe095d85ceced7b7f7263 Reload amount left to select in choose coins step (edouard)
86896c822317ab108541acbf0622d94a9119c479 Check output amount superior to dust value (edouard)
ecd35d2bd171c5975de62188d142494268e394a2 Add available balance to choose recipient step (edouard)
Pull request description:
close#195close#237close#196
ACKs for top commit:
edouardparis:
Self-ACK afc4636ad98bcff9ab2b63f3fbf08f9318031cf9
Tree-SHA512: 1f3e6703e3f01a5496f890fe8e8104693ab58f74510f07593b65dead7e1629f91753c1b169a2c0d481fc14d85136cbbcb3076057c9535f3afd93f290ac580692
03c39c44f6ebbac46383a5ebb88cd1561b2d2eb8 bump iced 0.6 (edouard)
Pull request description:
The version of the iced crates are
upgraded without introducing version
change in the other external dependencies.
This upgrade introduces fixes of the iced
framework. See:
https://github.com/iced-rs/iced/releases/tag/0.6.0
ACKs for top commit:
edouardparis:
Self-ACK 03c39c44f6ebbac46383a5ebb88cd1561b2d2eb8
Tree-SHA512: 6e3f3021aee04c4958dd221ff525b1683af126e5980f6ebbad5daeae877917ccc82ddff53cc064ad0526afb73d8cd6b51279cf071b125952c702f75bc761c6d5
The version of the iced crates are
upgraded without introducing version
change in the other external dependencies.
This upgrade introduces fixes of the iced
framework. See:
https://github.com/iced-rs/iced/releases/tag/0.6.0
c31751dee3a42f8d3ed3f116b9bb2fd8c333fc1b liana: 0.1 (edouard)
Pull request description:
Once this PR is merged, gui will have its liana last commit updated and version set to 0.1
ACKs for top commit:
darosior:
utACK c31751dee3a42f8d3ed3f116b9bb2fd8c333fc1b
Tree-SHA512: bc6e9340817363905dc1175b6c97d525c77d76d1cdbb91d1198099c07132ff2e8656ec29c9669c8ce47ba23327d65adb051996e2821ef16a1fa4243b4cd59692
9e1c16bc3fef5aa01a62cb34304cc161d4623468 Check the address network during spend creation (edouard)
Pull request description:
ACKs for top commit:
darosior:
utACK 9e1c16bc3fef5aa01a62cb34304cc161d4623468 check looks good to me
Tree-SHA512: 638d9d461230f487e8a150d02814baaa2a9c93ad2de339aa7f3f2436431276f41b4b833b7d5f2abdc505004fefd962d54596e581bfe732613f2765ef6d61260d
a0404e5d69e895467a5a51621e728b78140eae8e contrib: fix windows archive creation in release script (Antoine Poinsot)
Pull request description:
It would create an empty archive since it didn't recurse down the directories..
ACKs for top commit:
darosior:
ACK a0404e5d69e895467a5a51621e728b78140eae8e
Tree-SHA512: 60fb2b019244453c0dc003b3bf8df587d64d5663adc9ac0d9fa94f22c1f785189532c175db0076f2862edce78b638f06008f3e424c3f4b325a8f198a6841976a
103c1950ba9af114cadde6f92117b31ec584ac73 Remove change_index from listspendtxs response (edouard)
Pull request description:
Multiple change indexes may be present in a spend
draft transaction and can be detected instead
in the response psbt with the bip32_derivation
outputs fields.
ACKs for top commit:
darosior:
utACK 103c1950ba9af114cadde6f92117b31ec584ac73
Tree-SHA512: 82619792c4424537e7320162c149ae946ca1fdc101661cf9bc3d0ba4d16f0327cc3cffd98f11165a9ab9db5d1690013f8ec9bdfe46bd6b1427c332b045d683a8
a56cab73c5c0193a90732f3ba0c2c5be7b993928 fix spend change detection (edouard)
Pull request description:
Use the presence of bip32_derivation
in the spend outputs to detect the
change outputs.
ACKs for top commit:
edouardparis:
Self-ACK a56cab73c5c0193a90732f3ba0c2c5be7b993928
Tree-SHA512: 092f8929ebed4ff4c80d8425a1c83831d165a5d31d0c80bc9aac26edf3dffb0241d547fe4fc5208e0dcb4caa39c09f85f3898af56cd0cd03136e5404b503d02e
Multiple change indexes may be present in a spend
draft transaction and can be detected instead
in the response psbt with the bip32_derivation
outputs fields.
c5f38ecb4acddbb7f813215518fb45ce4f1da65b contrib: add a script to produce the assets to be released (Antoine Poinsot)
e7f43492f9061b9fa9f391e4dfde28d9d66954db contrib: utilities for releasing a macOS application in a dmg (Antoine Poinsot)
Pull request description:
This adds a script to produce the binaries and packages we will be releasing. It:
1. Runs the deterministic build for each platform
2. Package them nicely according to the platform's requirements
3. Create a detached sig for each asset with my key, `590B 7292 695A FFA5 B672 CBB2 E13F C145 CD3F 4304`
Thanks to the Bitcoin Core project for the work on creating a neat `.dmg`, i mostly stole what's here from there.
Fixes#42.
ACKs for top commit:
darosior:
ACK c5f38ecb4acddbb7f813215518fb45ce4f1da65b
Tree-SHA512: 98c92ca51fa0893541ce246cd0ca0e1e6e99f9a56aa70269d4c8e67122116adb282fc49995beee4be6fc3ed53fcb1fb93274b29588084b3ef0c9187cd7e205ad
This was mostly inspired by (or outright stolen from) the Bitcoin Core
project. I think most contributions in this area were Michael Ford's
(fanquake), so credits to him.
This is everything that needs to be present in a dmg in order to have a
nice fancy installation drag-and-drop screen. Configuration contains
dummy values to be replaced with specifics at release time.
c9551eca00f555bc486dcf3feac5c0184193c961 README: mention the minimum supported Ledger Bitcoin app version (Antoine Poinsot)
75a26a7f8eb6853c3ab77bb92fd31164d436bf20 README: add a small paragraph on recovery (Antoine Poinsot)
361367a75a873a94352d44514278f8f70b89fa8d doc: document the download of Liana binaries (Antoine Poinsot)
Pull request description:
Some additions to the documentation that were missing or depending on other things.
ACKs for top commit:
darosior:
ACK c9551ec
Tree-SHA512: c78f952396afd489416936f883bf702e3b0703a20b13e0c48493b04d8fe9b51fc67bc396b8cc26cf061b7430a4cf0716de006858c7cfc894b0cd8a4c9abb0993
