c8e455c8ceb2a7b5408380dbe3cd30ce3959ff57 lianad: add a test for LianaDescriptor::contains_fingerprint() (pythcoiner)
aead34cc8eaa3e74d2c76c7e1e8341d756d779a2 installer: hint the user if the plugged signing device is not part of the descriptor (pythcoiner)
5ae13dd025c2e038e17746f5bfc8cf72ec5120c7 liana-ui: make it more clear when a device key is not part of the wallet descriptor (pythcoiner)
fa8fd4782f97b8969f6a655e0511bf8f96924232 liana: implement LianaDescriptor::contains_fingerprint() (pythcoiner)
Pull request description:
This PR:
- [x] Add `LianaDescriptor::contains_fingerprint()` method
- [x] make more explicit when a signing device is not part of the wallet descriptor
before (user had to hover the button to see the tooltip):
after:
- [x] Hint the user in the installer if the plugged device is not part of the created/imported descriptor:
ACKs for top commit:
jp1ac4:
tACK c8e455c8ceb2a7b5408380dbe3cd30ce3959ff57.
Tree-SHA512: 092b8cb6efe6b6a6dc4f8505649783cb7c83c231242ab14f479b573e12cd61bab4e6e27a173bee19097d3ad90a8f1e578ecf4b699a4a481b40588f5f60cb9c71
c20318af64fddb2959ba90f2d510af42f4e2e20e Upgrade pytest (thomas)
Pull request description:
Had issues because of a too old version of pytest-timeout. I had to update it so I took advantage of it to update pytest and other requirements
ACKs for top commit:
pythcoiner:
tACK c20318af on arch + python 3.10/3.13
Tree-SHA512: 22e7abf810c49d29f908e493db4055a9fd94d8a623e8a9ae8cfc33e2b9ab1865ad64acb8a2837b0b9b0ed1846b1ba9ea21242ccd7f0a4f4f221041d8465c55bd
c4715acb047b48e882102e38b67ed9bb37816306 refac liana-gui: network flag redirects to launcher (edouardparis)
Pull request description:
Adding the network flag to liana-gui command opens now the launcher with the network set instead of trying to run the wallet in the network directory.
This is preparatory work for the multiple wallet feature.
ACKs for top commit:
edouardparis:
Self-ACK c4715acb047b48e882102e38b67ed9bb37816306
Tree-SHA512: dad9b349c55d6e3884e79d9d314f926121c590f8b59a2322b2aee9461cfb2ddcc2d6b3d105d0bde4684fd2e097077cecf0a2f0f365e0ce52b6cadb1dc935d96a
Adding the network flag to liana-gui command opens now
the launcher with the network set instead of trying to
run the wallet in the network directory.
This is preparatory work for the multiple wallet feature.
fe14c7807e60a080052ebc94c1e0d160c8db8ed6 pin email in liana connect login (edouardparis)
1746314e7d8ef4e06cc05951dc620d88d280d26e Add liana-connect cache file (edouardparis)
Pull request description:
This PR introduces a new file in the network directory: `connect.json` where the access tokens per email accounts are stored. Race conditions and potential conflicts to update the file are handle by the crate `async-fd-lock`.
If the cache is missing (like for a previous liana generated setup), then the user is asked to authenticate again.
The change does not remove totally the legacy `refresh_token` field in the settings file in order to be backward compatible with previous liana-gui versions.
ACKs for top commit:
edouardparis:
Self-ACK fe14c7807e60a080052ebc94c1e0d160c8db8ed6
Tree-SHA512: a4ce6c78e8edd8378f227ae464a5ff0ebd88ee16b519a26f78eb95c9ab5752d14a50ea559902ce5edb9a00452e77b2552c2743a75182a9de825846b5c6f4d06c
ad2c096715da49223f7c2cf3389e575b7e62a064 gui: disable replacement fee input if tx is already replaced (pythcoiner)
Pull request description:
this PR disable input on feerate TextInput if the tx already have been replaced, it's fine to do so because we still can RBF the new replacing tx.
close#1138
ACKs for top commit:
jp1ac4:
tACK ad2c096715.
Tree-SHA512: 528dc513ee83a839c86a6dd8d49fa5af61814e7c440d5337d294205269ebcef3d50001a5b41815c95276d4f3e6660d5f5e081456feb77843b527d8f9eed897b8
eac6cdd197d75e957387db77126d2f258fd1bb27 ci: use self-hosted runner for integration tests (pythcoiner)
Pull request description:
this PR:
- move integrations tests from cirrus to a self hosted github worker (this solve many of the "timeout" errors)
- remove usage of docker: the worker run directly on the host machine (this solve almost remaining issues and cut integration test running time by half)
ACKs for top commit:
edouardparis:
ACK eac6cdd197d75e957387db77126d2f258fd1bb27
Tree-SHA512: 94035ed7b80c71b57c8507a64088898da7e7a8d6c83269a60abd330f592ad83ef032b7943bd3d2276494b568249194f816f6c4a109b27a5d1788075fecb3aba9
356301c79c6f621e8329287f70a112ddbb16d43d feat: add brief overview of recovery feature (Michael Mallan)
30aedb3e5b8b10cb0df9f937a5d362fccb91bf34 fix: use singular for one coin (Michael Mallan)
eb45d6ef8f50ea4384b1f5ce9fd4f0c0aaf98237 fix: show tooltip above to improve legibility (Michael Mallan)
ea8e8453d7ae59862f326f8e5111fd3d0b5ea9cc fix: clarify available recovery paths wording (Michael Mallan)
Pull request description:
This fixes and implements the items from #1664, except for the alias refresh, which is covered by #1667.
ACKs for top commit:
edouardparis:
utACK 356301c79c6f621e8329287f70a112ddbb16d43d
Tree-SHA512: ca5c71d214126e9447e48be5be9294c72b046136223f5b7848ee458c726ebf316042c612763a5c1a146450c15a566e56a2521bd2f0c2b6e0a04c7dcbc40163f7
bb7777878ea639def09a50f52fdd338467e8a87d Use type wrapper instead of PathBuf for directories (edouardparis)
Pull request description:
With the multiplicity of directories, liana directory, network directory and in the future per wallet lianad directories, passing a simple type PathBuf does not transmit to the contributors the information about which directory each module works with.
This commit introduces wrappers around PathBuf
to give this information and link parent directories to their child directories.
ACKs for top commit:
jp1ac4:
ACK bb7777878ea639def09a50f52fdd338467e8a87d.
Tree-SHA512: 3ed1e8a1e56f238c51768b9aef64a826527a89dc584976085db5cd8f8823f71910ee2e94fc09c78f7ce8de34535c9e416883a84a3a18430d1505a02ab2f88fb9
With the multiplicity of directories, liana directory,
network directory and in the future per wallet lianad
directories, passing a simple type PathBuf does not
transmit to the contributors the information about
which directory each module works with.
This commit introduces wrappers around PathBuf
to give this information and link parent directories
to their child directories.
7664567d41e54a79fd62a46077feea3f6ec28196 Fix sliders background color (use light grey) (thomas)
8a9dc083ab5a07cca9a0ddc699d5f5b83bfaf1ad Fix sliders background color (thomas)
Pull request description:
You can see here the black background for the slider :
Closes#1670
ACKs for top commit:
pythcoiner:
utACK 7664567
Tree-SHA512: 2c0954ab0d4571d19cc84e58f1ba6fe0a66aacdc3a4cd95a90caf3f63768724a3ce98ad47a4ac786519c6eda6f12726299ebd2ac6688da41b7de857916248432
7d2a1d4d315819ad18c040c7ee3e2830b40d8d6f fix: ensure spend panel steps use latest wallet (Michael Mallan)
Pull request description:
This fixes one of the items from #1664, but it's a little different from the other items there so I felt a separate PR would be better.
This fixes an issue for the Recovery panel that was introduced by #1658, but which was already present in the Send panel. If, while creating a regular spend, the user edits the fingerprint aliases, these updated aliases would not have shown in the signing info of the draft PSBT. For a recovery, this issue arises on the first step when selecting a recovery path, where the aliases are shown for each key required on that path.
The issue arises because the `wallet` field of individual steps was not being updated.
Now, the `wallet` will be stored by `CreateSpendPanel` and used by `load()` when moving between steps. Furthermore, the `WalletUpdated` message will be used to update the current step directly.
ACKs for top commit:
edouardparis:
utACK 7d2a1d4d315819ad18c040c7ee3e2830b40d8d6f
Tree-SHA512: c7b4d3da57bb3e856d101128f581ec3df055d1e2892ec3f1ba04550495250ed9bd9d5193760d0883224e0368a7cd425dfa010fc214e204f764176b975c66d515
The wallet is used in some steps to get fingerprint aliases.
The recovery panel previously handled a wallet update, but this
was omitted when making the recovery panel part of the spend
panel.
This bug already existed for the final step of a regular spend
where the signing information would show old aliases if these
were updated while defining the spend.
7085542066006d1d0debbe6fff0b3463ace834f1 Move lianalite to services::connect module (edouardparis)
f3ae84f91c2028d8e53da0d096867c8cf13a54c4 Move keys service to its own submodule (edouardparis)
Pull request description:
Move the current client implementation for https://keys.wizardsardine.com from `services` to `services::keys`.
Move the liana-connect client implementation to `services::connect`
ACKs for top commit:
jp1ac4:
ACK 7085542066006d1d0debbe6fff0b3463ace834f1.
Tree-SHA512: 853f8cde9de768f0b087125b7ae9a5aae3fec9a5d6085ccf0ae72e6b75c7833424ddf482bcc9eefeea05f35ef59b65727af8f6e0af1efcf0a95217f3d9b74b2c
61bc0ffbc85748437da0155ea25a5b741306aef2 tests: use data_directory (edouardparis)
6ccaa0573b42b8e1998f3a780e2f714af3ce9b6d Prepare datadir for multiple wallet support (edouardparis)
Pull request description:
A new field data_directory is introduced in lianad configuration, it resolves directly to the path of the wallet datadir without the per network reasoning. The previous data_dir field is kept for backward compatibility for already generated configuration file.
ACKs for top commit:
jp1ac4:
ACK 61bc0ffbc85748437da0155ea25a5b741306aef2.
Tree-SHA512: da2e1bcda9bbd4b11d29833694bc8f6f88506fd8f2d423c7eb8cab3a58f3e6a0b4330e89393f7cc70e5838d770a1571d8b5bdce1d83b068d1e958be3ee183021
This adds some explantory text about the recovery panel.
For consistency, the text stating that no recovery paths are
available will be shown in the same card as when recovery paths
are available, which will help differentiate between this text
and the explanatory text.
The previous wording could be misleading for recovery paths that
had already been available since many blocks ago.
For the user, it's enough to know that the path is available, i.e.
a spend on this recovery path can be created and broadcast.
A new field data_directory is introduced in lianad configuration, it
resolves directly to the path of the wallet datadir without the per network
reasoning. The previous data_dir field is kept for backward
compatibility for already generated configuration file.
19f5132ee8439ef3d4d27dd7254104d60c8540af Remove the link between gui config and lianad config (edouardparis)
Pull request description:
This commit is part of preparatory work to support multiple wallets.
This commit introduces two breaking change:
The fields daemon_config_path and daemon_rpc_path are removed. The GUI will deduce these values from their expected location in the root data directory.
Because this link is removed, the gui flag --conf is not useful anymore as it cannot then find the location of the root data directory.
ACKs for top commit:
jp1ac4:
ACK 19f5132ee8439ef3d4d27dd7254104d60c8540af.
Tree-SHA512: f883781e935e2253ebc2d4b71331c12efbaa142d45c418d17411c3de0b2288127832de8ff34eb24d07abfdb8e3045b48c3e5c3773857518c3a28df2a7c46263c
c7bbbd854ccfb8f2dccb6e7f63b6f4c982cd76c1 feat: enable coin control for recovery spends (Michael Mallan)
c2f964d5b365501ec5a608a8f8333ffeb1edc2b7 fix: load tip height directly rather than from cache (Michael Mallan)
0d9cf43bf9c623221be6ed9882ec7df6e710566d fix: avoid overflow when checking for previous step (Michael Mallan)
83c90b085a8fc3c6f738678a01b63f2811a33600 refactor: get first timelock from descriptor (Michael Mallan)
0514f743daae738c05bb124ce55f0ae01193df01 refactor: add function to filter coins for selection (Michael Mallan)
934d0c76f486016bdd2a7098d14694b9ba470442 fix: grey out next button in case of error (Michael Mallan)
71541c69bae7f8f33659337ad66e7ca161cbcef4 feat: support outpoints recovery parameter (Michael Mallan)
Pull request description:
This implements #1641.
The recovery process is treated as a regular spend, with an initial step for selecting the recovery path.
Further refactoring to `DefineSpend` could be applied in a follow-up to clearly distinguish between the three kinds of spends now handled:
1) regular primary path spend to external recipient(s)
2) self-send (using primary path)
3) recovery spend
ACKs for top commit:
edouardparis:
ACK c7bbbd854ccfb8f2dccb6e7f63b6f4c982cd76c1
Tree-SHA512: 2a949bed0e1d1eedc5179544597b36ff124badc31264672765ea77a8a3cd1257334190739ece5da25422d5a9009e6cf58f9f70ae1f0ebe4903aa455342142870
The regular spend panel has been updated to allow for recovery
spends.
A recovery spend will use the same panel type as a regular spend,
with an extra step added for selecting the recovery path.
This commit is part of preparatory work to support
multiple wallets.
This commit introduces two breaking change:
The fields daemon_config_path and daemon_rpc_path are removed.
The GUI will deduce these values from their expected
location in the root data directory.
Because this link is removed, the gui flag --conf is not useful
anymore as it cannot then find the location of the root data directory.
It should not be possible to click the Next button if there's
any error.
This could arise for a self-send if a very high feerate is chosen
and there are insufficient funds. In this case, the Next button
will now be greyed out until form values are edited and the error
has disappeared.
This changes the GUI daemon trait's create_recovery method to
support passing an outpoints parameter. For now, however, this
method is called with an empty outpoints slice, meaning that all
recoverable coins will be used.
