5b63fe813869af82bf70a027d38e32c15bd219fa doc/ci: Use Bitcoin Core 25.0 (fanquake)
Pull request description:
Leave minimum supported version as 24.0.1.
ACKs for top commit:
darosior:
ACK 5b63fe813869af82bf70a027d38e32c15bd219fa
Tree-SHA512: 2ec14693cc4ece42aab398c1e06722cd92799ee5806c3f3c526ae9f34d70d6fddc23feb66b72054ad49edf7aa92f717918f43e9745a2a8d6a48dd3a3463fb075
c55b992ace93da5b334a878b92a62a5d5325a0cd gui: clear fingerprint alias when changing device type (jp1ac4)
Pull request description:
This is to resolve#531.
ACKs for top commit:
edouardparis:
ACK c55b992ace93da5b334a878b92a62a5d5325a0cd
Tree-SHA512: d38d393d669704c4c980315b5f9c7eda433ce3b1faeeaa0efd71d5f2c4eee531c4943957d1236dd1d245f1e3fff896638600369d0c7e66b2b2be9568aa0036e0
700f6e1d6fc9f4fcbfeeffc00a49c655be8ce671 make compilable on aarch64 (M1) (raphjaph)
Pull request description:
I ran into some issues while trying to build this on an M1 Mac. First, the `bip39` crate was somehow not being imported correctly and secondly there wasn't a way to just use the `hardware_randomness()` if `cpu_randomness()` wasn't available. Not sure how to do the `#[cfg]` stuff correctly so feel free to close and do another way. Just wanted to post somewhere in case someone else runs into this.
ACKs for top commit:
darosior:
utACK 700f6e1d6fc9f4fcbfeeffc00a49c655be8ce671
Tree-SHA512: 01113ef48d103348159f366e70eacbae9b5fa9b255dc758e9b24ae079c2f2468eefc792b58ce3bc25e3e89e5b7719eba8ef6d60fbecfd726f42a62d55c5b46e0
4dcac426a941dd62b27d4df1379ef836e394a789 add udev dependency to TRY.md (pythcoiner)
Pull request description:
i just found out that on ubuntu 22.04, libudev-dev cannot be installed if udev is not installed first
ACKs for top commit:
darosior:
Thanks. utACK 4dcac426a941dd62b27d4df1379ef836e394a789.
Tree-SHA512: 916e00ba5679573692913272d9d827562c14742b7e4e5f08b8b3f4bbd88577b2361a5b74683d7865de4e279e26365a163edb8cbc13daef4485ae7d18065deb30
1eb7c08b4525861e93d4b9889499d7ab1bca912d doc/ci: Use Bitcoin Core 24.1 (fanquake)
Pull request description:
Leave minimum supported version as 24.0.1.
ACKs for top commit:
darosior:
ACK 1eb7c08b4525861e93d4b9889499d7ab1bca912d
Tree-SHA512: 9316932eb256884da33b7f975b53bb37a1a791af3b77fc9bbc1bba2a74547c91c122598760a4baa241092f29418d766930b3c6fac49e246437b4fff4c38d02a1
506f97dc8e7ad053e30e19a12327b2bf16f09882 minor wording fix (pythcoiner)
Pull request description:
following #508
ACKs for top commit:
darosior:
ACK 506f97dc8e7ad053e30e19a12327b2bf16f09882
Tree-SHA512: 5e511e8ebe1ec346dfdf70759f15e2548e78323efafe0ba97a15a8195e52dd6dde490c4320f8a42b533d3772e5f83f8fa9c9edba9dcb8012cb96b319507a3072
54679343ec04bffcaa9fa4e08b0489176ea22166 replace minisafe by liana (pythcoiner)
Pull request description:
just rewording minisafe => liana
ACKs for top commit:
darosior:
web ACK 54679343ec04bffcaa9fa4e08b0489176ea22166
Tree-SHA512: 42e8966d1f03a2217f0c573cf5220124a5f22954bc1c15c929a0f3842e53e7fa5298f8c0f6be6aae4122a416bcda0205c0e896b35d93bfc04c28347a20b9a767
07ede01855320d4c6869547b0264c9ed566cc31b add .idea/ to .gitignore (pythcoiner)
Pull request description:
.idea/ is folder for Jetbrains IDEs (Clion,Pycharm, etc...)
ACKs for top commit:
darosior:
web ACK 07ede01855320d4c6869547b0264c9ed566cc31b
Tree-SHA512: 009a3d660f2ff2002f697c58ed67e66121acf64db088d29f12bf625b62fbe3ef636b280d828a0ca1ed35b18d33414884f6626eecd5765eff172136c4b1f67971
039b82d9b3e11786f09c761a6d0a6d137cdff8ad sqlite: prevent races when updating the next derivation index (Antoine Poinsot)
Pull request description:
You can check the unit test triggering the race fails on master. I'm pretty sure it's the reason for the address generation bug i experienced yesterday when testing.
ACKs for top commit:
edouardparis:
utACK 039b82d9b3e11786f09c761a6d0a6d137cdff8ad
Tree-SHA512: e245d8732346731c5a98223363c9d2e77f3a568e046055007162167f7a7209cc0e9d0f57c7219e469788ff73c570962396c4da0e056c790ffffbd953c75ab3ee
0f07361d9b6a9d118360607479ef9f7e5d9278e1 bitcoind: adapt the warning detection with interface breakage in v25 (Antoine Poinsot)
3a82c3a81d2c6f6a726395a8a2fbab462466f3e6 bitcoind: do not assert presence of 'warning' field in unloadwallet response (Antoine Poinsot)
Pull request description:
We should really be less picky in the bitcoind interface... Too many unnecessary assertions.
ACKs for top commit:
darosior:
self-ACK 0f07361d9b6a9d118360607479ef9f7e5d9278e1
Tree-SHA512: 0e85f18caf777da40e8d91b6e834ba629d2c4d4b230b7d3d96f075864cb79670bfa3a48150b96c5bf7ff54a80e424b08117a3de2eb422ffbc9c887d121633796
d337568706c5e6070d05d378392e74d590438f0b Add instructions to build deamon for testing (Novo)
Pull request description:
@darosior I tried following the testing instructions and I got an error that indicated that the `target/debug` directory did not exist. This PR adds instructions that specifically ask devs to build the project before testing. I think this will be helpful to others when trying to run the tests.
ACKs for top commit:
darosior:
ACK d337568706c5e6070d05d378392e74d590438f0b -- Thank you for improving the documentation.
Tree-SHA512: 9ba9c141de13f30128497734f231df6763713e18d5d0e6f2d92cdd3f3d3ca0490755760ecb0b7375a067365156a781e4d42ce07da337cbda594b39855adc2e69
17d1f847bcf201fb452c7c9d950b0b1ee2f4e22c lib: on Windows unload the watchonly wallet before deleting it (Antoine Poinsot)
Pull request description:
Fixes#493
ACKs for top commit:
darosior:
ACK 17d1f847bcf201fb452c7c9d950b0b1ee2f4e22c -- tested on Windows by Kevin
Tree-SHA512: 2a92f5ce957ce4bd3a7c4a9b9c5f49ff0262157935c492a562c8a03af45b794db3bc5abd64d38b270d5b86fdc4c5288dcc4ea20c7343bc04b4c6a396c3a27ffc
4471516bec5c8fd478257197dcf17d70989d208f contrib: document the macOS distribution and codesigning (Antoine Poinsot)
d387ca19915fc4d4494d6be0268005ec3d4689d5 contrib: codesigning for MacOS in the release script (Antoine Poinsot)
1a1e0c245f208487dbec1ffda11c4ca0912e1610 contrib: make the Xcode archive configurable for MacOS builds (Antoine Poinsot)
471ecd296ed6c1d50dfed0cda85f4c4d4d0756ff contrib: distribute on macOS using a zip, not a dmg (Antoine Poinsot)
eade76e3f181c383f376ac27df80bd78e8409754 contrib: add the Liana icon to the macOS distribution bundle (Antoine Poinsot)
eb26e71019f13af5a67745a0826a995bb2d0a612 contrib: cleanup macOS' Info.plist (Antoine Poinsot)
Pull request description:
Still waiting on the notarization process to complete. But in the meantime, some cleanups of the macOS distribution process (we can now have an app with a nice logo that can be launched just by clicking on it 🎉) and (bulk) documentation of my codesigning experiment.
ACKs for top commit:
darosior:
ACK 4471516bec5c8fd478257197dcf17d70989d208f -- Just tested the notarized binary on a mac 🚀
Tree-SHA512: a37711b43f8153844da4b65e77d2bc054ad26f126970a0f2738b1c0fedf9da34318af7ea4795c89ebf393cfbf8a97c9d09563ab35a5c806646b7ca6c767696eb
200fa9e7b4497687890d91ca97add45aea88c1e2 fix installer final step view (edouard)
Pull request description:
The height of the content was filling too much and user can scroll down to the abyss
ACKs for top commit:
edouardparis:
Self-ACK 200fa9e7b4497687890d91ca97add45aea88c1e2
Tree-SHA512: 2163a70a5ff4b1c52377182c62e2d74559a09dfb272bccf96561832f01aebb591dc4873f563cd05644ce4126dfdebdc7708f4bad5e5d7ec8c2deacc3a1b35160
