d86d6852b93013df15e914f43a8e631dd7cbe084 fix: a wallet with remote auth does not use managed bitcoind (Michael Mallan)
Pull request description:
This is a follow-up to #1746 to address the case where the wallet uses Liana Connect, in which case `start_internal_bitcoind` is set to `null` in the settings file.
ACKs for top commit:
edouardparis:
utACK d86d6852b93013df15e914f43a8e631dd7cbe084
Tree-SHA512: 23cf226651f8321b1ff482c977e7d23137debf8d62a3d824d197c2fefed576234eaee7ea014e2ae16dcedc70c198cfc2c5e00d57040b13108033728bb2aeb863
f62d9429581371d830ef455feb1158024199739f Add check of user membership to delete wallet modal (edouardparis)
1ca02a48979a7a36440ac57d8d83f988241af92e Delete wallet on Liana-Connect (edouardparis)
Pull request description:
ACKs for top commit:
edouardparis:
Self-ACK f62d9429581371d830ef455feb1158024199739f
Tree-SHA512: d624955703c83b8308378231a4563c575ed13c7e419377f3f4d8636bdb2b1a7fc157f8ae75f47ccabbf4c9a44ae3f449314987052dbe8337e8e44f8a145700d2
ac1043a1e09ec1570c489d537fbcff3ebb4c7152 chore: fix some minor issues in the comments (cloudclaim)
Pull request description:
fix some minor issues in the comments
ACKs for top commit:
jp1ac4:
ACK ac1043a1e09ec1570c489d537fbcff3ebb4c7152.
Tree-SHA512: ef571e559dddf5a87d03d50cc0eaf041d961280e9e09cc9df4da7a963da6d45df1f91615779412465e75bec46c942cfd8a287434bf51e5f1cf6f8c1f737c8d61
cb60089ace858772446ba82dcb76fc082a13242e fix(poller): only update last used index for affected keychain (Michael Mallan)
Pull request description:
This fixes#1333 by only setting the last used index of the affected keychain.
ACKs for top commit:
edouardparis:
utACK cb60089ace858772446ba82dcb76fc082a13242e
Tree-SHA512: fe376063378e7b531f6e4db0a6b42272344e50da01274571cdd089245b4e42f632180fa30528030c73c47e647bb02cf5d91eecf815be2274e7f371a77057ccc6
612608616b8ab448b1fcfebabf33bcfeb41e5807 Add alias to confirmation message of delete wallet modal (edouardparis)
Pull request description:
close#1763
ACKs for top commit:
jp1ac4:
tACK 612608616b8ab448b1fcfebabf33bcfeb41e5807.
Tree-SHA512: aa5e578db9b750a111d5ed148bf1e883aa6a20a6d3e30728f0f9c831101721d6067f2165e83e9d9e91d0c72c44872e63d27962c6a91c9191346fac728f2a42b4
d9c540ad1442bc7787fe33b69b2e60b62e17a650 liana-ui: add warning to form::Value (pythcoiner)
Pull request description:
This PR add a `warning` field to `form::Value`, so the warning can be accessed also from outside the view scope. This field will be "inherited" by the `form::Form`.
This PR "closes" a TODO in `EditXpubModal`, but I decided to go with a separate `warning` field as it can be useful to display a warning even if a value is considered valid.
Note: as this change do not modify the usage from within the view scope, usages of `form::Form` have not been updated.
ACKs for top commit:
edouardparis:
utACK d9c540ad1442bc7787fe33b69b2e60b62e17a650
Tree-SHA512: 377c29c7ca8a6e62c496ac73f4beb6bf2677c7f4388e068e9ac51793b0e62c0345363bb3e7a5b2fd3b71f3a98121712a340b69103564ede60854d1d552a0f46d
ba96bb6c063641debcbe2baf2c0f8e52e133f89a fix: skip syncing screen if node is not bitcoind (Michael Mallan)
Pull request description:
Fixes#1256.
The loading screen showing the blockchain sync progress will skipped if the node type is not Bitcoin Core.
ACKs for top commit:
edouardparis:
utACK ba96bb6c063641debcbe2baf2c0f8e52e133f89a
Tree-SHA512: 3a438e0e8d031ea416c8096742514769e446422dfe6523eaf19fa12d7551f0b1c86df37851e03a4794de5a152aee25d6a169714f35c1ea88e793042ac3e84a34
91ed79cb559fbfc0e3fc6befef5690aab85caefd make remove_tab safer (edouardparis)
5587b5cb8dc1d963167f300ccb82451d44db0538 simplify logger_setup (edouardparis)
fd858d2b4ac71efe121b1da96d59dce2b0b1de3c Close tabs of deleted wallet (edouardparis)
8dce52e22de41ab04f387b659e7cca3f9696eba4 Make sidebar responsive (edouardparis)
2866b8ea18e233d76e41b2da75d6f489e7190a34 Add grid with split button (edouardparis)
9f1de060eb942887a9ae1e8d7311263baebe895f Add pane tabs (edouardparis)
e771a42f456fb710306d7a2d265aa58c64e7be36 Change log destination for a file in the liana directory (edouardparis)
cdc2b56a3b8b64be8a12827188244fd987a4b4ea Detach tab from the gui general scope (edouardparis)
ce38ea1881e2675d10199fb0cc89ea5d754fa5da Migrate gui to its own module (edouardparis)
Pull request description:
ACKs for top commit:
edouardparis:
Self-ACK 91ed79cb559fbfc0e3fc6befef5690aab85caefd
Tree-SHA512: 473d782667560e919120d9b858f86223b0fcb2e1f26bf32bbaeee2a5edd2ead1bfc078da1808db2218c08dbbe626fac96a2c342f41bcea7a48b420b80d870021
0fb1f3c1edb1a93b8e491d769497a618d9c06511 Add tiny-skia feature to iced dep (edouardparis)
Pull request description:
tiny-skia is an other renderer that does not
rely on wgpu. Iced uses it as a fallback in case
of wgpu problems.
The feature can be tested with:
`ICED_BACKEND=tiny-skia cargo run --release --bin liana-gui`
close#1676
ACKs for top commit:
jp1ac4:
tACK 0fb1f3c1edb1a93b8e491d769497a618d9c06511.
Tree-SHA512: 681a11e334759f4ef28ca95f08bfee2e898ad3be1af5d4fc6a78f6a499bb1b7e3b7d5e747b3207f758770437d2c83a8f8f1a6ef536a08c37ddc1b73618c963f4
tiny-skia is an other renderer that does not
rely on wgpu. Iced uses it as a fallback in case
of wgpu problems.
The feature can be tested with:
`ICED_BACKEND=tiny-skia cargo run --release --bin liana-gui`
close#1676
31798b7e4317125e671e2d52e28e9ddc16815bf0 export: allow to import a backup from a simple descriptor (pythcoiner)
54c83615b070a982ec99f3c58278ecabba8a264e export: add test cases for import_descriptor() (pythcoiner)
d66b596cf930597254b1e48426c9488fd77d210d import: allow to import a descriptor from a backup in export::import_descriptor() (pythcoiner)
53839e92744b24e1365c3b57108b350c729b17b5 gui: add a spacer below the main column at Add wallet step in liana-connect flow (pythcoiner)
4bb4269975e0469205c96751bcbf24311177d53d gui: add import descriptor from file feature in liana-connect flow (pythcoiner)
Pull request description:
This PR closes#1751:
- add the option to import a descriptor from a file.
- add a spacer at the bottom of the screen.
- add the possibility to import also a descriptor from a backup file.
ACKs for top commit:
edouardparis:
ACK 31798b7e4317125e671e2d52e28e9ddc16815bf0
Tree-SHA512: 7e5ae0f3bbc4af1d779e1cd97e9cadceabe62317f857c895d9f5de49ed84f81c1da1df8df4d935ff0b1c2a040e1fa03f598bbdc6d64e82b225089c884c774743
b7ca309af740b41e543cc4c2b1b7a3395a876c13 Add minimal nix development shell option (Edouard Paris)
Pull request description:
## Summary
- Add minimal nix development shell option that provides only essential development dependencies
- Enables faster development environment setup for contributors who prefer minimal tooling
🤖 Generated with [Claude Code](https://claude.ai/code)
ACKs for top commit:
edouardparis:
ACK b7ca309af740b41e543cc4c2b1b7a3395a876c13
Tree-SHA512: 15bc6a80c685e5e0e29b8b85317a8f378bdacaf5568f40a3ed18901756a7752b82db3f0a350093713bc0baf51c3dfacd3fb2782fe34ab985745850c7354e13f0
- Refactor flake.nix to use shared commonBuildInputs for all shells
- Add minimalShell without Rust toolchain accessible via `nix develop .#minimal`
- Keep default shell with full Rust development environment
- Maintains backward compatibility while providing minimal shell option
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
fef70879b9507e0429a8a0a5211ba0547b68cc92 refac: remove patch field from Version (edouardparis)
Pull request description:
The Version struct is used across the software
to display the release version. A release version
does not include patch number as we increment
only the major and the minor during a new release.
For very small patch that does not change the
API and does not require a new release, then the crates Cargo.toml version patch number will be incremented.
ACKs for top commit:
jp1ac4:
tACK fef70879b9507e0429a8a0a5211ba0547b68cc92.
Tree-SHA512: 1a4e94c156377e810e15ba93267e6eddd0a273de48b18d0722f9e879eceb9b6ce8cb5f1347c075c1c17a47278b5fd6a64b51ad244cf15f390250d267cd8e23c7
The Version struct is used across the software
to display the release version. A release version
does not include patch number as we increment
only the major and the minor during a new release.
For very small patch that does not change the
API and does not require a new release, then the crates
Cargo.toml version patch number will be incremented.
f8fcf7100b43e98398254d5c846ec9a8a96a1c74 fix checks for whether wallet uses managed bitcoind (Michael Mallan)
Pull request description:
This fixes a couple of checks for whether the wallet uses a managed bitcoind.
ACKs for top commit:
edouardparis:
ACK f8fcf7100b43e98398254d5c846ec9a8a96a1c74
Tree-SHA512: e15cffc10cbe06b4769c65900befdb903109518059f03d31aac10e6ee91a0a9179d45e27eb22a0216b8b1d9ee073564bfb9839de890d32c148c4b243143f4b71
