86e30d2d839462fc063702e3f4430656073a6aa2 fix: merge Taproot sigs when updating PSBT (Michael Mallan)
Pull request description:
While testing #1513, it became apparent that Taproot signatures were not being merged properly when updating a PSBT.
This PR fixes and refactors the code to use the `merge_signatures` function that contains the required logic.
ACKs for top commit:
edouardparis:
utACK 86e30d2d839462fc063702e3f4430656073a6aa2
Tree-SHA512: ba07d8d2e612d41a3960c5ce04258775334ca22c5268d51822d4e1fbce9614424937e72e688b6006946064c3c04581c20ca2f159bb1bc2a916d98e7e1ef2dc7b
036550c8b73edd25963ba13849a7537bc7df1ed1 Revert 'hide progress bar once export completed' (Michael Mallan)
Pull request description:
This reverts commit 98195e03b6878cd31e1d34ba246700b6ae95ceb1.
The progress bar can disappear too quickly.
ACKs for top commit:
edouardparis:
utACK 036550c8b73edd25963ba13849a7537bc7df1ed1
Tree-SHA512: 00dedcf7cde2ed735f67168cb1c6c1df2afb8687bd3c490505a2aa56b5ab574ddb02d03881bca3ca5ab6a3ab3549c29f4c9c8f979beb0a3f46805b9d3f189f6c
6c1d0518eb7748fe801c7fb141fbc7205eed27ec use left alignment for export modal text (Michael Mallan)
f92177c04ace796e7eef5bb7ee5cf5b2a6e563ec align export modal buttons to the right (Michael Mallan)
98195e03b6878cd31e1d34ba246700b6ae95ceb1 hide progress bar once export completed (Michael Mallan)
e5208bb7077ed05ebcc29ddec6d426d0efe6e247 use button helper for exporting transactions (Michael Mallan)
5529a8cd57e8a46327e018d94f903ee8008b6a70 change transactions export default file name (Michael Mallan)
Pull request description:
The default file name has been changed to "liana-txs-{date}.csv", e.g. "liana-txs-2025-01-03T10-03-39.csv".
I also changed the "Export" button to use a helper as suggested by edouardparis.
ACKs for top commit:
edouardparis:
ACK 6c1d0518eb7748fe801c7fb141fbc7205eed27ec
Tree-SHA512: 74a68c4130d7dce8f3e0839089191c7a34dd468a4c7e2a379ef30d049d38f3350a519465b792a6be14d3996288fdb6c5989c9c99b008f429fe85e62abcc4845a
020fef4b31a108e39b590b645aaca080c75871c9 fix: send-to-self payments include change from outgoing only (Michael Mallan)
Pull request description:
This is a follow-up fix to #1507.
Only those change outputs from outgoing transactions should be considered send-to-self payments.
ACKs for top commit:
edouardparis:
utACK 020fef4b31a108e39b590b645aaca080c75871c9
Tree-SHA512: 92a699d8bfd2724c1c309e7f957fe9bf9dd2460f562ff8f93d4e0fb026d43cae0f270fbc96d0ca6002ba9ce70c2ee09da80ff8c08b08d08db81d03ff2f78251c
1b3c4080c7a2a5894f019dccdbc140d33e8bfb77 gui: stop auto load of address when opening receive panel (edouardparis)
Pull request description:
close https://github.com/wizardsardine/liana/issues/1461
Stop generating addresses without user explicitly asking so.
Otherwise, the gap will be too big and some rescan with default gap limit on other wallets will not detect funds.
ACKs for top commit:
pythcoiner:
tACK 1b3c4080
jp1ac4:
tACK 1b3c4080c7.
Tree-SHA512: 97679dd0cceb9038342bc2bf5a91dd4f93134e5d13877e4aa4a327eedaa620230d166baf46beb870f2cf71d39bfeffd88f9926f4bd1816b5af006761f88b1b0f
b7b52d73bec0522af6dd08e9018868841b9363ca Revert "Merge #1500: gui: allow to connect to an electrum server w/ a self signed certificate" (edouardparis)
Pull request description:
This reverts commit 2d2d080888f5c2a0fd82d6c4a4009a254b2dbcb2, reversing changes made to cfe15b360d0f9a40d0de2ca00bdd1530e6e6c8e9.
We are not ready yet to have openssl dynamically link library dependency for our users.
ACKs for top commit:
jp1ac4:
utACK b7b52d73be.
Tree-SHA512: e85963ac9dd9d449c4af5806d7f7aaee70de676d38e9f931e50ed7c060a5a9522209a27db77a0a6254249f55ae52259dc7c747fe2032d830a4d6d92f1cb6a72b
6b914fd2491841bb3daa41f59641677c10cc880b bitcoind: parse descriptor before comparing strings (Michael Mallan)
652eb5b799c8d2ed9f65ab24c0101af3e09905f8 refactor(bitcoind): extract logic to function (Michael Mallan)
Pull request description:
The `startrescan` command uses the response from bitcoind's `listdescriptors` RPC method to confirm that the rescan has started.
This check includes a string comparison that can fail in some cases (Taproot descriptors with a spending path having only a single key) as the descriptor string returned by bitcoind may contain both `h` and `'` , whereas Liana's descriptor string only uses `'` (as per the `Descriptor::to_string()` method).
This PR changes the check to first parse each descriptor string as a `Descriptor` object to avoid any `h` / `'` mismatch issues.
ACKs for top commit:
edouardparis:
utACK 6b914fd2491841bb3daa41f59641677c10cc880b
Tree-SHA512: 14d3eaef950a490020af2157e03adcbd1cc821c92750f21e682ba74bc4fd3531552a7ba0f70144792d5bbc18546b919567f181e468e2b196c6c473ca45d9d9de
55b92b3da707310900fca1570269c5e13b709d64 fix: treat change outputs as send-to-self payments (Michael Mallan)
Pull request description:
This is a follow-up to #1503 to fix an issue with change outputs appearing as outgoing payments on the home page.
It expands the definition of `PaymentKind::SendToSelf` to include change outputs since these are also payments to self.
ACKs for top commit:
edouardparis:
utACK 55b92b3da707310900fca1570269c5e13b709d64
Tree-SHA512: 347045e45a75632024e2539fedc7ab3f76b25fa14aeeac2490e5def7a746cf37097e636110e52823af84744f0970a07c70300fd324b62703f8d4cbd1be76ae7a
b1736bbd404df91a0150c06985998ac1575c317d export transactions: output a blank if fee is 0 (pythcoiner)
Pull request description:
This PR replace the fee displayed as 0 by a blank.
ACKs for top commit:
jp1ac4:
Tested ACK b1736bbd404df91a0150c06985998ac1575c317d.
Tree-SHA512: 02d132b5de988e0f8b0c3ad6ec463c0a70f9d207b0620560ab1fb683b3729f96bc044d6f4315dc0f48eea4ddb6142ea60141e1cb430c879f2e177eb3a549ee9a
308355322cd62b4e98a91de40c92070c3a8ae011 ci: add openssl to 'windows_latest' (pythcoiner)
09bb450b1fbd39aabec61719b9e67e12180641ba gui: allow user to not validate the ssl domain for an electrum server (pythcoiner)
efb23300dae06702459e07334ab458bfcc54b3e6 lianad(electrum): add an option to not validate SSL domain in order to work w/ self signed certificates (pythcoiner)
Pull request description:
closes#1300
The issue about connecting to an electrum certificate using `rustls` have been fixed [upstream](https://github.com/bitcoindevkit/bdk/issues/1598) but in order to beneficiate from it we have to update `bdk_electrum` and `rust-bitvoin` dependencies.
Meanwhile, this PR introduce a workaround: the initial issue is related to `electrum-client` `use-rustls` feature and `use-openssl` feature is not reexported by `bdk_electrum` but we can use `electrum-client` crate directly and use `use-openssl` feature by this way:
- [x] use `electrum-client` directly w/ `use-openssl`
- [x] add and option to opt-out of ssl domain validation
- [x] let user change the `validate_domain` values in `Settings` menu.
Note: ssl://testnet.aranguren.org:51002 electrum server can be used to test this PR
ACKs for top commit:
jp1ac4:
ACK 308355322c.
Tree-SHA512: 28139ef6c6073045b413303c725c0d6c83b193d89c7b39edfb1d10108a1551c1ac9fdf20c941bc770d62f0075fb47ffa305b4975ea38e1840ae3d631ca9e39e6
22f48753a367187a1d08bc34d20e5b75bdfc01b8 gui: add and export transactions feature (pythcoiner)
Pull request description:
This PR add a feature to export transactions:
Done:
- [x] Subscription to run the feature in a detached thread w/ possibility to send update about the ongoing progress.
- [x] Let user choose the path using `rfd` crate
- [x] Add a modal that show progress of the process
- [x] estimate the progress
- [x] cancel feature
ACKs for top commit:
jp1ac4:
Tested ACK 22f48753a367187a1d08bc34d20e5b75bdfc01b8.
Tree-SHA512: 5cf271d52878c4845347c5951a562e08e7f7efea08f0dc702d0500e41d6ad8eab7cb31f7e8a7b4edba48916648759ce97a9f591d1bcb4564a0c7067d5274fa08
79057a0cd9ea8010e91f9d7ea035a85c1b06bdb1 Do not include self transfer in home events (edouardparis)
790beaa6700b514f6f94b38acb356d4938ab87f5 Use payment model in the home (edouardparis)
b1abce5a244b2fb101bb4faeabadab4ec877ac3d Separate Labelled from LabelsLoader (edouardparis)
0d8f88839eb01d3fce0b71bea955b288ef1c27cb change event selection in home to load model (edouardparis)
Pull request description:
Some users may have txs with a lot of inputs/outputs. We wrongly iter over them in the view which is the origin of performance issues.
ACKs for top commit:
jp1ac4:
Tested ACK 79057a0cd9ea8010e91f9d7ea035a85c1b06bdb1.
Tree-SHA512: 2c66703e35c1e67447cfd50d72e5dcd79ac7e1469e513d082001ec5ec94ca88c6a0a5e65f87e6ceb213e21b43e9bfa2005ca1c63fee4d230d2cd2d1374fd3212
