3ea85fa9506bc96440096a9d11cceffdbf5eab44 descriptor: introduce a helper to analyze a PSBT spending Liana coins (Antoine Poinsot)
aac330ca65686ddb0d5b64778f49025e602cfa02 descriptors: rename DescCreationError in a general desc-related error (Antoine Poinsot)
92905968234053feaaad8a83a5080860779d2898 qa: test using lianad with a multisig descriptor (Antoine Poinsot)
3c82173f468a099d298514ddfe2bd376ad9f08c8 qa: abstract the signer from the Lianad class (Antoine Poinsot)
e22e30dc8d3f0c99a0f176857f35ac5ed60a34f4 descriptors: support Multisig in both the primary and recovery paths (Antoine Poinsot)
Pull request description:
This permits the creation of a Liana descriptor containing a multisig in either of the two spending paths. The multisig is currently restricted at creation time to be a CHECKUMULTISIG-like multisig (k-of-n with n<20). See the linked issue for rationale.
Closes https://github.com/wizardsardine/liana/issues/53.
ACKs for top commit:
edouardparis:
ACK 3ea85fa9506bc96440096a9d11cceffdbf5eab44
Tree-SHA512: b95402b4483e9b282680288b6515049c3ab7ac0debe7659b39768e4b85de8e4b3d6000a2de8b633c47f7f7db49593a23853028f481a09fc13f3d9d574f7cca51
6c375ad06d3d16e8c99fc783fece1719ef06ad35 Gui: text and layout of recovery screen fix#265 (Trigger)
Pull request description:
Fix issue #265 + small UX improvements.
I rollbacked _rustfmt_ @edouardparis can you see if it makes ~100changes on your side too ?
ACKs for top commit:
edouardparis:
ACK 6c375ad06d3d16e8c99fc783fece1719ef06ad35
Tree-SHA512: a75b4e64867c49fa1b34c32d2ba05ea5b4715933ad71ec8b2b5848f02dc2d138083e8fdf84d6875f552f55f1b3c48d8ff1b726a1c919575d6670bda420cb64ef
We only allow to create "legacy" multisigs for now (that is, what fits
in a CHECKMULTISIG, ie k-of-n with n<=20). See
https://github.com/wizardsardine/liana/issues/53 for discussions around
this.
We are a bit more laxist on parsing, where any miniscript that
corresponds to a multisig policy will be accepted.
Note this makes the helper inferring the CSV value from semantic policy
incorrect, but this is fix in a later commit as part of a complete
refactor of this logic.
a2c584f6030d233854ae6508911c0c5301b9b6db doc: add a document about signing devices and specifically the Ledger app (Antoine Poinsot)
Pull request description:
ACKs for top commit:
edouardparis:
ACK a2c584f6030d233854ae6508911c0c5301b9b6db
Tree-SHA512: 2bedc0639094833b470236bacf19d8b93d9a9f75cd692e20363505929f01f8c233a8569e2ca50ddc92fc33494ec4f76750f46e9ecd86f5cd711fc50eff210f8e
b177f190d144986c1268c640075c89399f4c599d gui: store descriptor in wallet module (edouard)
Pull request description:
A new module wallet is introduced that contains the main_descriptor retrieved from `getinfo`.
It removes the requirement for the `Daemon` trait to provide the demon config in the other components of the application.
Actually BitcoindSettings cannot be edited if the gui is connected to an external daemon, this PR just remove the display of the Bitcoind Settings section.
ACKs for top commit:
edouardparis:
Self-ACK b177f190d144986c1268c640075c89399f4c599d
Tree-SHA512: 1b5d00b9406a96d51e2b974d850322ea6046d8232fdd061d4e79ac7a8529c1459815fa022b5e35156664c27aedc0b08ad94d9cbf6984af09ee3c2bdd44ebe2f6
should_exit method is replaced for the
iced:🪟:close() command at the main.rs
level. iced_native::Event message handling
is not anymore required in the sub states of
the iced application.
d81c22767c489d5a11db78cc34f59eb008f431f9 gui: order coins list in coins panel (edouard)
Pull request description:
close#193
ACKs for top commit:
edouardparis:
Self-ACK d81c22767c489d5a11db78cc34f59eb008f431f9
Tree-SHA512: 9ae179b38aaea7b5e74f071b9f7788996ae76de858f81be61169efcb75a4507d1245d210715b829cd2fe4151cd519a68bb2d75d422df9a98ff2b4a9559baf013
afc4636ad98bcff9ab2b63f3fbf08f9318031cf9 Forbid next step if amount sent > available amount (edouard)
3eddedd7a8c77acf53ebe095d85ceced7b7f7263 Reload amount left to select in choose coins step (edouard)
86896c822317ab108541acbf0622d94a9119c479 Check output amount superior to dust value (edouard)
ecd35d2bd171c5975de62188d142494268e394a2 Add available balance to choose recipient step (edouard)
Pull request description:
close#195close#237close#196
ACKs for top commit:
edouardparis:
Self-ACK afc4636ad98bcff9ab2b63f3fbf08f9318031cf9
Tree-SHA512: 1f3e6703e3f01a5496f890fe8e8104693ab58f74510f07593b65dead7e1629f91753c1b169a2c0d481fc14d85136cbbcb3076057c9535f3afd93f290ac580692
03c39c44f6ebbac46383a5ebb88cd1561b2d2eb8 bump iced 0.6 (edouard)
Pull request description:
The version of the iced crates are
upgraded without introducing version
change in the other external dependencies.
This upgrade introduces fixes of the iced
framework. See:
https://github.com/iced-rs/iced/releases/tag/0.6.0
ACKs for top commit:
edouardparis:
Self-ACK 03c39c44f6ebbac46383a5ebb88cd1561b2d2eb8
Tree-SHA512: 6e3f3021aee04c4958dd221ff525b1683af126e5980f6ebbad5daeae877917ccc82ddff53cc064ad0526afb73d8cd6b51279cf071b125952c702f75bc761c6d5
The version of the iced crates are
upgraded without introducing version
change in the other external dependencies.
This upgrade introduces fixes of the iced
framework. See:
https://github.com/iced-rs/iced/releases/tag/0.6.0
c31751dee3a42f8d3ed3f116b9bb2fd8c333fc1b liana: 0.1 (edouard)
Pull request description:
Once this PR is merged, gui will have its liana last commit updated and version set to 0.1
ACKs for top commit:
darosior:
utACK c31751dee3a42f8d3ed3f116b9bb2fd8c333fc1b
Tree-SHA512: bc6e9340817363905dc1175b6c97d525c77d76d1cdbb91d1198099c07132ff2e8656ec29c9669c8ce47ba23327d65adb051996e2821ef16a1fa4243b4cd59692
9e1c16bc3fef5aa01a62cb34304cc161d4623468 Check the address network during spend creation (edouard)
Pull request description:
ACKs for top commit:
darosior:
utACK 9e1c16bc3fef5aa01a62cb34304cc161d4623468 check looks good to me
Tree-SHA512: 638d9d461230f487e8a150d02814baaa2a9c93ad2de339aa7f3f2436431276f41b4b833b7d5f2abdc505004fefd962d54596e581bfe732613f2765ef6d61260d
