091d7728ee33d231fbafb839ac497f86122d0851 commands: use unconfirmed from self for coin selection (Michael Mallan)
Pull request description:
This is to resolve#1484.
We previously used unconfirmed change for coin selection as a best-guess way of identifying those unconfirmed coins from self, but now we have the `is_from_self` field we can use it directly and be sure we only select coins that are fully under our control.
ACKs for top commit:
edouardparis:
Self-ACK 091d7728ee33d231fbafb839ac497f86122d0851
Tree-SHA512: 31e3b292e6f2ed293374ba6971f82736fa53f12341f433ffb7b59891d996682eebf031154aed6619f5c3b17fda176e01cccc20fdc523d428b04856bc5d444518
We previously used unconfirmed change as a best-guess way of
identifying those coins from self, but now we have the
`is_from_self` field we can use it directly and be sure we only
select coins that are fully under our control.
715aeb9298d1bac41ab3c904201696ddf9a794be gui(lianalite): use is_from_self from response (Michael Mallan)
8d99981c143b424d660b04b829da17afdfb1608a gui: include unconfirmed from self in confirmed balance (Michael Mallan)
31224ba44369e8eb76f004fefb0ddb4206458f4d gui: set missing fields for new home page (Michael Mallan)
0a4861f409867744c768228889b1107ea2ae8a9a refactor(gui): use common function for coins summary (Michael Mallan)
Pull request description:
This is to complete #1375, building on the changes from #1483.
The Liana Connect API response has been updated to include `is_from_self` so this will work for both local and remote backends.
ACKs for top commit:
edouardparis:
utACK 715aeb9298d1bac41ab3c904201696ddf9a794be
Tree-SHA512: 905494ee29f19dd527b2b1173075e6f2c332030b00ec05aca680921fc50411fee0d65977d2ee29b82fcfb07472df7717d8844a60cd629ffd8850d77c29b4f71e
e3acfa7f806a0694d29adb9369984c25760840e3 Update guix commit: rust 1.82 (edouardparis)
d2379bd71ad395891d45c307ca0e9f2174221e8b Use cargo-zigbuild for reproducible build with glibc 2.31 (edouardparis)
Pull request description:
Zig language has solved many issues regarding compilation linker.
It allows us to compile to a smaller version of glibc while using latest guix commit.
No need then to bootstrap multiple version of rust, the current supported version is 1.71.1
close#414
ACKs for top commit:
edouardparis:
Self-ACK e3acfa7f806a0694d29adb9369984c25760840e3
Tree-SHA512: 1a0bce14900034c5522fe06dc00807d5d2e4660f58a6c9d035c26a34f13b893a3cf56cb43dd246913926c6cf76d61cff039418c2c55b436e8673ab700829577c
1c0338610f76419287157c14a6647a362160f9e4 commands: add is_from_self to listcoins response (Michael Mallan)
c1e55716e619249c264193776d36c640df9bc946 database: add is_from_self to Coin (Michael Mallan)
6dd92052af0afc37bddb67493a64af396e7964c9 database: track whether coin is from self (Michael Mallan)
da185361f99eb319554ec78daa2fccdcd72eb298 sqlite: add helper to query single row (Michael Mallan)
4f6dcbfdfd7eaf471a38badc0c9ce48aefac814c sqlite: add columns to transactions and coins tables (Michael Mallan)
f2c910f6eb9f2b74329fa026c93f7e813f3baa53 sqlite: refactor test to not depend on order of coins (Michael Mallan)
bde3299db1c38eb6b0b09d7da2a73c43e40181b9 sqlite: refactor migration tests (Michael Mallan)
Pull request description:
⚠️ This PR upgrades and migrates DB version so a wallet opened against this PR will no longer work on Liana v8.
This is a first step towards #1375.
Following the approach from #1391, this PR adds a new `is_from_self` field to the response of the `listcoins` command.
The underlying information is stored in a new `is_from_self` column in the coins database table. This column could instead have been added to the transactions table, but for consistency with other transaction-related columns, I added it to the coins table. It's also important to note that being from self is wallet-dependent, so adding it to the transactions table would not work if multiple wallets were supported in the same DB (h/t edouardparis).
A subsequent PR will then use this field in the GUI to determine which unconfirmed coins, if any, can be included in the confirmed balance. It also needs to be added to the corresponding Liana Connect API call. Another use of this field will be to determine which unconfirmed coins to include in coin selection (https://github.com/wizardsardine/liana/issues/1484).
The first commit in this PR refactors some existing DB migration tests so that they will not be affected by future changes to the coins table schema.
ACKs for top commit:
pythcoiner:
utACK 1c033861
edouardparis:
ACK 1c0338610f76419287157c14a6647a362160f9e4
Tree-SHA512: cdadb1f887989d40a08370a479310d80087b9075ff766dd518167baed4630ccbcbb0dc8f49b7fb31ad9aebddfb4ca459d83aeed3c47158bdb046a91352f98fc7
The new columns in the transactions table will be populated for
new transactions by the poller, while existing rows will be
updated in a subsequent migration.
New and existing coins will all have `is_from_self` set to false
due to the default column value.
None of these columns will be used by the wallet at this stage.
Some migration tests used structs and methods that are expected
to change and so will not be backward compatible.
This change replaces those with structs and methods specific to
the migration tests so that the tests will be unaffected by DB
schema changes. At the same time, these new structs and methods
simplify some of the setup by allowing to store new coins,
including their confirmation and spend status, in a single
DB operation.
bd6e6f456b04b1ffb2a78e6232a3de34afb5ae4e Use a flake instead of shell nix (edouardparis)
Pull request description:
A flake makes more sense for development with nix declarative systems.
To launch the shell: do `nix develop`
ACKs for top commit:
edouardparis:
Self-ACK bd6e6f456b04b1ffb2a78e6232a3de34afb5ae4e
Tree-SHA512: e9d81ee2e7e6e08a7ea6eca3ae8c5b5d58de517dd5615d6c73578832bd1d2e1e9a9c99781079d48683268fd93647b8a95f70cfafabf818f08321410961ee38f0
da4c102a66c1f340797be13d70659b2f875c3438 Fix reproducible system to handle lianad crate (edouardparis)
74820d97e9257e44c5c9d3bc64926e30066b285a Split into lianad and liana crate (edouardparis)
Pull request description:
This change introduce two crates:
- `lianad` the crate responsible to create the `lianad` and `liana-cli` binaries and expose daemon modules for `liana-gui` to embed
- `liana` the crate responsible for the descriptors and the core logic of the bitcoin scripts and spend transactions creation. This will allow multiple platforms and mediums to start manipulating these modules without importing all the daemon dependencies (like the database or bitcoin core clients).
ACKs for top commit:
jp1ac4:
ACK da4c102a66.
Tree-SHA512: 85a268b2bffe5fe7b54d7b1e452dd2097ae606b903e5684a7b0e996b61981ab222b6718fb19739a05d1153b4d48a85d0ec3e1e15f68afe17936eec80111ecf04
4668980ff12c1026bf3a1b3b520d1d38db8939cb remove commands import in spend module (edouardparis)
Pull request description:
This is preparatory work to create a specific liana lib.
We keep modules separated.
ACKs for top commit:
edouardparis:
Self-ACK 4668980ff12c1026bf3a1b3b520d1d38db8939cb
Tree-SHA512: 0c33ab252a2e8b5404893367467ea48dbed8d84b5de0cb15dcc91bf5491b8af0d6bddd4aafe55699e16dcd7cd97b96d462d004b1921a38ae5e438c908d515c03
6cefd2464a55fbfaea5c4e9a3a370fb034c5462e remove liana from vendored source link (edouardparis)
b0fbe0839d15914cf1d56d35184bdc49683adfd3 liana-gui: import liana with directory path (edouardparis)
Pull request description:
We import directly liana with the directory path instead of the git url.
ACKs for top commit:
edouardparis:
Self-ACK 6cefd2464a55fbfaea5c4e9a3a370fb034c5462e
Tree-SHA512: a4ef7e0a8899751b6200f9753856ae6b6a9ddf1a0c1c8d8576238631b5bf33358d59a6988f8f26e153ee09824eb217df13590bdf82560d3889a99a123df9f0b0
c14c55beeea56655096eb873ba0bce4d37ccd6bb remove daemonize from config (edouardparis)
c8112ab02752f3f49e67452cc2ef5e628d6804ac move rpc code to its own module (edouardparis)
a636cda2f7f9925d44f7bde3069255b3cbc618ea liana: remove the daemon feature (edouardparis)
Pull request description:
We expect user to use systemd service to manage a daemon or
to handle their process by themself.
The json-rpc server is exposed only for unix systems through
unix sockets, it is moved to its own module while the implementation
for windows is marked as TODO.
ACKs for top commit:
jp1ac4:
ACK c14c55beee.
Tree-SHA512: d4acafda399e9645cb5a80474a46290b6fac1e9695bb6ce04ce1eec7f68209ae67c70f858cd8f4d3ea5371818c2d5f68f9bcb3e4da349f5f86e53c0ec1123883
We expect user to use systemd service to manage a daemon or
to handle their process by themself.
The json-rpc server is exposed only for unix systems through
unix sockets, it is moved to its own module while the implementation
for windows is marked as TODO.
e4ae6dc368d6600fbbdd5adaea1d52feb0f4b2a9 descriptors: include segwit marker and flag (Michael Mallan)
03a3230a67e9bf09e556d10550d9cdd08fb805d6 descriptors: add method to get max tx weight (Michael Mallan)
Pull request description:
This fixes#1406, building on the fix from #1451 for estimating the weight of each input.
An extra 2 is added to the unsigned transaction's weight to account for the Segwit marker and flag.
ACKs for top commit:
edouardparis:
utACK e4ae6dc368d6600fbbdd5adaea1d52feb0f4b2a9
Tree-SHA512: de78763d85ed38d5e2797d6f95b1ef293bbedf3cd4d5d1f69085bd134a117ae270a24c3487d738398191fb4126c4f8319bba53b902cec1625dad1c501f3f2aa9
71ad55e06bfc804754983debd7502db02b6bc524 gui: reload home if wallet is not syncing (Michael Mallan)
Pull request description:
Following #1386, this PR will show past payments on the home page while the blockchain is still syncing. Currently, these are not loaded until the wallet has finished syncing.
This change won't apply if the wallet itself is still syncing. The reason is that this is not expected to take so long and so it's better to wait for the updated data. Furthermore, the DB may be locked if the poller is running, in which case we wouldn't be able to load past transactions until the wallet has synced anyway. The home page reloads automatically as soon as the wallet finishes syncing.
ACKs for top commit:
edouardparis:
utACK 71ad55e06bfc804754983debd7502db02b6bc524
Tree-SHA512: 5fcf179ec859616ff1d7150597e73e20cb2ef0aa3ad882eeea37d6149754e58b44e37d6553ecb690a60383a95228f9724ec812dc4ae825d2620d377861c31e19
5d65a4e1253a7f8312641523981ec90344ffb9ac Use 2 decimal for sync progression in home page (thomas)
Pull request description:
Solves #907
ACKs for top commit:
pythcoiner:
ACK [5d65a4e](5d65a4e125)
Tree-SHA512: 677a132d42f426a37e30829e8a91bc6e7f258d3cfe808d4f0b5cadd1951b3cccd75527574200cf5e2319cf90e6ff5e6e88f387c457123cb9d556c81da458fe12
