6e74a96e12feb00fcf0f6974f56002c0356e0960 Revert "spend: add 10 sats to fee for 1 sat/vb txs" (Michael Mallan)
cf88aca3aee0fed9a817dd4946db7ad3c1b080a7 descriptors: fix satisfaction size for Taproot (Michael Mallan)
e9c699570669e9723bec47b1fcd6df66257a8128 qa: add threshold paramater for multisig descs (Michael Mallan)
Pull request description:
This is a fix to #1371 and the related #1322.
As per https://github.com/wizardsardine/liana/issues/1371#issuecomment-2446921093, this adds the varint length for the script and control block elements of a Taproot primary path spend.
I think this is what caused #1322 and so I have reverted the change from #1323.
ACKs for top commit:
edouardparis:
utACK 6e74a96e12feb00fcf0f6974f56002c0356e0960
Tree-SHA512: 754e5c2186de853cde9006aeab7989141a4d363b9e3d8adb3f0264bcbca7e3b56a94822d434f6f7d8108e7c0e3023959fa407643e5868082f8981c5ce10b9a1e
439af752a57410f4667664a2d5de93ddb9fa705e Fix blockchain sync precision, add tests (thomas)
Pull request description:
I've merged `roundup_progress` in `rounded_up_progress` since was in utils and was no longer used by any other method.
I also added some tests to verify the precision's update but also for specific cases that we manage. By the way tests has been moved in the related file.
Solves #907
ACKs for top commit:
pythcoiner:
ACK 439af75
jp1ac4:
Tested ACK 439af752a5.
Tree-SHA512: a87998d1e25c47d751dabc38f641f05f2544bf17cbdcf95d24e829a0aa9dd8ce2de3bdc72a52aced04ffd777412ca206641f914d9a083241d98ceea33d4c10cc
ef55e8f01e65f67faff5bd2f07c2c1302d562dd9 gui(installer): list wallets using secondary buttons (Michael Mallan)
Pull request description:
This is to fix#1445:
ACKs for top commit:
edouardparis:
ACK ef55e8f01e65f67faff5bd2f07c2c1302d562dd9
Tree-SHA512: 4bad1cb94f43d69c0e4da79ce251ca73c529f1e093ab65b78a8054b187f9f7072d2527f112ecfe7670c279e275c9d16b183ac4c3ce2d62bd4896ce763b33df04
86cebc2ddf70b1cfe2d717eb379999ee68699a5e gui(installer): use fixed keys ordering (Michael Mallan)
Pull request description:
This is to fix#1439. It follows the same approach as used in the settings to ensure consistent ordering when iterating over keys.
ACKs for top commit:
edouardparis:
utACK 86cebc2ddf70b1cfe2d717eb379999ee68699a5e
Tree-SHA512: 97c95804d9656f1a24c65134f7f4269b3410252f4ebd743d57e4ef9400b68e5ab534cf304cb5c414ffb2339ea00ed64564a43eee7338dc0c0f07f87d4b421a5b
d1bcb71ea4d4bdafe4b81fcfbfe78558b7fd8366 gui(installer): fix word plurality when adding keys (Michael Mallan)
Pull request description:
This is to fix#1440.
ACKs for top commit:
edouardparis:
utACK d1bcb71ea4d4bdafe4b81fcfbfe78558b7fd8366
Tree-SHA512: 590b19ec0d717fc3c82f9323a9fc41e79cc52e7b60df9b1319e24b851f1c99d75e12b4bf74d4e6381671895298388b942d494c395d2bbd8c6138b941b01f218b
953a85b94321093d29926283df951c3f4f00d2aa Add compression algo flag to dpkg command for arch build (edouardparis)
Pull request description:
Arch package failed to be extracted during pacman update because of the default zstd algo
ACKs for top commit:
edouardparis:
Self-ACK 953a85b94321093d29926283df951c3f4f00d2aa
Tree-SHA512: f5c0885981c5f60e291614fae8f8942b243059bc3c98c2fd313eb8f30a99d4eb832cde1e63e0206e0f71ccb637a0ddb3426283abb8e56231a5eadc65f8775309
f075b3de74ccbce8d73bf3fc2e8a1ced32192e2e gui(installer): 37dab1bff29333e6f73616238d5e608975002ce7 make only the warning displayed when a device does not support tapminiscript, this commit add also the 'selected' icon (pythcoiner)
Pull request description:
ACKs for top commit:
edouardparis:
ACK f075b3de74ccbce8d73bf3fc2e8a1ced32192e2e
Tree-SHA512: bda25aec6719cf6934e021bfa7ba0c6fa2d193b00cb63f53f52d956b3541769942eb9e4a9b0a09f66fc94ac4f3533441d7f7725fd61136cf40544cd90d130f17
c620c8278ffb8a051a5613be7620b2589c6a19f7 Add specific comparaison order for HistoryTransaction (edouardparis)
6de5016c0886d297350b47267e3a6614bae38df3 Refac pagination: sort list in async command (edouardparis)
Pull request description:
This is part of a major rework to fix performance issue while loading lot of transactions in the gui.
ACKs for top commit:
jp1ac4:
ACK c620c8278ffb8a051a5613be7620b2589c6a19f7.
Tree-SHA512: 54abaf0a00e14b6ca0ae58dc8025cdd0707cc7ced3b168a4cbc97b60ab46ee72fdbda99e488053b8a101b17682c8fe1d996b5721e49134f4e520f84a5a692eb3
47a5d3218503294065acebaee1add5b7d52d3a81 gui(installer): make edit key modal scrollable (Michael Mallan)
Pull request description:
This is to fix#1402 following the suggestion in https://github.com/wizardsardine/liana/issues/1402#issuecomment-2448730840.
ACKs for top commit:
pythcoiner:
tACK [47a5d32](47a5d32185)
edouardparis:
ACK 47a5d3218503294065acebaee1add5b7d52d3a81
Tree-SHA512: 4bf84e041e4e2ae6cbb7645a75290912d975c7c7312e7779b95f855753dc8000ff6f377b13c85ed69cd68be721fde2998c6c1f3034b92b0dab03a07edc82af68
a105c495005ba715883a6e9a53fbdde93e7741ae gui(installer): add space at bottom of pages (Michael Mallan)
Pull request description:
This is to fix#1410, including for the mnemonic and descriptor backup steps.
The space height in all cases will be 70.0 when combined with the existing vertical spacing between elements.
ACKs for top commit:
pythcoiner:
ACK tested [a105c49](a105c49500)
edouardparis:
ACK a105c495005ba715883a6e9a53fbdde93e7741ae
Tree-SHA512: 5e9f27b80490e1eea0690750a52c650c7ea607c9c42a25cb0e96dab779d691e057a2629c00c772b0c5101d4054108eb8f33ea984b837026bb858824221aca71f
918909db235ff8a0886a9f74d7ac3b1caec83324 gui: include last poll for cache refresh interval (Michael Mallan)
c915970c7b00adbd27c0d8a20116d1bda57a8d2c gui(home): pass sync status directly (Michael Mallan)
92a4a4f8dcaa75bc7181767b1958e39c94e8ad3f gui(cache): store last poll at startup (Michael Mallan)
acf14c6d734fc238dc1f44a4b5bab1f3f6411c9b gui: refresh cache more often while syncing (Michael Mallan)
e419784e9f2da76e8e86c03c8773f0dcb2a883da gui: move sync status function to wallet module (Michael Mallan)
Pull request description:
This is to resolve#1414.
In the end, I felt it was simple enough to include commits that cover both parts of #1414 (the short-term change and the follow-up).
I start with the short-term change (setting the refresh interval ignoring the last poll logic) and then follow with commits that cover all syncing statuses.
I don't use as high a refresh frequency for a remote backend as for a local backend, but these values can be easily changed if required.
ACKs for top commit:
pythcoiner:
tACK [918909d](918909db23)
Tree-SHA512: 6b47f315b0d50b2898435247b288562413e0f0abf520747edc67166c66153f7432e65ae5b3337bba67c71ade7181110e5dbfbc58df3b8510bfb5d9eb29b2bb02
01f6d2b76985a92ec19ccd37a8e4005219b94563 gui: add support for tapminiscript on bitbox02 (pythcoiner)
Pull request description:
This PR is build on top of #1357, with few adds:
- get the version from bitbox device
- check the version for taproot support
- copy `tap_script_signs` & `tap_key_sig` if present in the pruned psbt after signature
Tested spending by internal key & taptree w/ differents setups
~~Note: this PR use `bitbox-tapminiscript` branch of `async-hwi`~~
ACKs for top commit:
edouardparis:
ACK 01f6d2b76985a92ec19ccd37a8e4005219b94563
Tree-SHA512: aa66a0ebe8553fd13dd5e279adaf1360cdce0d4ccb09f49181f20bc5e4c3c653c0ab056c35ac5cf6ccb3eeb696dcfd94463e6235d1cdb2063ecb503695ad4b99
456fce35a58564b4a3195eb17e906965f42a9d5a bump gui msrv to 1.71.1 (edouardparis)
Pull request description:
This PR updates our build system to use rust 1.71.1, required by the last version of async-hwi
ACKs for top commit:
edouardparis:
Self-ACK 456fce35a58564b4a3195eb17e906965f42a9d5a
Tree-SHA512: 2b5431d4ffc92d6f7dc03fd0524ea1f534489025c3e120f6be5f08af2c2c973908f03f1dabacfd74e9b3820d4e9d5cec0a4d6184c641c1b9096646a4508ea3ca
322597f474a7b726540f28e383fb19c76e161d2b gui(installer): re-add next button (Michael Mallan)
Pull request description:
This Next button was accidentally removed in commit bd03cc9cfffb7c5c45dd0dd60d54db807d4e02a2.
ACKs for top commit:
pythcoiner:
tACK 322597f
Tree-SHA512: 35e17d52b3ba9145078e7a70bc732792a21e6a903e49c16b5d3fa79cc9b4a6e69111029476b338f592402bfcfac12e2b9ff77fe57eaddb9a62f5a52870893698
