a8e256eb6b5463dfd32599618998592a94835193 clippyfy (pythcoiner)
Pull request description:
Note [this](7a11fe584a/gui/src/main.rs (L5-L6)) is related to a clippy warning that appear on MacOs (and i guess on windows)
ACKs for top commit:
edouardparis:
utACK a8e256eb6b5463dfd32599618998592a94835193
Tree-SHA512: 33d84a14718f14caf97c0a46796488cd1f3415b78efb285277afa8384b10831522a2ed15c73c9bdee4dd775ffd294ba76b146e3034d734a067c30ab25b483790
0eda557fdf219b16af8b2d831a755148f1286669 descriptors: improve satisfaction size estimate for primary path (jp1ac4)
Pull request description:
This is to resolve#1118.
It improves the satisfaction size estimate in the case of a primary path spend involving a single key.
Tests have been updated to account for transaction fees now being lower in some cases due to better estimates.
It was already known that we sometimes end up with a transaction feerate (in sat/vb) lower than our target value, since our fee calculation from coin selection is based on sat/weight, which can give a sat/vb value lower than our target due to rounding. This will probably happen more often now given that we'll pay lower fees due to better size estimates.
ACKs for top commit:
darosior:
ACK 0eda557fdf219b16af8b2d831a755148f1286669
Tree-SHA512: 588ded7d69e937dd32ee66ca0d59daad405a1bc4605eef1b6342788625f07a6b9d2c166fb35722d0f002e10104d6e57c13abfa7a7fbbc0fd84391b91c766b2aa
40f9dd9bc43bac0c966585ac2770a02aa4c92765 replace the descriptor by template + key vector in descriptor registration step (pythcoiner)
Pull request description:
This PR replace the descriptor displayed in the installer descriptor registration step, by the wallet policies template + its keys, as almost (all?) signing devices displays the discriptor in this way for registration.
closes#727
ACKs for top commit:
jp1ac4:
Tested ACK 40f9dd9bc43bac0c966585ac2770a02aa4c92765.
Tree-SHA512: 396d20d766b89b93d3f598b3168311dfa693fcd83efe02e0515ee6428e006a5e2db4f502e3b21f50a085f37e44a1049bbfa3e4e09719a6101396012b80486cea
3bca6faffe6f1802e08471af05548f355804767c set minimum window size (pythcoiner)
Pull request description:
fixes#506
i put ~~800x800~~ as default size, feel free to told me if you think something else more appropriate.
edit: i change to 1000x800 so we can also close#507 (i do not have strong opinion, 1000 looks a bit large to me, but if we decide less than 1000 i think we shouls close#507 also)
ACKs for top commit:
edouardparis:
ACK 3bca6faffe6f1802e08471af05548f355804767c
Tree-SHA512: 673e40304c9070777ebcc539975fdc28b14df559330b68dd8f6b23f7ab09dee22364a037967604ab70e1ca9596ecc028930dbb80878faadd085f11e47d3fa491
33b67fca980e364d97fca9b2142bdae381960914 update hw support info (pythcoiner)
Pull request description:
Fixes#1106, taproot support already specified in doc/signing_devices.md
ACKs for top commit:
jp1ac4:
ACK 33b67fca98.
Tree-SHA512: c5fcc6ea7bb2af49039ad0649e689e1d4d3c01bb510e9f6b5f3db1622f42c84eefbe1f2205d667d369bcc89dd45cabac4bb3a830484557296667a88d2e598af3
8921140f6b5adec85f129b07a2040b78c45a72c1 Revert "add specter support for tap-miniscript" (edouardparis)
Pull request description:
This reverts commit 876d83af6518a3e4ae45e156ef2952a7e67affc1.
TAP_KEY_SIG was in fact not implemented by specter version 1.9.0 db3ce3e918
ACKs for top commit:
jp1ac4:
ACK 8921140f6b.
Tree-SHA512: abe108775441680139d72b7067dac0679f20f176762fc4d9471fc31061de594840099c7b4f4fc7a3bf75d54026af8cb7256bee9d3c15ef84eb2da1f20b88cbda
a9cfe45c0a010e39cb2fdd0b59926be5c13f2a4e fix ui: wrong usage of widget state (edouardparis)
Pull request description:
In a previous PR #1096, we made usage
of the widget state instead of the component state to set the collapsed value when the widget is created. But the widget is reset at each refresh of the interface, instead the component state does not change.
This commit makes the distinction between the two by having the widget state as an initial state and the component one as a capture of the user clicks.
ACKs for top commit:
jp1ac4:
Tested ACK a9cfe45c0a.
Tree-SHA512: abe108775441680139d72b7067dac0679f20f176762fc4d9471fc31061de594840099c7b4f4fc7a3bf75d54026af8cb7256bee9d3c15ef84eb2da1f20b88cbda
In a previous PR #1096, we made usage
of the widget state instead of the component state to
set the collapsed value when the widget is created.
But the widget is reset at each refresh of the interface,
instead the component state does not change.
This commit makes the distinction between the two by
having the widget state as an initial state and the component
one as a capture of the user clicks.
c0e7b63809fd60f4fc6f5e9cd5223c138e25cfde fix launcher wording (edouardparis)
977d8fa2dda00b45178b18ee3120082c0780b5ad Create datadir before install to store installer.log (edouardparis)
dee083c6d1b12eff07edef2f888bc1899c57bb72 Add blue banner for testing network (edouardparis)
be343aec37d6a8d6249285cf64759e23673e85e8 Add previous button to installer first page (edouardparis)
9ae33408cb0c0446e5ce729d46aa23dce3eb614d Move all network setup in launcher (edouardparis)
Pull request description:
This Pull requests introduce three changes:
1. Network can only be chosen with the launcher panel. A drop down showing what network user can install is shown to the user when clicking on install a new network.
2. A previous button is added to the first installer page, so user can be redirected to launcher and the network choices if he has chosen the wrong network. close#306
3. In order to make it clear for the user which network he is actually using or he is currently installing a blue banner is added on top of the window if the network is different than the bitcoin mainnet.
ACKs for top commit:
jp1ac4:
Tested ACK c0e7b63809.
Tree-SHA512: 9a0673ac785835da06fe313a861d76bdd14438cff56edb37b108b0564fd473e54028a63e209ad253b25aea318b3eb65a062cc190f76117df1baf35a251ce8356
3b604093ce13a6727b5201c59b9af014f28d329f gui: fix rbf feerate input form (jp1ac4)
Pull request description:
This fixes#860.
It makes it possible to edit a single-digit feerate, for example, by deleting the existing value and then entering a new one.
ACKs for top commit:
edouardparis:
ACK 3b604093ce13a6727b5201c59b9af014f28d329f
Tree-SHA512: 1e9add231590fc42b12cd3153892644cac75c4b4560236f8d892c152a06a63cda583229a78bc78365f050317574b6098c927f9c67e3cd4282e83a50cbd212758
d770e62e19687a4e6357ac24f899653d922d9293 Collapse advanced settings menu and grey-out `Next` button in installer if mainnet wallet already exists (pythcoiner)
Pull request description:
this PR fixes#1039, it add a warning in the installer if an wallet already exists on mainnet & grey-out `Next` button if the network is not valid.
ACKs for top commit:
edouardparis:
ACK d770e62e19687a4e6357ac24f899653d922d9293
Tree-SHA512: c756804fb89aa9cc8bc1009517f88745521580c8d3128ebfdd5b364280fd56dbdbc7490680e0e7208b6c0e1fb55279ce357f46ad2c312311c5cb6e941d27a214
d80dba048c2a020e6b0ce191d1470bdb0a82c148 doc: document the release process in a new document (Antoine Poinsot)
187857f106d639246f70278d4a55422f89014fd1 README: add a link to our Discord (Antoine Poinsot)
Pull request description:
This document a bunch of stuff i've been doing for every release in the past years. I've detailed it in a number of steps for clarity.
Fixes https://github.com/wizardsardine/liana/issues/803.
ACKs for top commit:
edouardparis:
ACK d80dba048c2a020e6b0ce191d1470bdb0a82c148
Tree-SHA512: c9f166c1ecfc595fcc3cd34d8603f6f2a67747625847e745fde5846dc5e687f04ac2e57886949f3f620ff1a55c40dc398cabc3013f058ddf70e00c73f3ec5922
6531cc293def967f63cb737b2ca5547b95bb3d9a fix local date time and bump chrono (edouardparis)
Pull request description:
close#1057
ACKs for top commit:
edouardparis:
Self-ACK 6531cc293def967f63cb737b2ca5547b95bb3d9a
Tree-SHA512: 5519cd01edcb3864f08a652b4f652d71db28b0f306f56bd11fe4bcb2ff1e56e3737da8eba16873cc4fc5e5c640cc482f69b307f5de6679ab5a8d23730c043165
99e4af84ffd64a0aad3dbb99af2d64a3cd38f490 bum async-hwi 0.0.18 (edouardparis)
Pull request description:
Include coldcard 0.12.2 that fixes the
nightly build on MacOS
ACKs for top commit:
edouardparis:
Self-ACK 99e4af84ffd64a0aad3dbb99af2d64a3cd38f490
Tree-SHA512: 5fb06e47f0f419681075df5968d7c43b50012d86f7d53f8cffb4d9584d74fd9b1936f30f8ebc9545808c79cbc5b349db17f2df5e18dc9b25dff8e3af5edafa55
570f0af35b84372d0e4684f9afd42ea7c900b43e installer: refresh hw list only if modal is open (edouardparis)
4e2015922d2a40ce934440a23f18fe8d1323ebcc doc: add Jade section to signing devices (edouardparis)
6b0c93c5c3fe2a5b6e7a3dfe49755c6edc704510 Add jade hardware wallet (edouardparis)
Pull request description:
ACKs for top commit:
edouardparis:
Self-ACK 570f0af35b84372d0e4684f9afd42ea7c900b43e
Tree-SHA512: 3f27c8bcc7afa74f751de245b44f53ce3e99b42175809566e2bf15832600d6466afd56684de08333a11079b7cb1daca3412e7224299d98f0c76cf2575b48494d
45c7b850a64318152e245b269ffef25d63033384 Remove legacy harware_wallets field from gui config (edouardparis)
Pull request description:
Ledger hmacs, wallet name and fingerprint labels where moved one year ago in the settings.json file.
Here the commit of the new settings module:
bf1e9e4b80
A second commit in v4 checked that settings.json is present otherwise it does the migration from the gui configuration file to the settings file:
3eeba08248
We remove the legacy field from the config field so the wallet module does not depend on the config module anymore to load hardware wallet information.
Tested on gui.toml config with legacy field hardware_wallets and it does not fail to launch.
ACKs for top commit:
jp1ac4:
ACK 45c7b850a6.
Tree-SHA512: a13c042c3842c732117ee8099d5a90d28462c5916408edb9fcee5518427acca5b737cd6e1ebe77a94e7d8dabf7a6bdd124ddf927ed850c58b5f980c6efe4f391
9cd36a76d09a1d563769f9c3dac81ec8ce1005eb gui: enable advanced text shaping (edouardparis)
Pull request description:
Set text shaping and font fallback to text widget.
It enable Emojis
based on #597
ACKs for top commit:
edouardparis:
Self-ACK 9cd36a76d09a1d563769f9c3dac81ec8ce1005eb
Tree-SHA512: 1ed1621135c5bfbd624a9cf4bd96385db42d021e8432334429b2ec376d769715920d90d76cc000f43625367bdac85444b131be249197e4fab4d5629c7a0138e1
52e32b6a69c751f68e461f4e858170e4ade6619d Update iced patch branch in guix build (edouardparis)
acea67bc35738843144204539833b5767f6c936e Remove transaparency from PickList for tiny-skia (edouardparis)
7801d8cb1f11511cd8e11a556add9e8c62656780 Change descriptor view in installer behind scrollable (edouardparis)
c39d544566a76b126fdc4613197d5b937f72fad3 Use wgpu with tiny-skia fallback (edouardparis)
4920291d04302a5d73196b1d8eeb6ce05d7753a2 fix ui button and badge width (edouardparis)
de371116371c61c5cd2e3bd0d44cdc849f14c5cf Change text size (edouardparis)
a24d9416f62712fc5a5c6fe5d8fa619d06f4006a gui: bump msrv 1.70 (edouardparis)
fdcc30236721f2cf7bdffe788127a35ca376d453 gui: iced-0.12 (edouardparis)
64a626d7e871fd82db27b8ddf773231fe1361755 gui: bump iced 0.10 (edouard)
Pull request description:
This PR does the migration from iced 0.9 to iced 0.12.
This new iced version has impact on the fonts size. I reverted the size according to the original UX figma file.
The new backend renderer is the `wgpu` with `tiny-skia` as a fallback. `wgpu` is the first class citizen of the iced renderers, it supports everything. The `tiny-skia` has some layout problems and does not support some features that is the reason why this PR introduces tiny change in the theme or long string display (ad69711c4a, 88fd0f18e2).
In order to keep the MSRV as low as possible, a custom patch of the crates `iced_winit`,`iced_style`, `iced_futures` is added to the Cargo.toml
ACKs for top commit:
darosior:
ACK 52e32b6a69c751f68e461f4e858170e4ade6619d -- it's been tested a bunch, in particular by Kevin.
Tree-SHA512: 6afda45c227f0dd864c59aee100895af3f0d511c5a425f4d032c5891f900f2e438de778adaa82c5213dba768e608bf7610b6c78d4cb10a2d7ae59f5b132938f4
View is broken because of the long line of text of the
descriptor, current fix is to put it behind a scrollable
until we find a better way to display it to the user.
