a0404e5d69e895467a5a51621e728b78140eae8e contrib: fix windows archive creation in release script (Antoine Poinsot)
Pull request description:
It would create an empty archive since it didn't recurse down the directories..
ACKs for top commit:
darosior:
ACK a0404e5d69e895467a5a51621e728b78140eae8e
Tree-SHA512: 60fb2b019244453c0dc003b3bf8df587d64d5663adc9ac0d9fa94f22c1f785189532c175db0076f2862edce78b638f06008f3e424c3f4b325a8f198a6841976a
103c1950ba9af114cadde6f92117b31ec584ac73 Remove change_index from listspendtxs response (edouard)
Pull request description:
Multiple change indexes may be present in a spend
draft transaction and can be detected instead
in the response psbt with the bip32_derivation
outputs fields.
ACKs for top commit:
darosior:
utACK 103c1950ba9af114cadde6f92117b31ec584ac73
Tree-SHA512: 82619792c4424537e7320162c149ae946ca1fdc101661cf9bc3d0ba4d16f0327cc3cffd98f11165a9ab9db5d1690013f8ec9bdfe46bd6b1427c332b045d683a8
a56cab73c5c0193a90732f3ba0c2c5be7b993928 fix spend change detection (edouard)
Pull request description:
Use the presence of bip32_derivation
in the spend outputs to detect the
change outputs.
ACKs for top commit:
edouardparis:
Self-ACK a56cab73c5c0193a90732f3ba0c2c5be7b993928
Tree-SHA512: 092f8929ebed4ff4c80d8425a1c83831d165a5d31d0c80bc9aac26edf3dffb0241d547fe4fc5208e0dcb4caa39c09f85f3898af56cd0cd03136e5404b503d02e
Multiple change indexes may be present in a spend
draft transaction and can be detected instead
in the response psbt with the bip32_derivation
outputs fields.
c5f38ecb4acddbb7f813215518fb45ce4f1da65b contrib: add a script to produce the assets to be released (Antoine Poinsot)
e7f43492f9061b9fa9f391e4dfde28d9d66954db contrib: utilities for releasing a macOS application in a dmg (Antoine Poinsot)
Pull request description:
This adds a script to produce the binaries and packages we will be releasing. It:
1. Runs the deterministic build for each platform
2. Package them nicely according to the platform's requirements
3. Create a detached sig for each asset with my key, `590B 7292 695A FFA5 B672 CBB2 E13F C145 CD3F 4304`
Thanks to the Bitcoin Core project for the work on creating a neat `.dmg`, i mostly stole what's here from there.
Fixes#42.
ACKs for top commit:
darosior:
ACK c5f38ecb4acddbb7f813215518fb45ce4f1da65b
Tree-SHA512: 98c92ca51fa0893541ce246cd0ca0e1e6e99f9a56aa70269d4c8e67122116adb282fc49995beee4be6fc3ed53fcb1fb93274b29588084b3ef0c9187cd7e205ad
This was mostly inspired by (or outright stolen from) the Bitcoin Core
project. I think most contributions in this area were Michael Ford's
(fanquake), so credits to him.
This is everything that needs to be present in a dmg in order to have a
nice fancy installation drag-and-drop screen. Configuration contains
dummy values to be replaced with specifics at release time.
c9551eca00f555bc486dcf3feac5c0184193c961 README: mention the minimum supported Ledger Bitcoin app version (Antoine Poinsot)
75a26a7f8eb6853c3ab77bb92fd31164d436bf20 README: add a small paragraph on recovery (Antoine Poinsot)
361367a75a873a94352d44514278f8f70b89fa8d doc: document the download of Liana binaries (Antoine Poinsot)
Pull request description:
Some additions to the documentation that were missing or depending on other things.
ACKs for top commit:
darosior:
ACK c9551ec
Tree-SHA512: c78f952396afd489416936f883bf702e3b0703a20b13e0c48493b04d8fe9b51fc67bc396b8cc26cf061b7430a4cf0716de006858c7cfc894b0cd8a4c9abb0993
73eb1d38e3612110ad467fd608863519838aa988 fix state: add new hws in list without dropping the old ones (edouard)
d9336c11ea7d3ad4dcb68fbe322d9247cf9ad52e spend detail: add a refresh button for hws (edouard)
5a7eaff17ba895418b368deaa74f8ed1b4ac26e7 fix hws: ledger dongle must load wallet (edouard)
Pull request description:
Fixes#246Fixes#238
ACKs for top commit:
edouardparis:
ACK 73eb1d38e3612110ad467fd608863519838aa988
Tree-SHA512: 969824ba2ac28a5726b8b0e87cc9a0e216ae54e2ec1fde6c5cb73d9a9326071d3b1ede9dcde1e06eb1946a38627b4ed3be2efa23955b88b11db66f36f94de14a
ffbe2f71d36ac1125e749efcaf7882a6f2c46c33 guix update Miniscript branch in cargo config (Antoine Poinsot)
b7e349459d7cadf227d2bd13fa970ed230103e41 guix: create the cargo config in the repo directory, not home (Antoine Poinsot)
b0ade5993745951b113f2c8aff26cf0b4b53aa16 README: mention reproducible builds (Antoine Poinsot)
01481ba7d7d3fd1c9b42ddafb22e5fdcb9f08976 contrib: move the docker and guix folders under a single 'reproducible' (Antoine Poinsot)
Pull request description:
Better to have those under a single, more meaningful, folder.
ACKs for top commit:
darosior:
self-ACK ffbe2f71d36ac1125e749efcaf7882a6f2c46c33
Tree-SHA512: 2f1763a952f51046ec9e8d9ea545680452aa5716fd30973bc3f4096d40e21f8b5f8479f492a3b9d02f1fff21b57835cbf0cf3044e8211501cf5077b553b454fe
88c969a6a107d347ee97fbb225ae1568e98acb37 contrib: document Docker reproducible builds (Antoine Poinsot)
9a800113a713b1687960c14b77b1ada1df17bdff contrib: reproducible builds for macOS using Docker (Antoine Poinsot)
Pull request description:
This finishes the work on reproducible build with the last missing cross compilation: macOS. I still need to add a README to this folder. I'll do it in this PR.
ACKs for top commit:
darosior:
re-ACK 88c969a6a107d347ee97fbb225ae1568e98acb37
Tree-SHA512: 5442d20fc33de16370b7776cec55e3d2d0ef5d66b595160a15099959f2f3b59705aeb945fef7a0e59a5909a8569a243ed85a63f09679fcc642c23010d67090a4
f996e2565797b413870d75fa764ebd207bb264c4 ci: pin clippy to 1.65.0 for the GUI (Antoine Poinsot)
d529cd8b6c7245852deacbfa9d14b349b1ad04e3 ci: pin clippy at 1.66.0 (Antoine Poinsot)
ab9fff4395c9d368d4d8c795af4d4ada295ac36b Remove clippy.toml (Antoine Poinsot)
d3b89add9aa8d7329bbb2afc7b2288fc1ea95189 daemon: apply clippy 1.66.0 fixes (Antoine Poinsot)
Pull request description:
The CI broke again because clippy is configured to target `stable` and introduces breaking changes with each version. Apply the fixes for the latest stable, then pin clippy to this version.
For the GUI i wasn't sure so i just pinned clippy to the latest stable.
ACKs for top commit:
darosior:
self-ACK f996e2565797b413870d75fa764ebd207bb264c4 -- trivial
Tree-SHA512: 5f41af6b568e20556a4f781f3cff110790eee7f13c62842882a4211ddac9513fd84293a751b6b0fa9206cccecf06c8b04d365dd070cf26de88f4af78be1b10fc
48e4909e7ad83c21f788802953327f8041a69b7d daemon: store the watchonly wallet file in bitcoind's datadir on Windows (Antoine Poinsot)
Pull request description:
Turns out that providing an absolute path to bitcoind when loading a wallet on Windows results in surprising behaviour.
ACKs for top commit:
edouardparis:
ACK 48e4909e7ad83c21f788802953327f8041a69b7d
Tree-SHA512: b432460d529cf5b879361452af1e7947ec877c293f8a8a2e1740975a2957c0cdb288d1f9a1fa07e56193c7c65edf1f985d9e24dd3412f2bfc10922df239de766
89d2e67625b1308d621af0fe15081588459e22b8 Windows reproducible builds using Docker (Antoine Poinsot)
43ece74cf747e278a1ce0b96203a4bc958d1cb12 gui: target 'windows' subsystem for Windows targets (Antoine Poinsot)
Pull request description:
Using Docker for now. I'll add documentation once i've figured out macOS.
ACKs for top commit:
darosior:
Cool. ACK 89d2e67625b1308d621af0fe15081588459e22b8
Tree-SHA512: 74cf8b5184fbf1fe64bccdf5e7a0f856bf5890e61559fd759485af6fa9bd4ef3430d4c010748a8cf97ca0d9086f49e93d1bb90899610fd98638bdd8c01f33819
192072ea257ae50e6c90bda00677b5f07ca9ada9 fix recovery state coins filtering (edouard)
Pull request description:
Recoverable coins are coins that recovery
path is available *next* block
ACKs for top commit:
darosior:
Not familiar with this code, but it appears it now check whether the timelock will be mature in one block or less. If that is the case then it is consistent with the behaviour of the daemon. utACK 192072ea257ae50e6c90bda00677b5f07ca9ada9.
edouardparis:
ACK 192072ea257ae50e6c90bda00677b5f07ca9ada9
Tree-SHA512: 0bf5f39fcf393a16667f498d851a3cd7dd6b0831696db05c27363b6f9d5006225afc919d6a6c4d3992cd3d3ce702bc5a7e0a7e57d9f21234649237ee172f1f2d
030bfadaf7ef5e88500f6f64ea814d3656b07fba bitcoind: decrease the sync progress roundup threshold (Antoine Poinsot)
4560bc9ed2e41e81797cadfdecb5a97a6d351850 bitcoind: move roundup_progress() to utils and unit test it (Antoine Poinsot)
Pull request description:
Part of #217.
ACKs for top commit:
darosior:
ACK 030bfadaf7ef5e88500f6f64ea814d3656b07fba
Tree-SHA512: 253eaaa7a2dfad34858bcb54e9d001ac4f0f5037646075f80db1bf2259f8b2bcda002e8bf19f5d06aa0959d62b1a770df9fc2eba8454b3545734ee27b36234e3
52341db41d719f7cbb224d9164593f5f2992eae7 just put the whole gpg key (Kevin Loaec)
Pull request description:
I'm quite sure it does the check for you. So i also removed the extra comment. If i'm doing something wrong plz educate me :D
ACKs for top commit:
darosior:
I wouldn't be surprised if gpg was doing something surprising like transforming the key into a fingerprint before pulling from the keyserver. On the other hand it's the only bit of additional information re: checking GPG signatures in this document so being consistent is probably better. ACK 52341db41d719f7cbb224d9164593f5f2992eae7
Tree-SHA512: 95cadf5a6d93b63dbf7072cc61129feb2d5a229442ba6a4eaa6f741228d5404b929ba262b3550759edef230baa3aa09e469017362e37103de0a6eed5e4331a90
