f8e702b65ea894131b212fdfed89b16068699fe9 feat: list unused addresses already revealed (Michael Mallan)
d84c75c1ce548c2c7dfecf98960e9a19409cb9e7 refactor: extract address card logic to function (Michael Mallan)
daa3daa938567e6d76e7dce02bddd725b97a72d9 refactor: add message for next receive address (Michael Mallan)
8b8b48142f60ede2b8ce702c89a61f3fd32a1842 feat: add list addresses method to gui daemon interface (Michael Mallan)
Pull request description:
This implements #809 by listing unused addresses on the Receive panel.
ACKs for top commit:
edouardparis:
ACK f8e702b65ea894131b212fdfed89b16068699fe9
Tree-SHA512: 05538d099433bad33c947694e91bc082147159bebd4607ac2d37f9127013656c928a2a332f1212fc5f9d6a2d68e3047e7c3da5523233b92d47b2802811a706d8
3d6a22ea05df70d6f0c11f2f00c85dc16975ad28 feat: add rpc command to list revealed addresses (Michael Mallan)
4945dba7c066d1434fa38a09a955339b7182e693 feat: add command to list revealed addresses (Michael Mallan)
75f37708b3b1f6a89e0f5488c95618a07356f166 test: implement methods for getting/setting labels (Michael Mallan)
16b96b5456b46cd3703d4829b24746c8a489b3ed style: apply black formatting (Michael Mallan)
Pull request description:
This implements #1678.
The command parameters differ slightly from those described in the issue:
- instead of a `keychain` enum parameter, I used `is_change` to control whether receive or change addresses are returned.
- I used an optional `continue_from` parameter to control pagination. The value to pass in the next request is provided by the previous response. If no value is provided in the response, there are no more addresses to list. If no value is set in the request, the addresses will be returned starting from the last revealed address.
Setting the positional argument for `continue_after` as `null` will be treated the same as omitting it (for other RPC commands, a `null` value results in a parsing error).
ACKs for top commit:
pythcoiner:
utACK 3d6a22e
Tree-SHA512: 0efa93bc40d0751cbe64570f9789b3a701e0bc5aab982da9ed9f21117a2eea073a81388370d56a9021c0ff87b6cbaec7338339427e6c879e8e97eababb107f57
8c0c23e688b02a73393a7172b3f41bfaa2a9c143 Use gui panic hook (edouardparis)
40dc9ae8c01da0b250bf0e8ea40e275ef77bd23c Delete process internal bitcoind locks in case of panic (edouardparis)
0488ed37a3651add672212664d59f637be17c716 feat: asynchronous management of internal bitcoind (edouardparis)
Pull request description:
This PR introduces a feature allowing multiple liana processes to the same internally managed bitcoind binary,
by having the first process running a wallet relying a managed bitcoind to start it and the last process standing stopping it when closing.
A new directory `./liana/bitcoind/locks` is introduces where a Liana process creates a file `pid-timestamp` when it starts or uses the internally managed bitcoind binary and removes it when it does not use it anymore.
Another Liana process can infer that it can stop the bitcoind binary by looking if any other lock file is present in this directory.
In order to make the bitcoind child process survive once the Liana process that started it is closed, the `libc::setsid();` method for unix and the `DETACHED_PROCESS` flag for windows are added to the process command.
The current panic hook of the gui was override by the one present in lianad daemon start method. The latter was moved to the daemon main.rs file.
ACKs for top commit:
edouardparis:
Self-ACK 8c0c23e688b02a73393a7172b3f41bfaa2a9c143
Tree-SHA512: b8ea415750c656786b64bc7ea97194f27db37267820f1a413ce6639e48dae542e644958856ffaddd53ab1ad047072a9bcc11ad304c060417b9542d4ee61089a3
9411017da5dd775fe358e16c4ad9545343422c44 gui & ci: upgrade managed bitcoind version to 29.0 (thomas)
Pull request description:
Integration tests has been passed using bitcoin core 29.0 (with tests requirements updated as in #1684).
Closes#1656.
ACKs for top commit:
pythcoiner:
utACK 9411017, tryed on linux, seems it download well 29.0 but my connection to bitcoincore.org is bad, the download always fail, but likely not related to this PR but rather to my poor connection
jp1ac4:
ACK 9411017da5dd775fe358e16c4ad9545343422c44.
Tree-SHA512: 2cb183b0da77eaf84c3957ad6cfcac0dc9b0a05d21aebeaf0f9f84d3bf81708a19c1ac6ef0e67a8ca48c71d7196dcf3b3e230ba8eae17da8b9c1bdc74f8af119
c8e455c8ceb2a7b5408380dbe3cd30ce3959ff57 lianad: add a test for LianaDescriptor::contains_fingerprint() (pythcoiner)
aead34cc8eaa3e74d2c76c7e1e8341d756d779a2 installer: hint the user if the plugged signing device is not part of the descriptor (pythcoiner)
5ae13dd025c2e038e17746f5bfc8cf72ec5120c7 liana-ui: make it more clear when a device key is not part of the wallet descriptor (pythcoiner)
fa8fd4782f97b8969f6a655e0511bf8f96924232 liana: implement LianaDescriptor::contains_fingerprint() (pythcoiner)
Pull request description:
This PR:
- [x] Add `LianaDescriptor::contains_fingerprint()` method
- [x] make more explicit when a signing device is not part of the wallet descriptor
before (user had to hover the button to see the tooltip):
after:
- [x] Hint the user in the installer if the plugged device is not part of the created/imported descriptor:
ACKs for top commit:
jp1ac4:
tACK c8e455c8ceb2a7b5408380dbe3cd30ce3959ff57.
Tree-SHA512: 092b8cb6efe6b6a6dc4f8505649783cb7c83c231242ab14f479b573e12cd61bab4e6e27a173bee19097d3ad90a8f1e578ecf4b699a4a481b40588f5f60cb9c71
c20318af64fddb2959ba90f2d510af42f4e2e20e Upgrade pytest (thomas)
Pull request description:
Had issues because of a too old version of pytest-timeout. I had to update it so I took advantage of it to update pytest and other requirements
ACKs for top commit:
pythcoiner:
tACK c20318af on arch + python 3.10/3.13
Tree-SHA512: 22e7abf810c49d29f908e493db4055a9fd94d8a623e8a9ae8cfc33e2b9ab1865ad64acb8a2837b0b9b0ed1846b1ba9ea21242ccd7f0a4f4f221041d8465c55bd
c4715acb047b48e882102e38b67ed9bb37816306 refac liana-gui: network flag redirects to launcher (edouardparis)
Pull request description:
Adding the network flag to liana-gui command opens now the launcher with the network set instead of trying to run the wallet in the network directory.
This is preparatory work for the multiple wallet feature.
ACKs for top commit:
edouardparis:
Self-ACK c4715acb047b48e882102e38b67ed9bb37816306
Tree-SHA512: dad9b349c55d6e3884e79d9d314f926121c590f8b59a2322b2aee9461cfb2ddcc2d6b3d105d0bde4684fd2e097077cecf0a2f0f365e0ce52b6cadb1dc935d96a
Adding the network flag to liana-gui command opens now
the launcher with the network set instead of trying to
run the wallet in the network directory.
This is preparatory work for the multiple wallet feature.
fe14c7807e60a080052ebc94c1e0d160c8db8ed6 pin email in liana connect login (edouardparis)
1746314e7d8ef4e06cc05951dc620d88d280d26e Add liana-connect cache file (edouardparis)
Pull request description:
This PR introduces a new file in the network directory: `connect.json` where the access tokens per email accounts are stored. Race conditions and potential conflicts to update the file are handle by the crate `async-fd-lock`.
If the cache is missing (like for a previous liana generated setup), then the user is asked to authenticate again.
The change does not remove totally the legacy `refresh_token` field in the settings file in order to be backward compatible with previous liana-gui versions.
ACKs for top commit:
edouardparis:
Self-ACK fe14c7807e60a080052ebc94c1e0d160c8db8ed6
Tree-SHA512: a4ce6c78e8edd8378f227ae464a5ff0ebd88ee16b519a26f78eb95c9ab5752d14a50ea559902ce5edb9a00452e77b2552c2743a75182a9de825846b5c6f4d06c
ad2c096715da49223f7c2cf3389e575b7e62a064 gui: disable replacement fee input if tx is already replaced (pythcoiner)
Pull request description:
this PR disable input on feerate TextInput if the tx already have been replaced, it's fine to do so because we still can RBF the new replacing tx.
close#1138
ACKs for top commit:
jp1ac4:
tACK ad2c096715.
Tree-SHA512: 528dc513ee83a839c86a6dd8d49fa5af61814e7c440d5337d294205269ebcef3d50001a5b41815c95276d4f3e6660d5f5e081456feb77843b527d8f9eed897b8
eac6cdd197d75e957387db77126d2f258fd1bb27 ci: use self-hosted runner for integration tests (pythcoiner)
Pull request description:
this PR:
- move integrations tests from cirrus to a self hosted github worker (this solve many of the "timeout" errors)
- remove usage of docker: the worker run directly on the host machine (this solve almost remaining issues and cut integration test running time by half)
ACKs for top commit:
edouardparis:
ACK eac6cdd197d75e957387db77126d2f258fd1bb27
Tree-SHA512: 94035ed7b80c71b57c8507a64088898da7e7a8d6c83269a60abd330f592ad83ef032b7943bd3d2276494b568249194f816f6c4a109b27a5d1788075fecb3aba9
356301c79c6f621e8329287f70a112ddbb16d43d feat: add brief overview of recovery feature (Michael Mallan)
30aedb3e5b8b10cb0df9f937a5d362fccb91bf34 fix: use singular for one coin (Michael Mallan)
eb45d6ef8f50ea4384b1f5ce9fd4f0c0aaf98237 fix: show tooltip above to improve legibility (Michael Mallan)
ea8e8453d7ae59862f326f8e5111fd3d0b5ea9cc fix: clarify available recovery paths wording (Michael Mallan)
Pull request description:
This fixes and implements the items from #1664, except for the alias refresh, which is covered by #1667.
ACKs for top commit:
edouardparis:
utACK 356301c79c6f621e8329287f70a112ddbb16d43d
Tree-SHA512: ca5c71d214126e9447e48be5be9294c72b046136223f5b7848ee458c726ebf316042c612763a5c1a146450c15a566e56a2521bd2f0c2b6e0a04c7dcbc40163f7
bb7777878ea639def09a50f52fdd338467e8a87d Use type wrapper instead of PathBuf for directories (edouardparis)
Pull request description:
With the multiplicity of directories, liana directory, network directory and in the future per wallet lianad directories, passing a simple type PathBuf does not transmit to the contributors the information about which directory each module works with.
This commit introduces wrappers around PathBuf
to give this information and link parent directories to their child directories.
ACKs for top commit:
jp1ac4:
ACK bb7777878ea639def09a50f52fdd338467e8a87d.
Tree-SHA512: 3ed1e8a1e56f238c51768b9aef64a826527a89dc584976085db5cd8f8823f71910ee2e94fc09c78f7ce8de34535c9e416883a84a3a18430d1505a02ab2f88fb9
With the multiplicity of directories, liana directory,
network directory and in the future per wallet lianad
directories, passing a simple type PathBuf does not
transmit to the contributors the information about
which directory each module works with.
This commit introduces wrappers around PathBuf
to give this information and link parent directories
to their child directories.
7664567d41e54a79fd62a46077feea3f6ec28196 Fix sliders background color (use light grey) (thomas)
8a9dc083ab5a07cca9a0ddc699d5f5b83bfaf1ad Fix sliders background color (thomas)
Pull request description:
You can see here the black background for the slider :
Closes#1670
ACKs for top commit:
pythcoiner:
utACK 7664567
Tree-SHA512: 2c0954ab0d4571d19cc84e58f1ba6fe0a66aacdc3a4cd95a90caf3f63768724a3ce98ad47a4ac786519c6eda6f12726299ebd2ac6688da41b7de857916248432
7d2a1d4d315819ad18c040c7ee3e2830b40d8d6f fix: ensure spend panel steps use latest wallet (Michael Mallan)
Pull request description:
This fixes one of the items from #1664, but it's a little different from the other items there so I felt a separate PR would be better.
This fixes an issue for the Recovery panel that was introduced by #1658, but which was already present in the Send panel. If, while creating a regular spend, the user edits the fingerprint aliases, these updated aliases would not have shown in the signing info of the draft PSBT. For a recovery, this issue arises on the first step when selecting a recovery path, where the aliases are shown for each key required on that path.
The issue arises because the `wallet` field of individual steps was not being updated.
Now, the `wallet` will be stored by `CreateSpendPanel` and used by `load()` when moving between steps. Furthermore, the `WalletUpdated` message will be used to update the current step directly.
ACKs for top commit:
edouardparis:
utACK 7d2a1d4d315819ad18c040c7ee3e2830b40d8d6f
Tree-SHA512: c7b4d3da57bb3e856d101128f581ec3df055d1e2892ec3f1ba04550495250ed9bd9d5193760d0883224e0368a7cd425dfa010fc214e204f764176b975c66d515
The wallet is used in some steps to get fingerprint aliases.
The recovery panel previously handled a wallet update, but this
was omitted when making the recovery panel part of the spend
panel.
This bug already existed for the final step of a regular spend
where the signing information would show old aliases if these
were updated while defining the spend.
7085542066006d1d0debbe6fff0b3463ace834f1 Move lianalite to services::connect module (edouardparis)
f3ae84f91c2028d8e53da0d096867c8cf13a54c4 Move keys service to its own submodule (edouardparis)
Pull request description:
Move the current client implementation for https://keys.wizardsardine.com from `services` to `services::keys`.
Move the liana-connect client implementation to `services::connect`
ACKs for top commit:
jp1ac4:
ACK 7085542066006d1d0debbe6fff0b3463ace834f1.
Tree-SHA512: 853f8cde9de768f0b087125b7ae9a5aae3fec9a5d6085ccf0ae72e6b75c7833424ddf482bcc9eefeea05f35ef59b65727af8f6e0af1efcf0a95217f3d9b74b2c
