ffbe2f71d36ac1125e749efcaf7882a6f2c46c33 guix update Miniscript branch in cargo config (Antoine Poinsot)
b7e349459d7cadf227d2bd13fa970ed230103e41 guix: create the cargo config in the repo directory, not home (Antoine Poinsot)
b0ade5993745951b113f2c8aff26cf0b4b53aa16 README: mention reproducible builds (Antoine Poinsot)
01481ba7d7d3fd1c9b42ddafb22e5fdcb9f08976 contrib: move the docker and guix folders under a single 'reproducible' (Antoine Poinsot)
Pull request description:
Better to have those under a single, more meaningful, folder.
ACKs for top commit:
darosior:
self-ACK ffbe2f71d36ac1125e749efcaf7882a6f2c46c33
Tree-SHA512: 2f1763a952f51046ec9e8d9ea545680452aa5716fd30973bc3f4096d40e21f8b5f8479f492a3b9d02f1fff21b57835cbf0cf3044e8211501cf5077b553b454fe
88c969a6a107d347ee97fbb225ae1568e98acb37 contrib: document Docker reproducible builds (Antoine Poinsot)
9a800113a713b1687960c14b77b1ada1df17bdff contrib: reproducible builds for macOS using Docker (Antoine Poinsot)
Pull request description:
This finishes the work on reproducible build with the last missing cross compilation: macOS. I still need to add a README to this folder. I'll do it in this PR.
ACKs for top commit:
darosior:
re-ACK 88c969a6a107d347ee97fbb225ae1568e98acb37
Tree-SHA512: 5442d20fc33de16370b7776cec55e3d2d0ef5d66b595160a15099959f2f3b59705aeb945fef7a0e59a5909a8569a243ed85a63f09679fcc642c23010d67090a4
f996e2565797b413870d75fa764ebd207bb264c4 ci: pin clippy to 1.65.0 for the GUI (Antoine Poinsot)
d529cd8b6c7245852deacbfa9d14b349b1ad04e3 ci: pin clippy at 1.66.0 (Antoine Poinsot)
ab9fff4395c9d368d4d8c795af4d4ada295ac36b Remove clippy.toml (Antoine Poinsot)
d3b89add9aa8d7329bbb2afc7b2288fc1ea95189 daemon: apply clippy 1.66.0 fixes (Antoine Poinsot)
Pull request description:
The CI broke again because clippy is configured to target `stable` and introduces breaking changes with each version. Apply the fixes for the latest stable, then pin clippy to this version.
For the GUI i wasn't sure so i just pinned clippy to the latest stable.
ACKs for top commit:
darosior:
self-ACK f996e2565797b413870d75fa764ebd207bb264c4 -- trivial
Tree-SHA512: 5f41af6b568e20556a4f781f3cff110790eee7f13c62842882a4211ddac9513fd84293a751b6b0fa9206cccecf06c8b04d365dd070cf26de88f4af78be1b10fc
48e4909e7ad83c21f788802953327f8041a69b7d daemon: store the watchonly wallet file in bitcoind's datadir on Windows (Antoine Poinsot)
Pull request description:
Turns out that providing an absolute path to bitcoind when loading a wallet on Windows results in surprising behaviour.
ACKs for top commit:
edouardparis:
ACK 48e4909e7ad83c21f788802953327f8041a69b7d
Tree-SHA512: b432460d529cf5b879361452af1e7947ec877c293f8a8a2e1740975a2957c0cdb288d1f9a1fa07e56193c7c65edf1f985d9e24dd3412f2bfc10922df239de766
89d2e67625b1308d621af0fe15081588459e22b8 Windows reproducible builds using Docker (Antoine Poinsot)
43ece74cf747e278a1ce0b96203a4bc958d1cb12 gui: target 'windows' subsystem for Windows targets (Antoine Poinsot)
Pull request description:
Using Docker for now. I'll add documentation once i've figured out macOS.
ACKs for top commit:
darosior:
Cool. ACK 89d2e67625b1308d621af0fe15081588459e22b8
Tree-SHA512: 74cf8b5184fbf1fe64bccdf5e7a0f856bf5890e61559fd759485af6fa9bd4ef3430d4c010748a8cf97ca0d9086f49e93d1bb90899610fd98638bdd8c01f33819
192072ea257ae50e6c90bda00677b5f07ca9ada9 fix recovery state coins filtering (edouard)
Pull request description:
Recoverable coins are coins that recovery
path is available *next* block
ACKs for top commit:
darosior:
Not familiar with this code, but it appears it now check whether the timelock will be mature in one block or less. If that is the case then it is consistent with the behaviour of the daemon. utACK 192072ea257ae50e6c90bda00677b5f07ca9ada9.
edouardparis:
ACK 192072ea257ae50e6c90bda00677b5f07ca9ada9
Tree-SHA512: 0bf5f39fcf393a16667f498d851a3cd7dd6b0831696db05c27363b6f9d5006225afc919d6a6c4d3992cd3d3ce702bc5a7e0a7e57d9f21234649237ee172f1f2d
030bfadaf7ef5e88500f6f64ea814d3656b07fba bitcoind: decrease the sync progress roundup threshold (Antoine Poinsot)
4560bc9ed2e41e81797cadfdecb5a97a6d351850 bitcoind: move roundup_progress() to utils and unit test it (Antoine Poinsot)
Pull request description:
Part of #217.
ACKs for top commit:
darosior:
ACK 030bfadaf7ef5e88500f6f64ea814d3656b07fba
Tree-SHA512: 253eaaa7a2dfad34858bcb54e9d001ac4f0f5037646075f80db1bf2259f8b2bcda002e8bf19f5d06aa0959d62b1a770df9fc2eba8454b3545734ee27b36234e3
52341db41d719f7cbb224d9164593f5f2992eae7 just put the whole gpg key (Kevin Loaec)
Pull request description:
I'm quite sure it does the check for you. So i also removed the extra comment. If i'm doing something wrong plz educate me :D
ACKs for top commit:
darosior:
I wouldn't be surprised if gpg was doing something surprising like transforming the key into a fingerprint before pulling from the keyserver. On the other hand it's the only bit of additional information re: checking GPG signatures in this document so being consistent is probably better. ACK 52341db41d719f7cbb224d9164593f5f2992eae7
Tree-SHA512: 95cadf5a6d93b63dbf7072cc61129feb2d5a229442ba6a4eaa6f741228d5404b929ba262b3550759edef230baa3aa09e469017362e37103de0a6eed5e4331a90
User is asked which network to start with.
This is a required step in case the user
start the software without a console and
can not set himself the network or launch
the install for another non existing network.
ba994ff8ff01d04fd31ed77cf7f66e0862e68e17 commands: do not underestimate the size of created transactions (Antoine Poinsot)
46a94d6c8eb144484a4b0df2ddbd48b32d4d096f qa: test recovery 'sweep' transaction creation (Antoine Poinsot)
3b5cbd5122fa53d0247e82dd7fc703b5d0a4bae3 qa: introduce a sign_and_broadcast utility (Antoine Poinsot)
d362885b85107b616447899d5eaaa5ba1b55c170 qa: record the recovery xpub too (Antoine Poinsot)
a69fb625ea3b8dfbfa1bf384e001f167fd04ff86 qa: use a CSV of 10 for recovery (Antoine Poinsot)
a78f46fa2fc5337c51d1eaa6ac6bbee04cfdf437 [refactoring] jsonrpc: sort command names alphabetically (Antoine Poinsot)
c09ae3f87bc8bb2391d88d1a718b35d4a6c568fa commands, jsonrpc: add a new 'createrecovery' command (Antoine Poinsot)
3d5d0134b4b5bc06910a89d23def36de5b548c30 commands: fix the capacity of input vectors in create_spend (Antoine Poinsot)
f2312593da8b27c6c6a69c7b0463959369c5acb6 commands: check for dust outputs in the PSBT sanity checks (Antoine Poinsot)
9f23161a53ad32d03d4ec464c48a819862dbf3e5 commands: correct the max feerate value (Antoine Poinsot)
54410cd9c435e1e6228b985d78e55b357c2368b8 database: allow to query coins by their spending status (Antoine Poinsot)
Pull request description:
A new command that provides a simple way for a user to sweep all the coins whose timelocked recovery path is available.
The first part of #180. Note this also contains a number of drive-by fixes that i noticed while coding this up.
ACKs for top commit:
darosior:
self-ACK ba994ff8ff01d04fd31ed77cf7f66e0862e68e17 -- tested by Edouard on the GUI
Tree-SHA512: 002cb8602370fe3bec0692fe7bbe9e7af494b43756d3092da99b37e4ce2837bcdfcfb3afe7043900eb41c70de12e2129e19363b9efe41cee91c7f1f7c2824fb0
acd6929831964d643565f8f22b552f74613a3a1d doc: update for bitcoind 24.0.1 release (Antoine Poinsot)
650101525d890f50290989bd58c367024a69115c bitcoind: set minimum required version to 24.0 (Antoine Poinsot)
9211d849c191ff5d2552bde681edaa7038c8d049 bitcoind: be less stupid when loading the watchonly wallet (Antoine Poinsot)
Pull request description:
Fixes#210Fixes#209Fixes#213
ACKs for top commit:
darosior:
self-ACK acd6929831964d643565f8f22b552f74613a3a1d
Tree-SHA512: 8cacf41b0e00faed877462dc57b595265ff2936937d45535d1be2b42fd1bf80df2928ccacbefd43f82d88a728aca898a8549899380e341de8b8e74d34ec74642
