nik/navidrome
1
0
Fork 0
mirror of https://github.com/navidrome/navidrome.git synced 2026-10-18 07:30:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

docs(artwork): say why media files are exempt from settling absent

Browse Source 
The comment justified the exemption with the fallback to disc or album
art, which is true of any track but is not the reason. Media files
resolve embedded-only, from a local read, and nothing but a view ever
enqueues one — so there is no provider to protect and nothing to gain
from recording a state that stops the retry.
This commit is contained in:
Deluan 2026-09-01 18:45:01 -04:00
parent e92a90f5a9
commit 60fff953de
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
core/artwork/housekeeping.go
View File

@ -31,7 +31,8 @@ func KeepsState(kind model.Kind) bool { return kind != model.KindDiscArtwork }
var RefreshableKinds = append(slices.Clone(ReprocessKinds), model.KindMediaFileArtwork)
// settlesAbsentOnGiveUp reports whether an exhausted retry budget records an absent state. Media
// files are excluded: a track with no row still falls back to its disc or album art.
// files are excluded because retrying one costs nothing: they resolve embedded-only, from a local
// read, and only a view ever enqueues them.
func settlesAbsentOnGiveUp(prefix string) bool {
kind, ok := model.ParseKind(prefix)
return ok && KeepsState(kind) && kind != model.KindMediaFileArtwork