nik/navidrome
1
0
Fork 0
mirror of https://github.com/navidrome/navidrome.git synced 2026-02-02 06:24:14 +00:00
Code Issues Packages Projects Releases Wiki Activity
4,438 Commits 28 Branches 109 Tags 104 MiB
Commit Graph

4438 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Deluan
c65aaafdcd feat(scan): add '@Recycle' (QNAP) to ignored directories list 
Signed-off-by: Deluan <deluan@navidrome.org>
 2025-11-14 17:23:43 -05:00
Deluan
b60043aa12 refactor(scan): streamline folder entry creation and update handling 
Signed-off-by: Deluan <deluan@navidrome.org>
 2025-11-14 16:45:25 -05:00
Deluan
e0b544a31c fix(scanner): prevent race condition when scanning deleted folders 
When the watcher detects changes in a folder that gets deleted before
the scanner runs (due to the 10-second delay), the scanner was
prematurely removing these folders from the tracking map, preventing
them from being marked as missing.

The issue occurred because `newFolderEntry` was calling `popLastUpdate`
before verifying the folder actually exists on the filesystem.

Changes:
- Move fs.Stat check before newFolderEntry creation in loadDir to
  ensure deleted folders remain in lastUpdates for finalize() to handle
- Add early existence check in walkDirTree to skip non-existent target
  folders with a warning log
- Add unit test verifying non-existent folders aren't removed from
  lastUpdates prematurely
- Add integration test for deleted folder scenario with ScanFolders

Fixes the issue where deleting entire folders (e.g., /music/AC_DC)
wouldn't mark tracks as missing when using selective folder scanning.
 2025-11-14 16:34:30 -05:00
Deluan
67c876539e feat(gc): enhance garbage collection to support selective library purging 
Signed-off-by: Deluan <deluan@navidrome.org>
 2025-11-13 15:27:20 -05:00
deluan
de773b9bcd test(scan): suppress unused return value from SetUserLibraries in tests 2025-11-13 12:04:45 -05:00
deluan
f1f4615966 refactor(scan): move ParseTargets function to model package 2025-11-13 11:55:41 -05:00
deluan
a2d48e5138 feat(scan): update scanning parameters from 'path' to 'target' for selective scans. 2025-11-13 11:54:10 -05:00
Deluan
6ea249608c feat(ui): add Scan buttonsto the LibraryList 
Signed-off-by: Deluan <deluan@navidrome.org>
 2025-11-13 10:19:57 -05:00
Deluan
8cebf82590 feat(ui): add quick and full scan options for individual libraries 
Signed-off-by: Deluan <deluan@navidrome.org>
 2025-11-12 16:21:01 -05:00
Deluan
acae163b0f feat(ui): add selective scan options and update translations 
Signed-off-by: Deluan <deluan@navidrome.org>
 2025-11-12 16:19:18 -05:00
Deluan
62a8d85772 test(scanner): refactor tests 
Signed-off-by: Deluan <deluan@navidrome.org>
 2025-11-12 16:19:18 -05:00
Deluan
e898deaa9f fix(library): update PRAGMA optimize to check table sizes without ANALYZE 
Signed-off-by: Deluan <deluan@navidrome.org>
 2025-11-12 16:19:18 -05:00
Deluan
d8dfbc0732 test(scanner): add tests for ScanBegin and ScanEnd functionality 
Signed-off-by: Deluan <deluan@navidrome.org>
 2025-11-12 16:19:18 -05:00
Deluan
5eb867b639 refactor(scanner): replace parseTargets function with direct call to scanner.ParseTargets 
Signed-off-by: Deluan <deluan@navidrome.org>
 2025-11-12 16:19:18 -05:00
Deluan Quintão
d30f6cfc92 Update scanner/phase_1_folders.go 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
 2025-11-12 16:19:18 -05:00
Deluan
2998cd3f7c fix(scanner, watcher): handle errors when pushing ignore patterns for folders 
Signed-off-by: Deluan <deluan@navidrome.org>
 2025-11-12 16:19:18 -05:00
Deluan
e222d8d8db refactor(scanner): enhance walkDirTree to support target folder scanning 
Signed-off-by: Deluan <deluan@navidrome.org>
 2025-11-12 16:19:18 -05:00
Deluan
08bccad020 docs(scanner): comments 
Signed-off-by: Deluan <deluan@navidrome.org>
 2025-11-12 16:19:18 -05:00
Deluan
587249bf81 feat(watcher): enhance .ndignore handling for folder deletions and file changes 
Signed-off-by: Deluan <deluan@navidrome.org>
 2025-11-12 16:19:18 -05:00
Deluan
7ed817c1c0 feat(configuration): add DevSelectiveWatcher configuration option 
Signed-off-by: Deluan <deluan@navidrome.org>
 2025-11-12 16:19:18 -05:00
Deluan
71acd02d1b refactor(tests): rename selective scan test file to scanner_selective_test.go 
Signed-off-by: Deluan <deluan@navidrome.org>
 2025-11-12 16:19:18 -05:00
Deluan
78904257df refactor(scanner): move initialization logic from phase_1 to the scanner itself 
Signed-off-by: Deluan <deluan@navidrome.org>
 2025-11-12 16:19:18 -05:00
Deluan
b9f368ad0d refactor(scanner): streamline phase folder and album creation by removing unnecessary library parameter 
Signed-off-by: Deluan <deluan@navidrome.org>
 2025-11-12 16:19:18 -05:00
Deluan
fadaaf3ad1 refactor(scanner): simplify selective scan logic using slice.Filter 
Signed-off-by: Deluan <deluan@navidrome.org>
 2025-11-12 16:19:18 -05:00
Deluan
4386c3a876 test(folder_repository): add comprehensive tests for folder retrieval and child exclusion 
Signed-off-by: Deluan <deluan@navidrome.org>
 2025-11-12 16:19:18 -05:00
Deluan
eeb73d24f0 refactor(folder_repository): normalize target path handling by using filepath.Clean 
Signed-off-by: Deluan <deluan@navidrome.org>
 2025-11-12 16:19:18 -05:00
Deluan
bfa31a246f refactor(scanner): update scanner interface and implementations to use model.Scanner 
Signed-off-by: Deluan <deluan@navidrome.org>
 2025-11-12 16:19:18 -05:00
Deluan
ed781e8da0 refactor: move scanner types to model,implement MockScanner 
Signed-off-by: Deluan <deluan@navidrome.org>
 2025-11-12 16:19:18 -05:00
Deluan
54f19c598a refactor(scanner): move scanner.ScanTarget to model.ScanTarget 
Signed-off-by: Deluan <deluan@navidrome.org>
 2025-11-12 16:19:18 -05:00
Deluan
63c3a95814 test: enhance mockScanner for thread safety and improve test reliability 
Signed-off-by: Deluan <deluan@navidrome.org>
 2025-11-12 16:19:18 -05:00
Deluan
dec658c235 refactor(scanner): streamline scanning logic by removing scanAll method 
Signed-off-by: Deluan <deluan@navidrome.org>
 2025-11-12 16:19:18 -05:00
Deluan
7e396fd6ce refactor(scanner): update CallScan to handle specific library/folder pairs 
Signed-off-by: Deluan <deluan@navidrome.org>
 2025-11-12 16:19:18 -05:00
Deluan
265a6973bc feat(subsonic): allow selective scan in the /startScan endpoint 
Signed-off-by: Deluan <deluan@navidrome.org>
 2025-11-12 16:19:18 -05:00
Deluan
847cc92e88 feat(scanner): update folder scanning to include all descendants of specified folders 
Signed-off-by: Deluan <deluan@navidrome.org>
 2025-11-12 16:19:18 -05:00
Deluan
33704edc1c refactor(scanner): simplify GC method by removing library ID parameter 
Signed-off-by: Deluan <deluan@navidrome.org>
 2025-11-12 16:19:18 -05:00
Deluan
01f68f4a75 fix(scanner): validate library ID to prevent negative values 
Signed-off-by: Deluan <deluan@navidrome.org>
 2025-11-12 16:19:18 -05:00
Deluan
f64b51f161 refactor(scanner): enhance ScanTarget struct with String method for better target representation 
Signed-off-by: Deluan <deluan@navidrome.org>
 2025-11-12 16:19:18 -05:00
Deluan
b06d90a4db refactor(ignore_checker): rename scanner to lineScanner for clarity 
Signed-off-by: Deluan <deluan@navidrome.org>
 2025-11-12 16:19:18 -05:00
Deluan
0b06ecb034 refactor(scanner): implement IgnoreChecker for managing .ndignore patterns 
Signed-off-by: Deluan <deluan@navidrome.org>
 2025-11-12 16:19:18 -05:00
Deluan
3cbbb440c2 feat(watcher): implement path ignoring based on .ndignore patterns 
Signed-off-by: Deluan <deluan@navidrome.org>
 2025-11-12 16:19:18 -05:00
Deluan
b361837f50 refactor(watcher): add resolveFolderPath function for testability 
Signed-off-by: Deluan <deluan@navidrome.org>
 2025-11-12 16:19:18 -05:00
Deluan
1bd58a14ab feat(watcher): implement folder scanning notifications with deduplication 
Signed-off-by: Deluan <deluan@navidrome.org>
 2025-11-12 16:19:18 -05:00
Deluan
712bf2815e refactor(scanner): simplify scanner methods 
Signed-off-by: Deluan <deluan@navidrome.org>
 2025-11-12 16:19:18 -05:00
Deluan
1250647dc3 refactor(folder): enhance external scanner to support target-specific scanning 
Signed-off-by: Deluan <deluan@navidrome.org>
 2025-11-12 16:19:18 -05:00
Deluan
305148e124 refactor(folder): remove unused LibraryPath struct and update GC logging message 
Signed-off-by: Deluan <deluan@navidrome.org>
 2025-11-12 16:19:18 -05:00
Deluan
36a7040df3 test: update parseTargets test to handle folder names with spaces 
Signed-off-by: Deluan <deluan@navidrome.org>
 2025-11-12 16:19:18 -05:00
Deluan
f1dbd88024 feat(folder): replace GetByPaths with GetFolderUpdateInfo for improved folder updates retrieval 
Signed-off-by: Deluan <deluan@navidrome.org>
 2025-11-12 16:19:18 -05:00
Deluan
8f1a6116fe feat: Add selective folder scanning capability 
Implement targeted scanning of specific library/folder pairs without
full recursion. This enables efficient rescanning of individual folders
when changes are detected, significantly reducing scan time for large
libraries.

Key changes:
- Add ScanTarget struct and ScanFolders API to Scanner interface
- Implement CLI flag --targets for specifying libraryID:folderPath pairs
- Add FolderRepository.GetByPaths() for batch folder info retrieval
- Create loadSpecificFolders() for non-recursive directory loading
- Scope GC operations to affected libraries only (with TODO for full impl)
- Add comprehensive tests for selective scanning behavior

The selective scan:
- Only processes specified folders (no subdirectory recursion)
- Maintains library isolation
- Runs full maintenance pipeline scoped to affected libraries
- Supports both full and quick scan modes

Examples:
  navidrome scan --targets "1:Music/Rock,1:Music/Jazz"
  navidrome scan --full --targets "2:Classical"
 2025-11-12 16:19:18 -05:00
Deluan
f939ad84f3 fix(ui): increase contrast of button text in the Dark theme 
Signed-off-by: Deluan <deluan@navidrome.org>
 2025-11-12 16:17:41 -05:00
Deluan
c3e8c67116 feat(ui): update totalSize formatting to display two decimal places 
Signed-off-by: Deluan <deluan@navidrome.org>
 2025-11-12 13:23:18 -05:00