mirror of
https://github.com/navidrome/navidrome.git
synced 2026-08-31 07:30:32 +00:00
* test: unskip AbsolutePath and i18n path-separator tests on Windows (#5381) Signed-off-by: junkerderprovinz <jdp@braethoria.com> * test: unskip metadata folder-PID test on Windows via path.Dir (#5381) Signed-off-by: junkerderprovinz <jdp@braethoria.com> * test(storage): make relative-folder assertion cross-platform and unskip on Windows (#5381) Signed-off-by: junkerderprovinz <jdp@braethoria.com> * fix(persistence): normalize folder-update-info paths with forward slashes on Windows (#5381) Signed-off-by: junkerderprovinz <jdp@braethoria.com> * review: drop folder-PID change, trim storage_test comment (#5381) Revert model/metadata/persistent_ids.go to master: switching the `folder` PID attribute from filepath.Dir to path.Dir would change the persistent IDs of existing Windows libraries and needs a migration path, so it is out of scope for this PR. The matching test unskip is reverted with it, leaving #TBD-path-sep-metadata open in #5381. Trim the core/storage/storage_test.go comment to two lines. Signed-off-by: junkerderprovinz <jdp@braethoria.com> --------- Signed-off-by: junkerderprovinz <jdp@braethoria.com> Co-authored-by: Deluan Quintão <deluan@navidrome.org>
57 lines
1.4 KiB
Go
57 lines
1.4 KiB
Go
package core
|
|
|
|
import (
|
|
"context"
|
|
"path/filepath"
|
|
|
|
. "github.com/onsi/ginkgo/v2"
|
|
. "github.com/onsi/gomega"
|
|
|
|
"github.com/navidrome/navidrome/model"
|
|
"github.com/navidrome/navidrome/model/request"
|
|
"github.com/navidrome/navidrome/tests"
|
|
)
|
|
|
|
var _ = Describe("common.go", func() {
|
|
Describe("userName", func() {
|
|
It("returns the username from context", func() {
|
|
ctx := request.WithUser(context.Background(), model.User{UserName: "testuser"})
|
|
Expect(userName(ctx)).To(Equal("testuser"))
|
|
})
|
|
|
|
It("returns 'UNKNOWN' if no user in context", func() {
|
|
ctx := context.Background()
|
|
Expect(userName(ctx)).To(Equal("UNKNOWN"))
|
|
})
|
|
})
|
|
|
|
Describe("AbsolutePath", func() {
|
|
var (
|
|
ds *tests.MockDataStore
|
|
libId int
|
|
path string
|
|
)
|
|
|
|
BeforeEach(func() {
|
|
ds = &tests.MockDataStore{}
|
|
libId = 1
|
|
path = "music/file.mp3"
|
|
mockLib := &tests.MockLibraryRepo{}
|
|
mockLib.SetData(model.Libraries{{ID: libId, Path: "/library/root"}})
|
|
ds.MockedLibrary = mockLib
|
|
})
|
|
|
|
It("returns the absolute path when library exists", func() {
|
|
ctx := context.Background()
|
|
abs := AbsolutePath(ctx, ds, libId, path)
|
|
Expect(abs).To(Equal(filepath.FromSlash("/library/root/music/file.mp3")))
|
|
})
|
|
|
|
It("returns the original path if library not found", func() {
|
|
ctx := context.Background()
|
|
abs := AbsolutePath(ctx, ds, 999, path)
|
|
Expect(abs).To(Equal(path))
|
|
})
|
|
})
|
|
})
|