mirror of
https://github.com/navidrome/navidrome.git
synced 2026-11-19 15:23:36 +00:00
* fix(stream): cap DSD transcoded to lossless PCM at 88.2kHz DSD64 was sent as 352.8kHz FLAC/WAV, which many clients cannot play. Client and codec profile limits below 88.2kHz still apply. ffprobe already reports DSD at rate/8 with 8 bits per sample, so only rates read from tags are divided, and any DSD depth maps to 24-bit PCM. Probed files used to come out at 44.1kHz with a bit depth of 8. Fixes #6288 Co-authored-by: Olli Sulopuisto <1051255+ollisulopuisto@users.noreply.github.com> Signed-off-by: Junker der Provinz <133605895+junkerderprovinz@users.noreply.github.com> * fix(stream): let a client's sample rate limit replace the DSD cap The 88.2kHz cap on DSD transcoded to lossless PCM is meant for clients that say nothing about sample rates, like the legacy stream endpoint. Applied unconditionally, it also overrode clients that declared their own audioSamplerate limit: a client accepting up to 192kHz got 88.2kHz, and one accepting only 96kHz or 192kHz got no compatible profile at all. The cap now applies only when the client has no audioSamplerate limitation for the target codec. Otherwise the client's limit decides the rate. * refactor(stream): share the audio codec profile matcher Direct play checks, transcode limitations and the new DSD cap check each looped over the client's codec profiles with the same audio-type and codec alias filter. They now use one audioCodecProfiles iterator, so the DSD cap decision cannot drift from the limitations that are actually applied. targetSampleRate takes a single capDSD flag instead of two adjacent bools. * test(stream): table-drive the DSD to FLAC sample rate specs Six specs repeated the same DSD source and FLAC transcoding profile and differed only in the source rate, the client's codec profiles and the expected rate. A DescribeTable lists the cap policy case by case, and every entry now also checks the 24-bit depth. --------- Signed-off-by: Junker der Provinz <133605895+junkerderprovinz@users.noreply.github.com> Co-authored-by: Olli Sulopuisto <1051255+ollisulopuisto@users.noreply.github.com> Co-authored-by: Deluan Quintão <deluan@navidrome.org>