dd864905cd0a27a661e7e274c599672093755e34 bump bdk_electrum to latest commit (Michael Mallan)
Pull request description:
This bumps the bdk_electrum dependency to the latest commit of our "release/1.0.0-alpha.13" branch, which will enable the resolution of #1300.
ACKs for top commit:
edouardparis:
ACK dd864905cd0a27a661e7e274c599672093755e34
Tree-SHA512: 4a2fca7cd6084ae4772914c32f746e8d6946701dfd790c0aae62d7062071e6ab23557b240612f7b259ae95c78187098845ebb11c54b4cea1dd89d33eb8caec08
efba78844396ae9ccbf520f328783b44b367333e refactor: response has not succeed and add missing checks (Thomas Ballivet)
Pull request description:
This should resolves#1679
ACKs for top commit:
jp1ac4:
tACK efba78844396ae9ccbf520f328783b44b367333e.
Tree-SHA512: 69bc94c8a5528b941e7796b4cf53a7945de8b1bbfc76954f65dce410be059b601e6b31d70790e04dd02dc6dc13a17600a4cc878d64de8deb89ce343bff101ac6
52d6e03d75f35118adb919347950592d59dd628b flake.nix: devshells include toolchain (VzxPLnHqr)
Pull request description:
on x86_64-linux, this was necessary to get cargo into the path so as to be able to execute things like `cargo build ...`.
When trying to test out the latest release candidate from NixOS (x86_64-linux), running `nix develop` did not drop me into a devshell with cargo available. The fix here may not have been the best way to remedy that, but it did work, and then I was able to test the latest code by:
1. `nix develop` to get into the devshell
2. `cargo build --release`
3. `target/release/liana-gui --datadir ./test_alice`
ACKs for top commit:
edouardparis:
ACK 52d6e03d75f35118adb919347950592d59dd628b
Tree-SHA512: 2e2570e230e296d10a3b8be96c580afd91f6b135d0bc6a57c0d587cf7ad159d740769370cf6bcad9a0c551b65af12905d7e08b5fbc21989ac513b379e7e83c4c
546ac29587e831abbe79e66d23cac9683467a842 fix update wallet alias in wallet settings (edouardparis)
Pull request description:
L522 the wallet was populated with its new alias
and the check L567 was always false.
wallet_alias is None if we do not have to update it, so better pass the variable directly.
ACKs for top commit:
edouardparis:
Self-ACK 546ac29587e831abbe79e66d23cac9683467a842
Tree-SHA512: 971e441eb67cdc20aea7e2631bf74b568ce216e2a4d86a292d5f6d04bcfef37c3180c2df2510a150bc13ef605ab60bea40a8a7e8683f020b01f84aae9dd08098
L522 the wallet was populated with its new alias
and the check L567 was always false.
wallet_alias is None if we do not have to update it,
so better pass the variable directly.
53df4ed9692a62ddf8f9f0da27e0dbe7706510d7 CHANGELOG for v11 (Michael Mallan)
33a0e147b4f49c6f230c0e8234e4b01dded0d88d revert change to CHANGELOG (Michael Mallan)
Pull request description:
This adds the CHANGELOG for v11.
I also reverted an accidental change made recently.
ACKs for top commit:
edouardparis:
ACK 53df4ed9692a62ddf8f9f0da27e0dbe7706510d7
Tree-SHA512: 3c7517c3784dd02af31c2a7d8d8d12220638430d1e307b8f0135a3baf16d65b0e9b18f926b15892c4c21a538fda1a028dc866252733e966bd9315b7b44226242
874d2d406804b853e399800435bb0ee223d5d769 Make user finish sign process before opening new modal (edouardparis)
1d1a28195527cc04ce99969e5c85d2632402d73e Revert "gui: store SignModal state and allow to open export modal after signing in PSBT panel" (edouardparis)
Pull request description:
This Pr is to mitigate three issues:
close#1719close#1685
and try to prevent a little bit the problem of impossible cancellation of the signing Task by disabling any other buttons and making aware of the user that he has to finish it (reject of approve).
Sadly it is not the case for the sidebar menu button, so if user start the signing process and quit by switching panel, he may still have the problem of the signing task blocking in the background and may be surprised by the impossibility of iced to close properly.
Proper signing task cancellation will require a change in the async-hwi library: https://github.com/wizardsardine/async-hwi/issues/108
ACKs for top commit:
pythcoiner:
tACK 874d2d40, it fixes back #1681
jp1ac4:
tACK 874d2d406804b853e399800435bb0ee223d5d769.
Tree-SHA512: bb25dcc086787cf491ca11359db756ef19508f1518d600d7091b0cb14422d9148ae3ee1f3ed47aa5dc642d7089152b7b36e1746be7dbe94d22bab71f2899645b
78a261da5a5e92f3589403760858105026e6278d show partial address in collapsed view (Michael Mallan)
Pull request description:
To avoid the need for a scrollbar when showing previous addresses in the collapsed view, we will now show the first and last 16 characters only.
ACKs for top commit:
edouardparis:
utACK 78a261da5a5e92f3589403760858105026e6278d
Tree-SHA512: ca7282e47de3b828a8f8746f710a30650992499b785e5bb766c80ffafb83aa872dc63b5f1d85c2f1394a5eb4c018a2c4feeb772f8bafde021e81f5294811780c
aa417be12781f995854dc2f4fc49da85d23569f2 gui: add parsing for xpub from coldcard format (pythcoiner)
Pull request description:
this PR implement parsing Xpub from files exported from a coldcard via `Advanced/Tools` => `Export Wallet` => `Generic JSON`
ACKs for top commit:
edouardparis:
utACK aa417be12781f995854dc2f4fc49da85d23569f2
Tree-SHA512: eca22295926522ba199a3c0ace0adb52ee236a6a6b0fbd9ba52ba18cbbbbb4032ef3ef06dfd493fddd83e17ac0fbba84612bd73a3e0c1142783e30b60b781ff9
250ba8bb45d8b883772fe5e49e7b48f2a827306b Apply backup alias in installer import backup step (edouardparis)
317ad0a70e3fd0b36e41a142003cb056e78c164d Add default value to installer wallet alias step (edouardparis)
Pull request description:
- We add a default wallet alias if not value is set in the installer context.
- We add the wallet alias field to the backup file.
- While importing a backup in the installer, the backup wallet alias will be suggested to the user at the final step.
- While importing a backup in the wallet settings for an already installed wallet, we keep the current wallet alias and not override it by the backup one.
ACKs for top commit:
jp1ac4:
tACK 250ba8bb45d8b883772fe5e49e7b48f2a827306b.
Tree-SHA512: ba26ba43b33159424813cf9eb1d1bd491cb148ec2ff3286b58ff7ef7a0060a02f8acc60dba8f89e06e657cc61cfecdecb271b7cce2a1d3b0ea85fbb9f3ca5339
ce8e1f3c3eed5a6e991307f8740e54cb0680e5bc installer: let user choose account (derivation path) before fetching an xpub from signing device (pythcoiner)
8efc55bcf5a314997ac4b2a1de9a0a587fb7c9fe ui: add a widget to let user select custom derivation path of an xpub (pythcoiner)
Pull request description:
This PR closes#1700.
ACKs for top commit:
jp1ac4:
tACK ce8e1f3c3eed5a6e991307f8740e54cb0680e5bc.
edouardparis:
ACK ce8e1f3c3eed5a6e991307f8740e54cb0680e5bc
Tree-SHA512: a24ebe58da30b81767d67e4da587299a6942f1a62ec0ccd02fd52b06cbe33dca3e27c9e6ab713f141cad84208a200ebbb21f988180862c4909d6080262ef5fea
654be987f2da61ed47310c3d30720126b64aa292 fix settings: missing update_aliases for backup restore (edouardparis)
Pull request description:
While restoring a backup at the import/export panel, the message to update the wallet keys aliases was not handled and although the aliases are stored in the settings file, the wallet was not "reloaded" through the Message::WalletUpdated result. The consequence was while opening the wallet section, users found the aliases not updated by the backup (even if the file was updated).
The change in the update_aliases is to update the wallet alias only if the function require the change by passing
`Some(alias)` in arg.
ACKs for top commit:
jp1ac4:
utACK 654be987f2da61ed47310c3d30720126b64aa292.
Tree-SHA512: eabaeb48f6167365373a1839ca317879c1314d79c687d0648cae1d001ee125c364ad10a411c3392be4f001fbfb2cf85be63371e0cc36f8351066c832adfe9789
01ceb237f8446a31653bc294142a3a1397128373 fix: use scrollbar for node settings (Michael Mallan)
Pull request description:
This fixes an issue when viewing a long node setting value, such as the cookie path, on a reduced window size.
ACKs for top commit:
edouardparis:
utACK 01ceb237f8446a31653bc294142a3a1397128373
Tree-SHA512: f81b70df5c20d7339bdcd2e480dfbfb8e9381859ecc64338e32873dea11f8159b2d59c97d947bf2003aff38cebcabca50763f7d7a988a153b14c17d237f8e9a2
904fc728de20cdd283a4273093e6b59c5609630c fix import backup for existing wallet (edouardparis)
Pull request description:
We pass the wallet to the import_backup method
so the wallet id is used to find the correct wallet settings to update in the settings file.
ACKs for top commit:
jp1ac4:
utACK 904fc728de20cdd283a4273093e6b59c5609630c.
Tree-SHA512: 0a2a6c77d333460cc06ad141a7685d88911bc40bc3cd221111dd6611ca45e8c5552f46f7a694e44f0b47b4a5c1cd6946e25c755de83cbfe6259de93d6b9b65e0
7281e6352967009419a493ccd3825887001afa14 gui: store SignModal state and allow to open export modal after signing in PSBT panel (pythcoiner)
Pull request description:
This PR fixes#1681:
- `PsbtState::modal` was not properly reset after signing modal closed
- When `PsbtState::modal` is of type `SignModal` we store it's state, else we lost track of which key already signed.
- `SignModal::display_modal` is not useful anymore, as we store the modal state, and only "hidding" the modal not let display another modal (export modal for instance)
ACKs for top commit:
jp1ac4:
tACK 7281e6352967009419a493ccd3825887001afa14.
Tree-SHA512: 6627c1f788048349fee2fd9f6fc1a9044da03c9b6ac61339b19c5ae503cb0d522501ce4438f70359906231c06928c8756b52715901898c56fa58dd7da5194cdc
a9917d17810b3d47c0bd5623ffa7636e2f299c72 Add wallet alias step to installer (edouardparis)
51d913b9efff2ec360190fc75e0013d691dd8d7e Set wallet alias in settings if liana-connect wallet alias changed (edouardparis)
36fb3d877552099ef7fbdce21753352a1c4219df Add wallet alias in window title (edouardparis)
381421038b0e12ed257679b31a16102021d6d76a Add wallet alias to settings (edouardparis)
Pull request description:
We had a new `wallet_alias` to settings file.
This field is displayed in the launcher when wallets are listed and in the window title when the app is running the wallet.
The field is also store in liana-connect wallet.metadata field to facilitate import of wallet from Liana-Connect.
If the field was modified on Liana-Connect, then next time the user open the wallet in the gui, the settings field is updated.
User can modify the wallet alias in the Settings > Wallet section.
ACKs for top commit:
edouardparis:
Self-ACK a9917d17810b3d47c0bd5623ffa7636e2f299c72
Tree-SHA512: 819fb84660894a8c546132a21966c8084b4820b4cb7f57c9de80648355ebf053581964dea8e8fe455523e0c7692244fc0803e8dec03d50946139ed88832622f7
74087c37cf0b0796e794f98bebb11167ca243969 refactor: map fingerprint only once (Thomas Ballivet)
86c4896534c1ac169a3352651b0e27170e8cb06f Disable signing devices that are not related to the actual spending path (Thomas Ballivet)
Pull request description:
Inspired by #1607 this shoud closes#1041.
Notice that I added the wanted logic also for the recovery spending. That means you can only select a signing device related to the primary path for usual spend. But for recovery spending you can only select a signing device related to the recovery_path.
You can see here both examples :
ACKs for top commit:
jp1ac4:
tACK 74087c37cf0b0796e794f98bebb11167ca243969.
Tree-SHA512: 93e452ca9f56e214f308cbaf3cdc9ffb52301e64fded860d1a961e97df21270e18f994cef83358459981ddc3029c89183d23bc33bab863253cfa2a2c5a9d9554
78a2defb6c08ef19cc249da7415fac873d32e20f docs: add a link to SIGNING_DEVICES.md in USAGE.md instead having a duplicate of supported devices (pythcoiner)
Pull request description:
replacing list of supported devices by a link to SIGNING_DEVICES.md to avoid maintenance burden
fixes#1690
ACKs for top commit:
nondiremanuel:
ACK [78a2def](78a2defb6c)
Tree-SHA512: 83cae2da1865a55415c064a12c1fcac956827fbc910f19ad544fac90540bf4965ee414975bfd0bae781bd82eec606aa37bf2b290717751a419bece8689a69bd1
