59c12cd5844e19f296066465fd34a3be48e26f2e installer: wait process is done before next step (edouard)
0577b971b77c0691f0dbb948956eb7616c4c8614 installer: add progress information (edouard)
0365794f910833e400f2418e52b6259f3ccb9b22 installer: add final step summary (edouard)
437faef1af01d9952f5ed3156ce38d9964ba5efb Add learn more collapse to installer (edouard)
8348ad1afadc2e46994b364d595491cc327d4961 installer: add backup descriptor step (edouard)
b260ac420819cb41f8740fa12f65b3a79d69eed3 installer: keep refresh button to list hws (edouard)
92699c645b38f97bfcde35d30b83981335285bdf installer: create or import wallet (edouard)
c89b8d88f59f4dec556d083b6f39c8263279741c installer: rename network pick_list (edouard)
Pull request description:
base on #129
ACKs for top commit:
edouardparis:
Self-ACK 59c12cd5844e19f296066465fd34a3be48e26f2e
Tree-SHA512: d8016b353b54a744ab69c4d7278f4c04aab18326d97293b1b145bb5c3a46633c4ebbc4ccd3291e88fb508f02d44137d82f88218ce936b4a221335b16be879ff6
5721ab0fdeb5927b4a53a90d4820e30d3dcfea6a qa: test spent coins are always marked as such (Antoine Poinsot)
478707df27f411c1ca983def07b6f804369a6e82 bitcoind: detect coins as spent even if they are unconfirmed (Antoine Poinsot)
8e7e46a52c74fbd2c14f3647e5395c5737153fb1 bitcoind: detect spent coins for send-to-self transactions (Antoine Poinsot)
Pull request description:
There were a couple cases in which we would not detect a coin as spent:
1. If the deposit transaction was still unconfirmed
2. If the spend transaction did not contain any external output
This comes with a functional test that will fail on master. It tests both above cases as well as many other.
Fixes#125
ACKs for top commit:
edouardparis:
utACK 5721ab0fdeb5927b4a53a90d4820e30d3dcfea6a
Tree-SHA512: b05d3c3f7f4e9810346e5a86d4d789ab3dc2e1b5d6595e59bf140cb1c6d9c823ac3974ec89f1107e21e45711a8fe3e56dc20b9d094c965c92bb5640297baeea9
7e96cdd4949c15723ce1a150a1cc02dd5a402622 Add transaction history to home panel (edouard)
Pull request description:
ACKs for top commit:
edouardparis:
Self-ACK 7e96cdd4949c15723ce1a150a1cc02dd5a402622
Tree-SHA512: 98802d141073683ee09efe9e79ad28f9daba2145fdddf395c1b1758dc5f1c5763b483e1ca3d8ff35ce508138cf23989d8d3ed30c7d5044d311614b9fbe476b00
b4f6bbd8ffa722c48725fc724ca6cb1a4cf0b116 Add a README, finally. (Antoine Poinsot)
2663d970c77c7c13da8f39c3059123ef231b1787 Add a CONTRIBUTING.md (Antoine Poinsot)
f5ff0fad362a20d97d4ccc7fc5926bbfab50ec3a daemon: 'revaultd' name usage leftovers (Antoine Poinsot)
Pull request description:
Starting the documentation effort with those two main files. I'll address both a dedicated document about building the software and another dedicated document about recovering from descriptor backup in a follow-up.
ACKs for top commit:
darosior:
self-ACK b4f6bbd8ffa722c48725fc724ca6cb1a4cf0b116
Tree-SHA512: 58172527d6c09b718f9b15989fe976ceb4c20192bd8dfc7ee2cc9c683f8add19ef184869e1ab285c3d025b5ed6d69c6e9f3eaf5fc3f8e9a29ba632c0e3cae2d9
ee466798bd30fe9de0bc0f447b5a2ebe32b4ade1 gui: change project and crate name for liana (edouard)
Pull request description:
close#98
ACKs for top commit:
edouardparis:
Self-ACK ee466798bd30fe9de0bc0f447b5a2ebe32b4ade1
Tree-SHA512: 904c56b212821ef4d3d735f2cfd240b4ac5d3b1887a1335014dc007d438f84c6de04a1d2f3ef2abb579a473a210ee4b1606dbbc7175faf0a96e78f7896b18add
968a7d17a02bc776c38274fc9e61235163c22442 daemon: rename Minisafe to Liana (Antoine Poinsot)
Pull request description:
We decided on a new name for this project. Farewell Minisafe, "not a Bitcoin vault".
To avoid conflicts with ongoing work in the GUI i have only made the change on the daemon for now.
Fixes#91
ACKs for top commit:
edouardparis:
utACK 968a7d17a02bc776c38274fc9e61235163c22442
Tree-SHA512: e0d9324423b650bf4c8ec3084fb0002b2eb9b29e028f6f7c7be2062c10cc8ea3a2c3186689700495a0bfbd5c7cb75b549fffa06604bdd182c589aad3bbf61e0d
4bd65213e2561453f7c1fee16acccdd128296406 commands: swap the outpoints and destinations arguments to createspend (Antoine Poinsot)
838daa0c93ad72adde9b5c502796f87571fb5efd commands: set the BIP32 derivation in PSBT for change outputs (Antoine Poinsot)
dbf17681a432791f58ef4cdbb3fb2ebfa4ba0742 commands: signal for opt-in RBF in Spend transactions (Antoine Poinsot)
Pull request description:
It was missing a few things, see the linked issues for details.
Fixes#90.
Fixes#76.
Fixes#33.
ACKs for top commit:
darosior:
self-ACK 4bd65213e2561453f7c1fee16acccdd128296406
Tree-SHA512: f7122d48afa764b68993df7e66043900408ec64aa9181a87495168476d424a19dbf6adac3885df7a0d0865f0c47b17faea246f4abcbd7c908baf26fc8d0d6269
The outpoints argument could eventually be made optional in order to
introduce some automated coin selection. So it makes more sense for it
to be after a required parameter, the destinations.
94d8ea6d600479d00e08992aaf153e136e5198fa qa: test "next derivation index" update from onchain usage (Antoine Poinsot)
b31673de327bc968c4046267ef5d0433b80ddd7e poller: update our internal derivation index also from the chain (Antoine Poinsot)
42d2ffeec12edb22a789d92d8f83c8b535fc0477 db: more flexible interface for updating our next derivation indexes. (Antoine Poinsot)
Pull request description:
Currently, we wouldn't update our "next derivation index" to derive receive/change addresses if we noticed an address from a higher derivation index was used onchain. See #81. This fixes it.
Note that it can be tempting to set it with some leeway (for instance if we notice index `n` was used, we set our next derivation index to `n + 10`) since other wallets probably have generated addresses for more addresses than were actually used onchain.
However, i think it could have cascading effects in a multisig situation: A would use `n`, B would set its to `n + 10` and use `n + 11`, C would set its to `n + 21` and use `n + 22`. This is clear that we could end up very far indeed down the derivation tree without having used most indexes.
A functional test is included, demonstrating the behaviour after a rescan where we lost the database (and therefore knowledge of the previous "next derivation index"). It is in a separate commit to help reviewers attest it would fail on master and pass on this branch.
ACKs for top commit:
darosior:
self-ACK 94d8ea6d600479d00e08992aaf153e136e5198fa
Tree-SHA512: 67a44ac28dae391c23dd5143e9d560678e1928eddbfd2fc7ed721e02227151a8ea9571a867b6dd0e93f25ebe59adbdf846a8851c63a89144a818de870723b5da
