9b154c79681a0714951092069e68dd32f527a789 fix loader: do not start bitcoind if one is running (edouard)
Pull request description:
ACKs for top commit:
edouardparis:
Self-ACK 9b154c79681a0714951092069e68dd32f527a789
Tree-SHA512: 13831a16d872f4fe3a83bad7bf1f0ab92e8fb32cae74b067eadd7608adf36f491e8e13572bf323927d6c537c57e77069f0fd2c9385b141d9b1cf00f5e02a538c
Installer will install bitcoind in a directory
that will have always the same relative path to
the liana datadir.
GUI needs then only a flag "start_internal_bitcoind" set to true
to check the conventional path of the downloaded bitcoind exe
and start the internal bitcoind
9685920102b6f8340aeec5493b07e55ae9628398 tests: fix a small race in the rescan_and_recover test (Antoine Poinsot)
Pull request description:
ACKs for top commit:
darosior:
self-ACK 9685920102b6f8340aeec5493b07e55ae9628398 -- trivial, tested locally by running many instances of the test in parallel
Tree-SHA512: b384eeac6eba7416a9316b271c4ace26d933f9bfb85a6f4cc59133937cafda0baa9086926fad8ba8c262a1edaf3479b1a6db190da339fd8ff78820aa46b90656
6d8c9e437f6cc36d479f4be33779834b2180507d gui: forbid edit bitcoind client config if internal (edouard)
bfe73fad18ef3980af5821b6c899e6f3b7ac1918 Add bitcoind logs to loader (edouard)
4c4efebe5bc6560a82bfc4f348ed2663e726a66d gui: encapsulate bitcoind process management (edouard)
d4cf9e3466c40ae74a8099eb4b7b59474ccf2936 fix: move structs next to their methods (edouard)
c756969e7293585471cef64ae4bbe8f203c4866c cleanup bitcoind module dep to app config (edouard)
Pull request description:
- Small rearrangements of the bitcoind module.
- Add a wrapper around the bitcoind child process and share it to the states:
Installer -> loader -> app
- It makes it more easy to share the information if the gui started a bitcoind process, no need anymore to check multiple configuration files, just answer the question: do we have a child process started ?
ACKs for top commit:
darosior:
ACK 6d8c9e437f6cc36d479f4be33779834b2180507d
Tree-SHA512: dd3612d40d15ebde094150abc1cfbf4a54dd1f517fbdeed51934280b0b36e4a4871d3bfe9f5b98617746b042352a570b4be237c3a2b71f74bb636ece4a027208
To know and manage the fact that gui or installer
started a bitcoind sub process, the process child
is wrapped and passed by the different state of the app.
bf67f94f56d6ae28973c27f0a8999ecd1eab7398 installer: download and install bitcoind (jp1ac4)
d507d5760ac051cf264c95b4fdef9ced27dde9cd gui: add subscription to Step trait (jp1ac4)
ae23fbc81ddc903183ce971afa5597f95e26b82a gui: add download module (jp1ac4)
b3bc9435ceccf40cca0f8be1c107e9bbf9d3bb9e gui: add dependencies to download and install bitcoind (jp1ac4)
Pull request description:
This is a follow-up PR to #592 as part of #570 to download and install bitcoind.
I'm creating this draft PR now to facilitate discussion. Once #592 has been merged, I'll rebase on master.
ACKs for top commit:
darosior:
ACK bf67f94f56d6ae28973c27f0a8999ecd1eab7398 -- modulo a few changes we'll address in follow-ups. I've not reviewed the code but significantly tested it on both Windows and Linux.
edouardparis:
ACK bf67f94f56d6ae28973c27f0a8999ecd1eab7398
Tree-SHA512: bda4b8bfbb3a59917d9ea60c074c2b0021229213240bebc4bd176f9909c62ab323d0a8d4becffbac192f29fad92adb81b2da0bc9b37c8eea1654c26ec6699077
5680ad27ecce8409d582ebf834bdecb3650b9233 lib: on Windows, migrate the watchonly wallet from bitcoind datadir (Antoine Poinsot)
c9d86f1c75be693e796591be9f1f468687728600 lib: implement a superior workaround for the watchonly wallet on Windows (Antoine Poinsot)
Pull request description:
See the added comment for the details. No need to store the watchonly wallet under bitcoind's datadir anymore. 🎉🎉
I've noticed this while working on fixing #630 on Windows which failed for the same root reason as why the watchonly wallet path didn't work on Windows.
Fixes#653.
ACKs for top commit:
darosior:
ACK 5680ad27ecce8409d582ebf834bdecb3650b9233 -- tested it on Windows
edouardparis:
utACK 5680ad27ecce8409d582ebf834bdecb3650b9233
Tree-SHA512: 52158340097e286d882e6503d8bc1fbd4653729c08055cd2609a120aabc409ed38cbd40c7cb0c3a6cb9c67f163f8084fd886daa979e56ccf6223eb51773500ef
We used to store it there, if it's not within our own datadir copy it
from where it would have been stored by Liana v1.
Note we don't conditionally compile this on Windows so the codepath can
be tested with a functional test.
34f3946fc814bf5c915be131dd3092b21f4f48e1 lib: windows: don't unload the wo wallet if not loaded (Antoine Poinsot)
Pull request description:
ACKs for top commit:
darosior:
self-ACK 34f3946fc814bf5c915be131dd3092b21f4f48e1
Tree-SHA512: ef7b5a15ecc18b7ee2ecb286569742f6adf10e0487f94787cc8fc1842516b5d9e969f8cda76ac51897c3c934ed3357c89ac1eae2bc03512a69e832e998ef99ea
3250d8dc879f48959ae1827e2b0057361e1feef2 gui: adapt to latest change in lianad API (Antoine Poinsot)
Pull request description:
ACKs for top commit:
darosior:
self-ACK 3250d8d
Tree-SHA512: 7c66870dadd125c0159c12cbd9f1b1ec82d6a797fcfa811d53cd4c134cc70ac5bd12f95f58a1c81c3e4c89cd89ba6e18c4456d784c2a9861ebaad79eccc5aaf3
9255b5ed941f04e56de4f32251fbe9b3d692baaa bitcoind: use the node client to make node requests (Antoine Poinsot)
Pull request description:
Props to Kevin for finding this rather significant bug. We should really be catching this type of bugs with code review..
ACKs for top commit:
darosior:
Ironical self-ACK 9255b5ed941f04e56de4f32251fbe9b3d692baaa
Tree-SHA512: da7b54e73201ce7f6003b7c939a576a33f6b3ea7234370b976dc9a6525cb3a18a10d160d60932b44e445fbb6057d07efde283fcfad1974c6734b5b4d2d0868de
bc35cdaad8e18b0942b68de1d3a054232b2f0db1 installer: move bitcoind steps to own module (jp1ac4)
Pull request description:
This was originally part of #630, but will be easier to see changes by moving to its own PR.
It simply moves bitcoind-related content of `step/mod.rs` to its own module.
ACKs for top commit:
darosior:
ACK bc35cdaad8e18b0942b68de1d3a054232b2f0db1 -- move-only + adapting includes
Tree-SHA512: f3526c7d1d5325f1057f77dac9197d3548a796d860f8612577016138ac47dfab1f8a04b4063e74b69b337c6202999adfecb30c4a7e139e1419416a6906084b33
5c87937d4676354f19357e17b36655eb4853dbf9 Add more bitcoind-related setup logging (Antoine Poinsot)
Pull request description:
At startup it sometimes appear we may be hanging when setting up bitcoind. Add more logging to give more information about what's taking long to setup (for instance, loading the watchonly wallet).
Related to https://github.com/wizardsardine/liana/issues/475.
ACKs for top commit:
darosior:
ACK 5c87937d4676354f19357e17b36655eb4853dbf9
Tree-SHA512: 75c553cabf545d57a5fc2d251e5b4cd880a931a408c6f1b1052067f2ccc8e0728ad779f30de5a88c2566f9e67ac085b713393ee4fa193331e49c3a8e6112ecc8
b5b96b95937ef914aed237b7829a71ff3672c3f4 README: mention the guide on recovering a backup on Core (Antoine Poinsot)
8c7c7a71353a6054f80eeb5ce4be0f946cec89a5 doc: polish the Bitcoin Core recovery document (Antoine Poinsot)
Pull request description:
ACKs for top commit:
darosior:
self-ACK b5b96b95937ef914aed237b7829a71ff3672c3f4 -- it's only doc
Tree-SHA512: b51b8e0f2eac896872ca2380cf0e3f8b4e6e518232e5cbc57dbeaaa517c56dfadfa6d6165a27704ecfda0ffe6bdf5a683e1cfd15b94dedcd8480c3c58865ed51
fcfad2de348a7d8b362631cf787599c284242aad import descriptor w/o replacing hardened identifier (pythcoiner)
eb1e0131222893981ce58965881c62c847d54372 recover walkthrough (pythcoiner)
Pull request description:
xref #375
ACKs for top commit:
darosior:
ACK fcfad2de348a7d8b362631cf787599c284242aad. I'll have a second pass for the syntax and expliciting a couple things. Thanks!
Tree-SHA512: c2713d0db8240b844c3a4cf3d97044a5846bba903c1209f08ce903475525d5145b9555fa693eed326e3d4a8e85577922adfb366664ec162303cb0bf3a4aae2a0
