eebd0619812f5d70acab53bfb30e12094225a0b7 bitcoin: remove a confusing TODO (Antoine Poinsot)
Pull request description:
We don't assume that and in fact now use multiple descriptors
ACKs for top commit:
darosior:
self-ACK eebd0619812f5d70acab53bfb30e12094225a0b7 -- only removing a comment
Tree-SHA512: 995ab3671dd580d700663630b2a01d186df3c1cd84038873df5c6ee0232a0a943e3fae9873798e5fadb219a3146a2b7d335bd50296c90bc815c2b69bbba976f7
ebf5a294ad5eeb9359625e941013809f5544672b gui: fix some clippy warning (Antoine Poinsot)
cf3e9cafe05d703637e09220351113d7be4458e4 ci: run clippy using Rust 1.67.1 (Antoine Poinsot)
896575842119a5e2779309edea4f9b4141126825 bitcoind: fix a clippy warning about lifetime ellision (Antoine Poinsot)
Pull request description:
FIx clippy lints and bump the clippy version for the daemon. Also fix some lints for the GUI (there are some false positives that couldn't be fixed though).
ACKs for top commit:
darosior:
self-ACK ebf5a294ad5eeb9359625e941013809f5544672b -- trivial
Tree-SHA512: 3fccbce67637d417da1758584f1d4f027e1536054b21c7abafc2e6b70e65901abb373a1ffc7fc7efbbbdf5c504ccde9df75e477d72ecd46a8b7798ce7985f64d
9577e6a227a85aa3a2f337a52b0f2904ed836bdf gui: make daemon config optional (edouard)
Pull request description:
If no daemon config path is present in the
gui configuration file, gui will try first to connect
to the socket path, either `daemon_rpc_path`
if present in configuration file or default
path.
close#147
ACKs for top commit:
edouardparis:
Self-ACK 9577e6a227a85aa3a2f337a52b0f2904ed836bdf
Tree-SHA512: 85e95dc3e4d5c0e4642cd75387fffd17ddd23e14459644238fed82cb8477bee27ae4e1f603d3dd2a7615ec8e397d9f50e2239a9c1ced49892cb02bd8cc5f748b
If no daemon config path is present in the
gui config, gui will try first to connect
to the socket pat, either `daemon_rpc_path`
if present in configuration file or default
path.
close#147
A solution to keep it only for debug was
not found for now with tracing, but it could
be easily fixed if ledger_transport_hid use
debug instead of info as log level.
Installer has its own log file installer.log that is removed
after successful install.
When changing network, the destination log file change
to <datadir>/<network>/liana-gui.log
12050a3cc58cfeceab10b0a2689ff8a504a7f144 add link to TRY.md for dependencies (cc1)
Pull request description:
I got few errors while building liana-gui with Ubuntu Mate 22.10, then try on a fresh install with ubuntu 22.04 server (minimal install):
```
running: "cmake" "/home/pythcoiner/.cargo/registry/src/github.com-1ecc6299db9ec823/freetype-sys-0.13.1/freetype2" "-DWITH_BZip2=OFF" "-DWITH_HarfBuzz=OFF" "-DWITH_PNG=OFF" "-DWITH_ZLIB=OFF" "-DCMAKE_INSTALL_PREFIX=/home/pythcoiner/liana/gui/target/release/build/freetype-sys-952a2cbdb10ff868/out" "-DCMAKE_C_FLAGS= -ffunction-sections -fdata-sections -fPIC -m64" "-DCMAKE_C_COMPILER=/usr/bin/cc" "-DCMAKE_CXX_FLAGS= -ffunction-sections -fdata-sections -fPIC -m64" "-DCMAKE_CXX_COMPILER=c++" "-DCMAKE_ASM_FLAGS= -ffunction-sections -fdata-sections -fPIC -m64" "-DCMAKE_ASM_COMPILER=/usr/bin/cc" "-DCMAKE_BUILD_TYPE=Release"
--- stderr
thread 'main' panicked at '
failed to execute command: No such file or directory (os error 2)
is `cmake` not installed?
build script failed, must exit now', /home/pythcoiner/.cargo/registry/src/github.com-1ecc6299db9ec823/cmake-0.1.49/src/lib.rs:1104:5
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
warning: build failed, waiting for other jobs to finish...
```
fixed by
```
sudo apt install cmake.
```
then:
```
--- stderr
CMake Deprecation Warning at CMakeLists.txt:78 (cmake_minimum_required):
Compatibility with CMake < 2.8.12 will be removed from a future version of
CMake.
Update the VERSION argument <min> value or use a ...<max> suffix to tell
CMake that the project does not need compatibility with older versions.
CMake Error at CMakeLists.txt:119 (project):
The CMAKE_CXX_COMPILER:
c++
is not a full path and was not found in the PATH.
Tell CMake where to find the compiler by setting either the environment
variable "CXX" or the CMake cache entry CMAKE_CXX_COMPILER to the full path
to the compiler, or to the compiler name if it is in the PATH.
thread 'main' panicked at '
command did not execute successfully, got: exit status: 1
build script failed, must exit now', /home/pythcoiner/.cargo/registry/src/github.com-1ecc6299db9ec823/cmake-0.1.49/src/lib.rs:1104:5
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
warning: build failed, waiting for other jobs to finish...
```
fix by:
```
sudo apt install build-essential
```
then:
```
--- stderr
thread 'main' panicked at 'Could not run `"pkg-config" "--libs" "--cflags" "fontconfig" "fontconfig >= 2.11.1"`
The pkg-config command could not be found.
Most likely, you need to install a pkg-config package for your OS.
Try `apt install pkg-config`, or `yum install pkg-config`,
or `pkg install pkg-config` depending on your distribution.
If you've already installed it, ensure the pkg-config command is one of the
directories in the PATH environment variable.
If you did not expect this build to link to a pre-installed system library,
then check documentation of the servo-fontconfig-sys crate for an option to
build the library from source, or disable features or dependencies
that require pkg-config.', /home/pythcoiner/.cargo/registry/src/github.com-1ecc6299db9ec823/servo-fontconfig-sys-5.1.0/build.rs:34:17
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
warning: build failed, waiting for other jobs to finish...
```
fix by:
```
sudo apt install libfontconfig1-dev
```
then:
```
--- stderr
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: "`\"pkg-config\" \"--libs\" \"--cflags\" \"libudev\"` did not exit successfully: exit status: 1\nerror: could not find system library 'libudev' required by the 'libudev-sys' crate\n\n--- stderr\nPackage libudev was not found in the pkg-config search path.\nPerhaps you should add the directory containing `libudev.pc'\nto the PKG_CONFIG_PATH environment variable\nNo package 'libudev' found\n"', /home/pythcoiner/.cargo/registry/src/github.com-1ecc6299db9ec823/libudev-sys-0.1.4/build.rs:38:41
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
warning: build failed, waiting for other jobs to finish...
```
fix by:
```
sudo apt install librust-libudev-dev
```
ACKs for top commit:
darosior:
Thanks! ACK 12050a3
Tree-SHA512: 547768c2b71e4cfa23ce7681f0420bb19e57a8bf4ac2e3a05ad1eb415c4e2935fb32afd1363bb74a3736938d23fdbdae108d058aaa83a72a67d434b9fe7a686a
bf02236239e4977bb30e56fb85fd63efc5145e10 Update TRY.md: Resolve dead link (MarcoFalke)
Pull request description:
ACKs for top commit:
darosior:
ACK bf02236239e4977bb30e56fb85fd63efc5145e10
Tree-SHA512: 80b7af1d71bcef02a14270e04614418948abc410b55dcdde8b91283d4738dec58b0d112bcd628c57350c549db94c424e17db89c8ea94e756db0456ba6c1567a0
8b990a86efb426a33dc09df0f4d57517e803aace doc: some tiny additions to TRY.md (Antoine Poinsot)
Pull request description:
After feedback from Kevin
ACKs for top commit:
darosior:
self-ACK 8b990a86efb426a33dc09df0f4d57517e803aace -- just some doc.
Tree-SHA512: e63c3beb2ab7c925a02dfade8f85379d504080af09671bff77f71fdbb73003e88bae1e99bf86720fe5ce8cf7124d4e09c467d4f081dfb21203507f49f8002577
d24dc06d964bd89f491e483b0d0d3fc15541e03e doc: adapt the try-out guide to non-Linux platforms (Antoine Poinsot)
25760e88b4dc545ad79c29e9c1c45f760e260c7b README: various fixes, especially regarding hot keys now available (Antoine Poinsot)
c66eb430a863153229521f1897e6931a72e694bc doc: update the TRY.md tutorial to use hot keys (Antoine Poinsot)
1449c4865e02f34b72215c886cf4e1a7f0c6ca58 README: update the introduction with the current state of development (Antoine Poinsot)
46a4da38f80d65c3f38f9cdd256b9a82840cc8e1 gui: update Liana to 0.3 and release 0.3 (Antoine Poinsot)
Pull request description:
ACKs for top commit:
darosior:
self-ACK d24dc06d964bd89f491e483b0d0d3fc15541e03e -- mostly documentation
Tree-SHA512: 41692c5b2e0fcfe10313bef04280e5b1338e8efd3339980a6b0cb1bb78bba41adf18b8b6b4d216e5699077eda094b295e47343d2f6497dc286e9d2e3424b06cc
8c11197b3111b1be5809b0f7515f81cb99db7188 installer: use DescriptorMultiXKey without wildcard (edouard)
Pull request description:
close#350
ACKs for top commit:
edouardparis:
Self-ACK 8c11197b3111b1be5809b0f7515f81cb99db7188
Tree-SHA512: 7e91e64fa364daf402961680db574511c1ce604dc2507a08f1fbf69f6a1fb9d3393dc2623a914573e49091b22f4c7cd87a032645ae18675c842a17e1569b2d4d
518eb91064ac4120792b71cec8f52eb26e359b89 commands: print the PSBT in base64 on sanity checks failure (Antoine Poinsot)
6e1c41238faaca0b6cf7e4131885ec2588d2137c commands: have a detailed error for the insane fee sanity check (Antoine Poinsot)
c711c5b696b7c8353da29b3c451bf2ca00e8daa8 commands: don't overestimate the feerate in tx creation sanity checks (Antoine Poinsot)
Pull request description:
Fixes#343
ACKs for top commit:
edouardparis:
utACK 518eb91064ac4120792b71cec8f52eb26e359b89
Tree-SHA512: 99ec10c5e7aa050fcb2b0ac6f0d546e14b2f00e75430ebdaceff78758880a7a8336bda84692738599b7a0f1d56a92db75321e4d2f4e218a42ac920e7dd8503a5
26ad36f34e28e38a7c205343b6e5376a7f580e6f fix register descriptor prompt (edouard)
9fac6277f42b605200134e6a670cb3511edf80cc Sign with hot signer (edouard)
e76459d159630068f2c0bd9799ce908c30e42d6e Load hot signer in Wallet (edouard)
ecb3e114865b7e502b2a709f4bd2db4752de8976 installer: store mnemonic in datadir (edouard)
7a76754842b7eb688cbc6cd791c412f9006f407d Add title to installer final step (edouard)
c70ac114768a6410e01308bbc69ee4db853947e7 installer: add recover seed step (edouard)
037c4d025d651940ef42637ae5a6b8592dae56cb installer: add signer to participate wallet process (edouard)
233f9b1886078ad2a94704537df8dacfeb5fe06a installer: add backup mnemonic step (edouard)
f8dcd1116dfe820b6de18364b4d7ecaadbe0e7db Add hot signer to create descriptor step (edouard)
1f09653198aefd699afd0e2cc5d26235c3193fb8 Add signer module to gui (edouard)
f3f04a41b00aef014f7f45b3418f5913a4361b8e Use liana hot signer (edouard)
Pull request description:
ACKs for top commit:
darosior:
ACK 26ad36f34e28e38a7c205343b6e5376a7f580e6f -- tested the branch merged on master.
Tree-SHA512: 578be77aff99c40aa21049bfccfb8d310d04ca48213f7af62ec8d5444e044a8375966568e496ff5443a48d2aac648387c410747d12ad15fa21a1bff613d17673
