0fb1f3c1edb1a93b8e491d769497a618d9c06511 Add tiny-skia feature to iced dep (edouardparis)
Pull request description:
tiny-skia is an other renderer that does not
rely on wgpu. Iced uses it as a fallback in case
of wgpu problems.
The feature can be tested with:
`ICED_BACKEND=tiny-skia cargo run --release --bin liana-gui`
close#1676
ACKs for top commit:
jp1ac4:
tACK 0fb1f3c1edb1a93b8e491d769497a618d9c06511.
Tree-SHA512: 681a11e334759f4ef28ca95f08bfee2e898ad3be1af5d4fc6a78f6a499bb1b7e3b7d5e747b3207f758770437d2c83a8f8f1a6ef536a08c37ddc1b73618c963f4
tiny-skia is an other renderer that does not
rely on wgpu. Iced uses it as a fallback in case
of wgpu problems.
The feature can be tested with:
`ICED_BACKEND=tiny-skia cargo run --release --bin liana-gui`
close#1676
31798b7e4317125e671e2d52e28e9ddc16815bf0 export: allow to import a backup from a simple descriptor (pythcoiner)
54c83615b070a982ec99f3c58278ecabba8a264e export: add test cases for import_descriptor() (pythcoiner)
d66b596cf930597254b1e48426c9488fd77d210d import: allow to import a descriptor from a backup in export::import_descriptor() (pythcoiner)
53839e92744b24e1365c3b57108b350c729b17b5 gui: add a spacer below the main column at Add wallet step in liana-connect flow (pythcoiner)
4bb4269975e0469205c96751bcbf24311177d53d gui: add import descriptor from file feature in liana-connect flow (pythcoiner)
Pull request description:
This PR closes#1751:
- add the option to import a descriptor from a file.
- add a spacer at the bottom of the screen.
- add the possibility to import also a descriptor from a backup file.
ACKs for top commit:
edouardparis:
ACK 31798b7e4317125e671e2d52e28e9ddc16815bf0
Tree-SHA512: 7e5ae0f3bbc4af1d779e1cd97e9cadceabe62317f857c895d9f5de49ed84f81c1da1df8df4d935ff0b1c2a040e1fa03f598bbdc6d64e82b225089c884c774743
b7ca309af740b41e543cc4c2b1b7a3395a876c13 Add minimal nix development shell option (Edouard Paris)
Pull request description:
## Summary
- Add minimal nix development shell option that provides only essential development dependencies
- Enables faster development environment setup for contributors who prefer minimal tooling
🤖 Generated with [Claude Code](https://claude.ai/code)
ACKs for top commit:
edouardparis:
ACK b7ca309af740b41e543cc4c2b1b7a3395a876c13
Tree-SHA512: 15bc6a80c685e5e0e29b8b85317a8f378bdacaf5568f40a3ed18901756a7752b82db3f0a350093713bc0baf51c3dfacd3fb2782fe34ab985745850c7354e13f0
- Refactor flake.nix to use shared commonBuildInputs for all shells
- Add minimalShell without Rust toolchain accessible via `nix develop .#minimal`
- Keep default shell with full Rust development environment
- Maintains backward compatibility while providing minimal shell option
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
fef70879b9507e0429a8a0a5211ba0547b68cc92 refac: remove patch field from Version (edouardparis)
Pull request description:
The Version struct is used across the software
to display the release version. A release version
does not include patch number as we increment
only the major and the minor during a new release.
For very small patch that does not change the
API and does not require a new release, then the crates Cargo.toml version patch number will be incremented.
ACKs for top commit:
jp1ac4:
tACK fef70879b9507e0429a8a0a5211ba0547b68cc92.
Tree-SHA512: 1a4e94c156377e810e15ba93267e6eddd0a273de48b18d0722f9e879eceb9b6ce8cb5f1347c075c1c17a47278b5fd6a64b51ad244cf15f390250d267cd8e23c7
The Version struct is used across the software
to display the release version. A release version
does not include patch number as we increment
only the major and the minor during a new release.
For very small patch that does not change the
API and does not require a new release, then the crates
Cargo.toml version patch number will be incremented.
f8fcf7100b43e98398254d5c846ec9a8a96a1c74 fix checks for whether wallet uses managed bitcoind (Michael Mallan)
Pull request description:
This fixes a couple of checks for whether the wallet uses a managed bitcoind.
ACKs for top commit:
edouardparis:
ACK f8fcf7100b43e98398254d5c846ec9a8a96a1c74
Tree-SHA512: e15cffc10cbe06b4769c65900befdb903109518059f03d31aac10e6ee91a0a9179d45e27eb22a0216b8b1d9ee073564bfb9839de890d32c148c4b243143f4b71
df1fb7f8f574b7f80f772c0eb4450fc9128e67e5 allow to connect to an electrum server w/ a self signed certificate" (pythcoiner)
Pull request description:
This PR reintroduce the option to connect to an electrum server that use a self signed certificate
Note: ssl://testnet.aranguren.org:51002 electrum server can be used to test this PR
ACKs for top commit:
jp1ac4:
tACK df1fb7f8f574b7f80f772c0eb4450fc9128e67e5.
Tree-SHA512: 0386ba7d2de37e3d62c8366ffe93df55d6f47e04f71fef241304f3d7f36b64b39bb6e6c573e06983b084003b1d72fa3dbc2a30236658c18b9fd92fab576090ad
7785cbad28c476154499c931aab3ec7cb6d99650 fix: use correct path to daemon.toml in settings (Michael Mallan)
Pull request description:
This fixes#1743 by using the correct daemon config file path of the current wallet.
ACKs for top commit:
edouardparis:
ACK 7785cbad28c476154499c931aab3ec7cb6d99650
Tree-SHA512: 3e0f16d68cb7a67b4ce82295cb32fb230f7cb6ba4889f5c3aeb40f80cc2a0488e4d3bff0ea26a5b397ef0639b1e95c98a7779075dbfdc2cf49a224e8e1a1c51d
dd864905cd0a27a661e7e274c599672093755e34 bump bdk_electrum to latest commit (Michael Mallan)
Pull request description:
This bumps the bdk_electrum dependency to the latest commit of our "release/1.0.0-alpha.13" branch, which will enable the resolution of #1300.
ACKs for top commit:
edouardparis:
ACK dd864905cd0a27a661e7e274c599672093755e34
Tree-SHA512: 4a2fca7cd6084ae4772914c32f746e8d6946701dfd790c0aae62d7062071e6ab23557b240612f7b259ae95c78187098845ebb11c54b4cea1dd89d33eb8caec08
efba78844396ae9ccbf520f328783b44b367333e refactor: response has not succeed and add missing checks (Thomas Ballivet)
Pull request description:
This should resolves#1679
ACKs for top commit:
jp1ac4:
tACK efba78844396ae9ccbf520f328783b44b367333e.
Tree-SHA512: 69bc94c8a5528b941e7796b4cf53a7945de8b1bbfc76954f65dce410be059b601e6b31d70790e04dd02dc6dc13a17600a4cc878d64de8deb89ce343bff101ac6
52d6e03d75f35118adb919347950592d59dd628b flake.nix: devshells include toolchain (VzxPLnHqr)
Pull request description:
on x86_64-linux, this was necessary to get cargo into the path so as to be able to execute things like `cargo build ...`.
When trying to test out the latest release candidate from NixOS (x86_64-linux), running `nix develop` did not drop me into a devshell with cargo available. The fix here may not have been the best way to remedy that, but it did work, and then I was able to test the latest code by:
1. `nix develop` to get into the devshell
2. `cargo build --release`
3. `target/release/liana-gui --datadir ./test_alice`
ACKs for top commit:
edouardparis:
ACK 52d6e03d75f35118adb919347950592d59dd628b
Tree-SHA512: 2e2570e230e296d10a3b8be96c580afd91f6b135d0bc6a57c0d587cf7ad159d740769370cf6bcad9a0c551b65af12905d7e08b5fbc21989ac513b379e7e83c4c
546ac29587e831abbe79e66d23cac9683467a842 fix update wallet alias in wallet settings (edouardparis)
Pull request description:
L522 the wallet was populated with its new alias
and the check L567 was always false.
wallet_alias is None if we do not have to update it, so better pass the variable directly.
ACKs for top commit:
edouardparis:
Self-ACK 546ac29587e831abbe79e66d23cac9683467a842
Tree-SHA512: 971e441eb67cdc20aea7e2631bf74b568ce216e2a4d86a292d5f6d04bcfef37c3180c2df2510a150bc13ef605ab60bea40a8a7e8683f020b01f84aae9dd08098
L522 the wallet was populated with its new alias
and the check L567 was always false.
wallet_alias is None if we do not have to update it,
so better pass the variable directly.
53df4ed9692a62ddf8f9f0da27e0dbe7706510d7 CHANGELOG for v11 (Michael Mallan)
33a0e147b4f49c6f230c0e8234e4b01dded0d88d revert change to CHANGELOG (Michael Mallan)
Pull request description:
This adds the CHANGELOG for v11.
I also reverted an accidental change made recently.
ACKs for top commit:
edouardparis:
ACK 53df4ed9692a62ddf8f9f0da27e0dbe7706510d7
Tree-SHA512: 3c7517c3784dd02af31c2a7d8d8d12220638430d1e307b8f0135a3baf16d65b0e9b18f926b15892c4c21a538fda1a028dc866252733e966bd9315b7b44226242
874d2d406804b853e399800435bb0ee223d5d769 Make user finish sign process before opening new modal (edouardparis)
1d1a28195527cc04ce99969e5c85d2632402d73e Revert "gui: store SignModal state and allow to open export modal after signing in PSBT panel" (edouardparis)
Pull request description:
This Pr is to mitigate three issues:
close#1719close#1685
and try to prevent a little bit the problem of impossible cancellation of the signing Task by disabling any other buttons and making aware of the user that he has to finish it (reject of approve).
Sadly it is not the case for the sidebar menu button, so if user start the signing process and quit by switching panel, he may still have the problem of the signing task blocking in the background and may be surprised by the impossibility of iced to close properly.
Proper signing task cancellation will require a change in the async-hwi library: https://github.com/wizardsardine/async-hwi/issues/108
ACKs for top commit:
pythcoiner:
tACK 874d2d40, it fixes back #1681
jp1ac4:
tACK 874d2d406804b853e399800435bb0ee223d5d769.
Tree-SHA512: bb25dcc086787cf491ca11359db756ef19508f1518d600d7091b0cb14422d9148ae3ee1f3ed47aa5dc642d7089152b7b36e1746be7dbe94d22bab71f2899645b
78a261da5a5e92f3589403760858105026e6278d show partial address in collapsed view (Michael Mallan)
Pull request description:
To avoid the need for a scrollbar when showing previous addresses in the collapsed view, we will now show the first and last 16 characters only.
ACKs for top commit:
edouardparis:
utACK 78a261da5a5e92f3589403760858105026e6278d
Tree-SHA512: ca7282e47de3b828a8f8746f710a30650992499b785e5bb766c80ffafb83aa872dc63b5f1d85c2f1394a5eb4c018a2c4feeb772f8bafde021e81f5294811780c
aa417be12781f995854dc2f4fc49da85d23569f2 gui: add parsing for xpub from coldcard format (pythcoiner)
Pull request description:
this PR implement parsing Xpub from files exported from a coldcard via `Advanced/Tools` => `Export Wallet` => `Generic JSON`
ACKs for top commit:
edouardparis:
utACK aa417be12781f995854dc2f4fc49da85d23569f2
Tree-SHA512: eca22295926522ba199a3c0ace0adb52ee236a6a6b0fbd9ba52ba18cbbbbb4032ef3ef06dfd493fddd83e17ac0fbba84612bd73a3e0c1142783e30b60b781ff9
