493dbde666b73097848a5a4c7d10ee1ad7cfeab2 gui: cleanup the "amount left to select" calculation (Antoine Poinsot)
Pull request description:
It don't think it was blatantly wrong, but neither was it entirely correct. And it was seriously lacking comments explaining what was going on for such a tricky calculation.
In order to make sure it's correct, and make this more code more maintainable (and readable to future contributors), clean it up by using a more obviously-correct approach: a transaction template that is filled with inputs depending on the coins that were selected.
I DID NOT TEST IT!
ACKs for top commit:
edouardparis:
ACK 493dbde666b73097848a5a4c7d10ee1ad7cfeab2
Tree-SHA512: b8094326f42ed86a4fcd4e16961a7cb77b07d423215665248dd20db66e2c2eb5500fd7cbdb58d0febae5beb3a40f7b531ec24d1c3e7d7a16a45686ac40a89e9b
94f313133b80d9bd684fefee644a44621aed9066 contrib: add a script to generate coverage data for the daemon (Antoine Poinsot)
Pull request description:
Taken and adapted from revaultd. Can be trivially adapted to the GUI.
ACKs for top commit:
darosior:
ACK 94f313133b80d9bd684fefee644a44621aed9066
Tree-SHA512: 1899526aa134f01d36ce624fad536a3794afb61ddbdd55a5688c0d9647405c3200354634a05348e8b801c174ddcdbaf3f98609ef07f3d360222ef808b649d012
2e8b72a809155b6ec4989da270a96119956d531e gui: use glow feature instead of wgpu (edouard)
Pull request description:
ACKs for top commit:
darosior:
ACK 2e8b72a809155b6ec4989da270a96119956d531e. We don't need an efficient renderer, and it looks like it's helpful for Guix builds.
Tree-SHA512: eb75c2ef6913cd5a90a29843e4d2470f1693b2bdb814ba953dd7ee1d9b27d3a9a95712cd7b7bedf4627853993a9f25fc70a8a12cf7df6c042ae2be72bad3e27b
a4e66566886901f28e383e67f06de2215e3ebc42 daemon: remove / correct some TODOs (Antoine Poinsot)
628ed3d0ed3997a64d8d0d92206842ef5445e2fa descriptors: remove TODO in assertions, explain instead (Antoine Poinsot)
62067f0030795143cbec87dcc1d5db0e5265c5c5 qa: remove needless import in fixtures (Antoine Poinsot)
Pull request description:
Small things i noticed while working on #148.
ACKs for top commit:
darosior:
ACK a4e66566886901f28e383e67f06de2215e3ebc42
Tree-SHA512: 0d6b6b95a99744cd92b9ecd30d9678ff27c7223238a31c3e9093899caa11889d40cfe4c7d855c07c378ca127ca900269980d179aeb02478f04e3eaa1e20e1721
It was making unnecessary computations when no feerate was provided, and
was not accounting for VarInt's. Instead of adding more magic values
just build a transaction template and use that.
53514939da522f557c9c804a2b97fd5731b17864 Add clipboard to coin outpoint (edouard)
23e533fbeea96bb6ea5137ff66414e94b997b513 Add warning to home panel (edouard)
Pull request description:
when remaining sequence is inferior to timelock*10/100, a warning is displayed in home panel
based on #137
ACKs for top commit:
edouardparis:
Self-ACK 53514939da522f557c9c804a2b97fd5731b17864
Tree-SHA512: 5d317ae7e2094e6d8841ef58ed362abcc211111fa951969d42dc96ac1729055c60edc355de17524408e4e918de3d62d419d65869348c22b48e7d9ea42449dbac
9d60db3abf04cc03a36462a8b45b7d4da3978339 fix view: spend detail width (edouard)
70527a002ed04718789ba05389899b731e40146b spend: display amount left to select (edouard)
c3471c066540743b3725bd68abbff7779b1e79e6 spend: order coins by remaining sequence and amount (edouard)
c88c39a8b92854f5d50f267ee82be429c328e011 spend steps: add total sent (edouard)
f0758d28abf2ee255f02bafb0deb806ba4ac98aa spend: add remaining sequence to coins (edouard)
6d92056b9d5ea4c64d89845ead13b2fff2a3689d bump liana#38e342c8 (edouard)
Pull request description:
- [x] Add remaining sequence to coins
- [x] Order coins by remaining sequence or amount
- [x] Move feerate form to coins selection step
- [x] Check amount left to select at coins selection step
ACKs for top commit:
edouardparis:
Self-ACK 9d60db3abf04cc03a36462a8b45b7d4da3978339
Tree-SHA512: 8ecb9a7c75e2ecf2dcd90111d532542a83128209dc9d6057636fc5e6ceb5c1091633b987d64f30c46e1a75a6f27a26e05f469eb8b45b980e1fabd3a798e69a71
eebc96c4d53f0f6a86d5ddf4267b3d4a45aa7e3f descriptors: add a method to get the size of a spending input (Antoine Poinsot)
Pull request description:
ACKs for top commit:
edouardparis:
utACK eebc96c4d53f0f6a86d5ddf4267b3d4a45aa7e3f
Tree-SHA512: 6d94d7eccfed1d828633f7942072c7b044339c1df7add1df209bba6409131aa138f8cf83a36691df88af237943dcc45c3b1e050745143ab663a6c9c13c83176a
e13050385382a114b79f19e298fc74f2a3fbbf0d change clipboard icon (edouard)
4205f62972b4c61c4c1878fb120564bfedbd5eac Display output and input in collapse component (edouard)
Pull request description:
this resolve some comments in #50
ACKs for top commit:
edouardparis:
Self-ACK e13050385382a114b79f19e298fc74f2a3fbbf0d
Tree-SHA512: ddc4d1f5770fa5f839ef189a495f67f6a10c02d866bc3da23d245f0add532600fe24e819b8e119303128d10a355fee0f8aa75085db7653d0a46a6567b469e5ae
17669547ed8716c5bba08f73067c74ba7cb9c0ab Add loader error message and retry button (edouard)
Pull request description:
Refac notification::warning component to use a Collapse instead of Tooltip.
close#134
ACKs for top commit:
edouardparis:
Self-ACK 17669547ed8716c5bba08f73067c74ba7cb9c0ab
Tree-SHA512: b7c031e4daf99706bd46c83c6687b1c55b4d8ce496ea58c86db003c161fd281904e8ba76cd572bdc5c332ba96a9005cc1386e1a5967ecc4dd0d088e9f28e286b
59c12cd5844e19f296066465fd34a3be48e26f2e installer: wait process is done before next step (edouard)
0577b971b77c0691f0dbb948956eb7616c4c8614 installer: add progress information (edouard)
0365794f910833e400f2418e52b6259f3ccb9b22 installer: add final step summary (edouard)
437faef1af01d9952f5ed3156ce38d9964ba5efb Add learn more collapse to installer (edouard)
8348ad1afadc2e46994b364d595491cc327d4961 installer: add backup descriptor step (edouard)
b260ac420819cb41f8740fa12f65b3a79d69eed3 installer: keep refresh button to list hws (edouard)
92699c645b38f97bfcde35d30b83981335285bdf installer: create or import wallet (edouard)
c89b8d88f59f4dec556d083b6f39c8263279741c installer: rename network pick_list (edouard)
Pull request description:
base on #129
ACKs for top commit:
edouardparis:
Self-ACK 59c12cd5844e19f296066465fd34a3be48e26f2e
Tree-SHA512: d8016b353b54a744ab69c4d7278f4c04aab18326d97293b1b145bb5c3a46633c4ebbc4ccd3291e88fb508f02d44137d82f88218ce936b4a221335b16be879ff6
